tests: fix ospf json config confusion for topojson. #9482

gpnaveen · 2021-08-24T18:49:20Z

Signed-off-by: nguggarigoud nguggarigoud@vmware.com

polychaeta

Thanks for your contribution to FRR!

Style checking failed; check logs

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>

LabN-CI · 2021-08-24T21:23:38Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/9482 `af81dca`
Date	08/24/2021
Start	16:57:10
Finish	17:23:36
Run-Time	26:26
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-08-24-16:57:10.txt
Log	autoscript-2021-08-24-16:58:27.log.bz2
Memory	503 507 418

For details, please contact louberger

NetDEF-CI · 2021-08-24T22:18:56Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21345/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

polychaeta

Thanks for your contribution to FRR!

Style checking failed; check logs

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2021-08-25T02:07:24Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/9482 `5555f0d`
Date	08/24/2021
Start	21:40:53
Finish	22:07:22
Run-Time	26:29
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2021-08-24-21:40:53.txt
Log	autoscript-2021-08-24-21:42:07.log.bz2
Memory	509 504 425

For details, please contact louberger

choppsv1 · 2021-08-25T02:11:37Z

tests/topotests/ospf_basic_functionality/test_ospf_asbr_summary_type7_lsa.py

@@ -233,7 +233,7 @@ def red_connected(dut, config=True):
        ospf_red = {
            dut: {
                "ospf": {
-                    "redistribute": [{"redist_type": "connected", "del_action": True}]
+                    "redistribute": [{"redist_type": "connected", "delete": True}]


If you look below, the function being called is create_router_ospf. This function did not handle the old argument of del_action, so this change means this config is now being removed (which one expects) whereas before it was not, yet the tests passed previously.

Also note create_rotuer_ospf calls __create_ospf_global which then has multiple custom keys besides delete for various config which it should not; however, this does not include del_action as mentioned above.

choppsv1 · 2021-08-25T02:14:39Z

tests/topotests/ospfv3_basic_functionality/test_ospfv3_ecmp.py

@@ -219,7 +219,7 @@ def red_connected(dut, config=True):
        ospf_red = {
            dut: {
                "ospf6": {
-                    "redistribute": [{"redist_type": "connected", "del_action": True}]
+                    "redistribute": [{"redist_type": "connected", "delete": True}]


Same comment as above. This is calling create_router_ospf which did not do anything with the previous del_action key, but now will with the delete key. Yet the tests passed previously.

choppsv1

Some of these changes will alter previous test behavior from the unexpected but passing to the expected but 'who knows'. The calls to create_router_ospf in particular should be checked and why those tests pass prior to the key change. The non-delete custom keys used inside create_router_ospf should also be cleaned up to use delete as well.

choppsv1 · 2021-08-25T02:15:41Z

tests/topotests/ospfv3_basic_functionality/test_ospfv3_rte_calc.py

@@ -255,7 +255,7 @@ def red_static(dut, config=True):
        ospf_red = {
            dut: {
                "ospf6": {
-                    "redistribute": [{"redist_type": "static", "del_action": True}]
+                    "redistribute": [{"redist_type": "static", "delete": True}]


Same comment as above. This is calling create_router_ospf which did not do anything with the previous del_action key, but now will with the delete key. Yet the tests passed previously.

choppsv1 · 2021-08-25T02:15:49Z

tests/topotests/ospfv3_basic_functionality/test_ospfv3_rte_calc.py

@@ -273,7 +273,7 @@ def red_connected(dut, config=True):
        ospf_red = {
            dut: {
                "ospf6": {
-                    "redistribute": [{"redist_type": "connected", "del_action": True}]
+                    "redistribute": [{"redist_type": "connected", "delete": True}]


Same comment as above. This is calling create_router_ospf which did not do anything with the previous del_action key, but now will with the delete key. Yet the tests passed previously.

NetDEF-CI · 2021-08-25T04:35:53Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21348/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18I386-21348/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9:

2021-08-25 02:25:18,361 ERROR: assert failed at "test_ospf_authentication/test_ospf_authentication_different_auths_tc30_p1": setup_module :Failed 
   Error: [DUT: r2] OSPF is not Converged
assert '[DUT: r2] OSPF is not Converged' is True
2021-08-25 02:25:57,612 WARNING: vtysh_cmd: r0: failed to convert json output: : No JSON object could be decoded
2021-08-25 02:26:19,735 WARNING: vtysh_cmd: r1: failed to convert json output: : No JSON object could be decoded
2021-08-25 02:38:21,079 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-08-25 02:38:53,856 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 1908, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 360, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 618, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536 


2021-08-25 03:18:06,831 ERROR: r1: zebra left a dead pidfile (pid=9399)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21348/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests Ubuntu 18.04 i386 part 2
Ubuntu 20.04 deb pkg check
Debian 9 deb pkg check
Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 7
Topotests Ubuntu 18.04 arm8 part 7
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 1
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 6
CentOS 7 rpm pkg check
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 2
Topotests Ubuntu 18.04 arm8 part 3
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Addresssanitizer topotests part 9
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 3
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 5
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 8
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 amd64 part 6
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 0
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 0
Topotests debian 10 amd64 part 9
Static analyzer (clang)
Topotests Ubuntu 18.04 i386 part 5
Addresssanitizer topotests part 1
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 amd64 part 0
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests debian 10 amd64 part 5
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests Ubuntu 18.04 arm8 part 4
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 7
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 amd64 part 9
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 7

github-actions · 2022-07-10T02:12:33Z

This PR is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this PR closed.

choppsv1 · 2022-07-15T01:53:52Z

This needs to be rebased

github-actions · 2022-10-13T13:24:42Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

polychaeta added bugfix tests Topotests, make check, etc labels Aug 24, 2021

polychaeta reviewed Aug 24, 2021

View reviewed changes

tests: fix ospf json config confusion for topojson.

5555f0d

Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>

gpnaveen force-pushed the fix_ospf_tests branch from af81dca to 5555f0d Compare August 25, 2021 01:39

polychaeta reviewed Aug 25, 2021

View reviewed changes

choppsv1 reviewed Aug 25, 2021

View reviewed changes

choppsv1 requested changes Aug 25, 2021

View reviewed changes

github-actions bot added the autoclose label Jul 10, 2022

github-actions bot removed the autoclose label Jul 31, 2022

github-actions bot added the conflicts label Oct 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: fix ospf json config confusion for topojson. #9482

tests: fix ospf json config confusion for topojson. #9482

gpnaveen commented Aug 24, 2021

polychaeta left a comment

LabN-CI commented Aug 24, 2021 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Aug 24, 2021 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

polychaeta left a comment

LabN-CI commented Aug 25, 2021

choppsv1 Aug 25, 2021 •

edited

Loading

choppsv1 Aug 25, 2021

choppsv1 left a comment

choppsv1 Aug 25, 2021

choppsv1 Aug 25, 2021

NetDEF-CI commented Aug 25, 2021

github-actions bot commented Jul 10, 2022

choppsv1 commented Jul 15, 2022

github-actions bot commented Oct 13, 2022

tests: fix ospf json config confusion for topojson. #9482

Are you sure you want to change the base?

tests: fix ospf json config confusion for topojson. #9482

Conversation

gpnaveen commented Aug 24, 2021

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Aug 24, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Aug 24, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Aug 25, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

choppsv1 Aug 25, 2021 • edited Loading

Choose a reason for hiding this comment

choppsv1 Aug 25, 2021

Choose a reason for hiding this comment

choppsv1 left a comment

Choose a reason for hiding this comment

choppsv1 Aug 25, 2021

Choose a reason for hiding this comment

choppsv1 Aug 25, 2021

Choose a reason for hiding this comment

NetDEF-CI commented Aug 25, 2021

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

github-actions bot commented Jul 10, 2022

choppsv1 commented Jul 15, 2022

github-actions bot commented Oct 13, 2022

LabN-CI commented Aug 24, 2021 •

edited

Loading

NetDEF-CI commented Aug 24, 2021 •

edited

Loading

choppsv1 Aug 25, 2021 •

edited

Loading