Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add scapy_sendpkt.py util, replace arping use with it #9228

Merged
merged 1 commit into from
Jul 31, 2021

Conversation

choppsv1
Copy link
Contributor

Signed-off-by: Christian Hopps chopps@labn.net

@polychaeta polychaeta added the tests Topotests, make check, etc label Jul 29, 2021
@choppsv1 choppsv1 force-pushed the chopps/scapy-sendpkt branch 3 times, most recently from a967fe4 to 2619628 Compare July 29, 2021 15:15
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 29, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result 0
Date
Start
Finish vncregress-2021-07-29-10:51:36.txt
Run-Time autoscript-2021-07-29-10:53:01.log.bz2
Total 513 519 430
Pass Complete
Fail 04/29/2021
Valgrind-Errors 10:51:33
Valgrind-Loss 11:30:53
Details 39:20
Log 1815
Memory 1815
SUCCESS git merge/9228 31a03e8 0
07/29/2021 0
10:51:36 0
11:17:21 autoscript-2021-04-29-10:51:33.txt
25:45 autoscript-2021-04-29-10:51:33.log.bz2
1813 477 495 417
1813

For details, please contact louberger

@choppsv1 choppsv1 requested a review from mwinter-osr July 29, 2021 15:25
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 29, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9228 2619628
Date 07/29/2021
Start 12:12:42
Finish 12:38:27
Run-Time 25:45
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-29-12:12:42.txt
Log autoscript-2021-07-29-12:14:00.log.bz2
Memory 501 519 420

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 29, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20636/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Copy link
Contributor

@eqvinox eqvinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Between forking out arping or forking out this helper, the latter certainly seems an improvement.

Signed-off-by: Christian Hopps <chopps@labn.net>
@choppsv1 choppsv1 force-pushed the chopps/scapy-sendpkt branch from 2619628 to 002e682 Compare July 30, 2021 21:01
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 30, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9228 002e682
Date 07/30/2021
Start 17:05:51
Finish 17:31:27
Run-Time 25:36
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-30-17:05:51.txt
Log autoscript-2021-07-30-17:07:10.log.bz2
Memory 498 502 406

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20674/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@eqvinox eqvinox merged commit 0090895 into FRRouting:master Jul 31, 2021
@eqvinox eqvinox deleted the chopps/scapy-sendpkt branch July 31, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants