Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix various memory leaks in dampening #9217

Merged
merged 6 commits into from
Jul 30, 2021

Conversation

idryzhov
Copy link
Contributor

@idryzhov idryzhov commented Jul 28, 2021

Overall this PR aims to fix multiple memory leaks in the dampening code. All the leaks are regressions in 8.0 and I want this code to be backported even though there are a couple of cleanup-only commits. It is difficult to fix the leaks without doing the cleanup.

Please, check individual commits for descriptions.

The last commit changes the SLIST to a LIST. The dampening code was always using a double-linked list before the rework in 8.0 that introduced all those crashes and memory leaks. As there are frequent removals from the list, using a single-linked list is actually a real performance regression so changing it back to double-linked list should be considered as a fix.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 28, 2021

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/9217 d30c781
Date 07/28/2021
Start 19:16:13
Finish 19:41:52
Run-Time 25:39
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-28-19:16:13.txt
Log autoscript-2021-07-28-19:17:26.log.bz2
Memory 481 485 425

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 29, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20615/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18AMD64-20615/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9:

2021-07-29 00:04:16,837 WARNING: vtysh_cmd: r0: failed to convert json output: : No JSON object could be decoded
2021-07-29 00:04:41,256 WARNING: vtysh_cmd: r1: failed to convert json output: : No JSON object could be decoded
2021-07-29 00:16:42,980 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 1866, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-07-29 00:17:23,949 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 1866, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536 


2021-07-29 00:19:20,916 ERROR: r5: bgpd left a dead pidfile (pid=27470)
2021-07-29 00:28:49,863 ERROR: rt5: zebra left a dead pidfile (pid=5003)
2021-07-29 00:28:49,952 ERROR: rt1: zebra left a dead pidfile (pid=5153)
2021-07-29 00:36:41,149 ERROR: r2: bgpd left a dead pidfile (pid=11490)

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20615/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18I386-20615/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9:

2021-07-29 00:03:03,569 WARNING: vtysh_cmd: r0: failed to convert json output: : No JSON object could be decoded
2021-07-29 00:03:29,440 WARNING: vtysh_cmd: r1: failed to convert json output: : No JSON object could be decoded
2021-07-29 00:16:32,283 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 1866, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-07-29 00:17:22,760 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 1866, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9U18I386/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536 


2021-07-29 00:19:29,423 ERROR: r4: zebra left a dead pidfile (pid=26972)
2021-07-29 00:40:33,309 ERROR: assert failed at "test_ospfv3_single_area/test_ospfv3_p2p_tc3_p0": setup_module :Failed 
   Error: [DUT: r0] OSPF peer 1.0.4.17 missing,from r3 
assert '[DUT: r0] OSPF peer 1.0.4.17 missing,from r3 ' is True

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20615/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 3: No useful log found
Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP3U1804AMD64-20615/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3:

2021-07-28 23:58:39,932 ERROR: assert failed at "test_bgp_features/test_bgp_dampening_profile_peer_over_group": BGP session on router r1 did not dampen routes flapped by ExaBGP peer peer1
assert 0 == 4
  -0
  +4
r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:10:24 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:24 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 00:10:24 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:24 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 00:10:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:25 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 00:10:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:25 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 00:10:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:27 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:41 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:10:41 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r2: Daemon bgpd not running

From frr r2 bgpd log file:
2021/07/29 00:12:15 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:15 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart json
2021/07/29 00:12:16 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:16 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart 
2021/07/29 00:12:16 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:16 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart json
2021/07/29 00:12:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:17 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart 
2021/07/29 00:12:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:18 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:18 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:32 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:12:32 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:14:23 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:23 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 00:14:23 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:23 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 00:14:24 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:24 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 00:14:24 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:24 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 00:14:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:33 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:33 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:41 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:14:41 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:15:00 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/07/29 00:15:00 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:00 BGP: [M7Q4P-46WDR] vty[??]@# do show logging
2021/07/29 00:15:01 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:01 BGP: [M7Q4P-46WDR] vty[??]@# do write terminal

2021/07/29 00:15:01 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 00:15:01 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/07/29 00:15:02 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:02 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/07/29 00:15:02 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/07/29 00:15:02 BGP: [M7Q4P-46WDR] vty[??]@(config)# no log commands

2021/07/29 00:15:02 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 00:15:04 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 00:15:07 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 00:15:07 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/07/29 00:15:46 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 00:15:49 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 00:15:49 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default

r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:17:18 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:18 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 00:17:18 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:18 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 00:17:19 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:19 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 00:17:19 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:19 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 00:17:20 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:20 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:21 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:21 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:28 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:28 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:28 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:28 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:29 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:17:35 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:18:42 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:42 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 00:18:42 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:42 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 00:18:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:43 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 00:18:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:43 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 00:18:44 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:44 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:53 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:53 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:59 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:59 BGP: [M7Q4P-46WDR] vty[??]@# do write memory

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20615/artifact/TP3U1804AMD64/ErrorLog/log_topotests.txt

Topotests debian 10 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO3DEB10AMD64-20615/test

Topology Tests failed for Topotests debian 10 amd64 part 3:

2021-07-28 23:59:36,017 ERROR: assert failed at "test_bgp_features/test_bgp_dampening_profile_peer_over_group": BGP session on router r1 did not dampen routes flapped by ExaBGP peer peer1
assert 0 == 4
  -0
  +4
r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:11:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:35 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 00:11:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:35 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 00:11:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:36 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 00:11:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:36 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 00:11:37 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:37 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:38 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:38 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:46 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:46 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:53 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:11:53 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r2: Daemon bgpd not running

From frr r2 bgpd log file:
2021/07/29 00:13:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:26 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart json
2021/07/29 00:13:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:26 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart 
2021/07/29 00:13:27 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:27 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart json
2021/07/29 00:13:27 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:27 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart 
2021/07/29 00:13:27 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:27 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:28 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:28 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:13:43 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:15:37 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:37 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 00:15:37 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:37 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 00:15:38 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:38 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 00:15:38 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:38 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 00:15:39 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:39 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:39 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:40 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:47 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:47 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:47 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:48 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:48 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:54 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:15:54 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:16:11 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/07/29 00:16:12 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:16:12 BGP: [M7Q4P-46WDR] vty[??]@# do show logging
2021/07/29 00:16:13 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:16:13 BGP: [M7Q4P-46WDR] vty[??]@# do write terminal

2021/07/29 00:16:13 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 00:16:13 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/07/29 00:16:14 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:16:14 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/07/29 00:16:14 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/07/29 00:16:14 BGP: [M7Q4P-46WDR] vty[??]@(config)# no log commands

2021/07/29 00:16:14 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 00:16:16 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 00:16:19 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 00:16:20 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/07/29 00:16:59 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 00:17:02 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 00:17:02 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default

r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:18:31 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:31 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 00:18:31 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:31 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 00:18:32 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:32 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 00:18:32 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:32 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 00:18:33 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:41 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:41 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:42 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:42 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:42 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:49 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:18:49 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 00:19:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:19:57 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 00:19:58 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:19:58 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 00:19:59 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:19:59 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 00:19:59 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:19:59 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 00:20:00 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:00 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:00 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:01 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:08 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:08 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:08 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:09 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:15 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 00:20:15 BGP: [M7Q4P-46WDR] vty[??]@# do write memory

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20615/artifact/TOPO3DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO3U18I386-20615/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 3:

2021-07-29 01:58:55,236 ERROR: assert failed at "test_bgp_features/test_bgp_dampening_profile_peer_over_group": BGP session on router r1 did not dampen routes flapped by ExaBGP peer peer1
assert 0 == 4
  -0
  +4
r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 02:11:53 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:11:53 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 02:11:54 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:11:54 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 02:11:55 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:11:55 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 02:11:55 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:11:55 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 02:11:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:11:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:11:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:11:58 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:12:06 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:12:06 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:12:06 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:12:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:12:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:12:15 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:12:15 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r2: Daemon bgpd not running

From frr r2 bgpd log file:
2021/07/29 02:14:06 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:06 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart json
2021/07/29 02:14:06 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:06 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart 
2021/07/29 02:14:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:07 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart json
2021/07/29 02:14:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:07 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart 
2021/07/29 02:14:08 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:08 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:08 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:09 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:16 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:16 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:24 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:14:24 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 02:16:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:26 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 02:16:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:26 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 02:16:27 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:27 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 02:16:27 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:27 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 02:16:28 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:29 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:29 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:29 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:37 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:37 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:37 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:38 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:38 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:16:45 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 02:17:03 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/07/29 02:17:04 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:17:04 BGP: [M7Q4P-46WDR] vty[??]@# do show logging
2021/07/29 02:17:05 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 02:17:05 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/07/29 02:17:05 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:17:05 BGP: [M7Q4P-46WDR] vty[??]@# do write terminal

2021/07/29 02:17:06 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:17:06 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/07/29 02:17:06 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/07/29 02:17:06 BGP: [M7Q4P-46WDR] vty[??]@(config)# no log commands

2021/07/29 02:17:06 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 02:17:08 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 02:17:12 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 02:17:12 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/07/29 02:17:52 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 02:17:55 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 02:17:56 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default

r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 02:19:32 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:32 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 02:19:33 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:33 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 02:19:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:34 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 02:19:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:34 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 02:19:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:44 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:44 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:44 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:45 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:19:52 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 02:21:05 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:05 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 02:21:06 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:06 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 02:21:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:07 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 02:21:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:07 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 02:21:08 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:08 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:09 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:09 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:16 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:17 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:18 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:24 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 02:21:24 BGP: [M7Q4P-46WDR] vty[??]@# do write memory

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20615/artifact/TOPO3U18I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 7
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 arm8 part 0
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 0
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests debian 10 amd64 part 4
  • Topotests debian 10 amd64 part 6
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 1
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv6 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 8
  • Topotests debian 10 amd64 part 8
  • Topotests debian 10 amd64 part 7
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 6
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 5
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 20.04 deb pkg check
  • Topotests debian 10 amd64 part 1
  • Debian 9 deb pkg check
  • Topotests debian 10 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 3
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 2

idryzhov added 6 commits July 30, 2021 00:59
Current code is a complete misuse of SLIST structure. Instead of just
adding a SLIST_ENTRY to struct bgp_damp_info, it allocates a separate
structure to be a node in the list.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
bdi->path is never NULL, therefore the structure was never freed.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
bgp_damp_config, afi and safi are never used.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
When bgp_damp_info_free is called from bgp_route.c, we were never
deleting the BDI from the list.

Move the deletion inside bgp_damp_info_free to cover all cases.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
This code always used double-linked list before this rework in 8.0 that
introduced all these crashes and memory leaks. Using single-linked list
is actually a performance regression, because there are frequent removes
here and single-linked list obviously handles removes much worse.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 29, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9217 db0e636
Date 07/29/2021
Start 18:08:05
Finish 18:33:38
Run-Time 25:33
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-29-18:08:05.txt
Log autoscript-2021-07-29-18:09:20.log.bz2
Memory 498 521 427

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 30, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20647/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-20647/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1:

2021-07-29 22:43:09,273 ERROR: 'router_json_cmp' failed after 130.60 seconds
2021-07-29 22:43:09,282 ERROR: assert failed at "bfd_topo2.test_bfd_topo2/test_protocols_convergence": "r4" JSON output mismatches
assert Generated JSON diff error report:
  
  > $: d2 has key '2001:db8:1::/64' which is not present in d1
2021-07-29 23:12:56,509 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 204, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
% Specify remote-as or peer-group commands first
line 7: Failure to communicate[13] to bgpd, line: neighbor 10.0.0.13 timers 3 10 

line 9: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 11: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 timers 3 10 

% Specify remote-as or peer-group commands first
line 14: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2021-07-29 23:12:57,175 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 204, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20647/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 arm8 part 5
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 4
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 9
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Static analyzer (clang)
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 amd64 part 3
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests debian 10 amd64 part 7
  • Addresssanitizer topotests part 6
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests debian 10 amd64 part 1
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 4
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 2
  • Debian 10 deb pkg check
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 0
  • Addresssanitizer topotests part 9
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 5
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 1

@idryzhov
Copy link
Contributor Author

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20653/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@ton31337
Copy link
Member

@Mergifyio backport stable/8.0

@mergify
Copy link

mergify bot commented Jul 30, 2021

Command backport stable/8.0: pending

Waiting for the pull request to get merged

@ton31337 ton31337 merged commit c48aaa0 into FRRouting:master Jul 30, 2021
@mergify
Copy link

mergify bot commented Jul 30, 2021

Command backport stable/8.0: success

Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants