Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Set addresses before we use snmpd #9216

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

donaldsharp
Copy link
Member

The test_simple_snmp.py test starts bgp, zebra and snmpd at the
same time. Then zebra configuration is read in and interface
addresses are applied. If snmp start slower than zebra
the snmp process can properly get it's ip address to bind to
if it is faster than zebra, it will fail. Ensure that the
test has addresses before we start daemons.

Signed-off-by: Donald Sharp sharpd@nvidia.com

The test_simple_snmp.py test starts bgp, zebra and snmpd at the
same time.  Then zebra configuration is read in and interface
addresses are applied.  If snmp start slower than zebra
the snmp process can properly get it's ip address to bind to
if it is faster than zebra, it will fail.  Ensure that the
test has addresses before we start daemons.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
@polychaeta polychaeta added the tests Topotests, make check, etc label Jul 28, 2021
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 28, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9216 14fdbe0
Date 07/28/2021
Start 18:25:50
Finish 18:51:19
Run-Time 25:29
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-28-18:25:50.txt
Log autoscript-2021-07-28-18:27:03.log.bz2
Memory 511 520 409

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20614/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit 31a8ea0 into FRRouting:master Jul 29, 2021
@choppsv1
Copy link
Contributor

This similar to another fix we put in. These seem more like stop-gap fixes though. I think we need to look into doing a couple things to fix this type of error:

  1. fix how the framework launches zebra, perhaps pausing before launching other daemons to give time for the interface config to be sent to the kernel.'
  2. Do we need to fix the user startup scripts to do something similar (i.e., launch zebra first)?

How does this play with the integrated config option?

@donaldsharp donaldsharp deleted the simple_snmp_fix branch September 5, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Topotests, make check, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants