Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: prevent crash in make check in some situations #9211

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

donaldsharp
Copy link
Member

When running make check against a build that zeromq enabled
the test_zmq unit test was crashing. The commit:

e08165d

Introduced this crash. Removing the part of the commit
that was causing the crash in the test. This is mainly
to get make check working again for those people using
zeromq in their builds.

Fixes: #9176
Signed-off-by: Donald Sharp sharpd@nvidia.com

When running `make check` against a build that zeromq enabled
the test_zmq unit test was crashing.  The commit:

e08165d

Introduced this crash.  Removing the part of the commit
that was causing the crash in the test.  This is mainly
to get `make check` working again for those people using
zeromq in their builds.

Fixes: FRRouting#9176
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
@donaldsharp donaldsharp force-pushed the revert_logic_changes branch from 99ede8f to fb1df4c Compare July 28, 2021 18:41
@donaldsharp
Copy link
Member Author

I tried to document in the code the pitfalls of the zeromq. I erred on the side of getting make check working again for people just compiling with zeromq( us developers ). I also tried to call out to future developers that they need to be a bit more careful about changes to this file. Hopefully we can catch changes before they become a problem.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 28, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/9211 fb1df4c
Date 07/28/2021
Start 14:45:51
Finish 15:11:26
Run-Time 25:35
Total 1813
Pass 1813
Fail 0
Valgrind-Errors
Valgrind-Loss
Details vncregress-2021-07-28-14:45:51.txt
Log autoscript-2021-07-28-14:47:04.log.bz2
Memory 520 502 431

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 28, 2021

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20604/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 28, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20605/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO1DEB10AMD64-20605/test

Topology Tests failed for Topotests debian 10 amd64 part 1:

2021-07-28 19:28:00,377 ERROR: 'router_json_cmp' failed after 131.85 seconds
2021-07-28 19:28:00,379 ERROR: assert failed at "bfd_topo2.test_bfd_topo2/test_protocols_convergence": "r4" JSON output mismatches
assert Generated JSON diff error report:
  
  > $: d2 has key '2001:db8:1::/64' which is not present in d1
2021-07-28 19:44:39,866 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/bgp.py", line 204, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
% Specify remote-as or peer-group commands first
line 7: Failure to communicate[13] to bgpd, line: neighbor 10.0.0.13 timers 3 10 

line 9: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 11: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 timers 3 10 

% Specify remote-as or peer-group commands first
line 14: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2021-07-28 19:44:40,441 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/bgp.py", line 204, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 363, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO1DEB10AMD64/topotests/lib/common_config.py", line 590, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20605/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 amd64 part 9
  • Addresssanitizer topotests part 9
  • Fedora 29 rpm pkg check
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 4
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 i386 part 4
  • Static analyzer (clang)
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 arm8 part 0
  • Topotests Ubuntu 18.04 amd64 part 0
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 3
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests Ubuntu 18.04 amd64 part 3
  • IPv6 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 1
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 1
  • Addresssanitizer topotests part 6
  • Addresssanitizer topotests part 8
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 arm8 part 6
  • Topotests debian 10 amd64 part 7
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests debian 10 amd64 part 9
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 arm8 part 4
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 i386 part 5
  • Debian 10 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 8
  • IPv4 ldp protocol on Ubuntu 18.04
  • Debian 9 deb pkg check

Copy link
Contributor

@mjstapp mjstapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in agreement with this - avoid hurting unit-test users, and I'll look again to see whether there's anything more to do in this path

@mjstapp
Copy link
Contributor

mjstapp commented Jul 29, 2021

CI:rerun

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jul 29, 2021

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20630/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP3U1804AMD64-20630/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3:

2021-07-29 13:48:47,328 ERROR: 'router_json_cmp' failed after 45.81 seconds
2021-07-29 13:48:47,336 ERROR: assert failed at "test_bgp_features/test_bgp_delayopen_dual": BGP session on r2 did not establish a connection with peer
assert Generated JSON diff error report:
  
  > $->ipv4Unicast->peers->192.168.201.2->state: d1 has element with value 'Connect' but in d2 it has value 'Established'
r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 14:00:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:00:52 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 14:00:52 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:00:52 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 14:00:53 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:00:53 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 14:00:53 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:00:53 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 14:00:54 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:00:54 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:00:55 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:00:55 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:01:02 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:01:02 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:01:03 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:01:03 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:01:03 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:01:10 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:01:10 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r2: Daemon bgpd not running

From frr r2 bgpd log file:
2021/07/29 14:02:47 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:47 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart json
2021/07/29 14:02:47 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:47 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.1 graceful-restart 
2021/07/29 14:02:48 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:48 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart json
2021/07/29 14:02:48 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:48 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::1 graceful-restart 
2021/07/29 14:02:48 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:49 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:49 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:49 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:02:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:03:04 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:03:04 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 14:04:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:04:56 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 14:04:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:04:56 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 14:04:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:04:57 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 14:04:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:04:57 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 14:04:58 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:04:58 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:04:58 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:04:59 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:07 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:08 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:14 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:14 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 14:05:33 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/07/29 14:05:34 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:34 BGP: [M7Q4P-46WDR] vty[??]@# do show logging
2021/07/29 14:05:35 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:35 BGP: [M7Q4P-46WDR] vty[??]@# do write terminal

2021/07/29 14:05:35 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 14:05:35 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/07/29 14:05:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:05:36 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/07/29 14:05:36 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/07/29 14:05:36 BGP: [M7Q4P-46WDR] vty[??]@(config)# no log commands

2021/07/29 14:05:36 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 14:05:38 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 14:05:41 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 14:05:42 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default
2021/07/29 14:06:20 BGP: [VTVCM-Y2NW3] Configuration Read in Took: 00:00:00
2021/07/29 14:06:23 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv4 Unicast from 192.168.0.2 in vrf default
2021/07/29 14:06:23 BGP: [M59KS-A3ZXZ] bgp_update_receive: rcvd End-of-RIB for IPv6 Unicast from fd00::2 in vrf default

r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 14:07:53 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:07:53 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 14:07:55 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:07:55 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 14:07:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:07:56 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 14:07:56 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:07:56 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 14:07:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:07:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:07:57 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:07:58 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:08:04 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:08:05 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:08:05 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:08:05 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:08:06 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:08:12 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:08:12 BGP: [M7Q4P-46WDR] vty[??]@# do write memory


r1: Daemon bgpd not running

From frr r1 bgpd log file:
2021/07/29 14:09:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:25 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart json
2021/07/29 14:09:25 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:25 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv4 neighbor 192.168.0.2 graceful-restart 
2021/07/29 14:09:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:26 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart json
2021/07/29 14:09:26 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:26 BGP: [M7Q4P-46WDR] vty[??]@# show bgp ipv6 neighbor fd00::2 graceful-restart 
2021/07/29 14:09:27 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:28 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:28 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:29 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:36 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:37 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:43 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/07/29 14:09:43 BGP: [M7Q4P-46WDR] vty[??]@# do write memory

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20630/artifact/TP3U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 0
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 0
  • Addresssanitizer topotests part 0
  • Topotests Ubuntu 18.04 arm8 part 5
  • IPv4 ldp protocol on Ubuntu 18.04
  • Topotests debian 10 amd64 part 4
  • Topotests Ubuntu 18.04 i386 part 0
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 i386 part 5
  • Topotests debian 10 amd64 part 9
  • Static analyzer (clang)
  • Addresssanitizer topotests part 1
  • CentOS 7 rpm pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Topotests debian 10 amd64 part 8
  • Topotests Ubuntu 18.04 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 arm8 part 3
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 amd64 part 4
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 arm8 part 6
  • IPv4 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 arm8 part 1
  • Topotests debian 10 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 2
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 7
  • Ubuntu 16.04 deb pkg check
  • Topotests Ubuntu 18.04 arm8 part 2
  • Topotests Ubuntu 18.04 i386 part 6
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 amd64 part 6
  • Addresssanitizer topotests part 6
  • Topotests debian 10 amd64 part 2
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Debian 9 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests debian 10 amd64 part 3
  • Addresssanitizer topotests part 2
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 i386 part 8
  • Addresssanitizer topotests part 7
  • Topotests debian 10 amd64 part 0
  • Topotests Ubuntu 18.04 i386 part 3
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 7
  • Addresssanitizer topotests part 3

@mjstapp
Copy link
Contributor

mjstapp commented Jul 30, 2021

CI:rerun

@mjstapp
Copy link
Contributor

mjstapp commented Jul 30, 2021

Living in hope...

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20671/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@mjstapp mjstapp merged commit 08bbca7 into FRRouting:master Aug 2, 2021
@donaldsharp donaldsharp deleted the revert_logic_changes branch September 5, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lib: ZeroMQ unit test crashes with double free
6 participants