-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: prevent crash in make check in some situations #9211
Conversation
When running `make check` against a build that zeromq enabled the test_zmq unit test was crashing. The commit: e08165d Introduced this crash. Removing the part of the commit that was causing the crash in the test. This is mainly to get `make check` working again for those people using zeromq in their builds. Fixes: FRRouting#9176 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
99ede8f
to
fb1df4c
Compare
I tried to document in the code the pitfalls of the zeromq. I erred on the side of getting |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20604/ This is a comment from an automated CI system. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO1DEB10AMD64-20605/test Topology Tests failed for Topotests debian 10 amd64 part 1:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20605/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in agreement with this - avoid hurting unit-test users, and I'll look again to see whether there's anything more to do in this path
CI:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP3U1804AMD64-20630/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 3:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20630/artifact/TP3U1804AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
CI:rerun |
Living in hope... |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20671/ This is a comment from an automated CI system. |
When running
make check
against a build that zeromq enabledthe test_zmq unit test was crashing. The commit:
e08165d
Introduced this crash. Removing the part of the commit
that was causing the crash in the test. This is mainly
to get
make check
working again for those people usingzeromq in their builds.
Fixes: #9176
Signed-off-by: Donald Sharp sharpd@nvidia.com