grpc: improve checks for GRPC C++ requirements #8707

choppsv1 · 2021-05-20T07:34:02Z

Just checking for grpc++ is not enough as older distributions have incompatible versions (e.g., Ubuntu 18.04)

Signed-off-by: Christian Hopps chopps@labn.net

LabN-CI · 2021-05-20T08:27:11Z

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 1 tests failed

_	_
Result	SUCCESS git merge/8707 `5d37661`
Date	05/20/2021
Start	04:01:24
Finish	04:27:07
Run-Time	25:43
Total	1815
Pass	1814
Fail	1
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-05-20-04:01:24.txt
Log	autoscript-2021-05-20-04:02:45.log.bz2
Memory	497 484 428

For details, please contact louberger

NetDEF-CI · 2021-05-20T13:53:27Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19130/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

LabN-CI · 2021-05-20T14:07:18Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/8707 `05ca018`
Date	05/20/2021
Start	09:41:25
Finish	10:07:13
Run-Time	25:48
Total	1815
Pass	1815
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-05-20-09:41:25.txt
Log	autoscript-2021-05-20-09:42:38.log.bz2
Memory	500 489 427

For details, please contact louberger

NetDEF-CI · 2021-05-20T18:46:28Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19140/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9DEB10AMD64-19140/test

Topology Tests failed for Topotests debian 10 amd64 part 9:

2021-05-20 14:15:51,054 WARNING: vtysh_cmd: failed to convert json output
2021-05-20 14:16:16,705 WARNING: vtysh_cmd: failed to convert json output
2021-05-20 14:27:14,717 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 1803, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-05-20 14:27:55,223 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 1803, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536 


2021-05-20 14:33:32,243 ERROR: 'router_json_cmp' failed after 87.07 seconds
2021-05-20 14:33:32,245 ERROR: assert failed at "ospf_sr_topo1.test_ospf_sr_topo1/test_rib_ipv4_step4": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.8.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "prefix": "10.0.8.0/24",
  	    "protocol": "ospf",
  	    "metric": 10,
  	    "nexthops": [
  	        {
  	            "active": true,
  	            "directlyConnected": true,
  	            "interfaceName": "eth-rt5"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.8.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "active": true,
  		    "directlyConnected": true,
  		    "interfaceName": "eth-rt5"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.8.0/24[0]->nexthops[0]: d2 has key 'active' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19140/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 4: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1804AMD64-19140/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4:

2021-05-20 14:33:42,565 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2021-05-20 14:33:42,755 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2021-05-20 14:33:42,942 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2021-05-20 14:33:43,133 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2021-05-20 14:33:44,417 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 1:a:2 



2021-05-20 14:36:13,859 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 2512, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP4U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Unknown command[4]: bgp large-community-list standard Test1 permit  


r2: Daemon bgpd not running

From frr r2 bgpd log file:
2021/05/20 14:37:59 BGP: [HG1WF-2N96F] YANG model "ietf-yang-types@*" "*@*"not embedded, trying external file
2021/05/20 14:37:59 BGP: [HG1WF-2N96F] YANG model "ietf-inet-types@*" "*@*"not embedded, trying external file
2021/05/20 14:37:59 BGP: [T83RR-8SM5G] bgpd 8.1-dev-20210520-00-g05ca0188f starting: vty@2605, bgp@10.0.0.2:179, bgp@10.0.1.1:179
2021/05/20 14:37:59 BGP: [M7Q4P-46WDR] vty[??]@(config)# log file bgpd.log
2021/05/20 14:38:01 BGP: [M7Q4P-46WDR] vty[??]@> enable
2021/05/20 14:38:01 BGP: [M7Q4P-46WDR] vty[??]@# configure terminal
2021/05/20 14:38:01 BGP: [M7Q4P-46WDR] vty[??]@(config)# XFRR_start_configuration
2021/05/20 14:38:01 BGP: [M7Q4P-46WDR] vty[??]@(config)# router bgp 2000 

2021/05/20 14:38:01 BGP: [WNS64-X9NY5][EC 100663299] bind: Cannot assign requested address
2021/05/20 14:38:01 BGP: [HHAYK-1Y778][EC 100663299] bgp_socket: no usable addresses please check other programs usage of specified port 179
2021/05/20 14:38:01 BGP: [VD9ME-QCNTF][EC 100663299] bgp_socket: Program cannot continue

2021-05-20 14:38:03,178 ERROR: assert failed at "test_bgp_listen_on_multiple_addresses/test_peering": r2: Daemon bgpd not running

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19140/artifact/TP4U1804AMD64/ErrorLog/log_topotests.txt

Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-19140/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1:

2021-05-20 14:17:21,718 ERROR: 'router_json_cmp' failed after 121.59 seconds
2021-05-20 14:17:21,721 ERROR: assert failed at "bfd_topo2.test_bfd_topo2/test_protocols_convergence": "r2" JSON output mismatches
assert Generated JSON diff error report:
  
  > $: d2 has key '10.254.254.1/32' which is not present in d1
2021-05-20 14:44:56,303 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 203, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 
% Specify remote-as or peer-group commands first
line 7: Failure to communicate[13] to bgpd, line: neighbor 10.0.0.13 timers 3 10 

line 9: % Unknown command[30]: neighbor fd00:0:0:3::1 remote-as 0 
% Specify remote-as or peer-group commands first
line 11: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 activate 

% Specify remote-as or peer-group commands first
line 12: Failure to communicate[13] to bgpd, line: neighbor fd00:0:0:3::1 timers 3 10 

% Specify remote-as or peer-group commands first
line 14: Failure to communicate[13] to bgpd, line: no neighbor fd00:0:0:3::1 activate 



2021-05-20 14:44:56,832 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 203, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19140/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 6
Topotests Ubuntu 18.04 arm8 part 1
Topotests debian 10 amd64 part 3
Addresssanitizer topotests part 3
Addresssanitizer topotests part 6
Topotests debian 10 amd64 part 7
Ubuntu 16.04 deb pkg check
Topotests debian 10 amd64 part 8
Topotests Ubuntu 18.04 i386 part 1
Topotests Ubuntu 18.04 amd64 part 5
Topotests Ubuntu 18.04 i386 part 6
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 6
Ubuntu 20.04 deb pkg check
IPv4 ldp protocol on Ubuntu 18.04
Topotests debian 10 amd64 part 1
Debian 9 deb pkg check
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 i386 part 0
Topotests Ubuntu 18.04 i386 part 5
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 2
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 8
Addresssanitizer topotests part 2
Topotests debian 10 amd64 part 0
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 8
Topotests Ubuntu 18.04 i386 part 3
Topotests Ubuntu 18.04 arm8 part 4
Addresssanitizer topotests part 9
Addresssanitizer topotests part 5
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 amd64 part 9
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 i386 part 2
Topotests Ubuntu 18.04 arm8 part 0
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 arm8 part 5
Topotests debian 10 amd64 part 4
Topotests Ubuntu 18.04 i386 part 7
Addresssanitizer topotests part 4
Static analyzer (clang)
Ubuntu 18.04 deb pkg check
Topotests debian 10 amd64 part 6
Addresssanitizer topotests part 1
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 0
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 2
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 9

choppsv1 · 2021-05-21T19:22:45Z

ci:rerun

Signed-off-by: Christian Hopps <chopps@labn.net>

LabN-CI · 2021-05-22T00:31:18Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/8644 `11f27f5`
Date	05/06/2021
Start	20:05:48
Finish	20:31:27
Run-Time	25:39
Total	1815
Pass	1815
Fail	0
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2021-05-06-20:05:48.txt
Log	autoscript-2021-05-06-20:07:07.log.bz2
Memory	507 488 428
SUCCESS git merge/8707 `41b7a98`	SUCCESS git merge/8105 `a831c41`
05/21/2021	02/17/2021
20:05:40	20:05:40
20:31:13	20:44:57
25:33	39:17
1818	1815
1818	1815
0	0
0
0
vncregress-2021-05-21-20:05:40.txt	vncregress-2021-02-17-20:05:40.txt
autoscript-2021-05-21-20:06:56.log.bz2	autoscript-2021-02-17-20:06:43.log.bz2
516 490 428	505 494 427

For details, please contact louberger

NetDEF-CI · 2021-05-22T04:46:54Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19178/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9DEB10AMD64-19178/test

Topology Tests failed for Topotests debian 10 amd64 part 9:

2021-05-22 00:42:54,025 WARNING: vtysh_cmd: failed to convert json output
2021-05-22 00:43:16,603 WARNING: vtysh_cmd: failed to convert json output
2021-05-22 00:53:21,092 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 1803, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf hello-interval 65536 


2021-05-22 00:53:59,453 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 1803, in create_interfaces_cfg
    tgen, c_router, interface_data, "interface_config", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 344, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPO9DEB10AMD64/topotests/lib/common_config.py", line 605, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 3: % Unknown command[16]: ip ospf dead-interval 65536 


2021-05-22 00:55:46,962 ERROR: r4: zebra left a dead pidfile (pid=17773)
2021-05-22 00:58:20,706 ERROR: 'router_json_cmp' failed after 84.77 seconds
2021-05-22 00:58:20,708 ERROR: assert failed at "ospf_sr_topo1.test_ospf_sr_topo1/test_rib_ipv4_step4": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.8.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "prefix": "10.0.8.0/24",
  	    "protocol": "ospf",
  	    "metric": 10,
  	    "nexthops": [
  	        {
  	            "active": true,
  	            "directlyConnected": true,
  	            "interfaceName": "eth-rt5"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.8.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "active": true,
  		    "directlyConnected": true,
  		    "interfaceName": "eth-rt5"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.8.0/24[0]->nexthops[0]: d2 has key 'active' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19178/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Topotests debian 10 amd64 part 1
Topotests Ubuntu 18.04 i386 part 7
Topotests debian 10 amd64 part 6
Ubuntu 20.04 deb pkg check
Addresssanitizer topotests part 4
Topotests Ubuntu 18.04 amd64 part 1
Addresssanitizer topotests part 2
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
CentOS 7 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 8
Topotests Ubuntu 18.04 i386 part 2
Addresssanitizer topotests part 9
Topotests Ubuntu 18.04 arm8 part 2
Topotests Ubuntu 18.04 arm8 part 7
Topotests Ubuntu 18.04 arm8 part 3
Topotests Ubuntu 18.04 i386 part 8
Topotests debian 10 amd64 part 0
Topotests Ubuntu 18.04 i386 part 3
Topotests debian 10 amd64 part 5
Topotests Ubuntu 18.04 i386 part 1
Addresssanitizer topotests part 7
Topotests Ubuntu 18.04 arm8 part 8
Topotests Ubuntu 18.04 amd64 part 2
Addresssanitizer topotests part 5
Static analyzer (clang)
Topotests debian 10 amd64 part 3
Topotests Ubuntu 18.04 amd64 part 6
Ubuntu 16.04 deb pkg check
Topotests Ubuntu 18.04 arm8 part 0
Topotests debian 10 amd64 part 2
Topotests Ubuntu 18.04 i386 part 6
Topotests Ubuntu 18.04 arm8 part 5
IPv4 ldp protocol on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 4
Topotests Ubuntu 18.04 i386 part 0
Addresssanitizer topotests part 3
Topotests Ubuntu 18.04 i386 part 5
Topotests debian 10 amd64 part 4
Addresssanitizer topotests part 0
Topotests Ubuntu 18.04 i386 part 4
Topotests Ubuntu 18.04 i386 part 9
IPv6 protocols on Ubuntu 18.04
Topotests Ubuntu 18.04 amd64 part 0
Addresssanitizer topotests part 1
Topotests Ubuntu 18.04 amd64 part 3
Topotests Ubuntu 18.04 arm8 part 4
Topotests debian 10 amd64 part 7
Topotests Ubuntu 18.04 arm8 part 9
Topotests Ubuntu 18.04 arm8 part 6
IPv4 protocols on Ubuntu 18.04
Addresssanitizer topotests part 8
Topotests Ubuntu 18.04 arm8 part 1
Debian 10 deb pkg check
Topotests Ubuntu 18.04 amd64 part 7
Topotests Ubuntu 18.04 amd64 part 9
Addresssanitizer topotests part 6
Fedora 29 rpm pkg check
Topotests Ubuntu 18.04 amd64 part 5
Topotests debian 10 amd64 part 8

choppsv1 · 2021-05-22T10:18:13Z

ci:rerun

NetDEF-CI · 2021-05-22T15:01:25Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19180/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

riw777

this looks good to me ... will wait a bit to see if someone else reviews

eqvinox · 2021-05-27T00:05:56Z

configure.ac

@@ -1924,7 +1924,9 @@ dnl ---------------
 dnl gRPC
 dnl ---------------
 if test "$enable_grpc" = "yes"; then
-  PKG_CHECK_MODULES([GRPC], [grpc grpc++ protobuf], [
+  AC_LANG([C++])


This changes the language for the entire remainder of configure.ac, can you fix it to use AC_LANG_PUSH + AC_LANG_POP afterwards?

I pushed the change, but I don't know if it's picking it up since this is merged now. SHould I do another PR?

eqvinox · 2021-05-27T00:06:52Z

Actually still had a small problem :/

@choppsv1 can you push a PR to fix?

choppsv1 force-pushed the chopps/improve-grpc-req-checks branch from 5d37661 to 05ca018 Compare May 20, 2021 13:28

grpc: improve checks for GRPC C++ requirements

41b7a98

Signed-off-by: Christian Hopps <chopps@labn.net>

choppsv1 force-pushed the chopps/improve-grpc-req-checks branch from 05ca018 to 41b7a98 Compare May 22, 2021 00:01

riw777 approved these changes May 25, 2021

View reviewed changes

qlyoung self-requested a review May 25, 2021 15:33

qlyoung added this to the 8.0 milestone May 25, 2021

qlyoung added libfrr backport labels May 25, 2021

qlyoung merged commit f4db21a into FRRouting:master May 26, 2021

eqvinox reviewed May 27, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

grpc: improve checks for GRPC C++ requirements #8707

grpc: improve checks for GRPC C++ requirements #8707

choppsv1 commented May 20, 2021

LabN-CI commented May 20, 2021 •

edited

Loading

Basic BGPD CI results: Partial FAILURE, 1 tests failed

NetDEF-CI commented May 20, 2021 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

LabN-CI commented May 20, 2021 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 20, 2021 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

choppsv1 commented May 21, 2021 •

edited

Loading

LabN-CI commented May 22, 2021

NetDEF-CI commented May 22, 2021 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

choppsv1 commented May 22, 2021

NetDEF-CI commented May 22, 2021

riw777 left a comment

eqvinox May 27, 2021

choppsv1 May 27, 2021

eqvinox commented May 27, 2021

grpc: improve checks for GRPC C++ requirements #8707

grpc: improve checks for GRPC C++ requirements #8707

Conversation

choppsv1 commented May 20, 2021

LabN-CI commented May 20, 2021 • edited Loading

Basic BGPD CI results: Partial FAILURE, 1 tests failed

NetDEF-CI commented May 20, 2021 • edited Loading

Continuous Integration Result: SUCCESSFUL

LabN-CI commented May 20, 2021 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 20, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

choppsv1 commented May 21, 2021 • edited Loading

LabN-CI commented May 22, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 22, 2021 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

choppsv1 commented May 22, 2021

NetDEF-CI commented May 22, 2021

Continuous Integration Result: SUCCESSFUL

riw777 left a comment

Choose a reason for hiding this comment

eqvinox May 27, 2021

Choose a reason for hiding this comment

choppsv1 May 27, 2021

Choose a reason for hiding this comment

eqvinox commented May 27, 2021

LabN-CI commented May 20, 2021 •

edited

Loading

NetDEF-CI commented May 20, 2021 •

edited

Loading

LabN-CI commented May 20, 2021 •

edited

Loading

NetDEF-CI commented May 20, 2021 •

edited

Loading

choppsv1 commented May 21, 2021 •

edited

Loading

NetDEF-CI commented May 22, 2021 •

edited

Loading