[7.6] libs, ospfd: remove inet_ntoa

[mjstapp]

[7.6 version] remove calls to inet_ntoa, introduced recently.

[polychaeta]

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/54913b1f7455710f38f71a03c6606489/raw/f94b88e0668a6d93a52f1cba4cf0595f57f18b61/cr_7979_1611926584.diff | git apply

diff --git a/lib/link_state.c b/lib/link_state.c
index 8dc5ab8ee..90495ea55 100644
--- a/lib/link_state.c
+++ b/lib/link_state.c
@@ -1272,11 +1272,9 @@ void ls_dump_ted(struct ls_ted *ted)
 	}
 	frr_each(subnets, &ted->subnets, subnet) {
 		ls_subnet2msg(&msg, subnet);
-		zlog_debug(
-			"\tTed subnet key:%pFX vertex:%pI4 pfx:%pFX",
-			&subnet->key,
-			&subnet->vertex->node->adv.id.ip.addr,
-			&subnet->ls_pref->pref);
+		zlog_debug("\tTed subnet key:%pFX vertex:%pI4 pfx:%pFX",
+			   &subnet->key, &subnet->vertex->node->adv.id.ip.addr,
+			   &subnet->ls_pref->pref);
 	}
 	zlog_debug("(%s) Ted end", __func__);
 }
diff --git a/ospfd/ospf_lsa.c b/ospfd/ospf_lsa.c
index a71453854..bfd82a1d3 100644
--- a/ospfd/ospf_lsa.c
+++ b/ospfd/ospf_lsa.c
@@ -2854,10 +2854,11 @@ static int ospf_maxage_lsa_remover(struct thread *thread)
 				 * as the LSA in LSDB
 				 */
 				if (old != lsa) {
-					flog_err(EC_OSPF_LSA_MISSING,
-						 "%s: LSA[Type%d:%pI4]: LSA not in LSDB",
-						 __func__, lsa->data->type,
-						 &lsa->data->id);
+					flog_err(
+						EC_OSPF_LSA_MISSING,
+						"%s: LSA[Type%d:%pI4]: LSA not in LSDB",
+						__func__, lsa->data->type,
+						&lsa->data->id);
 
 					continue;
 				}

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16832/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16832/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210129-02-gaedbc33d9-0 (missing) -> 7.6-dev-20210129-02-gaedbc33d9-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210129-02-gaedbc33d9-0 (missing) -> 7.6-dev-20210129-02-gaedbc33d9-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210129-02-gaedbc33d9-0 (missing) -> 7.6-dev-20210129-02-gaedbc33d9-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210129-02-gaedbc33d9-0 (missing) -> 7.6-dev-20210129-02-gaedbc33d9-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20210129-02-gaedbc33d9-0 (missing) -> 7.6-dev-20210129-02-gaedbc33d9-0~deb10u1