-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pceplib: Integrate pcelib into frr #7963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to FRR!
sprintf, strcat, strcpy
are banned; please usesnprintf, strlcat, strlcpy
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 11 amd64 build: Failed (click for details)Configure failed for FreeBSD 11 amd64 build:
FreeBSD 11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/CI009BUILD/config.log/config.log Ubuntu 16.04 arm7 build: Failed (click for details)Ubuntu 16.04 arm7 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/CI101BUILD/config.log/config.logConfigure failed for Ubuntu 16.04 arm7 build:
Ubuntu 18.04 arm8 build: Failed (click for details)Ubuntu 18.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/U18ARM8BUILD/config.log/config.logConfigure failed for Ubuntu 18.04 arm8 build:
Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/CI008BLD/config.log/config.logConfigure failed for Debian 8 amd64 build:
FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/FBSD12AMD64/config.log/config.log OpenBSD 6 amd64 build: Failed (click for details)Configure failed for OpenBSD 6 amd64 build:
OpenBSD 6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/CI011BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 16.04 amd64 build:
Ubuntu 16.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/CI014BUILD/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/U1804AMD64/config.log/config.log Ubuntu 18.04 arm7 build: Failed (click for details)Configure failed for Ubuntu 18.04 arm7 build:
Ubuntu 18.04 arm7 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/U18ARM7BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/U2004AMD64BUILD/config.log/config.log Ubuntu 18.04 ppc64le build: Failed (click for details)Configure failed for Ubuntu 18.04 ppc64le build:
Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/U1804PPC64LEBUILD/config.log/config.log NetBSD 8 amd64 build: Failed (click for details)NetBSD 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/CI012BUILD/config.log/config.logConfigure failed for NetBSD 8 amd64 build:
Debian 9 amd64 build: Failed (click for details)Configure failed for Debian 9 amd64 build:
Debian 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/CI021BUILD/config.log/config.log Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/U16ARM8BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16766/artifact/U1604I386/config.log/config.log Successful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedFreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/U1804AMD64/config.log/config.log Ubuntu 16.04 arm7 build: Failed (click for details)Ubuntu 16.04 arm7 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/CI101BUILD/config.log/config.logConfigure failed for Ubuntu 16.04 arm7 build:
Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/CI008BLD/config.log/config.logConfigure failed for Debian 8 amd64 build:
Ubuntu 18.04 ppc64le build: Failed (click for details)Configure failed for Ubuntu 18.04 ppc64le build:
Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/U1804PPC64LEBUILD/config.log/config.log Debian 9 amd64 build: Failed (click for details)Configure failed for Debian 9 amd64 build:
Debian 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/CI021BUILD/config.log/config.log OpenBSD 6 amd64 build: Failed (click for details)Configure failed for OpenBSD 6 amd64 build:
OpenBSD 6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/CI011BUILD/config.log/config.log FreeBSD 11 amd64 build: Failed (click for details)Configure failed for FreeBSD 11 amd64 build:
FreeBSD 11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/CI009BUILD/config.log/config.log NetBSD 8 amd64 build: Failed (click for details)NetBSD 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/CI012BUILD/config.log/config.logConfigure failed for NetBSD 8 amd64 build:
Ubuntu 18.04 arm7 build: Failed (click for details)Configure failed for Ubuntu 18.04 arm7 build:
Ubuntu 18.04 arm7 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/U18ARM7BUILD/config.log/config.log Ubuntu 18.04 arm8 build: Failed (click for details)Ubuntu 18.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/U18ARM8BUILD/config.log/config.logConfigure failed for Ubuntu 18.04 arm8 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 16.04 amd64 build:
Ubuntu 16.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/CI014BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/U2004AMD64BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/U1604I386/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16771/artifact/U16ARM8BUILD/config.log/config.log Successful on other platforms/tests
|
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16782/ This is a comment from an automated CI system. |
This does not build properly with --enable-dev:
|
Warnings need to be cleaned up:
|
I'd like to follow the same directory structure if at all possible in FRR across the board. Can we move everything in the src directory up one level? |
the jpg images. Probably belong in the user/developer directory now? |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
Thank you for your comments. |
doc/developer/pceplib sounds great |
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-16826/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16826/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-16827/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16827/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16831/ This is a comment from an automated CI system. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-16834/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16834/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
ci:rerun |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-16852/test Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16852/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16853/ This is a comment from an automated CI system. |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: IncompleteUbuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U16ARM8BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U2004AMD64BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build:
Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/F29BUILD/config.log/config.log FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1804AMD64/config.log/config.log CentOS 8 amd64 build: Failed (click for details)Configure failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CENTOS8BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1604I386/config.log/config.log Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U16ARM8BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U2004AMD64BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build:
Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/F29BUILD/config.log/config.log FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1804AMD64/config.log/config.log CentOS 8 amd64 build: Failed (click for details)Configure failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CENTOS8BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1604I386/config.log/config.log Ubuntu 16.04 arm7 build: Incomplete(check logs for details)Debian 9 amd64 build: Failed (click for details)Configure failed for Debian 9 amd64 build:
Debian 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI021BUILD/config.log/config.log Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI008BLD/config.log/config.logConfigure failed for Debian 8 amd64 build:
FreeBSD 11 amd64 build: Failed (click for details)Configure failed for FreeBSD 11 amd64 build:
FreeBSD 11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI009BUILD/config.log/config.log Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U16ARM8BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U2004AMD64BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build:
Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/F29BUILD/config.log/config.log FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1804AMD64/config.log/config.log CentOS 8 amd64 build: Failed (click for details)Configure failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CENTOS8BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1604I386/config.log/config.log Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U16ARM8BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U2004AMD64BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build:
Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/F29BUILD/config.log/config.log FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1804AMD64/config.log/config.log CentOS 8 amd64 build: Failed (click for details)Configure failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CENTOS8BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1604I386/config.log/config.log Ubuntu 16.04 arm7 build: Incomplete(check logs for details)Debian 9 amd64 build: Failed (click for details)Configure failed for Debian 9 amd64 build:
Debian 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI021BUILD/config.log/config.log Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI008BLD/config.log/config.logConfigure failed for Debian 8 amd64 build:
FreeBSD 11 amd64 build: Failed (click for details)Configure failed for FreeBSD 11 amd64 build:
FreeBSD 11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI009BUILD/config.log/config.log Ubuntu 18.04 ppc64le build: Incomplete(check logs for details)Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U16ARM8BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U2004AMD64BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build:
Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/F29BUILD/config.log/config.log FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1804AMD64/config.log/config.log CentOS 8 amd64 build: Failed (click for details)Configure failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CENTOS8BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1604I386/config.log/config.log Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U16ARM8BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U2004AMD64BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build:
Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/F29BUILD/config.log/config.log FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1804AMD64/config.log/config.log CentOS 8 amd64 build: Failed (click for details)Configure failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CENTOS8BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1604I386/config.log/config.log Ubuntu 16.04 arm7 build: Incomplete(check logs for details)Debian 9 amd64 build: Failed (click for details)Configure failed for Debian 9 amd64 build:
Debian 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI021BUILD/config.log/config.log Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI008BLD/config.log/config.logConfigure failed for Debian 8 amd64 build:
FreeBSD 11 amd64 build: Failed (click for details)Configure failed for FreeBSD 11 amd64 build:
FreeBSD 11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI009BUILD/config.log/config.log Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U16ARM8BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U2004AMD64BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build:
Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/F29BUILD/config.log/config.log FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1804AMD64/config.log/config.log CentOS 8 amd64 build: Failed (click for details)Configure failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CENTOS8BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1604I386/config.log/config.log Ubuntu 16.04 arm8 build: Failed (click for details)Configure failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm8 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U16ARM8BUILD/config.log/config.log Ubuntu 20.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 20.04 amd64 build:
Ubuntu 20.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U2004AMD64BUILD/config.log/config.log Debian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/DEB10BUILD/config.log/config.logConfigure failed for Debian 10 amd64 build:
Fedora 29 amd64 build: Failed (click for details)Configure failed for Fedora 29 amd64 build:
Fedora 29 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/F29BUILD/config.log/config.log FreeBSD 12 amd64 build: Failed (click for details)Configure failed for FreeBSD 12 amd64 build:
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/FBSD12AMD64/config.log/config.log Ubuntu 18.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 18.04 amd64 build:
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1804AMD64/config.log/config.log CentOS 8 amd64 build: Failed (click for details)Configure failed for CentOS 8 amd64 build:
CentOS 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CENTOS8BUILD/config.log/config.log Ubuntu 16.04 i386 build: Failed (click for details)Configure failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U1604I386/config.log/config.log Ubuntu 16.04 arm7 build: Incomplete(check logs for details)Debian 9 amd64 build: Failed (click for details)Configure failed for Debian 9 amd64 build:
Debian 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI021BUILD/config.log/config.log Debian 8 amd64 build: Failed (click for details)Debian 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI008BLD/config.log/config.logConfigure failed for Debian 8 amd64 build:
FreeBSD 11 amd64 build: Failed (click for details)Configure failed for FreeBSD 11 amd64 build:
FreeBSD 11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI009BUILD/config.log/config.log Ubuntu 18.04 ppc64le build: Incomplete(check logs for details)Ubuntu 18.04 arm8 build: Incomplete(check logs for details)OpenBSD 6 amd64 build: Failed (click for details)Configure failed for OpenBSD 6 amd64 build:
OpenBSD 6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI011BUILD/config.log/config.log NetBSD 8 amd64 build: Failed (click for details)NetBSD 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI012BUILD/config.log/config.logConfigure failed for NetBSD 8 amd64 build:
Ubuntu 16.04 amd64 build: Failed (click for details)Configure failed for Ubuntu 16.04 amd64 build:
Ubuntu 16.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI014BUILD/config.log/config.log CentOS 7 amd64 build: Failed (click for details)Configure failed for CentOS 7 amd64 build:
CentOS 7 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/CI005BUILD/config.log/config.log Ubuntu 18.04 arm7 build: Failed (click for details)Configure failed for Ubuntu 18.04 arm7 build:
Ubuntu 18.04 arm7 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16884/artifact/U18ARM7BUILD/config.log/config.log |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
CLANG Static Analyzer Summary
5 Static Analyzer issues remaining.See details at |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17153/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base5 Static Analyzer issues remaining.See details at |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-17167/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17167/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base4 Static Analyzer issues remaining.See details at |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17274/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
4 Static Analyzer issues remaining.See details at |
Thanks for this great contribution. However, I have 2 remarks: 1/ Can you change the documentation format from Markdown to RST to fit all others documentations and link it with the whole FRR documentation ? 2/ You modify the pathd for the pceplib include, that's ok, but, I'm wondering if the form should |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
@donaldsharp @qlyoung @odd22 it seems that all comments have been covered already so maybe could you consider to merge this PR? |
Re-reviewing |
Alright, scratch that, there's no way I'm reviewing 27k sloc. Did you happen to do any fuzz testing on this library? Just curious |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17419/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
4 Static Analyzer issues remaining.See details at |
The library is since some months ago working with pathd in the volta stack and passing the integration testing which includes interoperability with cisco pce. |
So no? |
Quentin, Im the original author of the PCEPlib library, and I was working on other tasks here at Volta while my colleague Javier submit this PR and addressed the code review comments. Is there any sort of fuzz testing on other parts of FRR? If so, it would be good to include the PCEPlib with those. We have done extensive testing on the library internally (as Javier mentioned in his answer) both manually and with our CI here at Volta. We have also run all the unit tests with Valgrind and dont expect any memory issues. Perhaps its not 100% fuzz testing, but it has been tested a good bit. I hope this is sufficient to merge this PR. |
Yep, as I stated, "just curious" :) There's bound to be bugs in a merge of this size and since I realistically do not have the time to do a thorough review of 27k SLOC I'm going to have to merge it blind. Hopefully you agree with me that that means the bar for testing will be much higher.
There are fuzzing shims (in the Anyway, speaking of testing, we need to figure out how to get pceplib tests to run in CI. Do you think we should keep pceplib tests in the pceplib directory or pull them into FRR's |
Signed-off-by: Brady Johnson <brady@voltanet.io> Co-authored-by: Javier Garcia <javier.garcia@voltanet.io> Signed-off-by: Javier Garcia <javier.garcia@voltanet.io>
Quentin, agreed PRs this size are not ideal, thanks for your review and your patience. |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-17495/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
4 Static Analyzer issues remaining.See details at |
@donaldsharp can you recheck and see if your comments have been addressed? |
The PCEPlib is a PCEP implementation library that can be used by either a PCE or PCC.
Currently, only the FRR pathd has been implemented as a PCC with the PCEPlib. The PCEPlib is able to simultaneously connect to multiple PCEP
peers and can maintain persistent PCEP connections.
Signed-off-by: Brady Johnson brady@voltanet.io
Co-authored-by: Javier Garcia javier.garcia@voltanet.io
Signed-off-by: Javier Garcia javier.garcia@voltanet.io