Flowspec leak #7485

pguibert6WIND · 2020-11-07T13:54:40Z

==837256== 56 bytes in 2 blocks are definitely lost in loss record 45 of 97
==837256== at 0x483AB65: calloc (vg_replace_malloc.c:760)
==837256== by 0x48D961F: qcalloc (memory.c:115)
==837256== by 0x2FAA55: bgp_nlri_parse_flowspec (bgp_flowspec.c:155)
==837256== by 0x1F2F74: bgp_nlri_parse (bgp_packet.c:323)
==837256== by 0x1F5DD1: bgp_update_receive (bgp_packet.c:1673)
==837256== by 0x1F78A6: bgp_process_packet (bgp_packet.c:2389)
==837256== by 0x4924373: thread_call (thread.c:1675)
==837256== by 0x48D2AE6: frr_run (libfrr.c:1099)
==837256== by 0x18F79F: main (bgp_main.c:521)
==837256==
==837256== 56 bytes in 2 blocks are definitely lost in loss record 46 of 97
==837256== at 0x483AB65: calloc (vg_replace_malloc.c:760)
==837256== by 0x48D961F: qcalloc (memory.c:115)
==837256== by 0x48F51FA: prefix_copy (prefix.c:336)
==837256== by 0x491CB59: route_node_get (table.c:289)
==837256== by 0x200D63: bgp_node_get (bgp_table.h:230)
==837256== by 0x204BDE: bgp_afi_node_get (bgp_route.c:152)
==837256== by 0x20CD3C: bgp_update (bgp_route.c:3526)
==837256== by 0x2FAC48: bgp_nlri_parse_flowspec (bgp_flowspec.c:192)
==837256== by 0x1F2F74: bgp_nlri_parse (bgp_packet.c:323)
==837256== by 0x1F5DD1: bgp_update_receive (bgp_packet.c:1673)
==837256== by 0x1F78A6: bgp_process_packet (bgp_packet.c:2389)
==837256== by 0x4924373: thread_call (thread.c:1675)

LabN-CI · 2020-11-07T14:01:02Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/7485 `f4dd4ed` frr.github Build
Date	11/07/2020
Start	09:00:39
Finish	09:00:58
Run-Time	00:19
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2020-11-07-09:00:39.txt
Log	make-2020-11-07-09:00:39.out.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2020-11-07T14:13:34Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_free:
lib/prefix.c:1121:32: error: passing argument 2 of qfree makes pointer from integer without a cast [-Werror=int-conversion]
lib/memory.h:173:16: note: in definition of macro XFREE
lib/memory.h:165:13: note: expected void * but argument is of type uintptr_t {aka long unsigned int}
 extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/memory.h:174:7: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro XFREE
cc1: all warnings being treated as errors

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_free:
lib/prefix.c:1121:55: error: passing argument 2 of qfree makes pointer from integer without a cast [-Werror=int-conversion]
 1121 |   XFREE(MTYPE_PREFIX_FLOWSPEC, (*p)->u.prefix_flowspec.ptr);
lib/memory.h:173:16: note: in definition of macro XFREE
lib/memory.h:165:45: note: expected void * but argument is of type uintptr_t {aka long unsigned int}
lib/memory.h:174:7: error: assignment to uintptr_t {aka long unsigned int} from void * makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro XFREE
 1121 |   XFREE(MTYPE_PREFIX_FLOWSPEC, (*p)->u.prefix_flowspec.ptr);

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_free:
lib/prefix.c:1121:55: error: passing argument 2 of qfree makes pointer from integer without a cast [-Werror=int-conversion]
lib/memory.h:173:16: note: in definition of macro XFREE
lib/memory.h:165:45: note: expected void * but argument is of type uintptr_t {aka long unsigned int}
 extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/memory.h:174:7: error: assignment to uintptr_t {aka long unsigned int} from void * makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro XFREE
cc1: all warnings being treated as errors

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/DEB10BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_free:
lib/prefix.c:1121:55: error: passing argument 2 of qfree makes pointer from integer without a cast [-Werror=int-conversion]
lib/memory.h:173:16: note: in definition of macro XFREE
lib/memory.h:165:45: note: expected void * but argument is of type uintptr_t {aka long unsigned int}
 extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/memory.h:174:7: error: assignment to uintptr_t {aka long unsigned int} from void * makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro XFREE
cc1: all warnings being treated as errors

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/F29BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_free':
lib/prefix.c:1121:32: error: passing argument 2 of 'qfree' makes pointer from integer without a cast [-Werror=int-conversion]
lib/memory.h:173:16: note: in definition of macro 'XFREE'
lib/memory.h:165:13: note: expected 'void *' but argument is of type 'uintptr_t {aka long unsigned int}'
 extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/memory.h:174:7: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro 'XFREE'
cc1: all warnings being treated as errors

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from ./lib/if.h:26:0,
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:18: error: MTYPE_PREFIX_FLOWSPEC undeclared (first use in this function); did you mean MTYPE_BGP_FLOWSPEC?
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
bgpd/bgp_flowspec.c:155:18: note: each undeclared identifier is reported only once for each function it appears in
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U1804AMD64/config.status/config.status

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_free:
lib/prefix.c:1121:55: error: passing argument 2 of qfree makes pointer from integer without a cast [-Werror=int-conversion]
lib/memory.h:173:16: note: in definition of macro XFREE
lib/memory.h:165:45: note: expected void * but argument is of type uintptr_t {aka long unsigned int}
 extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/memory.h:174:7: error: assignment to uintptr_t {aka long unsigned int} from void * makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro XFREE
cc1: all warnings being treated as errors

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from ./lib/if.h:26:0,
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:18: error: MTYPE_PREFIX_FLOWSPEC undeclared (first use in this function)
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
bgpd/bgp_flowspec.c:155:18: note: each undeclared identifier is reported only once for each function it appears in
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U1604I386/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_free:
lib/prefix.c:1121:32: error: passing argument 2 of qfree makes pointer from integer without a cast [-Werror=int-conversion]
lib/memory.h:173:16: note: in definition of macro XFREE
lib/memory.h:165:13: note: expected void * but argument is of type uintptr_t {aka unsigned int}
 extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/memory.h:174:7: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro XFREE
cc1: all warnings being treated as errors

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from ./lib/if.h:26:0,
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:18: error: MTYPE_PREFIX_FLOWSPEC undeclared (first use in this function)
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
bgpd/bgp_flowspec.c:155:18: note: each undeclared identifier is reported only once for each function it appears in
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI021BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI008BLD/ErrorLog/log_make.txt)

In file included from ./lib/if.h:26:0,
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:18: error: MTYPE_PREFIX_FLOWSPEC undeclared (first use in this function)
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
bgpd/bgp_flowspec.c:155:18: note: each undeclared identifier is reported only once for each function it appears in
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
Makefile:7618: recipe for target 'bgpd/bgp_flowspec.o' failed

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI008BLD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_free':
lib/prefix.c:1121:55: error: passing argument 2 of 'qfree' makes pointer from integer without a cast [-Werror=int-conversion]
 1121 |   XFREE(MTYPE_PREFIX_FLOWSPEC, (*p)->u.prefix_flowspec.ptr);
lib/memory.h:173:16: note: in definition of macro 'XFREE'
lib/memory.h:165:45: note: expected 'void *' but argument is of type 'uintptr_t' {aka 'long unsigned int'}
lib/memory.h:174:7: error: assignment to 'uintptr_t' {aka 'long unsigned int'} from 'void *' makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro 'XFREE'
 1121 |   XFREE(MTYPE_PREFIX_FLOWSPEC, (*p)->u.prefix_flowspec.ptr);

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from ./lib/if.h:26:0,
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:18: error: MTYPE_PREFIX_FLOWSPEC undeclared (first use in this function); did you mean MTYPE_BGP_FLOWSPEC?
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
bgpd/bgp_flowspec.c:155:18: note: each undeclared identifier is reported only once for each function it appears in
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U1804PPC64LEBUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15284/frr-source'
lib/prefix.c:1121:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'
./lib/memory.h:165:45: note: passing argument to parameter 'ptr' here
extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/prefix.c:1121:3: error: incompatible pointer to integer conversion assigning to 'uintptr_t' (aka 'unsigned long') from 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:174:7: note: expanded from macro 'XFREE'
2 errors generated.

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_free':
lib/prefix.c:1121:32: error: passing argument 2 of 'qfree' makes pointer from integer without a cast [-Werror=int-conversion]
lib/memory.h:173:16: note: in definition of macro 'XFREE'
lib/memory.h:165:13: note: expected 'void *' but argument is of type '__uintptr_t {aka long unsigned int}'
 extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/memory.h:174:7: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro 'XFREE'
cc1: all warnings being treated as errors

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI012BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_free:
lib/prefix.c:1121:32: error: passing argument 2 of qfree makes pointer from integer without a cast [-Werror=int-conversion]
lib/memory.h:173:16: note: in definition of macro XFREE
lib/memory.h:165:13: note: expected void * but argument is of type uintptr_t {aka long unsigned int}
 extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/memory.h:174:7: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro XFREE
cc1: all warnings being treated as errors

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from ./lib/if.h:26:0,
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:18: error: MTYPE_PREFIX_FLOWSPEC undeclared (first use in this function)
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
bgpd/bgp_flowspec.c:155:18: note: each undeclared identifier is reported only once for each function it appears in
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI014BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI005BUILD/ErrorLog/log_make.txt)

In file included from ./lib/if.h:26:0,
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:18: error: MTYPE_PREFIX_FLOWSPEC undeclared (first use in this function)
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
bgpd/bgp_flowspec.c:155:18: note: each undeclared identifier is reported only once for each function it appears in
./lib/memory.h:168:39: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
make[1]: *** [bgpd/bgp_flowspec.o] Error 1

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15284/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_free:
lib/prefix.c:1121:32: error: passing argument 2 of qfree makes pointer from integer without a cast [-Werror=int-conversion]
lib/memory.h:173:16: note: in definition of macro XFREE
lib/memory.h:165:13: note: expected void * but argument is of type uintptr_t {aka unsigned int}
 extern void qfree(struct memtype *mt, void *ptr) __attribute__((nonnull(1)));
lib/memory.h:174:7: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
lib/prefix.c:1121:3: note: in expansion of macro XFREE
cc1: all warnings being treated as errors

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/d0c7643dbadf68b2761e7f65749284a8/raw/80b3d43db4e0cf904eed21b54346cbad757f4427/cr_7485_1604758507.diff | git apply

diff --git a/bgpd/bgp_flowspec.c b/bgpd/bgp_flowspec.c
index fd7632fc9..011ebb1cc 100644
--- a/bgpd/bgp_flowspec.c
+++ b/bgpd/bgp_flowspec.c
@@ -152,8 +152,9 @@ int bgp_nlri_parse_flowspec(struct peer *peer, struct attr *attr,
 		/* Flowspec encoding is in bytes */
 		p.u.prefix_flowspec.prefixlen = psize;
 		p.u.prefix_flowspec.family = afi2family(afi);
-		prefix_flowspec_allocate(&p, pnt, psize)
-		if (BGP_DEBUG(flowspec, FLOWSPEC)) {
+		prefix_flowspec_allocate(
+			&p, pnt, psize) if (BGP_DEBUG(flowspec, FLOWSPEC))
+		{
 			char return_string[BGP_FLOWSPEC_NLRI_STRING_MAX];
 			char local_string[BGP_FLOWSPEC_NLRI_STRING_MAX*2+16];
 			char ec_string[BGP_FLOWSPEC_NLRI_STRING_MAX];
diff --git a/lib/prefix.c b/lib/prefix.c
index dad66a3dd..2f3e8ac11 100644
--- a/lib/prefix.c
+++ b/lib/prefix.c
@@ -1119,7 +1119,7 @@ void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size)
 	char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
 
 	memcpy(temp, pnt, psize);
-	p.u.prefix_flowspec.ptr = (uintptr_t) temp;
+	p.u.prefix_flowspec.ptr = (uintptr_t)temp;
 	return;
 }

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-07T14:15:59Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/7485 `0678c65` frr.github Build
Date	11/07/2020
Start	09:15:38
Finish	09:15:56
Run-Time	00:18
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2020-11-07-09:15:38.txt
Log	make-2020-11-07-09:15:38.out.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2020-11-07T14:31:40Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: request for member u in something not a structure or union

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/F29BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/DEB10BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI014BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: 'p' is a pointer; did you mean to use '->'?

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1804AMD64/config.status/config.status

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: request for member u in something not a structure or union

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1604I386/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1122:3: error: 'p' is a pointer; did you mean to use '->'?

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI009BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t *
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1804PPC64LEBUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI005BUILD/ErrorLog/log_make.txt)

./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t *
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: warning: unused variable temp [-Wunused-variable]
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:64: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size)
lib/prefix.c:1121:20: error: use of undeclared identifier 'psize'; did you mean 'size'?
lib/prefix.c:1117:64: note: 'size' declared here

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI011BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: request for member 'u' in something not a structure or union

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI021BUILD/config.status/config.status

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: request for member u in something not a structure or union

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/F29BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/DEB10BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI014BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: 'p' is a pointer; did you mean to use '->'?

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1804AMD64/config.status/config.status

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: request for member u in something not a structure or union

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1604I386/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1122:3: error: 'p' is a pointer; did you mean to use '->'?

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI009BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t *
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U1804PPC64LEBUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI005BUILD/ErrorLog/log_make.txt)

./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t *
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: warning: unused variable temp [-Wunused-variable]
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:64: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size)
lib/prefix.c:1121:20: error: use of undeclared identifier 'psize'; did you mean 'size'?
lib/prefix.c:1117:64: note: 'size' declared here

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI011BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: p is a pointer; did you mean to use ->?

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1122:3: error: request for member 'u' in something not a structure or union

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15285/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15285/artifact/CI021BUILD/config.status/config.status

Report for prefix.c | 2 issues
===============================================
< WARNING: void function return statements are not generally useful
< #1124: FILE: /tmp/f1-6623/prefix.c:1124:

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/76ae9bfb3d0f579a17291caeeaa92ca3/raw/57e0fa883ead584d1e0cd00d34013055fb08eb60/cr_7485_1604762938.diff | git apply

diff --git a/bgpd/bgp_flowspec.c b/bgpd/bgp_flowspec.c
index fd7632fc9..011ebb1cc 100644
--- a/bgpd/bgp_flowspec.c
+++ b/bgpd/bgp_flowspec.c
@@ -152,8 +152,9 @@ int bgp_nlri_parse_flowspec(struct peer *peer, struct attr *attr,
 		/* Flowspec encoding is in bytes */
 		p.u.prefix_flowspec.prefixlen = psize;
 		p.u.prefix_flowspec.family = afi2family(afi);
-		prefix_flowspec_allocate(&p, pnt, psize)
-		if (BGP_DEBUG(flowspec, FLOWSPEC)) {
+		prefix_flowspec_allocate(
+			&p, pnt, psize) if (BGP_DEBUG(flowspec, FLOWSPEC))
+		{
 			char return_string[BGP_FLOWSPEC_NLRI_STRING_MAX];
 			char local_string[BGP_FLOWSPEC_NLRI_STRING_MAX*2+16];
 			char ec_string[BGP_FLOWSPEC_NLRI_STRING_MAX];
diff --git a/lib/prefix.c b/lib/prefix.c
index 0670a08e3..49421bfa7 100644
--- a/lib/prefix.c
+++ b/lib/prefix.c
@@ -1119,7 +1119,7 @@ void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size)
 	char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
 
 	memcpy(temp, pnt, size);
-	p->u.prefix_flowspec.ptr = (uintptr_t) temp;
+	p->u.prefix_flowspec.ptr = (uintptr_t)temp;
 	return;
 }

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

NetDEF-CI · 2020-11-07T15:47:09Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/F29BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI009BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/FBSD12AMD64/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/DEB10BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1804AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1604I386/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI005BUILD/ErrorLog/log_make.txt)

./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t *
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: warning: unused variable temp [-Wunused-variable]
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t *
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1804PPC64LEBUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI021BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_free:

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:64: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size)
lib/prefix.c:1132:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI011BUILD/config.status/config.status

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/F29BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI009BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/FBSD12AMD64/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/DEB10BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1804AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1604I386/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI005BUILD/ErrorLog/log_make.txt)

./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t *
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: warning: unused variable temp [-Wunused-variable]
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t *
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U1804PPC64LEBUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:155:32: error: pointer targets in passing argument 2 of prefix_flowspec_allocate differ in signedness [-Werror=pointer-sign]
In file included from bgpd/bgp_flowspec.c:24:0:
./lib/prefix.h:435:13: note: expected char * but argument is of type uint8_t * {aka unsigned char *}
 extern void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size);
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI021BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_free:

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15287/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:64: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, char *pnt, int size)
lib/prefix.c:1132:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15287/artifact/CI011BUILD/config.status/config.status

Report for prefix.c | 2 issues
===============================================
< WARNING: void function return statements are not generally useful
< #1124: FILE: /tmp/f1-8565/prefix.c:1124:

LabN-CI · 2020-11-07T16:41:20Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/7485 `8b08f00` frr.github Build
Date	11/07/2020
Start	11:40:56
Finish	11:41:16
Run-Time	00:20
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2020-11-07-11:40:56.txt
Log	make-2020-11-07-11:40:56.out.bz2
Memory

For details, please contact louberger

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/523994bbe777ce79020a257402b5f1fe/raw/9e09d22aab316c43f1119f3b8e8bddafc8df8899/cr_7485_1604786370.diff | git apply

diff --git a/bgpd/bgp_flowspec.c b/bgpd/bgp_flowspec.c
index fd7632fc9..011ebb1cc 100644
--- a/bgpd/bgp_flowspec.c
+++ b/bgpd/bgp_flowspec.c
@@ -152,8 +152,9 @@ int bgp_nlri_parse_flowspec(struct peer *peer, struct attr *attr,
 		/* Flowspec encoding is in bytes */
 		p.u.prefix_flowspec.prefixlen = psize;
 		p.u.prefix_flowspec.family = afi2family(afi);
-		prefix_flowspec_allocate(&p, pnt, psize)
-		if (BGP_DEBUG(flowspec, FLOWSPEC)) {
+		prefix_flowspec_allocate(
+			&p, pnt, psize) if (BGP_DEBUG(flowspec, FLOWSPEC))
+		{
 			char return_string[BGP_FLOWSPEC_NLRI_STRING_MAX];
 			char local_string[BGP_FLOWSPEC_NLRI_STRING_MAX*2+16];
 			char ec_string[BGP_FLOWSPEC_NLRI_STRING_MAX];
diff --git a/lib/prefix.c b/lib/prefix.c
index 6478128bf..f7f8c0fa4 100644
--- a/lib/prefix.c
+++ b/lib/prefix.c
@@ -1119,7 +1119,7 @@ void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
 	char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
 
 	memcpy(temp, pnt, size);
-	p->u.prefix_flowspec.ptr = (uintptr_t) temp;
+	p->u.prefix_flowspec.ptr = (uintptr_t)temp;
 	return;
 }

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-07T22:01:05Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/7485 `f8a68c5` frr.github Build
Date	11/07/2020
Start	17:00:39
Finish	17:01:01
Run-Time	00:22
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2020-11-07-17:00:39.txt
Log	make-2020-11-07-17:00:39.out.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2020-11-07T22:14:55Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/F29BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:67: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
lib/prefix.c:1132:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI011BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI009BUILD/config.status/config.status

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/DEB10BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1604I386/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI021BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1804AMD64/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI005BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory `/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: warning: unused variable temp [-Wunused-variable]
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI005BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7618: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1804PPC64LEBUILD/config.status/config.status

Warnings Generated during build:

Checkout code: Successful with additional warnings

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/F29BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:67: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
lib/prefix.c:1132:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI011BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI009BUILD/config.status/config.status

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/DEB10BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1604I386/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI021BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1804AMD64/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI005BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory `/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: warning: unused variable temp [-Wunused-variable]
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI005BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7618: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15289/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:156:3: error: expected ; before if
bgpd/bgp_flowspec.c:193:3: error: else without a previous if
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15289/artifact/U1804PPC64LEBUILD/config.status/config.status

Report for prefix.c | 2 issues
===============================================
< WARNING: void function return statements are not generally useful
< #1124: FILE: /tmp/f1-18192/prefix.c:1124:

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/712851b2d5a16ee39b794e42fcd57b6f/raw/b06bad0225b9377db5bd9b3f4bba0242d0507cfc/cr_7485_1604822165.diff | git apply

diff --git a/lib/prefix.c b/lib/prefix.c
index 6478128bf..f7f8c0fa4 100644
--- a/lib/prefix.c
+++ b/lib/prefix.c
@@ -1119,7 +1119,7 @@ void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
 	char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
 
 	memcpy(temp, pnt, size);
-	p->u.prefix_flowspec.ptr = (uintptr_t) temp;
+	p->u.prefix_flowspec.ptr = (uintptr_t)temp;
 	return;
 }

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-08T08:01:05Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/7485 `acaa986` frr.github Build
Date	11/08/2020
Start	03:00:39
Finish	03:01:00
Run-Time	00:21
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2020-11-08-03:00:39.txt
Log	make-2020-11-08-03:00:39.out.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2020-11-08T08:13:28Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7618: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI008BLD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/DEB10BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI009BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/F29BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:67: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
lib/prefix.c:1132:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI011BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI005BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI005BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1804AMD64/config.status/config.status

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI021BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1804PPC64LEBUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1604I386/config.status/config.status

Warnings Generated during build:

Checkout code: Successful with additional warnings

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7618: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI008BLD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/DEB10BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI009BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/F29BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:67: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
lib/prefix.c:1132:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI011BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI005BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI005BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1804AMD64/config.status/config.status

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI021BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1804PPC64LEBUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15292/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15292/artifact/U1604I386/config.status/config.status

Report for prefix.c | 2 issues
===============================================
< WARNING: void function return statements are not generally useful
< #1124: FILE: /tmp/f1-26906/prefix.c:1124:

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/935f86af2199a34f0bc0f400195ecc1a/raw/6e2cb8ae06ed51112890ccd9e45e9fbbe9b9f0dd/cr_7485_1604840593.diff | git apply

diff --git a/lib/prefix.c b/lib/prefix.c
index 6f179b36a..428ef328c 100644
--- a/lib/prefix.c
+++ b/lib/prefix.c
@@ -1119,7 +1119,7 @@ void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
 	char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
 
 	memcpy(temp, pnt, size);
-	p->u.prefix_flowspec.ptr = (uintptr_t) temp;
+	p->u.prefix_flowspec.ptr = (uintptr_t)temp;
 	return;
 }

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-08T13:06:15Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/7485 `615a320` frr.github Build
Date	11/08/2020
Start	08:05:50
Finish	08:06:11
Run-Time	00:21
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2020-11-08-08:05:50.txt
Log	make-2020-11-08-08:05:50.out.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2020-11-08T13:20:09Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_flowspec_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI009BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI005BUILD/ErrorLog/log_make.txt)

bgpd/bgp_flowspec.c:107:8: warning: unused variable temp [-Wunused-variable]
bgpd/bgpd.c: In function peer_group_delete:
bgpd/bgpd.c:2656:8: error: p undeclared (first use in this function)
bgpd/bgpd.c:2656:8: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [bgpd/bgpd.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI005BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_flowspec_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/FBSD12AMD64/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/DEB10BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:67: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
lib/prefix.c:1137:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI011BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1804AMD64/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_flowspec_free:

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
bgpd/bgpd.c: In function peer_group_delete:
bgpd/bgpd.c:2656:8: error: p undeclared (first use in this function); did you mean ip?
bgpd/bgpd.c:2656:8: note: each undeclared identifier is reported only once for each function it appears in

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1804PPC64LEBUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_flowspec_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI021BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/F29BUILD/config.status/config.status

Warnings Generated during build:

Checkout code: Successful with additional warnings

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_flowspec_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI009BUILD/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI005BUILD/ErrorLog/log_make.txt)

bgpd/bgp_flowspec.c:107:8: warning: unused variable temp [-Wunused-variable]
bgpd/bgpd.c: In function peer_group_delete:
bgpd/bgpd.c:2656:8: error: p undeclared (first use in this function)
bgpd/bgpd.c:2656:8: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [bgpd/bgpd.o] Error 1
In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI005BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_flowspec_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/FBSD12AMD64/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/DEB10BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:67: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
lib/prefix.c:1137:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI011BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1804AMD64/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_flowspec_free:

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_flowspec.c: In function bgp_nlri_parse_flowspec:
bgpd/bgp_flowspec.c:107:8: error: unused variable temp [-Werror=unused-variable]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'bgpd/bgp_flowspec.o' failed
make[1]: *** [bgpd/bgp_flowspec.o] Error 1
bgpd/bgpd.c: In function peer_group_delete:
bgpd/bgpd.c:2656:8: error: p undeclared (first use in this function); did you mean ip?
bgpd/bgpd.c:2656:8: note: each undeclared identifier is reported only once for each function it appears in

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1804PPC64LEBUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_flowspec_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/CI021BUILD/config.status/config.status

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15294/frr-source'
bgpd/bgp_debug.c: In function bgp_debug_list_free:
bgpd/bgp_debug.c:233:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)
bgpd/bgp_debug.c: In function bgp_debug_list_remove_entry:
bgpd/bgp_debug.c:339:26: error: passing argument 1 of bgp_debug_prefix_free from incompatible pointer type [-Werror=incompatible-pointer-types]
bgpd/bgp_debug.c:217:13: note: expected struct prefix * but argument is of type struct prefix **
 static void bgp_debug_prefix_free(struct prefix *p)

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_flowspec_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15294/artifact/F29BUILD/config.status/config.status

Report for prefix.c | 2 issues
===============================================
< WARNING: void function return statements are not generally useful
< #1124: FILE: /tmp/f1-26497/prefix.c:1124:

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/6ea56cbafb08699a6c3aafaf1ec189cf/raw/b06bad0225b9377db5bd9b3f4bba0242d0507cfc/cr_7485_1604841842.diff | git apply

diff --git a/lib/prefix.c b/lib/prefix.c
index 6478128bf..f7f8c0fa4 100644
--- a/lib/prefix.c
+++ b/lib/prefix.c
@@ -1119,7 +1119,7 @@ void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
 	char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
 
 	memcpy(temp, pnt, size);
-	p->u.prefix_flowspec.ptr = (uintptr_t) temp;
+	p->u.prefix_flowspec.ptr = (uintptr_t)temp;
 	return;
 }

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-08T13:26:04Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/7485 `7614ed7` frr.github Build
Date	11/08/2020
Start	08:25:39
Finish	08:26:00
Run-Time	00:21
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2020-11-08-08:25:39.txt
Log	make-2020-11-08-08:25:39.out.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2020-11-08T13:40:36Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI005BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI008BLD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI008BLD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/FBSD12AMD64/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/DEB10BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15295/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:67: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
lib/prefix.c:1132:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1804AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1804PPC64LEBUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI021BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/F29BUILD/config.status/config.status

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI101BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI005BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI008BLD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI008BLD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/FBSD12AMD64/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/DEB10BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/DEB10BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake  all-am
gmake[1]: Entering directory '/home/ci/cibuild.15295/frr-source'
lib/prefix.c:1119:46: error: use of undeclared identifier 'psize'; did you mean 'size'?
./lib/memory.h:168:46: note: expanded from macro 'XCALLOC'
#define XCALLOC(mtype, size)            qcalloc(mtype, size)
lib/prefix.c:1117:67: note: 'size' declared here
void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
lib/prefix.c:1132:32: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'void *' [-Werror,-Wint-conversion]
./lib/memory.h:173:16: note: expanded from macro 'XFREE'

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI012BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function 'prefix_free':

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI014BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI014BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1804AMD64/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1804AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI009BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function 'prefix_flowspec_allocate':
lib/prefix.c:1119:46: error: 'psize' undeclared (first use in this function); did you mean 'size'?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro 'XCALLOC'
lib/prefix.c: In function 'prefix_free':

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1804PPC64LEBUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI021BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/CI021BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
 1119 |  char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, psize);
lib/memory.h:168:46: note: in definition of macro XCALLOC
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1604I386/ErrorLog/log_make.txt)

In file included from lib/if.h:26:0,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function)
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/F29BUILD/ErrorLog/log_make.txt)

In file included from lib/if.h:26,
lib/prefix.c: In function prefix_flowspec_allocate:
lib/prefix.c:1119:46: error: psize undeclared (first use in this function); did you mean size?
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c:1119:46: note: each undeclared identifier is reported only once for each function it appears in
lib/memory.h:168:46: note: in definition of macro XCALLOC
 #define XCALLOC(mtype, size)  qcalloc(mtype, size)
lib/prefix.c: In function prefix_free:

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15295/artifact/F29BUILD/config.status/config.status

Report for prefix.c | 2 issues
===============================================
< WARNING: void function return statements are not generally useful
< #1124: FILE: /tmp/f1-2796/prefix.c:1124:

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/f24c2fab1a091c880f34f62229c13933/raw/bdf70ffa00e9920a0adab3db90c691b5690a8809/cr_7485_1604867551.diff | git apply

diff --git a/lib/prefix.c b/lib/prefix.c
index f3a3f551e..8268a7097 100644
--- a/lib/prefix.c
+++ b/lib/prefix.c
@@ -1119,7 +1119,7 @@ void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)
 	char *temp = XCALLOC(MTYPE_PREFIX_FLOWSPEC, size);
 
 	memcpy(temp, pnt, size);
-	p->u.prefix_flowspec.ptr = (uintptr_t) temp;
+	p->u.prefix_flowspec.ptr = (uintptr_t)temp;
 	return;
 }

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-09T09:00:55Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/7485 `263282f`
Date	11/09/2020
Start	03:25:40
Finish	04:00:49
Run-Time	35:09
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-09-03:25:40.txt
Log	autoscript-2020-11-09-03:26:38.log.bz2
Memory	492 480 417

For details, please contact louberger

LabN-CI · 2020-11-09T10:22:49Z

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 3 tests failed

_	_
Result	SUCCESS git merge/7485 `4cc2271`
Date	11/09/2020
Start	04:45:40
Finish	05:22:44
Run-Time	37:04
Total	1815
Pass	1812
Fail	3
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-09-04:45:40.txt
Log	autoscript-2020-11-09-04:46:43.log.bz2
Memory	495 478 418

For details, please contact louberger

NetDEF-CI · 2020-11-09T11:23:43Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15306/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt

IPv4 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: No useful log found

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15306/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15306/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15306/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP2U1604I386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15306/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15306/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

IPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15306/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15306/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15306/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt

IPv6 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15306/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15306/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt

IPv4 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: No useful log found

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15306/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15306/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15306/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP2U1604I386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15306/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15306/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

IPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15306/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15306/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15306/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt

IPv6 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15306/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Addresssanitizer topotests part 1: Incomplete

(check logs for details)

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15306/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15306/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Debian 10 deb pkg check
Static analyzer (clang)
Ubuntu 16.04 deb pkg check
Fedora 29 rpm pkg check
Addresssanitizer topotests part 2
Ubuntu 20.04 deb pkg check
Debian 8 deb pkg check
Ubuntu 18.04 deb pkg check
Debian 9 deb pkg check
CentOS 7 rpm pkg check
Addresssanitizer topotests part 0

NetDEF-CI · 2020-11-09T12:28:46Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15309/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15309/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15309/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt

IPv4 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15309/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15309/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP2U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15309/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15309/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15309/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TOPOU1604/ErrorLog/log_topotests.txt

IPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: No useful log found

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15309/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15309/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15309/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15309/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt

IPv4 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15309/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15309/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP2U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15309/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15309/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15309/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TOPOU1604/ErrorLog/log_topotests.txt

IPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: No useful log found

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15309/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Addresssanitizer topotests part 1: Incomplete

(check logs for details)

IPv6 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15309/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15309/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15309/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Debian 10 deb pkg check
Static analyzer (clang)
Fedora 29 rpm pkg check
Ubuntu 18.04 deb pkg check
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
Addresssanitizer topotests part 2
Debian 8 deb pkg check
CentOS 7 rpm pkg check
Addresssanitizer topotests part 0
Debian 9 deb pkg check

LabN-CI · 2020-11-10T17:27:10Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/7485 `4cc2271`
Date	11/10/2020
Start	11:51:53
Finish	12:27:05
Run-Time	35:12
Total	1818
Pass	1818
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-10-11:51:53.txt
Log	autoscript-2020-11-10-11:52:51.log.bz2
Memory	484 490 417

For details, please contact louberger

donaldsharp · 2020-11-11T23:32:08Z

This now crashes with this decode:

(gdb) bt
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1 0x00007fc8b883a537 in __GI_abort () at abort.c:79
#2 0x00007fc8b8ac94b6 in core_handler (signo=11, siginfo=0x7ffc8b126230, context=0x7ffc8b126100)
at lib/sigevent.c:253
#3
#4 0x00007fc8b8ab1ddc in prefix_free (p=0x55b5623bb3f8) at lib/prefix.c:1132
#5 0x00007fc8b8a828c4 in connected_free (connected=0x7ffc8b1266f8) at lib/if.c:887
#6 0x000055b5602c5792 in connected_withdraw (ifc=0x55b5623bb3e0) at zebra/connected.c:68
#7 0x000055b5602c5caf in connected_update (ifp=0x55b5621aa910, ifc=0x55b562071a40) at zebra/connected.c:188
#8 0x000055b5602c6205 in connected_add_ipv4 (ifp=0x55b5621aa910, flags=0, addr=0x7ffc8b128934, prefixlen=24,
dest=0x7ffc8b12893c, label=0x0, metric=4294967295) at zebra/connected.c:336
#9 0x000055b5602cb400 in netlink_interface_addr (h=0x7ffc8b128910, ns_id=0, startup=0) at zebra/if_netlink.c:1252
#10 0x000055b5602d7077 in netlink_information_fetch (h=0x7ffc8b128910, ns_id=0, startup=0)
at zebra/kernel_netlink.c:350
#11 0x000055b5602d82d7 in netlink_parse_info (filter=0x55b5602d6fb3 <netlink_information_fetch>, nl=0x55b5621a1b88,
zns=0x7ffc8b130980, count=5, startup=0) at zebra/kernel_netlink.c:941
#12 0x000055b5602d71f2 in kernel_read (thread=0x7ffc8b130c30) at zebra/kernel_netlink.c:402
#13 0x00007fc8b8adf460 in thread_call (thread=0x7ffc8b130c30) at lib/thread.c:1674
#14 0x00007fc8b8a8db2e in frr_run (master=0x55b561f19d50) at lib/libfrr.c:1099
#15 0x000055b5602db7e6 in main (argc=8, argv=0x7ffc8b130ef8) at zebra/main.c:456
(gdb)

I would recommend spending some time running the bgp_flowspec topotest, especially w/ valgrind

LabN-CI · 2020-11-17T21:31:27Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/7485 `4dcef44`
Date	11/17/2020
Start	15:56:05
Finish	16:31:22
Run-Time	35:17
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-17-15:56:05.txt
Log	autoscript-2020-11-17-15:57:07.log.bz2
Memory	481 478 418

For details, please contact louberger

NetDEF-CI · 2020-11-17T23:39:01Z

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15484/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-15484/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Addresssanitizer topotests part 1: Incomplete

(check logs for details)

IPv6 protocols on Ubuntu 18.04: Failed (click for details)

IPv4 protocols on Ubuntu 18.04: Failed (click for details)

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-15484/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 arm8: Failed (click for details)

Topo tests part 1 on Ubuntu 18.04 arm8: No useful log found

Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15484/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TP2U1604I386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15484/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 arm8: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U18ARM8-15484/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 arm8
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TOPO0U18ARM8/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-15484/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-15484/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-15484/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15484/test

Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt

IPv4 ldp protocol on Ubuntu 18.04: Failed (click for details)

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15484/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-15484/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15484/artifact/TOPOI386/ErrorLog/log_topotests.txt

Successful on other platforms/tests

Fedora 29 rpm pkg check
Debian 8 deb pkg check
Static analyzer (clang)
Ubuntu 20.04 deb pkg check
Ubuntu 16.04 deb pkg check
Ubuntu 18.04 deb pkg check
Addresssanitizer topotests part 2
CentOS 7 rpm pkg check
Debian 10 deb pkg check
Debian 9 deb pkg check
Addresssanitizer topotests part 0

like for prefix_copy, the same memory block is used. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

if prefix is a flowspec prefix, free the flowspec pointer initially allocated. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

pguibert6WIND · 2020-11-20T15:06:11Z

There is no reason with flowspec code that zebra crashes because prefixes are not exchanged across daemons.
it probably comes from the fact that sometimes we call prefix_free() with a null pointer.
I added a check at prefix_free() entry; lets see.
I wonder if a separate prefix_flowspec_free() api would not be better

LabN-CI · 2020-11-20T17:50:55Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	0
Date	0
Start	0
Finish	vncregress-2020-11-20-12:15:35.txt
Run-Time	autoscript-2020-11-20-12:16:35.log.bz2
Total	467 471 417
Pass	SUCCESS git merge/6296 `ed97900`
Fail	06/20/2020
Valgrind-Errors	12:15:32
Valgrind-Loss	12:41:37
Details	26:05
Log	1818
Memory	1818
SUCCESS git merge/7485 `41abe26`	0
11/20/2020	0
12:15:35	0
12:50:50	vncregress-2020-06-20-12:15:32.txt
35:15	autoscript-2020-06-20-12:16:37.log.bz2
1815	488 500 421
1815

For details, please contact louberger

pguibert6WIND · 2020-11-20T18:12:47Z

ci:rerun

NetDEF-CI · 2020-11-20T18:15:18Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15553/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15553/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1

NetDEF-CI · 2020-11-20T21:09:34Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15556/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15556/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.5-0 -> 7.6-dev-20201120-08-g41abe2661-0 (missing) -> 7.6-dev-20201120-08-g41abe2661-0~deb10u1

pguibert6WIND · 2020-11-26T10:16:38Z

@donaldsharp , lets initiate the discussion.
How to detect memory leaks, knowing that we don't have any prefixes pointers available.
I see it like a mechanism that could do two things:
a- list the non freed prefixes
b- also detect if there is an extra allocation to do that

for the b) part, we could think of hosting a specific pointer to each prefix

struct prefix {
   union {
   }
   void *ptr_to_use_for_extra_allocation;
}

for the a) part, this is a larger problem. it looks like memory instrumentation without using valgrind

having a reference counter in each prefix could permit to know if a prefix is attached or not.
without using valgrind, some custom memory instrumentation could be specifically done for prefixes. but why limiting it to prefix objects. all memory objects could be eligible to that. memory library could be improved, for instance, by listing all memory blocks into a chunk of memory. this table would be refreshed after each XFREE/XMALLOC.
this mechanism should be optionally confiugrable per compilation, and would not rely on
waiting for any suggestions

pguibert6WIND · 2021-02-25T13:32:56Z

Hi @donaldsharp , can we statuate on this pull request, please?

pguibert6WIND · 2021-03-15T16:29:32Z

The issue is more, how should we prevent from forgetting about losing memory when freeing a prefix.
One possible solution would be to enforce the prefix API, and prevent the users to have the internal prefix structure exposed.
this is a brute solution that has been used for zebra dataplane. (solution 1)
I don't think it is good approach for prefix handler.

So, I think more of the current approach: having a memory block dedicated can be nice.
Also, having a common extra pointer in the prefix structure (solution 2) or in the prefix_flowspec (solution 3) structure can also be a choice in having more control over where the extra blocks would be allocated.

Based on this, the current implementation is based on solution 3.
Should we go for it ?

pjdruddy · 2021-03-15T16:52:35Z

lib/prefix.c

@@ -1114,6 +1114,15 @@ void prefix_free_lists(void *arg)
 	prefix_free(&p);
 }

+void prefix_flowspec_allocate(struct prefix *p, uint8_t *pnt, int size)


is this intended to be called from multiple places - that's what the commit headline implies.

yes. public API.
actually, it serves only bgp flowspec.
any recommendation?

mjstapp · 2021-03-15T16:58:46Z

bgpd/bgp_flowspec.c

-		memcpy(temp, pnt, psize);
-		p.u.prefix_flowspec.ptr = (uintptr_t) temp;
-
+		prefix_flowspec_allocate(&p, pnt, psize);


so this is ... malloc'ing some memory and attaching it to a prefix struct that's on the stack? how could you call the corresponding 'free' function in this case?

right now, it is up to the user to pay attention.

I ... don't understand that reply? 'p' is on the stack; the prefix_free() api is never called - right?

furthermore, the copy that's made in table.c:route_node_get() isn't freed either - how could it be, again it's on the stack.

I'm not certain this allocated info belongs in the prefix struct at all - how about putting it into the bgp_dest/bgp_node struct: that has a real dtor?

actually, sometimes, the user does not call prefix_free(), and directly call XFREE(..)
reworking all the code is not the goal of this ticket.

your suggestion to move extra data out of the prefix, I want to chat with you to understand more how that can be used ?.

vjardin · 2021-05-26T21:16:09Z

LGTM. This patch does not add more issue but it helps to avoid memory leakage, doesn't it ?

mjstapp · 2021-05-27T14:46:41Z

LGTM. This patch does not add more issue but it helps to avoid memory leakage, doesn't it ?

hmm - no, I think it would add new issues; I tried to point some of those out on March 15.

donaldsharp · 2022-01-13T15:29:05Z

@frrbot autoclose in 1 week

polychaeta added bgp libfrr labels Nov 7, 2020

pguibert6WIND force-pushed the flowspec_leak branch from f4dd4ed to 0678c65 Compare November 7, 2020 14:15

polychaeta reviewed Nov 7, 2020

View reviewed changes

pguibert6WIND force-pushed the flowspec_leak branch from 0678c65 to 8b08f00 Compare November 7, 2020 15:28

polychaeta reviewed Nov 7, 2020

View reviewed changes

pguibert6WIND force-pushed the flowspec_leak branch from 8b08f00 to f8a68c5 Compare November 7, 2020 21:59

polychaeta reviewed Nov 7, 2020

View reviewed changes

pguibert6WIND force-pushed the flowspec_leak branch from f8a68c5 to acaa986 Compare November 8, 2020 07:56

polychaeta reviewed Nov 8, 2020

View reviewed changes

pguibert6WIND force-pushed the flowspec_leak branch from acaa986 to 615a320 Compare November 8, 2020 13:03

polychaeta reviewed Nov 8, 2020

View reviewed changes

pguibert6WIND force-pushed the flowspec_leak branch from 615a320 to 7614ed7 Compare November 8, 2020 13:23

polychaeta reviewed Nov 8, 2020

View reviewed changes

pguibert6WIND force-pushed the flowspec_leak branch from 7614ed7 to 6a4eeda Compare November 8, 2020 20:32

polychaeta reviewed Nov 8, 2020

View reviewed changes

pguibert6WIND force-pushed the flowspec_leak branch from 263282f to 4cc2271 Compare November 9, 2020 09:13

pguibert6WIND force-pushed the flowspec_leak branch from 4cc2271 to 4dcef44 Compare November 17, 2020 20:43

pguibert6WIND added 2 commits November 20, 2020 15:03

bgpd, lib: use same allocator for flowspec prefixes

e9a558d

like for prefix_copy, the same memory block is used. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

lib: upon prefix_delete(), free extra flowspec stuff

41abe26

if prefix is a flowspec prefix, free the flowspec pointer initially allocated. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

pguibert6WIND force-pushed the flowspec_leak branch from 4dcef44 to 41abe26 Compare November 20, 2020 15:04

pjdruddy reviewed Mar 15, 2021

View reviewed changes

mjstapp reviewed Mar 15, 2021

View reviewed changes

frrbot bot added the autoclose label Jan 13, 2022

frrbot bot closed this Jan 20, 2022

frrbot bot removed the autoclose label Jan 20, 2022

pguibert6WIND mentioned this pull request Sep 8, 2023

lib: Free Temporary Memory for AF_FLOWSPEC Prefix #14372

Closed

Flowspec leak #7485

Flowspec leak #7485

Conversation

pguibert6WIND commented Nov 7, 2020

LabN-CI commented Nov 7, 2020 • edited Loading

Basic BGPD CI results: FAILURE

NetDEF-CI commented Nov 7, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 7, 2020 • edited Loading

Basic BGPD CI results: FAILURE

NetDEF-CI commented Nov 7, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Nov 7, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Nov 7, 2020 • edited Loading

Basic BGPD CI results: FAILURE

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 7, 2020 • edited Loading

Basic BGPD CI results: FAILURE

NetDEF-CI commented Nov 7, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 8, 2020 • edited Loading

Basic BGPD CI results: FAILURE

NetDEF-CI commented Nov 8, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 8, 2020 • edited Loading

Basic BGPD CI results: FAILURE

NetDEF-CI commented Nov 8, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 8, 2020 • edited Loading

Basic BGPD CI results: FAILURE

NetDEF-CI commented Nov 8, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 9, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Nov 9, 2020 • edited Loading

Basic BGPD CI results: Partial FAILURE, 3 tests failed

NetDEF-CI commented Nov 9, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

NetDEF-CI commented Nov 9, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

LabN-CI commented Nov 7, 2020 •

edited

Loading

NetDEF-CI commented Nov 7, 2020 •

edited

Loading

LabN-CI commented Nov 7, 2020 •

edited

Loading

NetDEF-CI commented Nov 7, 2020 •

edited

Loading

NetDEF-CI commented Nov 7, 2020 •

edited

Loading

LabN-CI commented Nov 7, 2020 •

edited

Loading

LabN-CI commented Nov 7, 2020 •

edited

Loading

NetDEF-CI commented Nov 7, 2020 •

edited

Loading

LabN-CI commented Nov 8, 2020 •

edited

Loading

NetDEF-CI commented Nov 8, 2020 •

edited

Loading

LabN-CI commented Nov 8, 2020 •

edited

Loading

NetDEF-CI commented Nov 8, 2020 •

edited

Loading

LabN-CI commented Nov 8, 2020 •

edited

Loading

NetDEF-CI commented Nov 8, 2020 •

edited

Loading

LabN-CI commented Nov 9, 2020 •

edited

Loading

LabN-CI commented Nov 9, 2020 •

edited

Loading

NetDEF-CI commented Nov 9, 2020 •

edited

Loading

NetDEF-CI commented Nov 9, 2020 •

edited

Loading

LabN-CI commented Nov 10, 2020 •

edited

Loading

LabN-CI commented Nov 17, 2020 •

edited

Loading

NetDEF-CI commented Nov 17, 2020 •

edited

Loading

pjdruddy Mar 15, 2021 •

edited

Loading