ospf6d: Json support added for command "show ipv6 ospf6 interface [json]" #7453

ranjanyash54 · 2020-11-04T09:38:10Z

Modify code to add JSON format output in show command
"show ipv6 ospf6 interface" with proper formating

Signed-off-by: Yash Ranjan ranjany@vmware.com

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/b66776a2c54e2fc2de06a41ea65cdee6/raw/383603aa096f4eef2dfa4869950081b3adb26d45/cr_7453_1604482694.diff | git apply

diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
index bedc6a9b0..16b8a2bc7 100644
--- a/ospf6d/ospf6_interface.c
+++ b/ospf6d/ospf6_interface.c
@@ -1149,15 +1149,9 @@ static int ospf6_interface_show(struct vty *vty, struct interface *ifp,
 }
 
 /* show interface */
-DEFUN(show_ipv6_ospf6_interface,
-      show_ipv6_ospf6_interface_ifname_cmd,
+DEFUN(show_ipv6_ospf6_interface, show_ipv6_ospf6_interface_ifname_cmd,
       "show ipv6 ospf6 interface [IFNAME] [json]",
-      SHOW_STR
-      IP6_STR
-      OSPF6_STR
-      INTERFACE_STR
-      IFNAME_STR
-      JSON_STR)
+      SHOW_STR IP6_STR OSPF6_STR INTERFACE_STR IFNAME_STR JSON_STR)
 {
 	struct vrf *vrf = vrf_lookup_by_id(VRF_DEFAULT);
 	int idx_ifname = 4;

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/19cd188c228c70ee56ec99a02b033289/raw/383603aa096f4eef2dfa4869950081b3adb26d45/cr_7453_1604483013.diff | git apply

diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
index bedc6a9b0..16b8a2bc7 100644
--- a/ospf6d/ospf6_interface.c
+++ b/ospf6d/ospf6_interface.c
@@ -1149,15 +1149,9 @@ static int ospf6_interface_show(struct vty *vty, struct interface *ifp,
 }
 
 /* show interface */
-DEFUN(show_ipv6_ospf6_interface,
-      show_ipv6_ospf6_interface_ifname_cmd,
+DEFUN(show_ipv6_ospf6_interface, show_ipv6_ospf6_interface_ifname_cmd,
       "show ipv6 ospf6 interface [IFNAME] [json]",
-      SHOW_STR
-      IP6_STR
-      OSPF6_STR
-      INTERFACE_STR
-      IFNAME_STR
-      JSON_STR)
+      SHOW_STR IP6_STR OSPF6_STR INTERFACE_STR IFNAME_STR JSON_STR)
 {
 	struct vrf *vrf = vrf_lookup_by_id(VRF_DEFAULT);
 	int idx_ifname = 4;

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-04T10:17:05Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/7453 `fa75bf9`
Date	11/04/2020
Start	04:50:40
Finish	05:17:00
Run-Time	26:20
Total	1818
Pass	1818
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-04-04:50:40.txt
Log	autoscript-2020-11-04-04:51:39.log.bz2
Memory	491 474 420

For details, please contact louberger

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/af20f1c0ae2777618dc016f585cbcb2c/raw/c7f6fa335fe25324749942036364e62f80c7b205/cr_7453_1604488004.diff | git apply

diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
index 683ca6607..3253da1a0 100644
--- a/ospf6d/ospf6_interface.c
+++ b/ospf6d/ospf6_interface.c
@@ -1148,15 +1148,9 @@ static int ospf6_interface_show(struct vty *vty, struct interface *ifp,
 }
 
 /* show interface */
-DEFUN(show_ipv6_ospf6_interface,
-      show_ipv6_ospf6_interface_ifname_cmd,
+DEFUN(show_ipv6_ospf6_interface, show_ipv6_ospf6_interface_ifname_cmd,
       "show ipv6 ospf6 interface [IFNAME] [json]",
-      SHOW_STR
-      IP6_STR
-      OSPF6_STR
-      INTERFACE_STR
-      IFNAME_STR
-      JSON_STR)
+      SHOW_STR IP6_STR OSPF6_STR INTERFACE_STR IFNAME_STR JSON_STR)
 {
 	struct vrf *vrf = vrf_lookup_by_id(VRF_DEFAULT);
 	int idx_ifname = 4;

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/eb54e2377e386c754cefcfdf724df3f6/raw/4e5a6efdc71ba0b4a1c38a1414b58487b6638174/cr_7453_1604488458.diff | git apply

diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
index d16dbdd27..e300d0028 100644
--- a/ospf6d/ospf6_interface.c
+++ b/ospf6d/ospf6_interface.c
@@ -1148,15 +1148,9 @@ static int ospf6_interface_show(struct vty *vty, struct interface *ifp,
 }
 
 /* show interface */
-DEFUN(show_ipv6_ospf6_interface,
-      show_ipv6_ospf6_interface_ifname_cmd,
+DEFUN(show_ipv6_ospf6_interface, show_ipv6_ospf6_interface_ifname_cmd,
       "show ipv6 ospf6 interface [IFNAME] [json]",
-      SHOW_STR
-      IP6_STR
-      OSPF6_STR
-      INTERFACE_STR
-      IFNAME_STR
-      JSON_STR)
+      SHOW_STR IP6_STR OSPF6_STR INTERFACE_STR IFNAME_STR JSON_STR)
 {
 	struct vrf *vrf = vrf_lookup_by_id(VRF_DEFAULT);
 	int idx_ifname = 4;

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/18ee7c89417d78c7c22312617a38c474/raw/f1b9a79e2cc9c2e955c15cb5b0e6aa262c9208b4/cr_7453_1604488550.diff | git apply

diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
index e56277d19..ddc85cc01 100644
--- a/ospf6d/ospf6_interface.c
+++ b/ospf6d/ospf6_interface.c
@@ -1148,15 +1148,9 @@ static int ospf6_interface_show(struct vty *vty, struct interface *ifp,
 }
 
 /* show interface */
-DEFUN(show_ipv6_ospf6_interface,
-      show_ipv6_ospf6_interface_ifname_cmd,
+DEFUN(show_ipv6_ospf6_interface, show_ipv6_ospf6_interface_ifname_cmd,
       "show ipv6 ospf6 interface [IFNAME] [json]",
-      SHOW_STR
-      IP6_STR
-      OSPF6_STR
-      INTERFACE_STR
-      IFNAME_STR
-      JSON_STR)
+      SHOW_STR IP6_STR OSPF6_STR INTERFACE_STR IFNAME_STR JSON_STR)
 {
 	struct vrf *vrf = vrf_lookup_by_id(VRF_DEFAULT);
 	int idx_ifname = 4;

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

NetDEF-CI · 2020-11-04T11:34:48Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U1604I386/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U1604I386/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U1804PPC64LEBUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI012BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
ospf6d/ospf6_interface.c: In function 'show_ipv6_ospf6_interface':
ospf6d/ospf6_interface.c:1180:5: error: 'json_int' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:8160: ospf6d/ospf6_interface.o] Error 1
doc/user/_build/texinfo/frr.texi:5: warning: unrecognized encoding name `UTF-8'.
doc/user/_build/texinfo/frr.texi:13937: warning: @image file `frr-figures/fig-normal-processing.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:13947: warning: @image file `frr-figures/fig_topologies_full.txt' (for text) unreadable: No such file or directory.
doc/user/_build/texinfo/frr.texi:13957: warning: @image file `frr-figures/fig_topologies_rs.txt' (for text) unreadable: No such file or directory.

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI012BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI021BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI021BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI014BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI014BUILD/config.status/config.status

Ubuntu 20.04 amd64 build: Failed (click for details)

Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U2004AMD64BUILD/config.status/config.status

Make failed for Ubuntu 20.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U2004AMD64BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
 1180 |     json_object_free(json_int);
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8161: ospf6d/ospf6_interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
make: *** [Makefile:4855: all] Error 2

Ubuntu 18.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U18ARM7BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI008BLD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7618: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
make[1]: Target 'all-am' not remade because of errors.

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI008BLD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/F29BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8160: ospf6d/ospf6_interface.o] Error 1
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
make: *** [Makefile:4854: all] Error 2

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/F29BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI011BUILD/ErrorLog/log_make.txt)

gmake[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
copying selected object files to avoid basename conflicts...
ospf6d/ospf6_interface.c:1180:22: error: variable 'json_int' is uninitialized when used here [-Werror,-Wuninitialized]
ospf6d/ospf6_interface.c:1165:23: note: initialize the variable 'json_int' to silence this warning
1 error generated.
gmake[1]: *** [Makefile:8159: ospf6d/ospf6_interface.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
gmake: *** [Makefile:4853: all] Error 2

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI011BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/DEB10BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8161: ospf6d/ospf6_interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:4855: all] Error 2

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/DEB10BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI009BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
ospf6d/ospf6_interface.c: In function 'show_ipv6_ospf6_interface':
ospf6d/ospf6_interface.c:1180:5: error: 'json_int' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 1180 |     json_object_free(json_int);
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:8160: ospf6d/ospf6_interface.o] Error 1
/usr/home/ci/cibuild.15178/frr-source/doc/user/eigrpd.rst:127: WARNING: duplicate clicmd description of redistribute kernel, other instance in bgp
/usr/home/ci/cibuild.15178/frr-source/doc/user/eigrpd.rst:139: WARNING: duplicate clicmd description of redistribute static, other instance in bgp
/usr/home/ci/cibuild.15178/frr-source/doc/user/eigrpd.rst:151: WARNING: duplicate clicmd description of redistribute connected, other instance in bgp

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 18.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U18ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'

Ubuntu 16.04 arm8 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm8 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U16ARM8BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
ospf6d/ospf6_interface.c: In function 'show_ipv6_ospf6_interface':
ospf6d/ospf6_interface.c:1180:5: error: 'json_int' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:8160: ospf6d/ospf6_interface.o] Error 1
gmake[1]: Target 'all-am' not remade because of errors.
gmake[1]: Leaving directory '/usr/home/ci/cibuild.15178/frr-source'
gmake: *** [Makefile:4854: all] Error 2

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U1804AMD64/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
Makefile:4330: recipe for target 'all' failed

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/U1804AMD64/config.status/config.status

Ubuntu 16.04 arm7 build: Failed (click for details)

Make failed for Ubuntu 16.04 arm7 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CI101BUILD/ErrorLog/log_make.txt)

make[1]: Entering directory '/home/ci/cibuild.15178/frr-source'
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
Makefile:7630: recipe for target 'ospf6d/ospf6_interface.o' failed
make[1]: *** [ospf6d/ospf6_interface.o] Error 1
copying selected object files to avoid basename conflicts...
make[1]: Target 'all-am' not remade because of errors.
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'

CentOS 8 amd64 build: Failed (click for details)

CentOS 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CENTOS8BUILD/config.status/config.status

Make failed for CentOS 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15178/artifact/CENTOS8BUILD/ErrorLog/log_make.txt)

copying selected object files to avoid basename conflicts...
ospf6d/ospf6_interface.c: In function show_ipv6_ospf6_interface:
ospf6d/ospf6_interface.c:1180:5: error: json_int may be used uninitialized in this function [-Werror=maybe-uninitialized]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8160: ospf6d/ospf6_interface.o] Error 1
make[1]: Leaving directory '/home/ci/cibuild.15178/frr-source'
make[1]: Target 'all-am' not remade because of errors.
make: *** [Makefile:4854: all] Error 2

Successful on other platforms/tests

CentOS 7 amd64 build

LabN-CI · 2020-11-04T11:37:04Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/7453 `15f740d`
Date	11/04/2020
Start	06:10:40
Finish	06:36:59
Run-Time	26:19
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-04-06:10:40.txt
Log	autoscript-2020-11-04-06:11:41.log.bz2
Memory	479 495 420

For details, please contact louberger

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/53b1afac9c1de27d2b113d1d05f14820/raw/950ef2cb140452c240d59d2e8de9580718a910b3/cr_7453_1604490679.diff | git apply

diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
index 1a7cb00bf..e07a60174 100644
--- a/ospf6d/ospf6_interface.c
+++ b/ospf6d/ospf6_interface.c
@@ -1148,15 +1148,9 @@ static int ospf6_interface_show(struct vty *vty, struct interface *ifp,
 }
 
 /* show interface */
-DEFUN(show_ipv6_ospf6_interface,
-      show_ipv6_ospf6_interface_ifname_cmd,
+DEFUN(show_ipv6_ospf6_interface, show_ipv6_ospf6_interface_ifname_cmd,
       "show ipv6 ospf6 interface [IFNAME] [json]",
-      SHOW_STR
-      IP6_STR
-      OSPF6_STR
-      INTERFACE_STR
-      IFNAME_STR
-      JSON_STR)
+      SHOW_STR IP6_STR OSPF6_STR INTERFACE_STR IFNAME_STR JSON_STR)
 {
 	struct vrf *vrf = vrf_lookup_by_id(VRF_DEFAULT);
 	int idx_ifname = 4;

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-04T12:06:58Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/7453 `4def16b`
Date	11/04/2020
Start	06:40:40
Finish	07:06:53
Run-Time	26:13
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-04-06:40:40.txt
Log	autoscript-2020-11-04-06:41:37.log.bz2
Memory	498 486 420

For details, please contact louberger

NetDEF-CI · 2020-11-04T12:08:40Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15174/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15174/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gc56ede5fa-0 (missing) -> 7.6-dev-20201104-00-gc56ede5fa-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gc56ede5fa-0 (missing) -> 7.6-dev-20201104-00-gc56ede5fa-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gc56ede5fa-0 (missing) -> 7.6-dev-20201104-00-gc56ede5fa-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gc56ede5fa-0 (missing) -> 7.6-dev-20201104-00-gc56ede5fa-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gc56ede5fa-0 (missing) -> 7.6-dev-20201104-00-gc56ede5fa-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 7453, comparing to Git base SHA 626d165

Fixed warnings:

Dead store: Dead assignment in ospf_asbr.c, function ospf_aggr_handle_external_info, line 427
Dead store: Dead assignment in ospf_asbr.c, function ospf_aggr_handle_external_info, line 419
Dead store: Dead assignment in ospf_vty.c, function show_ip_ospf_external_aggregator, line 11364

New warnings:

Dead store: Dead assignment in 6d/ospf6_interface.c, function show_ipv6_ospf6_interface, line 1171
- See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15174/artifact/shared/static_analysis/report-377c26.html#EndPath
Dead store: Dead assignment in d/ospf_asbr.c, function ospf_aggr_handle_external_info, line 427
- See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15174/artifact/shared/static_analysis/report-6049f0.html#EndPath
Dead store: Dead assignment in d/ospf_asbr.c, function ospf_aggr_handle_external_info, line 419
- See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15174/artifact/shared/static_analysis/report-1056cc.html#EndPath
Dead store: Dead assignment in d/ospf_vty.c, function show_ip_ospf_external_aggregator, line 11364
- See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15174/artifact/shared/static_analysis/report-349ba1.html#EndPath

Static Analysis warning summary compared to base:

Fixed warnings: 3
New warnings: 4

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15174/artifact/shared/static_analysis/index.html

NetDEF-CI · 2020-11-04T12:19:33Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15175/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15175/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gfa75bf972-0 (missing) -> 7.6-dev-20201104-00-gfa75bf972-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gfa75bf972-0 (missing) -> 7.6-dev-20201104-00-gfa75bf972-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gfa75bf972-0 (missing) -> 7.6-dev-20201104-00-gfa75bf972-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gfa75bf972-0 (missing) -> 7.6-dev-20201104-00-gfa75bf972-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-00-gfa75bf972-0 (missing) -> 7.6-dev-20201104-00-gfa75bf972-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 7453, comparing to Git base SHA 626d165

Fixed warnings:

Dead store: Dead assignment in ospf_asbr.c, function ospf_aggr_handle_external_info, line 427
Dead store: Dead assignment in ospf_asbr.c, function ospf_aggr_handle_external_info, line 419
Dead store: Dead assignment in ospf_vty.c, function show_ip_ospf_external_aggregator, line 11364

New warnings:

Dead store: Dead assignment in 6d/ospf6_interface.c, function show_ipv6_ospf6_interface, line 1171
- See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15175/artifact/shared/static_analysis/report-e8e865.html#EndPath
Dead store: Dead assignment in d/ospf_asbr.c, function ospf_aggr_handle_external_info, line 419
- See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15175/artifact/shared/static_analysis/report-ef7fec.html#EndPath
Dead store: Dead assignment in d/ospf_asbr.c, function ospf_aggr_handle_external_info, line 427
- See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15175/artifact/shared/static_analysis/report-0e749b.html#EndPath
Dead store: Dead assignment in d/ospf_vty.c, function show_ip_ospf_external_aggregator, line 11364
- See https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15175/artifact/shared/static_analysis/report-6ac158.html#EndPath

Static Analysis warning summary compared to base:

Fixed warnings: 3
New warnings: 4

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15175/artifact/shared/static_analysis/index.html

LabN-CI · 2020-11-04T12:37:18Z

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 1 tests failed

_	_
Result	SUCCESS git merge/7453 `e27d6af`
Date	11/04/2020
Start	07:10:40
Finish	07:37:13
Run-Time	26:33
Total	1818
Pass	1817
Fail	1
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-04-07:10:40.txt
Log	autoscript-2020-11-04-07:11:45.log.bz2
Memory	473 488 421

For details, please contact louberger

NetDEF-CI · 2020-11-04T13:40:47Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15177/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15177/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g15f740d95-0 (missing) -> 7.6-dev-20201104-01-g15f740d95-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g15f740d95-0 (missing) -> 7.6-dev-20201104-01-g15f740d95-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g15f740d95-0 (missing) -> 7.6-dev-20201104-01-g15f740d95-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g15f740d95-0 (missing) -> 7.6-dev-20201104-01-g15f740d95-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g15f740d95-0 (missing) -> 7.6-dev-20201104-01-g15f740d95-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 7453, comparing to Git base SHA 626d165

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15177/artifact/shared/static_analysis/index.html

NetDEF-CI · 2020-11-04T13:57:52Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15179/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15179/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g4def16b91-0 (missing) -> 7.6-dev-20201104-01-g4def16b91-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g4def16b91-0 (missing) -> 7.6-dev-20201104-01-g4def16b91-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g4def16b91-0 (missing) -> 7.6-dev-20201104-01-g4def16b91-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g4def16b91-0 (missing) -> 7.6-dev-20201104-01-g4def16b91-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-g4def16b91-0 (missing) -> 7.6-dev-20201104-01-g4def16b91-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 7453, comparing to Git base SHA 626d165

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15179/artifact/shared/static_analysis/index.html

NetDEF-CI · 2020-11-04T14:47:40Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15181/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15181/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-ge27d6afb1-0 (missing) -> 7.6-dev-20201104-01-ge27d6afb1-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-ge27d6afb1-0 (missing) -> 7.6-dev-20201104-01-ge27d6afb1-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-ge27d6afb1-0 (missing) -> 7.6-dev-20201104-01-ge27d6afb1-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-ge27d6afb1-0 (missing) -> 7.6-dev-20201104-01-ge27d6afb1-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201104-01-ge27d6afb1-0 (missing) -> 7.6-dev-20201104-01-ge27d6afb1-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 7453, comparing to Git base SHA 626d165

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15181/artifact/shared/static_analysis/index.html

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/e1673ebcd64e6796c5e6d93371f2c39f/raw/6a8f5402c97ec32cd97ecf3ea6bc11f1fb79e213/cr_7453_1604556256.diff | git apply

diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
index 135160261..fefec31d4 100644
--- a/ospf6d/ospf6_interface.c
+++ b/ospf6d/ospf6_interface.c
@@ -1149,15 +1149,9 @@ static int ospf6_interface_show(struct vty *vty, struct interface *ifp,
 }
 
 /* show interface */
-DEFUN(show_ipv6_ospf6_interface,
-      show_ipv6_ospf6_interface_ifname_cmd,
+DEFUN(show_ipv6_ospf6_interface, show_ipv6_ospf6_interface_ifname_cmd,
       "show ipv6 ospf6 interface [IFNAME] [json]",
-      SHOW_STR
-      IP6_STR
-      OSPF6_STR
-      INTERFACE_STR
-      IFNAME_STR
-      JSON_STR)
+      SHOW_STR IP6_STR OSPF6_STR INTERFACE_STR IFNAME_STR JSON_STR)
 {
 	struct vrf *vrf = vrf_lookup_by_id(VRF_DEFAULT);
 	int idx_ifname = 4;

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-05T07:18:35Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/7453 `38af39d`
Date	11/05/2020
Start	01:52:12
Finish	02:18:30
Run-Time	26:18
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-05-01:52:12.txt
Log	autoscript-2020-11-05-01:53:13.log.bz2
Memory	474 498 420

For details, please contact louberger

NetDEF-CI · 2020-11-05T08:38:32Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15206/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15206/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201105-00-g38af39d32-0 (missing) -> 7.6-dev-20201105-00-g38af39d32-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201105-00-g38af39d32-0 (missing) -> 7.6-dev-20201105-00-g38af39d32-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201105-00-g38af39d32-0 (missing) -> 7.6-dev-20201105-00-g38af39d32-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201105-00-g38af39d32-0 (missing) -> 7.6-dev-20201105-00-g38af39d32-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201105-00-g38af39d32-0 (missing) -> 7.6-dev-20201105-00-g38af39d32-0~deb10u1

CLANG Static Analyzer Summary

Github Pull Request 7453, comparing to Git base SHA 898fde3

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15206/artifact/shared/static_analysis/index.html

…on]" Modify code to add JSON format output in show command "show ipv6 ospf6 interface" with proper formating Signed-off-by: Yash Ranjan <ranjany@vmware.com>

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/8a816b22873b3ca3dd1a7521ef424cd9/raw/6a8f5402c97ec32cd97ecf3ea6bc11f1fb79e213/cr_7453_1605590362.diff | git apply

diff --git a/ospf6d/ospf6_interface.c b/ospf6d/ospf6_interface.c
index 135160261..fefec31d4 100644
--- a/ospf6d/ospf6_interface.c
+++ b/ospf6d/ospf6_interface.c
@@ -1149,15 +1149,9 @@ static int ospf6_interface_show(struct vty *vty, struct interface *ifp,
 }
 
 /* show interface */
-DEFUN(show_ipv6_ospf6_interface,
-      show_ipv6_ospf6_interface_ifname_cmd,
+DEFUN(show_ipv6_ospf6_interface, show_ipv6_ospf6_interface_ifname_cmd,
       "show ipv6 ospf6 interface [IFNAME] [json]",
-      SHOW_STR
-      IP6_STR
-      OSPF6_STR
-      INTERFACE_STR
-      IFNAME_STR
-      JSON_STR)
+      SHOW_STR IP6_STR OSPF6_STR INTERFACE_STR IFNAME_STR JSON_STR)
 {
 	struct vrf *vrf = vrf_lookup_by_id(VRF_DEFAULT);
 	int idx_ifname = 4;

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-11-17T06:56:04Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/7453 `f16ae8c`
Date	11/17/2020
Start	01:20:37
Finish	01:55:59
Run-Time	35:22
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-11-17-01:20:37.txt
Log	autoscript-2020-11-17-01:21:38.log.bz2
Memory	482 488 418

For details, please contact louberger

NetDEF-CI · 2020-11-17T08:01:50Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15455/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15455/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201117-01-gf16ae8cf5-0 (missing) -> 7.6-dev-20201117-01-gf16ae8cf5-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201117-01-gf16ae8cf5-0 (missing) -> 7.6-dev-20201117-01-gf16ae8cf5-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201117-01-gf16ae8cf5-0 (missing) -> 7.6-dev-20201117-01-gf16ae8cf5-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201117-01-gf16ae8cf5-0 (missing) -> 7.6-dev-20201117-01-gf16ae8cf5-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201117-01-gf16ae8cf5-0 (missing) -> 7.6-dev-20201117-01-gf16ae8cf5-0~deb10u1

riw777

looks good

polychaeta added the ospfv3 label Nov 4, 2020

polychaeta reviewed Nov 4, 2020

View reviewed changes

ranjanyash54 force-pushed the dev_7 branch from c56ede5 to fa75bf9 Compare November 4, 2020 09:43

polychaeta reviewed Nov 4, 2020

View reviewed changes

ranjanyash54 force-pushed the dev_7 branch from fa75bf9 to 15f740d Compare November 4, 2020 11:06

polychaeta reviewed Nov 4, 2020

View reviewed changes

ranjanyash54 force-pushed the dev_7 branch from 15f740d to f785ac4 Compare November 4, 2020 11:14

polychaeta reviewed Nov 4, 2020

View reviewed changes

ranjanyash54 force-pushed the dev_7 branch from f785ac4 to 4def16b Compare November 4, 2020 11:15

polychaeta reviewed Nov 4, 2020

View reviewed changes

ranjanyash54 force-pushed the dev_7 branch from 4def16b to e27d6af Compare November 4, 2020 11:51

polychaeta reviewed Nov 4, 2020

View reviewed changes

ranjanyash54 force-pushed the dev_7 branch from e27d6af to 38af39d Compare November 5, 2020 06:04

polychaeta reviewed Nov 5, 2020

View reviewed changes

ospf6d: Json support added for command "show ipv6 ospf6 interface [js…

f16ae8c

…on]" Modify code to add JSON format output in show command "show ipv6 ospf6 interface" with proper formating Signed-off-by: Yash Ranjan <ranjany@vmware.com>

ranjanyash54 force-pushed the dev_7 branch from 38af39d to f16ae8c Compare November 17, 2020 05:19

polychaeta reviewed Nov 17, 2020

View reviewed changes

riw777 approved these changes Nov 17, 2020

View reviewed changes

riw777 merged commit 4b5eb21 into FRRouting:master Nov 17, 2020

ranjanyash54 deleted the dev_7 branch November 27, 2020 09:50

ospf6d: Json support added for command "show ipv6 ospf6 interface [json]" #7453

ospf6d: Json support added for command "show ipv6 ospf6 interface [json]" #7453

Conversation

ranjanyash54 commented Nov 4, 2020

polychaeta left a comment

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 4, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

polychaeta left a comment

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

NetDEF-CI commented Nov 4, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

LabN-CI commented Nov 4, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 4, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 4, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

Fixed warnings:

New warnings:

Static Analysis warning summary compared to base:

4 Static Analyzer issues remaining.

NetDEF-CI commented Nov 4, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

Fixed warnings:

New warnings:

Static Analysis warning summary compared to base:

4 Static Analyzer issues remaining.

LabN-CI commented Nov 4, 2020 • edited Loading

Basic BGPD CI results: Partial FAILURE, 1 tests failed

NetDEF-CI commented Nov 4, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

NetDEF-CI commented Nov 4, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

NetDEF-CI commented Nov 4, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 5, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 5, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Nov 17, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Nov 17, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

riw777 left a comment

LabN-CI commented Nov 4, 2020 •

edited

Loading

NetDEF-CI commented Nov 4, 2020 •

edited

Loading

LabN-CI commented Nov 4, 2020 •

edited

Loading

LabN-CI commented Nov 4, 2020 •

edited

Loading

NetDEF-CI commented Nov 4, 2020 •

edited

Loading

NetDEF-CI commented Nov 4, 2020 •

edited

Loading

LabN-CI commented Nov 4, 2020 •

edited

Loading

NetDEF-CI commented Nov 4, 2020 •

edited

Loading

NetDEF-CI commented Nov 4, 2020 •

edited

Loading

NetDEF-CI commented Nov 4, 2020 •

edited

Loading

LabN-CI commented Nov 5, 2020 •

edited

Loading

NetDEF-CI commented Nov 5, 2020 •

edited

Loading