tests: bgp_l3vpn_to_bgp_vrf test needed to correct order #7256

donaldsharp · 2020-10-07T16:29:20Z

The bgp_l3vpn_to_bgp_vrf test is looking for a prefix
on multiple routers that the ordered received is non-deterministic.
As such the regex's are failing occassionaly when the
route is received in an unexpected order.

One possible order:
(#89) scripts/check_routes.py:120 COMMAND:ce3:vtysh -c "show bgp ipv4 uni 6.0.1.0":2 available, best .192.168.1.1. Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3.* Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best .Weight.* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56.* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1.* Origin IGP, metric 98, localpref 123, valid, internal.* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56:pass:Redundant route 1 details c:
COMMAND OUTPUT:BGP routing table entry for 6.0.1.0/24^M
Paths: (2 available, best #1, table default)^M
Advertised to non peer-group peers:^M
192.168.1.1^M
Local^M
99.0.0.3 from 0.0.0.0 (99.0.0.3)^M
Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best (Weight)^M
Community: 0:67^M
Extended Community: RT:89:123^M
Large Community: 12:34:56^M
Last update: Wed Oct 7 11:12:22 2020^M
Local^M
192.168.1.1 from 192.168.1.1 (192.168.1.1)^M
Origin IGP, metric 98, localpref 123, valid, internal^M
Community: 0:67^M
Extended Community: RT:52:100 RT:89:123^M
Large Community: 12:34:56^M
Last update: Wed Oct 7 11:12:41 2020:
R:89 ce3 Redundant route 1 details c 1 0

Second possible order:
(#89) scripts/check_routes.py:120 COMMAND:ce3:vtysh -c "show bgp ipv4 uni 6.0.1.0":2 available, best .192.168.1.1. Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3.* Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best .Weight.* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56.* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1.* Origin IGP, metric 98, localpref 123, valid, internal.* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56:pass:Redundant route 1 details c:
COMMAND OUTPUT:BGP routing table entry for 6.0.1.0/24^M
Paths: (2 available, best #2, table default)^M
Advertised to non peer-group peers:^M
192.168.1.1^M
Local^M
192.168.1.1 from 192.168.1.1 (192.168.1.1)^M
Origin IGP, metric 98, localpref 123, valid, internal^M
Community: 0:67^M
Extended Community: RT:52:100 RT:89:123^M
Large Community: 12:34:56^M
Last update: Wed Oct 7 11:14:45 2020^M
Local^M
99.0.0.3 from 0.0.0.0 (99.0.0.3)^M
Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best (Weight)^M
Community: 0:67^M
Extended Community: RT:89:123^M
Large Community: 12:34:56^M
Last update: Wed Oct 7 11:14:27 2020:
R:89 ce3 Redundant route 1 details c 0 1

BGP displays the paths in the order received since it's just a linked list.
For this test modify/add the luCommands to track that we may
receive the paths in a non-deterministic order.

Signed-off-by: Donald Sharp sharpd@nvidia.com

LabN-CI · 2020-10-07T17:01:31Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/7256 `d2daf74`
Date	10/07/2020
Start	12:35:34
Finish	13:01:27
Run-Time	25:53
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-10-07-12:35:34.txt
Log	autoscript-2020-10-07-12:36:36.log.bz2
Memory	504 503 428

For details, please contact louberger

NetDEF-CI · 2020-10-07T19:08:57Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14610/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14610/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201007-07-gd2daf74cf-0 (missing) -> 7.6-dev-20201007-07-gd2daf74cf-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201007-07-gd2daf74cf-0 (missing) -> 7.6-dev-20201007-07-gd2daf74cf-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201007-07-gd2daf74cf-0 (missing) -> 7.6-dev-20201007-07-gd2daf74cf-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201007-07-gd2daf74cf-0 (missing) -> 7.6-dev-20201007-07-gd2daf74cf-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201007-07-gd2daf74cf-0 (missing) -> 7.6-dev-20201007-07-gd2daf74cf-0~deb10u1

rzalamena · 2020-10-08T15:06:56Z

tests/topotests/bgp_l3vpn_to_bgp_vrf/scripts/check_routes.py

          ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .Weight" +
          ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56",
          "pass", "Redundant route 1 details")
 luCommand("ce3",'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
-          "2 available, best .*192.168.1.1.* Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3" +
+          "2 available, best "
+	  ".* Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3" +


two spaces missing here.

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/21c0a57ddd372a0c483e446aa2deddb4/raw/1360eb3519d6944a6107157d527411c71714c2f7/cr_7256_1602174399.diff | git apply

diff --git a/tests/topotests/bgp_l3vpn_to_bgp_vrf/scripts/check_routes.py b/tests/topotests/bgp_l3vpn_to_bgp_vrf/scripts/check_routes.py
index da4717114..98d2a3baf 100644
--- a/tests/topotests/bgp_l3vpn_to_bgp_vrf/scripts/check_routes.py
+++ b/tests/topotests/bgp_l3vpn_to_bgp_vrf/scripts/check_routes.py
@@ -306,8 +306,13 @@ want_r1_remote_cust1_routes = [
     {"p": "99.0.0.4/32", "n": "4.4.4.4"},
 ]
 bgpribRequireUnicastRoutes(
-    "r1", "ipv4", "r1-cust1", "Customer 1 routes in r1 vrf (2)", want_r1_remote_cust1_routes
-    , debug=False)
+    "r1",
+    "ipv4",
+    "r1-cust1",
+    "Customer 1 routes in r1 vrf (2)",
+    want_r1_remote_cust1_routes,
+    debug=False,
+)
 
 want_r3_remote_cust1_routes = [
     {"p": "5.1.0.0/24", "n": "1.1.1.1", "bp": True},
@@ -329,8 +334,13 @@ want_r3_remote_cust1_routes = [
     {"p": "99.0.0.4/32", "n": "4.4.4.4", "bp": True},
 ]
 bgpribRequireUnicastRoutes(
-    "r3", "ipv4", "r3-cust1", "Customer 1 routes in r3 vrf (2)", want_r3_remote_cust1_routes
-    , debug=False)
+    "r3",
+    "ipv4",
+    "r3-cust1",
+    "Customer 1 routes in r3 vrf (2)",
+    want_r3_remote_cust1_routes,
+    debug=False,
+)
 
 want_r4_remote_cust1_routes = [
     {"p": "5.1.0.0/24", "n": "1.1.1.1", "bp": True},
@@ -351,8 +361,13 @@ want_r4_remote_cust1_routes = [
     {"p": "99.0.0.4/32", "n": "192.168.2.2", "bp": True},
 ]
 bgpribRequireUnicastRoutes(
-    "r4", "ipv4", "r4-cust1", "Customer 1 routes in r4 vrf (2)", want_r4_remote_cust1_routes
-    , debug=False)
+    "r4",
+    "ipv4",
+    "r4-cust1",
+    "Customer 1 routes in r4 vrf (2)",
+    want_r4_remote_cust1_routes,
+    debug=False,
+)
 
 want_r4_remote_cust2_routes = [
     {"p": "5.1.0.0/24", "n": "1.1.1.1", "bp": True},
@@ -373,8 +388,13 @@ want_r4_remote_cust2_routes = [
     {"p": "99.0.0.4/32", "n": "192.168.2.2", "bp": True},
 ]
 bgpribRequireUnicastRoutes(
-    "r4", "ipv4", "r4-cust2", "Customer 2 routes in r4 vrf (2)", want_r4_remote_cust2_routes
-    , debug=False)
+    "r4",
+    "ipv4",
+    "r4-cust2",
+    "Customer 2 routes in r4 vrf (2)",
+    want_r4_remote_cust2_routes,
+    debug=False,
+)
 
 
 #########################################################################
@@ -402,7 +422,9 @@ want = [
     {"p": "6.0.1.0/24", "n": "99.0.0.1", "bp": True},
     {"p": "6.0.2.0/24", "n": "99.0.0.1", "bp": True},
 ]
-bgpribRequireUnicastRoutes("ce1", "ipv4", "", "Cust 1 routes from remote", want, debug=False)
+bgpribRequireUnicastRoutes(
+    "ce1", "ipv4", "", "Cust 1 routes from remote", want, debug=False
+)
 
 luCommand(
     "ce2",
@@ -425,7 +447,9 @@ want = [
     {"p": "6.0.1.0/24", "n": "99.0.0.2", "bp": True},
     {"p": "6.0.2.0/24", "n": "99.0.0.2", "bp": True},
 ]
-bgpribRequireUnicastRoutes("ce2", "ipv4", "", "Cust 1 routes from remote", want, debug=False)
+bgpribRequireUnicastRoutes(
+    "ce2", "ipv4", "", "Cust 1 routes from remote", want, debug=False
+)
 
 # human readable output for debugging
 luCommand("r4", 'vtysh -c "show bgp vrf r4-cust1 ipv4 uni"')
@@ -453,7 +477,9 @@ want = [
     {"p": "6.0.1.0/24", "n": "99.0.0.3", "bp": True},
     {"p": "6.0.2.0/24", "n": "99.0.0.3", "bp": True},
 ]
-bgpribRequireUnicastRoutes("ce3", "ipv4", "", "Cust 1 routes from remote", want, debug=False)
+bgpribRequireUnicastRoutes(
+    "ce3", "ipv4", "", "Cust 1 routes from remote", want, debug=False
+)
 
 luCommand(
     "ce4",
@@ -477,68 +503,117 @@ bgpribRequireUnicastRoutes(
     "ce4", "ipv4", "ce4-cust2", "Cust 2 routes from remote", want, debug=False
 )
 
-#verify details of exported/imported routes
-luCommand("ce1",'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
-          "1 available.*192.168.1.1.*99.0.0.1.*Community: 0:67.*Extended Community: RT:89:123.*Large Community: 12:34:56",
-          "pass", "Redundant route 1 details")
-luCommand("ce2",'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
-          "2 available, best .*192.168.1.1.* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1" +
-          ".* Origin IGP, metric 98, localpref 123, valid, internal" +
-          ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56",
-          "pass", "Redundant route 1 details")
-luCommand("ce2",'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
-          "2 available, best .*192.168.1.1.* Local.* 99.0.0.2 from 0.0.0.0 .99.0.0.2" +
-          ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .Weight" +
-          ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56",
-          "pass", "Redundant route 1 details")
-luCommand("ce3",'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
-          "2 available, best "
-          ".* Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3" +
-          ".* Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best .Weight" +
-          ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56",
-          "pass", "Redundant route 1 details")
-luCommand("ce3",'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
-          "2 available, best "
-          ".* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1" +
-          ".* Origin IGP, metric 98, localpref 123, valid, internal" +
-          ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56",
-          "pass", "Redundant route 1 details")
-luCommand("ce4",'vtysh -c "show bgp vrf ce4-cust2 ipv4 6.0.1.0"',
-          "2 available, best .*192.168.2.1.* Local.* 192.168.2.1 from 192.168.2.1 .192.168.2.1" +
-          ".* Origin IGP, metric 98, localpref 123, valid, internal" +
-          ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56" +
-          ".* Local.* 99.0.0.4 from 0.0.0.0 .99.0.0.4" +
-          ".* Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best .Weight" +
-          ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56",
-          "pass", "Redundant route 1 details")
-
-luCommand("ce1",'vtysh -c "show bgp ipv4 uni 6.0.2.0"',
-          "1 available, best .*192.168.1.1.* Local.* 99.0.0.1 from 0.0.0.0 .99.0.0.1" +
-          ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .First path received" +
-          ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:11",
-          "pass", "Redundant route 2 details")
-luCommand("ce2",'vtysh -c "show bgp ipv4 uni 6.0.2.0"', "1 available, best .*192.168.1.1.* Local.* 99.0.0.2 from 0.0.0.0 .99.0.0.2" +
-          ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .First path received" +
-          ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:12",
-          "pass", "Redundant route 2 details")
-luCommand("ce3",'vtysh -c "show bgp ipv4 uni 6.0.2.0"',
-          "2 available, best .*192.168.1.1.* Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3" +
-          ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .Weight" +
-          ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:13",
-          "pass", "Redundant route 2 details")
-luCommand("ce3",'vtysh -c "show bgp ipv4 uni 6.0.2.0"',
-          "2 available, best .*192.168.1.1.* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1" +
-          ".* Origin IGP, metric 100, localpref 100, valid, internal" +
-          ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:14",
-          "pass", "Redundant route 2 details")
-luCommand("ce4",'vtysh -c "show bgp  vrf ce4-cust2 ipv4 6.0.2.0"',
-          "2 available, best .*192.168.2.1.* Local.* 192.168.2.1 from 192.168.2.1 .192.168.2.1" +
-          ".* Origin IGP, metric 100, localpref 100, valid, internal" +
-          ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:13",
-          "pass", "Redundant route 2 details")
-luCommand("ce4",'vtysh -c "show bgp  vrf ce4-cust2 ipv4 6.0.2.0"',
-          "2 available, best .*192.168.2.1.* Local.* 99.0.0.4 from 0.0.0.0 .99.0.0.4" +
-          ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .Weight" +
-          ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:14",
-          "pass", "Redundant route 2 details")
-#done
+# verify details of exported/imported routes
+luCommand(
+    "ce1",
+    'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
+    "1 available.*192.168.1.1.*99.0.0.1.*Community: 0:67.*Extended Community: RT:89:123.*Large Community: 12:34:56",
+    "pass",
+    "Redundant route 1 details",
+)
+luCommand(
+    "ce2",
+    'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
+    "2 available, best .*192.168.1.1.* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1"
+    + ".* Origin IGP, metric 98, localpref 123, valid, internal"
+    + ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56",
+    "pass",
+    "Redundant route 1 details",
+)
+luCommand(
+    "ce2",
+    'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
+    "2 available, best .*192.168.1.1.* Local.* 99.0.0.2 from 0.0.0.0 .99.0.0.2"
+    + ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .Weight"
+    + ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56",
+    "pass",
+    "Redundant route 1 details",
+)
+luCommand(
+    "ce3",
+    'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
+    "2 available, best "
+    ".* Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3"
+    + ".* Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best .Weight"
+    + ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56",
+    "pass",
+    "Redundant route 1 details",
+)
+luCommand(
+    "ce3",
+    'vtysh -c "show bgp ipv4 uni 6.0.1.0"',
+    "2 available, best "
+    ".* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1"
+    + ".* Origin IGP, metric 98, localpref 123, valid, internal"
+    + ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56",
+    "pass",
+    "Redundant route 1 details",
+)
+luCommand(
+    "ce4",
+    'vtysh -c "show bgp vrf ce4-cust2 ipv4 6.0.1.0"',
+    "2 available, best .*192.168.2.1.* Local.* 192.168.2.1 from 192.168.2.1 .192.168.2.1"
+    + ".* Origin IGP, metric 98, localpref 123, valid, internal"
+    + ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56"
+    + ".* Local.* 99.0.0.4 from 0.0.0.0 .99.0.0.4"
+    + ".* Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best .Weight"
+    + ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56",
+    "pass",
+    "Redundant route 1 details",
+)
+
+luCommand(
+    "ce1",
+    'vtysh -c "show bgp ipv4 uni 6.0.2.0"',
+    "1 available, best .*192.168.1.1.* Local.* 99.0.0.1 from 0.0.0.0 .99.0.0.1"
+    + ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .First path received"
+    + ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:11",
+    "pass",
+    "Redundant route 2 details",
+)
+luCommand(
+    "ce2",
+    'vtysh -c "show bgp ipv4 uni 6.0.2.0"',
+    "1 available, best .*192.168.1.1.* Local.* 99.0.0.2 from 0.0.0.0 .99.0.0.2"
+    + ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .First path received"
+    + ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:12",
+    "pass",
+    "Redundant route 2 details",
+)
+luCommand(
+    "ce3",
+    'vtysh -c "show bgp ipv4 uni 6.0.2.0"',
+    "2 available, best .*192.168.1.1.* Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3"
+    + ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .Weight"
+    + ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:13",
+    "pass",
+    "Redundant route 2 details",
+)
+luCommand(
+    "ce3",
+    'vtysh -c "show bgp ipv4 uni 6.0.2.0"',
+    "2 available, best .*192.168.1.1.* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1"
+    + ".* Origin IGP, metric 100, localpref 100, valid, internal"
+    + ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:14",
+    "pass",
+    "Redundant route 2 details",
+)
+luCommand(
+    "ce4",
+    'vtysh -c "show bgp  vrf ce4-cust2 ipv4 6.0.2.0"',
+    "2 available, best .*192.168.2.1.* Local.* 192.168.2.1 from 192.168.2.1 .192.168.2.1"
+    + ".* Origin IGP, metric 100, localpref 100, valid, internal"
+    + ".* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:13",
+    "pass",
+    "Redundant route 2 details",
+)
+luCommand(
+    "ce4",
+    'vtysh -c "show bgp  vrf ce4-cust2 ipv4 6.0.2.0"',
+    "2 available, best .*192.168.2.1.* Local.* 99.0.0.4 from 0.0.0.0 .99.0.0.4"
+    + ".* Origin IGP, metric 100, localpref 100, weight 32768, valid, sourced, local, best .Weight"
+    + ".* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:14",
+    "pass",
+    "Redundant route 2 details",
+)
+# done

If you are a new contributor to FRR, please see our contributing guidelines.

After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.

LabN-CI · 2020-10-08T16:56:32Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/7256 `29893b0`
Date	10/08/2020
Start	12:30:34
Finish	12:56:28
Run-Time	25:54
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-10-08-12:30:34.txt
Log	autoscript-2020-10-08-12:31:36.log.bz2
Memory	484 504 427

For details, please contact louberger

The bgp_l3vpn_to_bgp_vrf test is looking for a prefix on multiple routers that the ordered received is non-deterministic. As such the regex's are failing occassionaly when the route is received in an unexpected order. One possible order: (FRRouting#89) scripts/check_routes.py:120 COMMAND:ce3:vtysh -c "show bgp ipv4 uni 6.0.1.0":2 available, best .*192.168.1.1.* Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3.* Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best .Weight.* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56.* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1.* Origin IGP, metric 98, localpref 123, valid, internal.* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56:pass:Redundant route 1 details c: COMMAND OUTPUT:BGP routing table entry for 6.0.1.0/24^M Paths: (2 available, best #1, table default)^M Advertised to non peer-group peers:^M 192.168.1.1^M Local^M 99.0.0.3 from 0.0.0.0 (99.0.0.3)^M Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best (Weight)^M Community: 0:67^M Extended Community: RT:89:123^M Large Community: 12:34:56^M Last update: Wed Oct 7 11:12:22 2020^M Local^M 192.168.1.1 from 192.168.1.1 (192.168.1.1)^M Origin IGP, metric 98, localpref 123, valid, internal^M Community: 0:67^M Extended Community: RT:52:100 RT:89:123^M Large Community: 12:34:56^M Last update: Wed Oct 7 11:12:41 2020: R:89 ce3 Redundant route 1 details c 1 0 Second possible order: (FRRouting#89) scripts/check_routes.py:120 COMMAND:ce3:vtysh -c "show bgp ipv4 uni 6.0.1.0":2 available, best .*192.168.1.1.* Local.* 99.0.0.3 from 0.0.0.0 .99.0.0.3.* Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best .Weight.* Community: 0:67.* Extended Community: RT:89:123.* Large Community: 12:34:56.* Local.* 192.168.1.1 from 192.168.1.1 .192.168.1.1.* Origin IGP, metric 98, localpref 123, valid, internal.* Community: 0:67.* Extended Community: RT:52:100 RT:89:123.* Large Community: 12:34:56:pass:Redundant route 1 details c: COMMAND OUTPUT:BGP routing table entry for 6.0.1.0/24^M Paths: (2 available, best #2, table default)^M Advertised to non peer-group peers:^M 192.168.1.1^M Local^M 192.168.1.1 from 192.168.1.1 (192.168.1.1)^M Origin IGP, metric 98, localpref 123, valid, internal^M Community: 0:67^M Extended Community: RT:52:100 RT:89:123^M Large Community: 12:34:56^M Last update: Wed Oct 7 11:14:45 2020^M Local^M 99.0.0.3 from 0.0.0.0 (99.0.0.3)^M Origin IGP, metric 200, localpref 50, weight 32768, valid, sourced, local, best (Weight)^M Community: 0:67^M Extended Community: RT:89:123^M Large Community: 12:34:56^M Last update: Wed Oct 7 11:14:27 2020: R:89 ce3 Redundant route 1 details c 0 1 BGP displays the paths in the order received since it's just a linked list. For this test modify/add the luCommands to track that we may receive the paths in a non-deterministic order. Signed-off-by: Donald Sharp <sharpd@nvidia.com> Signed-off-by: Quentin Young <qlyoung@nvidia.com>

LabN-CI · 2020-10-08T18:18:49Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/7256 `f20093b`
Date	10/08/2020
Start	13:52:48
Finish	14:18:45
Run-Time	25:57
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-10-08-13:52:48.txt
Log	autoscript-2020-10-08-13:53:48.log.bz2
Memory	493 477 428

For details, please contact louberger

NetDEF-CI · 2020-10-08T19:06:38Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14630/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14630/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-00-g29893b095-0 (missing) -> 7.6-dev-20201008-00-g29893b095-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-00-g29893b095-0 (missing) -> 7.6-dev-20201008-00-g29893b095-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-00-g29893b095-0 (missing) -> 7.6-dev-20201008-00-g29893b095-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-00-g29893b095-0 (missing) -> 7.6-dev-20201008-00-g29893b095-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-00-g29893b095-0 (missing) -> 7.6-dev-20201008-00-g29893b095-0~deb10u1

NetDEF-CI · 2020-10-08T19:45:11Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14632/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14632/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.5.0.3 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-01-gf20093b5c-0 (missing) -> 7.6-dev-20201008-01-gf20093b5c-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-01-gf20093b5c-0 (missing) -> 7.6-dev-20201008-01-gf20093b5c-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-01-gf20093b5c-0 (missing) -> 7.6-dev-20201008-01-gf20093b5c-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-01-gf20093b5c-0 (missing) -> 7.6-dev-20201008-01-gf20093b5c-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.6-dev-20201008-01-gf20093b5c-0 (missing) -> 7.6-dev-20201008-01-gf20093b5c-0~deb10u1

polychaeta added the tests Topotests, make check, etc label Oct 7, 2020

rzalamena approved these changes Oct 8, 2020

View reviewed changes

rzalamena reviewed Oct 8, 2020

View reviewed changes

donaldsharp force-pushed the topo_fixinator branch from d2daf74 to 29893b0 Compare October 8, 2020 16:26

polychaeta reviewed Oct 8, 2020

View reviewed changes

qlyoung force-pushed the topo_fixinator branch from 29893b0 to f20093b Compare October 8, 2020 17:03

rzalamena merged commit 0405eff into FRRouting:master Oct 8, 2020

donaldsharp deleted the topo_fixinator branch June 23, 2021 11:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: bgp_l3vpn_to_bgp_vrf test needed to correct order #7256

tests: bgp_l3vpn_to_bgp_vrf test needed to correct order #7256

donaldsharp commented Oct 7, 2020

LabN-CI commented Oct 7, 2020 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Oct 7, 2020 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

rzalamena Oct 8, 2020

polychaeta left a comment

LabN-CI commented Oct 8, 2020 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Oct 8, 2020

NetDEF-CI commented Oct 8, 2020 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Oct 8, 2020

tests: bgp_l3vpn_to_bgp_vrf test needed to correct order #7256

tests: bgp_l3vpn_to_bgp_vrf test needed to correct order #7256

Conversation

donaldsharp commented Oct 7, 2020

LabN-CI commented Oct 7, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Oct 7, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

rzalamena Oct 8, 2020

Choose a reason for hiding this comment

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Oct 8, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Oct 8, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Oct 8, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Oct 8, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Oct 7, 2020 •

edited

Loading

NetDEF-CI commented Oct 7, 2020 •

edited

Loading

LabN-CI commented Oct 8, 2020 •

edited

Loading

NetDEF-CI commented Oct 8, 2020 •

edited

Loading