Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ospf test speedup #7051

Merged
merged 13 commits into from
Sep 5, 2020
Merged

Ospf test speedup #7051

merged 13 commits into from
Sep 5, 2020

Conversation

donaldsharp
Copy link
Member

Reduce both ospf and bgp convergence of our tests by reducing hello timers to 2/10 for ospf and 3/10 for bgp

This is not all the tests but a decent chunk.

@donaldsharp
tests: Speedup ldp-topo1 tests
221bbed 
These ospf timer changes, speed up convergence from ~85 seconds to
~40 seconds.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Modify ldp-oc-topo1 to run faster
14f2e6b 
Convert run times by lowering hello/dead interval timers to
smaller values from ~66 seconds to ~36 seconds.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: ospf-topo2 speed up
d23a0ba 
Modify ospf hello/dead timers to speed up run time from ~25 seconds to
~17 seconds.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Decrease ospf-sr-topo1 run time
5a65e36 
Reduce ospf-sr-topo1 run time from ~60 seconds to ~30 seconds
by shortening the hello and dead timers.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Speedup bfd-profiles-topo1 runtime
b17dd2a 
Decrease run time from ~70 seconds to ~60 seconds
by modifying the hello/dead interval interface timers
in ospf

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Speedup bgp_rfapi_basic_sanity run
8add049 
Decrease run time from ~70 seconds to ~41 seconds by
reducing hello/dead interval timers in ospf

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Reduce ldp-vpls-topo1 run time
39adeb7 
Reduce this tests run time from ~76 seconds to ~49 seconds
by decreasing the hello/dead interval timers in ospf

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Reduce bgp_l3vpn_to_bgp_direct run time
20a91d0 
Reduce run time from ~76 seconds to ~47 seconds by modifying
both bgp and ospf timers to be more aggressive

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Reduce ospf-topo1 run time
0668365 
Reduce run time from ~114 seconds to ~55 seconds by
configuring hello/dead interval timers for ospf and ospfv3

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Reduce bgp-evpn-vxlan-topo1 run time
e1cbae1 
Reduce the runtime from ~82 seconds to ~51 seconds by
reducing hello/hold timers for both bgp and ospf.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Reduce ldp-oc-acl-topo1 run time
2022ed0 
Reduce the ldp-oc-acl-topo1 test run time from ~69 seconds
to ~39 seconds.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Reduce bfd-topo2 run time
f3ce48d 
Reduce run time of bfd-topo2 from ~62 seconds to ~33 seconds
by modifying the hello/dead intervals for both ospf and ospfv3

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
tests: Reduce run time of bgp_l3vpn_to_bgp_vrf
ff3218f 
Reduces run time of the bgp_l3vpn_to_bgp_vrf topotests
from ~118 seconds to ~87 seconds by reducing hello timers
in bgp and ospf

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@polychaeta polychaeta added the tests Topotests, make check, etc label Sep 3, 2020
@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 3, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/7051 ff3218f
Date 09/03/2020
Start 11:27:26
Finish 11:53:28
Run-Time 26:02
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-09-03-11:27:26.txt
Log autoscript-2020-09-03-11:28:21.log.bz2
Memory 498 469 424

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Sep 3, 2020 •
edited
Loading

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14014/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topo tests part 0 on Ubuntu 16.04 amd64: Incomplete (check logs for details)
Successful on other platforms/tests
  • Topo tests part 1 on Ubuntu 18.04 arm8
  • Topo tests part 1 on Ubuntu 16.04 amd64
  • Fedora 29 rpm pkg check
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 1
  • Topo tests part 1 on Ubuntu 16.04 i386
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Topo tests part 0 on Ubuntu 18.04 arm8
  • Static analyzer (clang)
  • Ubuntu 20.04 deb pkg check
  • Topo tests part 2 on Ubuntu 18.04 arm8
  • Topo tests part 2 on Ubuntu 16.04 i386
  • Topo tests part 0 on Ubuntu 18.04 amd64
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 2
  • Topo tests part 0 on Ubuntu 16.04 i386
  • Topo tests part 1 on Ubuntu 18.04 amd64
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 0
  • Topo tests part 2 on Ubuntu 18.04 amd64
  • Debian 10 deb pkg check
  • Debian 9 deb pkg check
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • IPv4 ldp protocol on Ubuntu 18.04

@donaldsharp
Copy link
Member Author

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14020/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14020/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200903-14-gff3218f5a-0 (missing) -> 7.5-dev-20200903-14-gff3218f5a-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200903-14-gff3218f5a-0 (missing) -> 7.5-dev-20200903-14-gff3218f5a-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200903-14-gff3218f5a-0 (missing) -> 7.5-dev-20200903-14-gff3218f5a-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200903-14-gff3218f5a-0 (missing) -> 7.5-dev-20200903-14-gff3218f5a-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200903-14-gff3218f5a-0 (missing) -> 7.5-dev-20200903-14-gff3218f5a-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 7051, comparing to Git base SHA 09209b4

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-14020/artifact/shared/static_analysis/index.html

rwestphal
rwestphal approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@ton31337 ton31337 merged commit a8b5178 into FRRouting:master Sep 5, 2020
@donaldsharp donaldsharp deleted the ospf_test_speedup branch June 23, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwestphal rwestphal rwestphal approved these changes

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@donaldsharp @LabN-CI @NetDEF-CI @rwestphal @ton31337 @polychaeta