tests: Add new tests to bgp-basic-functionality-topo1 #6925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13643/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
rzalamena
reviewed
Aug 23, 2020
tests/topotests/lib/common_config.py
Outdated
| @@ -36,6 +36,7 @@ | |||
| import ConfigParser | |||
| import traceback | |||
| import socket | |||
| import ipaddr | |||
There was a problem hiding this comment.
Same comment as the other PR:
nit: I'm no python expert, but I think we've been trying to move to ipaddress so we don't require the ipaddr package anymore.
There was a problem hiding this comment.
@rzalamena, Thank you. I have updated the code.
tests/topotests/lib/common_config.py
Outdated
| @@ -665,6 +667,9 @@ def generate_support_bundle(): | |||
| rnode.run("mkdir -p {}".format(dst_bundle)) | |||
| rnode.run("mv -f {}/* {}".format(src_bundle, dst_bundle)) | |||
|
|
|||
| """ | |||
| pass | |||
There was a problem hiding this comment.
Same comment as the other PR:
#6926 (comment)
@kuldeepkash can you fix this so I can test it, please?
There was a problem hiding this comment.
@rzalamena , Thank you. I have fixed it.
kuldeepkash
force-pushed
the
bgp_basic_functionality
branch
from
4711993 to
6fc8cd2
Compare
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13783/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
rzalamena
approved these changes
Aug 28, 2020
tests/topotests/lib/common_config.py
Outdated
|
|
||
| for st_rt in ip_list: | ||
| st_rt = str(ipaddress.ip_network(unicode(st_rt))) | ||
| #st_rt = str(ipaddr.IPNetwork(unicode(st_rt))) |
There was a problem hiding this comment.
Thanks Rafael, I have fixed it.
kuldeepkash
force-pushed
the
bgp_basic_functionality
branch
from
6fc8cd2 to
19f4da0
Compare
1. Added new tests to bgp-basic-functionality-topo1 3. Execution time increased by 55 sec Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
1 similar comment
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-13897/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13897/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
|
CI:rerun |
|
This test
|
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13900/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuldeep Kashyap kashyapk@vmware.com