Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.3] Sorted vtysh commands #6890

Merged
merged 2 commits into from
Aug 11, 2020
Merged

[7.3] Sorted vtysh commands #6890

merged 2 commits into from
Aug 11, 2020

Conversation

ton31337
Copy link
Member

Backport #6654 to 7.3.

@donaldsharp @ton31337
vtysh: master is a non-sorted list
7d5f6c7 
The commit:
a798241

attempted to use sorted master lists to do faster lookups
by using a RB Tree.  Unfortunately the original code
was creating a list->cmp function *but* never using it.
If you look at the commit, it clearly shows that the
function listnode_add is used to insert but when you
look at that function it is a tail push.

Fixes: #6573

Namely now this ordering is preserved:
bgp as-path access-list originate-only permit ^$
bgp as-path access-list originate-only deny .*

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp @ton31337
vtysh: Improve lookup performance
f8b5fe0 
When we find the line we are interested in, stop looking.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 11, 2020

🚧 Basic BGPD CI results: Partial FAILURE, 0 tests failed, has VALGRIND issues

Results table
_ _
Result SUCCESS git merge/6890 f8b5fe0
Date 08/11/2020
Start 02:50:16
Finish 03:16:03
Run-Time 25:47
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 1
Details vncregress-2020-08-11-02:50:16.txt
Log autoscript-2020-08-11-02:51:10.log.bz2
Memory 427 430 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13552/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for vtysh_config.c | 2 issues
===============================================
< WARNING: space prohibited between function name and open parenthesis '('
< #99: FILE: /tmp/f1-8052/vtysh_config.c:99:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13552/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-snmp: changelog-file-missing-explicit-entry 7.3.1-0 -> 7.3.1-20200811-01-gf8b5fe03d-0 (missing) -> 7.3.1-20200811-01-gf8b5fe03d-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.3.1-0 -> 7.3.1-20200811-01-gf8b5fe03d-0 (missing) -> 7.3.1-20200811-01-gf8b5fe03d-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 7.3.1-0 -> 7.3.1-20200811-01-gf8b5fe03d-0 (missing) -> 7.3.1-20200811-01-gf8b5fe03d-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.3.1-0 -> 7.3.1-20200811-01-gf8b5fe03d-0 (missing) -> 7.3.1-20200811-01-gf8b5fe03d-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.3.1-0 -> 7.3.1-20200811-01-gf8b5fe03d-0 (missing) -> 7.3.1-20200811-01-gf8b5fe03d-0~deb10u1

@donaldsharp donaldsharp merged commit 09ed403 into FRRouting:stable/7.3 Aug 11, 2020
@ton31337 ton31337 deleted the fix/vtysh_sorting branch August 11, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
vtysh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ton31337 @LabN-CI @NetDEF-CI @donaldsharp @polychaeta