-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.4] cherry-pick vtysh fixes #6728
Conversation
The commit: a798241 attempted to use sorted master lists to do faster lookups by using a RB Tree. Unfortunately the original code was creating a list->cmp function *but* never using it. If you look at the commit, it clearly shows that the function listnode_add is used to insert but when you look at that function it is a tail push. Fixes: FRRouting#6573 Namely now this ordering is preserved: bgp as-path access-list originate-only permit ^$ bgp as-path access-list originate-only deny .* Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
When we find the line we are interested in, stop looking. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-13094/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13094/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-13094/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13094/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt
Warnings Generated during build:Ubuntu 16.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 amd64 build:
Ubuntu 16.04 i386 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 i386 build:
Ubuntu 18.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 amd64 build:
Debian 8 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 8 amd64 build:
Ubuntu 18.04 arm8 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 arm8 build:
Ubuntu 20.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 20.04 amd64 build:
Ubuntu 18.04 arm7 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 arm7 build:
Ubuntu 18.04 ppc64le build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 ppc64le build:
Debian 9 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 9 amd64 build:
Ubuntu 16.04 arm8 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 arm8 build:
Ubuntu 16.04 arm7 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 arm7 build:
Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 0 un Ubuntu 16.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U16ARM8-13114/test Topology Tests failed for Topo tests part 0 un Ubuntu 16.04 arm8:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13114/artifact/TOPO0U16ARM8/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Checkout code: Successful with additional warningsTopo tests part 0 un Ubuntu 16.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO0U16ARM8-13114/test Topology Tests failed for Topo tests part 0 un Ubuntu 16.04 arm8:
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13114/artifact/TOPO0U16ARM8/ErrorLog/log_topotests.txt
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
Ubuntu 18.04 arm8 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 arm8 build:
Ubuntu 16.04 arm8 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 arm8 build:
Ubuntu 18.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 amd64 build:
Ubuntu 16.04 arm7 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 arm7 build:
Ubuntu 16.04 i386 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 i386 build:
Ubuntu 18.04 ppc64le build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 ppc64le build:
Debian 9 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 9 amd64 build:
Ubuntu 16.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 amd64 build:
Ubuntu 20.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 20.04 amd64 build:
Ubuntu 18.04 arm7 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 arm7 build:
Debian 8 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 8 amd64 build:
|
ci:rerun |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-13140/ This is a comment from an automated CI system. Warnings Generated during build:Checkout code: Successful with additional warnings
Warnings Generated during build:Ubuntu 16.04 arm8 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 arm8 build:
Ubuntu 20.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 20.04 amd64 build:
Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build:
Ubuntu 18.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 amd64 build:
Ubuntu 16.04 i386 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 i386 build:
Ubuntu 16.04 arm7 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 arm7 build:
Debian 9 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 9 amd64 build:
Debian 8 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 8 amd64 build:
Ubuntu 18.04 ppc64le build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 ppc64le build:
Ubuntu 18.04 arm8 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 arm8 build:
Ubuntu 16.04 amd64 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 16.04 amd64 build:
Ubuntu 18.04 arm7 build: Successful with additional warningsDebian Package lintian failed for Ubuntu 18.04 arm7 build:
|
No description provided.