bgpd: Actually find the sequence number for large-community-list

[ton31337]

Add argv_find.cocci script to catch all those cases. Seems nothing more to add.

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6669 947073e
Date	07/02/2020
Start	05:10:46
Finish	05:36:44
Run-Time	25:58
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-07-02-05:10:46.txt
Log	autoscript-2020-07-02-05:11:47.log.bz2
Memory	453 442 424

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12944/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12944/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-07-02 11:33:40,451 ERROR: 'router_json_cmp' failed after 7.15 seconds
2020-07-02 11:33:40,452 ERROR: assert failed at "test_bgp-vrf-route-leak-basic/test_vrf_route_leak": BGP VRF DONNA check failed:
  Generated JSON diff error report:
  
  
  > $: d2 has key '10.0.1.0/24' which is not present in d1
  > $: d2 has key '10.0.3.0/24' which is not present in d1
  
  
assert False
2020-07-02 11:36:04,967 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-07-02 11:36:07,022 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-07-02 11:36:13,167 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12944/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Successful on other platforms/tests

• Topo tests part 0 on Ubuntu 16.04 i386
• Topo tests part 1 on Ubuntu 16.04 i386
• Debian 10 deb pkg check
• Topo tests part 2 on Ubuntu 18.04 amd64
• Topo tests part 2 on Ubuntu 16.04 amd64
• IPv4 protocols on Ubuntu 18.04
• Fedora 29 rpm pkg check
• Debian 9 deb pkg check
• Static analyzer (clang)
• Ubuntu 18.04 deb pkg check
• Ubuntu 16.04 deb pkg check
• Ubuntu 20.04 deb pkg check
• Topo tests part 2 on Ubuntu 16.04 i386
• Topo tests part 1 on Ubuntu 18.04 amd64
• Addresssanitizer topotests part 2
• Addresssanitizer topotests part 1
• CentOS 7 rpm pkg check
• IPv4 ldp protocol on Ubuntu 18.04
• Addresssanitizer topotests part 0
• Debian 8 deb pkg check
• Topo tests part 1 on Ubuntu 16.04 amd64
• Topo tests part 0 un Ubuntu 16.04 arm8
• Topo tests part 0 on Ubuntu 18.04 amd64
• IPv6 protocols on Ubuntu 18.04

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12944/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1

[ton31337]

ci:rerun

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12946/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12946/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200702-03-g947073e39-0 (missing) -> 7.5-dev-20200702-03-g947073e39-0~deb10u1