ISIS VRF: ISIS Debug structure modifications Type 2 #6619
Conversation
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/a1c0c806c45ad8c7b4f3dad24fe3d6c8/raw/93ee93f4b0bd8644b9e9f4d5c776f599e003f248/cr_6619_1592593560.diff | git apply
diff --git a/isisd/isisd.h b/isisd/isisd.h
index 358e7799b..421de714e 100644
--- a/isisd/isisd.h
+++ b/isisd/isisd.h
@@ -273,19 +273,19 @@ extern unsigned long debug_sr;
#define lsp_debug(...) \
do { \
- if (IS_DEBUG_LSP_GEN) \
+ if (IS_DEBUG_LSP_GEN) \
zlog_debug(__VA_ARGS__); \
} while (0)
#define sched_debug(...) \
do { \
- if (IS_DEBUG_LSP_SCHED) \
+ if (IS_DEBUG_LSP_SCHED) \
zlog_debug(__VA_ARGS__); \
} while (0)
#define sr_debug(...) \
do { \
- if (IS_DEBUG_SR) \
+ if (IS_DEBUG_SR) \
zlog_debug(__VA_ARGS__); \
} while (0)
If you are a new contributor to FRR, please see our contributing guidelines.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedCentOS 7 amd64 build: Failed (click for details)Make failed for CentOS 7 amd64 build: CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/CI005BUILD/config.status/config.status Debian 8 amd64 build: Failed (click for details)Make failed for Debian 8 amd64 build: Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/CI008BLD/config.status/config.status Debian 10 amd64 build: Failed (click for details)Make failed for Debian 10 amd64 build: Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/DEB10BUILD/config.status/config.status FreeBSD 12 amd64 build: Failed (click for details)Make failed for FreeBSD 12 amd64 build: FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/FBSD12AMD64/config.status/config.status OpenBSD 6 amd64 build: Failed (click for details)Make failed for OpenBSD 6 amd64 build: OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/CI011BUILD/config.status/config.status NetBSD 8 amd64 build: Failed (click for details)Make failed for NetBSD 8 amd64 build: NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/CI012BUILD/config.status/config.status Ubuntu 16.04 amd64 build: Failed (click for details)Make failed for Ubuntu 16.04 amd64 build: Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/CI014BUILD/config.status/config.status FreeBSD 11 amd64 build: Failed (click for details)Make failed for FreeBSD 11 amd64 build: FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/CI009BUILD/config.status/config.status Ubuntu 18.04 amd64 build: Failed (click for details)Make failed for Ubuntu 18.04 amd64 build: Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/U1804AMD64/config.status/config.status Debian 9 amd64 build: Failed (click for details)Make failed for Debian 9 amd64 build: Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/CI021BUILD/config.status/config.status Ubuntu 20.04 amd64 build: Failed (click for details)Ubuntu 20.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/U2004AMD64BUILD/config.status/config.statusMake failed for Ubuntu 20.04 amd64 build: Ubuntu 18.04 ppc64le build: Failed (click for details)Make failed for Ubuntu 18.04 ppc64le build: Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/U1804PPC64LEBUILD/config.status/config.status Ubuntu 16.04 i386 build: Failed (click for details)Make failed for Ubuntu 16.04 i386 build: Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/U1604I386/config.status/config.status Fedora 29 amd64 build: Failed (click for details)Make failed for Fedora 29 amd64 build: Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12768/artifact/F29BUILD/config.status/config.status |
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/c966bac80a621ae667cf772b9cabc861/raw/93ee93f4b0bd8644b9e9f4d5c776f599e003f248/cr_6619_1592595071.diff | git apply
diff --git a/isisd/isisd.h b/isisd/isisd.h
index 358e7799b..421de714e 100644
--- a/isisd/isisd.h
+++ b/isisd/isisd.h
@@ -273,19 +273,19 @@ extern unsigned long debug_sr;
#define lsp_debug(...) \
do { \
- if (IS_DEBUG_LSP_GEN) \
+ if (IS_DEBUG_LSP_GEN) \
zlog_debug(__VA_ARGS__); \
} while (0)
#define sched_debug(...) \
do { \
- if (IS_DEBUG_LSP_SCHED) \
+ if (IS_DEBUG_LSP_SCHED) \
zlog_debug(__VA_ARGS__); \
} while (0)
#define sr_debug(...) \
do { \
- if (IS_DEBUG_SR) \
+ if (IS_DEBUG_SR) \
zlog_debug(__VA_ARGS__); \
} while (0)
If you are a new contributor to FRR, please see our contributing guidelines.
Outdated results 🛑Basic BGPD CI results: FAILURE
For details, please contact louberger |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12770/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12769/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
| @@ -264,7 +264,6 @@ int isis_dr_commence(struct isis_circuit *circuit, int level) | |||
| { | |||
| uint8_t old_dr[ISIS_SYS_ID_LEN + 2]; | |||
|
|
|||
| if (isis->debugs & DEBUG_EVENTS) | |||
There was a problem hiding this comment.
Thanks
It is resolved.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12772/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
hariosniral
force-pushed
the
niral_isis_debug_p2
branch
from
ff02c4d to
6a252f9
Compare
All the commits are squashed into single one. |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12818/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
There was a problem hiding this comment.
These changes look fine now -- thanks for the updates based on comments. Will wait for @donaldsharp to clear stopper before pushing.
| @@ -93,7 +108,6 @@ void isis_new(unsigned long process_id, vrf_id_t vrf_id) | |||
| /* | |||
| * uncomment the next line for full debugs | |||
| */ | |||
| /* isis->debugs = 0xFFFF; */ | |||
There was a problem hiding this comment.
nit: please remove the comment above as well.
There was a problem hiding this comment.
nit: please remove the comment above as well.
It is removed and squashed into single commit.
Thanks,
1. The "isis->debug" variable dependency on debug logs print is removed. Signed-off-by: harios <hari@niralnetworks.com>
hariosniral
force-pushed
the
niral_isis_debug_p2
branch
from
d2b9f6d to
e740f9c
Compare
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12842/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12843/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Signed-off-by: harios hari@niralnetworks.com