-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Docker centos 7 #6594
[fix] Docker centos 7 #6594
Conversation
docker: COPY was not working, changing by using git clone and second COPY by fixing the folder resolve: FRRouting#6592 Signed-off-by: Cyril Lopez <cylopez@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to FRR!
- One of your commits has an improperly formatted commit message
If you are a new contributor to FRR, please see our contributing guidelines.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Your build invocation is not correct, we have a wrapper script used to build centos images that should be run from the repository root, like so: ~/frr $ ./docker/centos7/build.sh I'm happy to accept patches that fix that to support the usual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments above
Continuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteAddresssanitizer topotests part 0: Incomplete(check logs for details)Successful on other platforms/tests
|
Hello, I got it now, ok. So this is stick to docker usage and not to podman... Any change to make it agnostic ? BR
|
Yeah we just need to move all the logic in the script to the dockerfile |
docker: COPY was not working, changing by using git clone and second COPY by fixing the folder
resolve: #6592
Signed-off-by: Cyril Lopez cylopez@redhat.com
Tested on Red Hat Enterprise Linux Server release 7.6 with podman-1.6.4-18.el7_8.x86_64