Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Docker centos 7 #6594

Closed
wants to merge 1 commit into from
Closed

Conversation

clopnis
Copy link

@clopnis clopnis commented Jun 16, 2020

docker: COPY was not working, changing by using git clone and second COPY by fixing the folder

resolve: #6592

Signed-off-by: Cyril Lopez cylopez@redhat.com

Tested on Red Hat Enterprise Linux Server release 7.6 with podman-1.6.4-18.el7_8.x86_64

podman build -t frr -f docker/centos-7/Dockerfile
[...]
STEP 13: COMMIT frr
5eff3acffcef31e4f414c4e4e96fc7635d9bedfc23429cd674694d961c3dab79
[root@frrouting frr]# podman run -d 5eff3acffcef31e4f414c4e4e96fc7635d9bedfc23429cd674694d961c3dab79
f2ab25fe765b89acd92c366dae1bbc7a88449ac362c8311e8e9f2644c8a40dc8
[root@frrouting frr]# podman ps
CONTAINER ID  IMAGE                 COMMAND  CREATED        STATUS            PORTS  NAMES
f2ab25fe765b  localhost/frr:latest           4 seconds ago  Up 4 seconds ago         reverent_lovelace

docker: COPY was not working, changing by using git clone and second COPY by fixing the folder

resolve: FRRouting#6592

Signed-off-by: Cyril Lopez <cylopez@redhat.com>
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has an improperly formatted commit message

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 16, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/6594 caf90fe
Date 06/16/2020
Start 13:38:41
Finish 14:04:36
Run-Time 25:55
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-06-16-13:38:41.txt
Log autoscript-2020-06-16-13:39:41.log.bz2
Memory 473 494 425

For details, please contact louberger

@qlyoung
Copy link
Member

qlyoung commented Jun 16, 2020

Your build invocation is not correct, we have a wrapper script used to build centos images that should be run from the repository root, like so:

~/frr $ ./docker/centos7/build.sh

I'm happy to accept patches that fix that to support the usual docker build syntax but I do not want a git clone as part of the build, that screws up the common use case of modifying FRR and building an image with those modifications (i.e. in-tree build)

@qlyoung qlyoung added the docker label Jun 16, 2020
@qlyoung qlyoung self-assigned this Jun 16, 2020
Copy link
Member

@qlyoung qlyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments above

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12712/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 0: Incomplete (check logs for details)
Successful on other platforms/tests
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 18.04 deb pkg check
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Ubuntu 20.04 deb pkg check
  • Topo tests part 0 on Ubuntu 16.04 amd64
  • Topo tests part 1 on Ubuntu 18.04 amd64
  • Debian 9 deb pkg check
  • Topo tests part 0 on Ubuntu 16.04 i386
  • CentOS 7 rpm pkg check
  • Debian 10 deb pkg check
  • Static analyzer (clang)
  • Topo tests part 2 on Ubuntu 18.04 amd64
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • Ubuntu 16.04 deb pkg check
  • Topo tests part 2 on Ubuntu 16.04 i386
  • Topo tests part 0 on Ubuntu 18.04 amd64
  • IPv6 protocols on Ubuntu 18.04
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 1
  • Topo tests part 1 on Ubuntu 16.04 amd64
  • Topo tests part 1 on Ubuntu 16.04 i386

@clopnis
Copy link
Author

clopnis commented Jun 18, 2020

Hello,
Thanks for the reply.

I got it now, ok. So this is stick to docker usage and not to podman...

Any change to make it agnostic ?

BR
Cyril

Your build invocation is not correct, we have a wrapper script used to build centos images that should be run from the repository root, like so:

~/frr $ ./docker/centos7/build.sh

I'm happy to accept patches that fix that to support the usual docker build syntax but I do not want a git clone as part of the build, that screws up the common use case of modifying FRR and building an image with those modifications (i.e. in-tree build)

@qlyoung
Copy link
Member

qlyoung commented Jun 19, 2020

Any change to make it agnostic ?

Yeah we just need to move all the logic in the script to the dockerfile

@qlyoung
Copy link
Member

qlyoung commented Jul 6, 2020

@clopnis actually you can build them manually with docker build, you just need to start from the repo root and tell docker where to look:

~/frr> docker build -f docker/centos-7/Dockerfile .

Added docs on docker builds here

Closing this

@qlyoung qlyoung closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker centos7 doesn't build
5 participants