Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVPN Multihoming, EVPN re-factoring for MPLS and L3 Nexthop Group enhancements #6515

Closed
wants to merge 162 commits into from

Conversation

AnuradhaKaruppiah
Copy link
Contributor

@AnuradhaKaruppiah AnuradhaKaruppiah commented Jun 4, 2020

Based on the discussions in the PR-review meeting we will break this PR up into five separate PRs -
PR-1 (30 commits) - EVPN-MH infra; includes the following sub-features - [mh-prep, EAD, SYNC] - #6587
PR-2 (40 commits) - L3NHG infra work
PR-3 (18 commits) - EVPN refactoring for mpls - [refactor-prep, refactor]
PR-4 (~50 commits) - Remaining EVPN MH work - [DF, IRB, feature-fixes]
PR-5 (21 commits) - netns re-work - [netns]

[
This PR is from a topic branch (evpn-mh) used for combining the EVPN-MH, EVPN re-factoring for MPLS and L3 Nexthop group changes.
EVPN Multihoming
FRR - EVPN Multihoming Overview.pdf
This includes support for Active/Active multihoming via the following sub-features -

  1. Ethernet Segment configuration and management
  2. Type-1/EAD route support
  3. Type2 routes with non-zero ESI
  4. MAC-ECMP support
  5. Layer2 nexthop group support for fast failover of MAC/FDB paths
  6. MAC-IP syncing (via type-2 routes)
  7. Support for fast failover via local ES-redirect
    PS: And support for slow failover where dataplane doesn't allow for fast failover
  8. Host routes (for Symmetric IRB) via Ethernet Segments
  9. BGP changes for allowing host routes to be programmed with a L3 nexthop group (again for fast failover)
  10. DF election via Type-4/Ethernet Segment routes
  11. Support for BUM non-DF and Split-horizon filtering
  12. Support for uplink/core tracking
  13. Initial support for consistency checking
    Signed-off-by: Anuradha Karuppiah anuradhak@cumulusnetworks.com

EVPN re-factoring
Note this is simply code being around and absolutely NO functional changes were introduced as a part of the re-factoring -

  1. Rename of vni to evpn where appropriate
  2. move MAC database code from zebra_vxlan.c to zebra_evpn_mac.c
  3. move Neighbor database from zebra_vxlan.c to zebra_evpn_neigh.c
  4. move core EVPN code from zebra_vxlan.c to zebra_evpn.c
  5. Add VXLAN IP learning topotests
    Signed-off-by: Pat Ruddy pat@voltanet.io

L3 Nexthop Group

  1. Implement NHG Upper-level Protocol ADD/DEL/REPLACE
  2. Divide ID space among all protos and implement ZAPI APIs for ADD/DEL/REPLACEMENT of NHGs in the RIB and dataplane.
  3. With this code, sharpd and multihoming BGP can do replacements for Gateway/Ifindex NHGs via 4. one ZAPI and Dataplane message.
  4. Upper protos own their ID space and send a full NHG down with the ID space. Zebra tracks them separately in its NHG rib so they are not shared by other protos/zebra.
    Signed-off-by: Stephen Worley sworley@cumulusnetworks.com

EVPN NetNS revert and re-work for rebase purposes
Signed-off-by: Philippe Guibert philippe.guibert@6wind.com
]

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
  • sprintf, strcat, strcpy are banned; please use snprintf, strlcat, strlcpy

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 4, 2020

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/6515 a1e542b
Date 06/04/2020
Start 16:43:06
Finish 17:09:05
Run-Time 25:59
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-06-04-16:43:06.txt
Log autoscript-2020-06-04-16:44:09.log.bz2
Memory 493 511 448

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 4, 2020

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12552/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-04 23:20:40,239 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:20:40,242 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:20:42,289 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:20:42,292 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:20:44,347 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:20:46,394 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:20:48,442 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:20:48,445 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:26:00,550 ERROR: 'router_json_cmp' failed after 76.68 seconds
2020-06-04 23:26:00,553 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-04 23:33:44,257 ERROR: 'router_json_cmp' failed after 101.99 seconds
2020-06-04 23:33:44,261 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r2" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r2-eth1",
  	            "ip": "10.0.1.1",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r2-eth2",
  	            "ip": "10.0.3.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth1",
  		    "ip": "10.0.1.1",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth2",
  		    "ip": "10.0.3.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12552/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-04 21:09:40,560 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-04 21:12:20,995 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-04 21:12:21,245 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-04 21:26:23,524 ERROR: '_bgp_has_routes' failed after 37.59 seconds
2020-06-04 21:26:35,528 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12552/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-04 23:17:16,094 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:17:16,096 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:17:18,145 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:17:18,148 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:17:20,201 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:17:22,251 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:17:24,305 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:17:24,308 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:22:42,195 ERROR: 'router_json_cmp' failed after 78.28 seconds
2020-06-04 23:22:42,196 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12552/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-04 21:17:49,493 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 21:17:49,496 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:17:51,564 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 21:17:51,566 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:17:53,641 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:17:55,718 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:17:57,781 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 21:17:57,784 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:23:11,002 ERROR: 'router_json_cmp' failed after 78.45 seconds
2020-06-04 21:23:11,005 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-04 21:31:04,604 ERROR: 'router_json_cmp' failed after 104.69 seconds
2020-06-04 21:31:04,606 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r2" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r2-eth1",
  	            "ip": "10.0.1.1",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r2-eth2",
  	            "ip": "10.0.3.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth1",
  		    "ip": "10.0.1.1",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth2",
  		    "ip": "10.0.3.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12552/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-04 23:09:40,432 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-04 23:12:18,425 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-04 23:12:18,677 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-04 23:26:24,676 ERROR: '_bgp_has_routes' failed after 37.53 seconds
2020-06-04 23:26:36,760 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12552/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-04 23:09:40,903 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-04 23:12:22,256 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-04 23:12:22,536 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-04 23:26:51,569 ERROR: '_bgp_has_routes' failed after 38.55 seconds
2020-06-04 23:27:03,145 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 0
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Ubuntu 20.04 deb pkg check
  • Debian 9 deb pkg check
  • CentOS 7 rpm pkg check
  • Debian 10 deb pkg check
  • Static analyzer (clang)
  • Topo tests part 2 on Ubuntu 18.04 amd64
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • Ubuntu 16.04 deb pkg check
  • Topo tests part 2 on Ubuntu 16.04 i386
  • IPv6 protocols on Ubuntu 18.04
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 1

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12552/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-04 23:20:40,239 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:20:40,242 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:20:42,289 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:20:42,292 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:20:44,347 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:20:46,394 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:20:48,442 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:20:48,445 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:26:00,550 ERROR: 'router_json_cmp' failed after 76.68 seconds
2020-06-04 23:26:00,553 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-04 23:33:44,257 ERROR: 'router_json_cmp' failed after 101.99 seconds
2020-06-04 23:33:44,261 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r2" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r2-eth1",
  	            "ip": "10.0.1.1",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r2-eth2",
  	            "ip": "10.0.3.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth1",
  		    "ip": "10.0.1.1",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth2",
  		    "ip": "10.0.3.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12552/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-04 21:09:40,560 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-04 21:12:20,995 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-04 21:12:21,245 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-04 21:26:23,524 ERROR: '_bgp_has_routes' failed after 37.59 seconds
2020-06-04 21:26:35,528 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12552/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-04 23:17:16,094 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:17:16,096 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:17:18,145 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:17:18,148 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:17:20,201 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:17:22,251 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:17:24,305 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 23:17:24,308 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 23:22:42,195 ERROR: 'router_json_cmp' failed after 78.28 seconds
2020-06-04 23:22:42,196 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12552/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-04 21:17:49,493 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 21:17:49,496 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:17:51,564 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 21:17:51,566 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:17:53,641 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:17:55,718 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:17:57,781 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-04 21:17:57,784 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-04 21:23:11,002 ERROR: 'router_json_cmp' failed after 78.45 seconds
2020-06-04 21:23:11,005 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-04 21:31:04,604 ERROR: 'router_json_cmp' failed after 104.69 seconds
2020-06-04 21:31:04,606 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r2" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r2-eth1",
  	            "ip": "10.0.1.1",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r2-eth2",
  	            "ip": "10.0.3.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth1",
  		    "ip": "10.0.1.1",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth2",
  		    "ip": "10.0.3.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12552/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-04 23:09:40,432 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-04 23:12:18,425 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-04 23:12:18,677 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-04 23:26:24,676 ERROR: '_bgp_has_routes' failed after 37.53 seconds
2020-06-04 23:26:36,760 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12552/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-04 23:09:40,903 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-04 23:12:22,256 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-04 23:12:22,536 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-04 23:26:51,569 ERROR: '_bgp_has_routes' failed after 38.55 seconds
2020-06-04 23:27:03,145 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

<stdin>:11504: trailing whitespace.
        
<stdin>:11598: trailing whitespace.
    
<stdin>:11997: space before tab in indent.
 		return 0;
<stdin>:8573: new blank line at EOF.
+
<stdin>:11371: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Report for bgp_evpn.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2973: FILE: /tmp/f1-9793/bgp_evpn.c:2973:
< WARNING: line over 80 characters
< #3549: FILE: /tmp/f1-9793/bgp_evpn.c:3549:
< WARNING: line over 80 characters
< #3766: FILE: /tmp/f1-9793/bgp_evpn.c:3766:
Report for bgp_evpn_mh.c | 87 issues
===============================================
ERROR: strcpy() is error-prone; please use strlcpy()#1829: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1829:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1831: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1831:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1834: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1834:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1891: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1891:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1893: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1893:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1896: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1896:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1951: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1951:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#1953: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1953:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#1955: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1955:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#1962: FILE: /tmp/f1-9793/bgp_evpn_mh.c:1962:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2024: FILE: /tmp/f1-9793/bgp_evpn_mh.c:2024:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2026: FILE: /tmp/f1-9793/bgp_evpn_mh.c:2026:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2031: FILE: /tmp/f1-9793/bgp_evpn_mh.c:2031:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2053: FILE: /tmp/f1-9793/bgp_evpn_mh.c:2053:
+				strcpy(incons_str + strlen(incons_str),

ERROR: strcpy() is error-prone; please use strlcpy()#2056: FILE: /tmp/f1-9793/bgp_evpn_mh.c:2056:
+			strcpy(incons_str, "-");

WARNING: line over 80 characters
#2185: FILE: /tmp/f1-9793/bgp_evpn_mh.c:2185:
+	nh.type = v4_nhg ? NEXTHOP_TYPE_IPV4_IFINDEX : NEXTHOP_TYPE_IPV6_IFINDEX;

ERROR: strcpy() is error-prone; please use strlcpy()#2574: FILE: /tmp/f1-9793/bgp_evpn_mh.c:2574:
+			strcpy(flags_str + strlen(flags_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#3233: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3233:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#3235: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3235:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "V");

ERROR: strcpy() is error-prone; please use strlcpy()#3238: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3238:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#3318: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3318:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3320: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3320:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3322: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3322:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#3351: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3351:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3353: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3353:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3357: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3357:
+			strcpy(vtep_str, "-");

WARNING: line over 80 characters
#3461: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3461:
+			vty_out(vty, "Flags: L local, R remote, I inconsistent\n");

WARNING: line over 80 characters
#3462: FILE: /tmp/f1-9793/bgp_evpn_mh.c:3462:
+			vty_out(vty, "VTEP-Flags: E EAD-per-ES, V EAD-per-EVI\n");
Report for bgp_evpn_vty.c | 4 issues
===============================================
< ERROR: spaces required around that '?' (ctx:VxW)
< #3753: FILE: /tmp/f1-9793/bgp_evpn_vty.c:3753:
< ERROR: spaces required around that ':' (ctx:WxV)
< #3753: FILE: /tmp/f1-9793/bgp_evpn_vty.c:3753:
Report for bgp_nht.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1039: FILE: /tmp/f1-9793/bgp_nht.c:1039:
< ERROR: space required after that ',' (ctx:VxV)
< #1049: FILE: /tmp/f1-9793/bgp_nht.c:1049:
Report for bitfield.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #61: FILE: /tmp/f1-9793/bitfield.h:61:
Report for debug.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #114: FILE: /tmp/f1-9793/debug.c:114:
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#959: FILE: /tmp/f1-9793/if.c:959:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#962: FILE: /tmp/f2-9793/if.c:962:
103c103
< #1051: FILE: /tmp/f1-9793/if.c:1051:
Report for if_netlink.c | 10 issues
===============================================
< ERROR: code indent should use tabs where possible
< #680: FILE: /tmp/f1-9793/if_netlink.c:680:
< WARNING: please, no space before tabs
< #680: FILE: /tmp/f1-9793/if_netlink.c:680:
< WARNING: please, no spaces at the start of a line
< #680: FILE: /tmp/f1-9793/if_netlink.c:680:
< WARNING: line over 80 characters
< #1483: FILE: /tmp/f1-9793/if_netlink.c:1483:
< WARNING: line over 80 characters
< #1597: FILE: /tmp/f1-9793/if_netlink.c:1597:
Report for prefix.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #49: FILE: /tmp/f1-9793/prefix.h:49:
< WARNING: line over 80 characters
< #50: FILE: /tmp/f1-9793/prefix.h:50:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #78: FILE: /tmp/f1-9793/rt_netlink.c:78:
< WARNING: line over 80 characters
< #2706: FILE: /tmp/f1-9793/rt_netlink.c:2706:
< WARNING: Block comments should align the * on each line
< #3843: FILE: /tmp/f1-9793/rt_netlink.c:3843:
Report for sharp_nht.c | 8 issues
===============================================
< WARNING: void function return statements are not generally useful
< #112: FILE: /tmp/f1-9793/sharp_nht.c:112:
< WARNING: void function return statements are not generally useful
< #125: FILE: /tmp/f1-9793/sharp_nht.c:125:
< WARNING: void function return statements are not generally useful
< #138: FILE: /tmp/f1-9793/sharp_nht.c:138:
< WARNING: void function return statements are not generally useful
< #154: FILE: /tmp/f1-9793/sharp_nht.c:154:
Report for zapi_msg.c | 30 issues
===============================================
< WARNING: line over 80 characters
< #1571: FILE: /tmp/f1-9793/zapi_msg.c:1571:
< WARNING: line over 80 characters
< #1619: FILE: /tmp/f1-9793/zapi_msg.c:1619:
< WARNING: line over 80 characters
< #1661: FILE: /tmp/f1-9793/zapi_msg.c:1661:
< WARNING: line over 80 characters
< #1662: FILE: /tmp/f1-9793/zapi_msg.c:1662:
< WARNING: line over 80 characters
< #1663: FILE: /tmp/f1-9793/zapi_msg.c:1663:
< WARNING: line over 80 characters
< #1664: FILE: /tmp/f1-9793/zapi_msg.c:1664:
< WARNING: line over 80 characters
< #1670: FILE: /tmp/f1-9793/zapi_msg.c:1670:
< WARNING: line over 80 characters
< #1671: FILE: /tmp/f1-9793/zapi_msg.c:1671:
< WARNING: void function return statements are not generally useful
< #1715: FILE: /tmp/f1-9793/zapi_msg.c:1715:
< WARNING: C99 // comments do not match recommendation
< #1736: FILE: /tmp/f1-9793/zapi_msg.c:1736:
< WARNING: C99 // comments do not match recommendation
< #1737: FILE: /tmp/f1-9793/zapi_msg.c:1737:
< WARNING: C99 // comments do not match recommendation
< #1738: FILE: /tmp/f1-9793/zapi_msg.c:1738:
< WARNING: C99 // comments do not match recommendation
< #1770: FILE: /tmp/f1-9793/zapi_msg.c:1770:
< WARNING: braces {} are not necessary for any arm of this statement
< #1782: FILE: /tmp/f1-9793/zapi_msg.c:1782:
< WARNING: void function return statements are not generally useful
< #1794: FILE: /tmp/f1-9793/zapi_msg.c:1794:
Report for zclient.h | 6 issues
===============================================
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #332: FILE: /tmp/f1-9793/zclient.h:332:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #333: FILE: /tmp/f1-9793/zclient.h:333:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #355: FILE: /tmp/f1-9793/zclient.h:355:
Report for zebra_dplane.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2739: FILE: /tmp/f1-9793/zebra_dplane.c:2739:
Report for zebra_evpn.c | 53 issues
===============================================
WARNING: line over 80 characters
#119: FILE: /tmp/f1-9793/zebra_evpn.c:119:
+		vty_out(vty, " Tenant VRF: %s\n", vrf_id_to_name(zevpn->vrf_id));

WARNING: C99 // comments do not match recommendation
#127: FILE: /tmp/f1-9793/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-9793/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

WARNING: line over 80 characters
#150: FILE: /tmp/f1-9793/zebra_evpn.c:150:
+				       zevpn->advertise_gw_macip ? "Yes" : "No");

WARNING: quoted string split across lines
#188: FILE: /tmp/f1-9793/zebra_evpn.c:188:
+			" Number of ARPs (IPv4 and IPv6, local and remote) "
+			"known for this VNI: %u\n",

WARNING: Missing a blank line after declarations
#232: FILE: /tmp/f1-9793/zebra_evpn.c:232:
+		char vni_str[VNI_STR_LEN];
+		snprintf(vni_str, VNI_STR_LEN, "%u", zevpn->vni);

WARNING: void function return statements are not generally useful
#537: FILE: /tmp/f1-9793/zebra_evpn.c:537:
+	return;
+}

WARNING: void function return statements are not generally useful
#577: FILE: /tmp/f1-9793/zebra_evpn.c:577:
+	return;
+}

WARNING: void function return statements are not generally useful
#623: FILE: /tmp/f1-9793/zebra_evpn.c:623:
+	return;
+}

ERROR: return is not a function, parentheses are not required
#943: FILE: /tmp/f1-9793/zebra_evpn.c:943:
+	return (jhash_1word(zevpn->vni, 0));

WARNING: line over 80 characters
#1079: FILE: /tmp/f1-9793/zebra_evpn.c:1079:
+		zlog_debug("Send EVPN_ADD %u %s tenant vrf %s to %s", zevpn->vni,

ERROR: return is not a function, parentheses are not required
#1138: FILE: /tmp/f1-9793/zebra_evpn.c:1138:
+	return (IPV4_ADDR_SAME(vtep_ip, &zvtep->vtep_ip));
Report for zebra_evpn.h | 8 issues
===============================================
WARNING: do not add new typedefs
#41: FILE: /tmp/f1-9793/zebra_evpn.h:41:
+typedef struct zebra_evpn_t_ zebra_evpn_t;

WARNING: do not add new typedefs
#42: FILE: /tmp/f1-9793/zebra_evpn.h:42:
+typedef struct zebra_vtep_t_ zebra_vtep_t;
Report for zebra_evpn_mac.c | 19 issues
===============================================
WARNING: suspect code indent for conditional statements (24, 24)
#740: FILE: /tmp/f1-9793/zebra_evpn_mac.c:740:
+			if (json_mac_hdr == NULL)
+			vty_out(vty, " %-5s", "");

WARNING: line over 80 characters
#988: FILE: /tmp/f1-9793/zebra_evpn_mac.c:988:
+		zlog_warn("%s: MAC %s flags 0x%x neigh list not empty %d", __func__,

WARNING: void function return statements are not generally useful
#1070: FILE: /tmp/f1-9793/zebra_evpn_mac.c:1070:
+	return;
+}

WARNING: quoted string split across lines
#2002: FILE: /tmp/f1-9793/zebra_evpn_mac.c:2002:
+						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u%s, "
+						"entry exists and has not changed ",
Report for zebra_evpn_mac.h | 4 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-9793/zebra_evpn_mac.h:32:
+typedef struct zebra_mac_t_ zebra_mac_t;
Report for zebra_evpn_mh.c | 63 issues
===============================================
WARNING: line over 80 characters
#252: FILE: /tmp/f1-9793/zebra_evpn_mh.c:252:
+					es_evi->es->esi_str, es_evi->zevpn->vni);

ERROR: strcpy() is error-prone; please use strlcpy()#288: FILE: /tmp/f1-9793/zebra_evpn_mh.c:288:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#326: FILE: /tmp/f1-9793/zebra_evpn_mh.c:326:
+			strcpy(type_str + strlen(type_str), "L");

WARNING: Missing a blank line after declarations
#692: FILE: /tmp/f1-9793/zebra_evpn_mh.c:692:
+			zebra_evpn_t *old_zevpn = acc_bd->zevpn;
+			acc_bd->zevpn = NULL;

WARNING: unnecessary whitespace before a quoted newline
#803: FILE: /tmp/f1-9793/zebra_evpn_mh.c:803:
+		vty_out(vty, " Members: \n");

WARNING: suspect code indent for conditional statements (8, 8)
#1014: FILE: /tmp/f1-9793/zebra_evpn_mh.c:1014:
+	if (nh1 == NULL || nh2 == NULL)
+	return false;

WARNING: suspect code indent for conditional statements (8, 8)
#1035: FILE: /tmp/f1-9793/zebra_evpn_mh.c:1035:
+	if (es1 == NULL || es2 == NULL)
+	return false;

WARNING: line over 80 characters
#1092: FILE: /tmp/f1-9793/zebra_evpn_mh.c:1092:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#1103: FILE: /tmp/f1-9793/zebra_evpn_mh.c:1103:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

ERROR: strcpy() is error-prone; please use strlcpy()#2620: FILE: /tmp/f1-9793/zebra_evpn_mh.c:2620:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2622: FILE: /tmp/f1-9793/zebra_evpn_mh.c:2622:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2624: FILE: /tmp/f1-9793/zebra_evpn_mh.c:2624:
+			strcpy(type_str + strlen(type_str), "N");

ERROR: strcpy() is error-prone; please use strlcpy()#2688: FILE: /tmp/f1-9793/zebra_evpn_mh.c:2688:
+			strcpy(type_str + strlen(type_str), "Local");

ERROR: strcpy() is error-prone; please use strlcpy()#2691: FILE: /tmp/f1-9793/zebra_evpn_mh.c:2691:
+				strcpy(type_str + strlen(type_str), ",");

ERROR: strcpy() is error-prone; please use strlcpy()#2692: FILE: /tmp/f1-9793/zebra_evpn_mh.c:2692:
+			strcpy(type_str + strlen(type_str), "Remote");

WARNING: line over 80 characters
#2904: FILE: /tmp/f1-9793/zebra_evpn_mh.c:2904:
+			vty_out(vty, "%%ESI already exists on a different interface\n");

WARNING: line over 80 characters
#3151: FILE: /tmp/f1-9793/zebra_evpn_mh.c:3151:
+		((struct zebra_if *)zif->bondslave_info.bond_if->info)->es_info.es;
Report for zebra_evpn_mh.h | 4 issues
===============================================
WARNING: function definition argument 'ZAPI_HANDLER_ARGS' should also have an identifier name
#295: FILE: /tmp/f1-9793/zebra_evpn_mh.h:295:
+extern void zebra_evpn_proc_remote_es(ZAPI_HANDLER_ARGS);
Report for zebra_evpn_neigh.c | 5 issues
===============================================
WARNING: void function return statements are not generally useful
#914: FILE: /tmp/f1-9793/zebra_evpn_neigh.c:914:
+	return;
+}
Report for zebra_evpn_neigh.h | 12 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-9793/zebra_evpn_neigh.h:32:
+typedef struct zebra_neigh_t_ zebra_neigh_t;

ERROR: Macros with complex values should be enclosed in parentheses
#38: FILE: /tmp/f1-9793/zebra_evpn_neigh.h:38:
+#define ZEBRA_NEIGH_SET_ACTIVE(n) n->state = ZEBRA_NEIGH_ACTIVE

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: /tmp/f1-9793/zebra_evpn_neigh.h:40:
+#define ZEBRA_NEIGH_SET_INACTIVE(n) n->state = ZEBRA_NEIGH_INACTIVE
Report for zebra_l2.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #129: FILE: /tmp/f1-9793/zebra_l2.c:129:
Report for zebra_nhg.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #54: FILE: /tmp/f1-9793/zebra_nhg.c:54:
< ERROR: Bad function definition - uint32_t nhg_get_next_id() should probably be uint32_t nhg_get_next_id(void)
< #71: FILE: /tmp/f1-9793/zebra_nhg.c:71:
< WARNING: space prohibited between function name and open parenthesis '('
< #2700: FILE: /tmp/f1-9793/zebra_nhg.c:2700:
Report for zebra_vxlan.c | 15 issues
===============================================
< WARNING: line over 80 characters
< #3233: FILE: /tmp/f1-9793/zebra_vxlan.c:3233:
< WARNING: line over 80 characters
< #3281: FILE: /tmp/f1-9793/zebra_vxlan.c:3281:
< ERROR: strcpy() is error-prone; please use strlcpy()#3834: FILE: /tmp/f1-9793/zebra_vxlan.c:3834:
< +				strcpy(esi_buf, "-");
---
> WARNING: quoted string split across lines
> #8289: FILE: /tmp/f2-9793/zebra_vxlan.c:8289:
> +						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u, "
> +						"entry exists and has not changed ",
44c103
< #4178: FILE: /tmp/f1-9793/zebra_vxlan.c:4178:
< WARNING: line over 80 characters
< #4478: FILE: /tmp/f1-9793/zebra_vxlan.c:4478:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200604-24-ga1e542bc3-0 (missing) -> 7.5-dev-20200604-24-ga1e542bc3-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200604-24-ga1e542bc3-0 (missing) -> 7.5-dev-20200604-24-ga1e542bc3-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200604-24-ga1e542bc3-0 (missing) -> 7.5-dev-20200604-24-ga1e542bc3-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200604-24-ga1e542bc3-0 (missing) -> 7.5-dev-20200604-24-ga1e542bc3-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200604-24-ga1e542bc3-0 (missing) -> 7.5-dev-20200604-24-ga1e542bc3-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 6515, comparing to Git base SHA ce49c42
  • Base image data for Git ce49c42 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12552/artifact/shared/static_analysis/index.html

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
  • sprintf, strcat, strcpy are banned; please use snprintf, strlcat, strlcpy

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 5, 2020

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/6515 fb1df9e
Date 06/05/2020
Start 10:08:04
Finish 10:34:03
Run-Time 25:59
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-06-05-10:08:04.txt
Log autoscript-2020-06-05-10:09:04.log.bz2
Memory 505 504 447

For details, please contact louberger

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
  • sprintf, strcat, strcpy are banned; please use snprintf, strlcat, strlcpy

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 5, 2020

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/6515 dc06617
Date 06/05/2020
Start 11:08:11
Finish 11:34:20
Run-Time 26:09
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-06-05-11:08:11.txt
Log autoscript-2020-06-05-11:09:13.log.bz2
Memory 486 503 446

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 5, 2020

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12558/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-05 16:44:16,787 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:44:16,789 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:44:18,848 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:44:18,851 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:44:20,913 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:44:22,969 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:44:25,034 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:44:25,038 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:49:45,320 ERROR: 'router_json_cmp' failed after 80.21 seconds
2020-06-05 16:49:45,323 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12558/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 14:36:10,922 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-05 14:38:55,606 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 14:38:55,853 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 14:52:57,718 ERROR: '_bgp_has_routes' failed after 37.47 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12558/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 16:36:07,444 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-05 16:38:49,289 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 16:38:49,572 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 16:53:22,386 ERROR: '_bgp_has_routes' failed after 38.61 seconds
2020-06-05 16:53:34,021 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12558/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-05 16:43:32,387 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:43:32,389 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:43:34,437 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:43:34,438 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:43:36,475 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:43:38,527 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:43:40,581 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:43:40,583 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:48:52,525 ERROR: 'router_json_cmp' failed after 76.23 seconds
2020-06-05 16:48:52,528 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12558/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 16:36:08,897 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-05 16:38:49,065 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 16:38:49,316 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 16:52:53,574 ERROR: '_bgp_has_routes' failed after 37.62 seconds
2020-06-05 16:53:05,407 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12558/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-05 14:43:38,906 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 14:43:38,908 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:43:40,951 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 14:43:40,953 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:43:43,006 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:43:45,069 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:43:47,129 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 14:43:47,132 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:49:01,341 ERROR: 'router_json_cmp' failed after 76.58 seconds
2020-06-05 14:49:01,344 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 2
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotests part 0
  • Topo tests part 2 on Ubuntu 18.04 amd64
  • Debian 8 deb pkg check
  • Debian 10 deb pkg check
  • Debian 9 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • IPv4 ldp protocol on Ubuntu 18.04
  • Static analyzer (clang)
  • Fedora 29 rpm pkg check
  • Ubuntu 20.04 deb pkg check
  • Topo tests part 2 on Ubuntu 16.04 i386
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 1
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 16.04 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12558/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-05 16:44:16,787 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:44:16,789 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:44:18,848 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:44:18,851 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:44:20,913 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:44:22,969 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:44:25,034 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:44:25,038 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:49:45,320 ERROR: 'router_json_cmp' failed after 80.21 seconds
2020-06-05 16:49:45,323 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12558/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 14:36:10,922 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-05 14:38:55,606 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 14:38:55,853 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 14:52:57,718 ERROR: '_bgp_has_routes' failed after 37.47 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12558/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 16:36:07,444 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-05 16:38:49,289 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 16:38:49,572 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 16:53:22,386 ERROR: '_bgp_has_routes' failed after 38.61 seconds
2020-06-05 16:53:34,021 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12558/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-05 16:43:32,387 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:43:32,389 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:43:34,437 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:43:34,438 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:43:36,475 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:43:38,527 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:43:40,581 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 16:43:40,583 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:48:52,525 ERROR: 'router_json_cmp' failed after 76.23 seconds
2020-06-05 16:48:52,528 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12558/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 16:36:08,897 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-05 16:38:49,065 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 16:38:49,316 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 16:52:53,574 ERROR: '_bgp_has_routes' failed after 37.62 seconds
2020-06-05 16:53:05,407 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12558/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-05 14:43:38,906 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 14:43:38,908 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:43:40,951 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 14:43:40,953 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:43:43,006 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:43:45,069 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:43:47,129 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 14:43:47,132 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 14:49:01,341 ERROR: 'router_json_cmp' failed after 76.58 seconds
2020-06-05 14:49:01,344 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/TOPOU1804/ErrorLog/log_topotests.txt

<stdin>:11504: trailing whitespace.
        
<stdin>:11598: trailing whitespace.
    
<stdin>:11997: space before tab in indent.
 		return 0;
<stdin>:8573: new blank line at EOF.
+
<stdin>:11371: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Report for bgp_evpn.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2973: FILE: /tmp/f1-10009/bgp_evpn.c:2973:
< WARNING: line over 80 characters
< #3549: FILE: /tmp/f1-10009/bgp_evpn.c:3549:
< WARNING: line over 80 characters
< #3766: FILE: /tmp/f1-10009/bgp_evpn.c:3766:
Report for bgp_evpn_mh.c | 87 issues
===============================================
ERROR: strcpy() is error-prone; please use strlcpy()#1829: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1829:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1831: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1831:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1834: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1834:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1891: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1891:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1893: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1893:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1896: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1896:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1951: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1951:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#1953: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1953:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#1955: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1955:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#1962: FILE: /tmp/f1-10009/bgp_evpn_mh.c:1962:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2024: FILE: /tmp/f1-10009/bgp_evpn_mh.c:2024:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2026: FILE: /tmp/f1-10009/bgp_evpn_mh.c:2026:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2031: FILE: /tmp/f1-10009/bgp_evpn_mh.c:2031:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2053: FILE: /tmp/f1-10009/bgp_evpn_mh.c:2053:
+				strcpy(incons_str + strlen(incons_str),

ERROR: strcpy() is error-prone; please use strlcpy()#2056: FILE: /tmp/f1-10009/bgp_evpn_mh.c:2056:
+			strcpy(incons_str, "-");

WARNING: line over 80 characters
#2185: FILE: /tmp/f1-10009/bgp_evpn_mh.c:2185:
+	nh.type = v4_nhg ? NEXTHOP_TYPE_IPV4_IFINDEX : NEXTHOP_TYPE_IPV6_IFINDEX;

ERROR: strcpy() is error-prone; please use strlcpy()#2574: FILE: /tmp/f1-10009/bgp_evpn_mh.c:2574:
+			strcpy(flags_str + strlen(flags_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#3233: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3233:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#3235: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3235:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "V");

ERROR: strcpy() is error-prone; please use strlcpy()#3238: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3238:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#3318: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3318:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3320: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3320:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3322: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3322:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#3351: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3351:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3353: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3353:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3357: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3357:
+			strcpy(vtep_str, "-");

WARNING: line over 80 characters
#3461: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3461:
+			vty_out(vty, "Flags: L local, R remote, I inconsistent\n");

WARNING: line over 80 characters
#3462: FILE: /tmp/f1-10009/bgp_evpn_mh.c:3462:
+			vty_out(vty, "VTEP-Flags: E EAD-per-ES, V EAD-per-EVI\n");
Report for bgp_evpn_vty.c | 4 issues
===============================================
< ERROR: spaces required around that '?' (ctx:VxW)
< #3753: FILE: /tmp/f1-10009/bgp_evpn_vty.c:3753:
< ERROR: spaces required around that ':' (ctx:WxV)
< #3753: FILE: /tmp/f1-10009/bgp_evpn_vty.c:3753:
Report for bgp_nht.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1039: FILE: /tmp/f1-10009/bgp_nht.c:1039:
< ERROR: space required after that ',' (ctx:VxV)
< #1049: FILE: /tmp/f1-10009/bgp_nht.c:1049:
Report for bitfield.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #61: FILE: /tmp/f1-10009/bitfield.h:61:
Report for debug.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #114: FILE: /tmp/f1-10009/debug.c:114:
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#959: FILE: /tmp/f1-10009/if.c:959:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#962: FILE: /tmp/f2-10009/if.c:962:
103c103
< #1051: FILE: /tmp/f1-10009/if.c:1051:
Report for if_netlink.c | 10 issues
===============================================
< ERROR: code indent should use tabs where possible
< #680: FILE: /tmp/f1-10009/if_netlink.c:680:
< WARNING: please, no space before tabs
< #680: FILE: /tmp/f1-10009/if_netlink.c:680:
< WARNING: please, no spaces at the start of a line
< #680: FILE: /tmp/f1-10009/if_netlink.c:680:
< WARNING: line over 80 characters
< #1483: FILE: /tmp/f1-10009/if_netlink.c:1483:
< WARNING: line over 80 characters
< #1597: FILE: /tmp/f1-10009/if_netlink.c:1597:
Report for prefix.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #49: FILE: /tmp/f1-10009/prefix.h:49:
< WARNING: line over 80 characters
< #50: FILE: /tmp/f1-10009/prefix.h:50:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #78: FILE: /tmp/f1-10009/rt_netlink.c:78:
< WARNING: line over 80 characters
< #2706: FILE: /tmp/f1-10009/rt_netlink.c:2706:
< WARNING: Block comments should align the * on each line
< #3843: FILE: /tmp/f1-10009/rt_netlink.c:3843:
Report for sharp_nht.c | 8 issues
===============================================
< WARNING: void function return statements are not generally useful
< #112: FILE: /tmp/f1-10009/sharp_nht.c:112:
< WARNING: void function return statements are not generally useful
< #125: FILE: /tmp/f1-10009/sharp_nht.c:125:
< WARNING: void function return statements are not generally useful
< #138: FILE: /tmp/f1-10009/sharp_nht.c:138:
< WARNING: void function return statements are not generally useful
< #154: FILE: /tmp/f1-10009/sharp_nht.c:154:
Report for zapi_msg.c | 30 issues
===============================================
< WARNING: line over 80 characters
< #1571: FILE: /tmp/f1-10009/zapi_msg.c:1571:
< WARNING: line over 80 characters
< #1619: FILE: /tmp/f1-10009/zapi_msg.c:1619:
< WARNING: line over 80 characters
< #1661: FILE: /tmp/f1-10009/zapi_msg.c:1661:
< WARNING: line over 80 characters
< #1662: FILE: /tmp/f1-10009/zapi_msg.c:1662:
< WARNING: line over 80 characters
< #1663: FILE: /tmp/f1-10009/zapi_msg.c:1663:
< WARNING: line over 80 characters
< #1664: FILE: /tmp/f1-10009/zapi_msg.c:1664:
< WARNING: line over 80 characters
< #1670: FILE: /tmp/f1-10009/zapi_msg.c:1670:
< WARNING: line over 80 characters
< #1671: FILE: /tmp/f1-10009/zapi_msg.c:1671:
< WARNING: void function return statements are not generally useful
< #1715: FILE: /tmp/f1-10009/zapi_msg.c:1715:
< WARNING: C99 // comments do not match recommendation
< #1736: FILE: /tmp/f1-10009/zapi_msg.c:1736:
< WARNING: C99 // comments do not match recommendation
< #1737: FILE: /tmp/f1-10009/zapi_msg.c:1737:
< WARNING: C99 // comments do not match recommendation
< #1738: FILE: /tmp/f1-10009/zapi_msg.c:1738:
< WARNING: C99 // comments do not match recommendation
< #1770: FILE: /tmp/f1-10009/zapi_msg.c:1770:
< WARNING: braces {} are not necessary for any arm of this statement
< #1782: FILE: /tmp/f1-10009/zapi_msg.c:1782:
< WARNING: void function return statements are not generally useful
< #1794: FILE: /tmp/f1-10009/zapi_msg.c:1794:
Report for zclient.h | 6 issues
===============================================
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #332: FILE: /tmp/f1-10009/zclient.h:332:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #333: FILE: /tmp/f1-10009/zclient.h:333:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #355: FILE: /tmp/f1-10009/zclient.h:355:
Report for zebra_dplane.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2739: FILE: /tmp/f1-10009/zebra_dplane.c:2739:
Report for zebra_evpn.c | 53 issues
===============================================
WARNING: line over 80 characters
#119: FILE: /tmp/f1-10009/zebra_evpn.c:119:
+		vty_out(vty, " Tenant VRF: %s\n", vrf_id_to_name(zevpn->vrf_id));

WARNING: C99 // comments do not match recommendation
#127: FILE: /tmp/f1-10009/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-10009/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

WARNING: line over 80 characters
#150: FILE: /tmp/f1-10009/zebra_evpn.c:150:
+				       zevpn->advertise_gw_macip ? "Yes" : "No");

WARNING: quoted string split across lines
#188: FILE: /tmp/f1-10009/zebra_evpn.c:188:
+			" Number of ARPs (IPv4 and IPv6, local and remote) "
+			"known for this VNI: %u\n",

WARNING: Missing a blank line after declarations
#232: FILE: /tmp/f1-10009/zebra_evpn.c:232:
+		char vni_str[VNI_STR_LEN];
+		snprintf(vni_str, VNI_STR_LEN, "%u", zevpn->vni);

WARNING: void function return statements are not generally useful
#537: FILE: /tmp/f1-10009/zebra_evpn.c:537:
+	return;
+}

WARNING: void function return statements are not generally useful
#577: FILE: /tmp/f1-10009/zebra_evpn.c:577:
+	return;
+}

WARNING: void function return statements are not generally useful
#623: FILE: /tmp/f1-10009/zebra_evpn.c:623:
+	return;
+}

ERROR: return is not a function, parentheses are not required
#943: FILE: /tmp/f1-10009/zebra_evpn.c:943:
+	return (jhash_1word(zevpn->vni, 0));

WARNING: line over 80 characters
#1079: FILE: /tmp/f1-10009/zebra_evpn.c:1079:
+		zlog_debug("Send EVPN_ADD %u %s tenant vrf %s to %s", zevpn->vni,

ERROR: return is not a function, parentheses are not required
#1138: FILE: /tmp/f1-10009/zebra_evpn.c:1138:
+	return (IPV4_ADDR_SAME(vtep_ip, &zvtep->vtep_ip));
Report for zebra_evpn.h | 8 issues
===============================================
WARNING: do not add new typedefs
#41: FILE: /tmp/f1-10009/zebra_evpn.h:41:
+typedef struct zebra_evpn_t_ zebra_evpn_t;

WARNING: do not add new typedefs
#42: FILE: /tmp/f1-10009/zebra_evpn.h:42:
+typedef struct zebra_vtep_t_ zebra_vtep_t;
Report for zebra_evpn_mac.c | 19 issues
===============================================
WARNING: suspect code indent for conditional statements (24, 24)
#740: FILE: /tmp/f1-10009/zebra_evpn_mac.c:740:
+			if (json_mac_hdr == NULL)
+			vty_out(vty, " %-5s", "");

WARNING: line over 80 characters
#988: FILE: /tmp/f1-10009/zebra_evpn_mac.c:988:
+		zlog_warn("%s: MAC %s flags 0x%x neigh list not empty %d", __func__,

WARNING: void function return statements are not generally useful
#1070: FILE: /tmp/f1-10009/zebra_evpn_mac.c:1070:
+	return;
+}

WARNING: quoted string split across lines
#2002: FILE: /tmp/f1-10009/zebra_evpn_mac.c:2002:
+						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u%s, "
+						"entry exists and has not changed ",
Report for zebra_evpn_mac.h | 4 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-10009/zebra_evpn_mac.h:32:
+typedef struct zebra_mac_t_ zebra_mac_t;
Report for zebra_evpn_mh.c | 63 issues
===============================================
WARNING: line over 80 characters
#252: FILE: /tmp/f1-10009/zebra_evpn_mh.c:252:
+					es_evi->es->esi_str, es_evi->zevpn->vni);

ERROR: strcpy() is error-prone; please use strlcpy()#288: FILE: /tmp/f1-10009/zebra_evpn_mh.c:288:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#326: FILE: /tmp/f1-10009/zebra_evpn_mh.c:326:
+			strcpy(type_str + strlen(type_str), "L");

WARNING: Missing a blank line after declarations
#692: FILE: /tmp/f1-10009/zebra_evpn_mh.c:692:
+			zebra_evpn_t *old_zevpn = acc_bd->zevpn;
+			acc_bd->zevpn = NULL;

WARNING: unnecessary whitespace before a quoted newline
#803: FILE: /tmp/f1-10009/zebra_evpn_mh.c:803:
+		vty_out(vty, " Members: \n");

WARNING: suspect code indent for conditional statements (8, 8)
#1014: FILE: /tmp/f1-10009/zebra_evpn_mh.c:1014:
+	if (nh1 == NULL || nh2 == NULL)
+	return false;

WARNING: suspect code indent for conditional statements (8, 8)
#1035: FILE: /tmp/f1-10009/zebra_evpn_mh.c:1035:
+	if (es1 == NULL || es2 == NULL)
+	return false;

WARNING: line over 80 characters
#1092: FILE: /tmp/f1-10009/zebra_evpn_mh.c:1092:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#1103: FILE: /tmp/f1-10009/zebra_evpn_mh.c:1103:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

ERROR: strcpy() is error-prone; please use strlcpy()#2620: FILE: /tmp/f1-10009/zebra_evpn_mh.c:2620:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2622: FILE: /tmp/f1-10009/zebra_evpn_mh.c:2622:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2624: FILE: /tmp/f1-10009/zebra_evpn_mh.c:2624:
+			strcpy(type_str + strlen(type_str), "N");

ERROR: strcpy() is error-prone; please use strlcpy()#2688: FILE: /tmp/f1-10009/zebra_evpn_mh.c:2688:
+			strcpy(type_str + strlen(type_str), "Local");

ERROR: strcpy() is error-prone; please use strlcpy()#2691: FILE: /tmp/f1-10009/zebra_evpn_mh.c:2691:
+				strcpy(type_str + strlen(type_str), ",");

ERROR: strcpy() is error-prone; please use strlcpy()#2692: FILE: /tmp/f1-10009/zebra_evpn_mh.c:2692:
+			strcpy(type_str + strlen(type_str), "Remote");

WARNING: line over 80 characters
#2904: FILE: /tmp/f1-10009/zebra_evpn_mh.c:2904:
+			vty_out(vty, "%%ESI already exists on a different interface\n");

WARNING: line over 80 characters
#3151: FILE: /tmp/f1-10009/zebra_evpn_mh.c:3151:
+		((struct zebra_if *)zif->bondslave_info.bond_if->info)->es_info.es;
Report for zebra_evpn_mh.h | 4 issues
===============================================
WARNING: function definition argument 'ZAPI_HANDLER_ARGS' should also have an identifier name
#295: FILE: /tmp/f1-10009/zebra_evpn_mh.h:295:
+extern void zebra_evpn_proc_remote_es(ZAPI_HANDLER_ARGS);
Report for zebra_evpn_neigh.c | 5 issues
===============================================
WARNING: void function return statements are not generally useful
#914: FILE: /tmp/f1-10009/zebra_evpn_neigh.c:914:
+	return;
+}
Report for zebra_evpn_neigh.h | 12 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-10009/zebra_evpn_neigh.h:32:
+typedef struct zebra_neigh_t_ zebra_neigh_t;

ERROR: Macros with complex values should be enclosed in parentheses
#38: FILE: /tmp/f1-10009/zebra_evpn_neigh.h:38:
+#define ZEBRA_NEIGH_SET_ACTIVE(n) n->state = ZEBRA_NEIGH_ACTIVE

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: /tmp/f1-10009/zebra_evpn_neigh.h:40:
+#define ZEBRA_NEIGH_SET_INACTIVE(n) n->state = ZEBRA_NEIGH_INACTIVE
Report for zebra_l2.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #129: FILE: /tmp/f1-10009/zebra_l2.c:129:
Report for zebra_nhg.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #54: FILE: /tmp/f1-10009/zebra_nhg.c:54:
< ERROR: Bad function definition - uint32_t nhg_get_next_id() should probably be uint32_t nhg_get_next_id(void)
< #71: FILE: /tmp/f1-10009/zebra_nhg.c:71:
< WARNING: space prohibited between function name and open parenthesis '('
< #2700: FILE: /tmp/f1-10009/zebra_nhg.c:2700:
Report for zebra_vxlan.c | 15 issues
===============================================
< WARNING: line over 80 characters
< #3233: FILE: /tmp/f1-10009/zebra_vxlan.c:3233:
< WARNING: line over 80 characters
< #3281: FILE: /tmp/f1-10009/zebra_vxlan.c:3281:
< ERROR: strcpy() is error-prone; please use strlcpy()#3834: FILE: /tmp/f1-10009/zebra_vxlan.c:3834:
< +				strcpy(esi_buf, "-");
---
> WARNING: quoted string split across lines
> #8289: FILE: /tmp/f2-10009/zebra_vxlan.c:8289:
> +						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u, "
> +						"entry exists and has not changed ",
44c103
< #4178: FILE: /tmp/f1-10009/zebra_vxlan.c:4178:
< WARNING: line over 80 characters
< #4478: FILE: /tmp/f1-10009/zebra_vxlan.c:4478:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-00-gfb1df9e51-0 (missing) -> 7.5-dev-20200605-00-gfb1df9e51-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-00-gfb1df9e51-0 (missing) -> 7.5-dev-20200605-00-gfb1df9e51-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-00-gfb1df9e51-0 (missing) -> 7.5-dev-20200605-00-gfb1df9e51-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-00-gfb1df9e51-0 (missing) -> 7.5-dev-20200605-00-gfb1df9e51-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-00-gfb1df9e51-0 (missing) -> 7.5-dev-20200605-00-gfb1df9e51-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 6515, comparing to Git base SHA ce49c42
  • Base image data for Git ce49c42 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12558/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 5, 2020

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12559/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-05 17:45:58,835 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:45:58,838 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:46:00,898 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:46:00,900 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:46:02,955 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:46:05,030 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:46:07,103 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:46:07,107 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:51:22,601 ERROR: 'router_json_cmp' failed after 79.76 seconds
2020-06-05 17:51:22,603 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-05 17:59:15,216 ERROR: 'router_json_cmp' failed after 106.09 seconds
2020-06-05 17:59:15,219 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12559/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 15:38:12,614 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-05 15:40:48,782 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 15:40:49,023 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 15:54:56,182 ERROR: '_bgp_has_routes' failed after 37.51 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12559/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 17:38:09,067 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-05 17:40:51,230 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 17:40:51,513 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 17:55:32,508 ERROR: '_bgp_has_routes' failed after 38.67 seconds
2020-06-05 17:55:44,778 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-12559/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64:

2020-06-05 15:50:04,673 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-06-05 15:50:04,792 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-06-05 15:50:04,901 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-06-05 15:50:05,010 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-06-05 15:52:07,027 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2020-06-05 16:08:30,993 ERROR: assert failed at "test_bgp_multi_vrf_topo2/test_shut_noshut_p1": Testcase test_shut_noshut_p1 : Failed 
   Error [DUT: r1] VRF: RED_A, BGP is not converged
assert '[DUT: r1] VRF: RED_A, BGP is not converged' is True
2020-06-05 16:14:00,913 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:14:02,997 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:14:05,078 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12559/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-05 17:45:25,149 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:45:25,152 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:45:27,197 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:45:27,199 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:45:29,247 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:45:31,290 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:45:33,338 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:45:33,341 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:50:45,322 ERROR: 'router_json_cmp' failed after 76.45 seconds
2020-06-05 17:50:45,328 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-05 17:58:33,084 ERROR: 'router_json_cmp' failed after 101.08 seconds
2020-06-05 17:58:33,086 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12559/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 17:38:11,686 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-05 17:40:47,474 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 17:40:47,720 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 17:54:55,390 ERROR: '_bgp_has_routes' failed after 37.79 seconds
2020-06-05 17:55:07,202 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12559/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-05 15:45:30,250 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 15:45:30,253 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:45:32,300 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 15:45:32,302 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:45:34,358 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:45:36,415 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:45:38,463 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 15:45:38,465 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:50:50,225 ERROR: 'router_json_cmp' failed after 76.37 seconds
2020-06-05 15:50:50,228 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-05 15:58:30,896 ERROR: 'router_json_cmp' failed after 100.84 seconds
2020-06-05 15:58:30,899 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Debian 10 deb pkg check
  • CentOS 7 rpm pkg check
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Debian 9 deb pkg check
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • Static analyzer (clang)
  • Fedora 29 rpm pkg check
  • Topo tests part 2 on Ubuntu 16.04 i386
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 1
  • IPv6 protocols on Ubuntu 18.04
  • Ubuntu 16.04 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12559/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-05 17:45:58,835 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:45:58,838 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:46:00,898 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:46:00,900 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:46:02,955 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:46:05,030 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:46:07,103 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:46:07,107 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:51:22,601 ERROR: 'router_json_cmp' failed after 79.76 seconds
2020-06-05 17:51:22,603 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-05 17:59:15,216 ERROR: 'router_json_cmp' failed after 106.09 seconds
2020-06-05 17:59:15,219 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12559/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 15:38:12,614 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-05 15:40:48,782 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 15:40:49,023 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 15:54:56,182 ERROR: '_bgp_has_routes' failed after 37.51 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12559/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 17:38:09,067 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-05 17:40:51,230 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 17:40:51,513 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 17:55:32,508 ERROR: '_bgp_has_routes' failed after 38.67 seconds
2020-06-05 17:55:44,778 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-12559/test

Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64:

2020-06-05 15:50:04,673 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:-1 



2020-06-05 15:50:04,792 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp community-list standard ANY permit 0:65536 



2020-06-05 15:50:04,901 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:4294967296 



2020-06-05 15:50:05,010 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % Malformed community-list value
line 2: Failure to communicate[13] to bgpd, line: bgp large-community-list standard ANY permit 0:-1:1 



2020-06-05 15:52:07,027 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 1985, in create_bgp_community_lists
    tgen, router, config_data, "bgp_community_list", build=build
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP2U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 2: % Command incomplete[4]: bgp large-community-list standard Test1 permit  



2020-06-05 16:08:30,993 ERROR: assert failed at "test_bgp_multi_vrf_topo2/test_shut_noshut_p1": Testcase test_shut_noshut_p1 : Failed 
   Error [DUT: r1] VRF: RED_A, BGP is not converged
assert '[DUT: r1] VRF: RED_A, BGP is not converged' is True
2020-06-05 16:14:00,913 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:14:02,997 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 16:14:05,078 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12559/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-05 17:45:25,149 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:45:25,152 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:45:27,197 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:45:27,199 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:45:29,247 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:45:31,290 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:45:33,338 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 17:45:33,341 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 17:50:45,322 ERROR: 'router_json_cmp' failed after 76.45 seconds
2020-06-05 17:50:45,328 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-05 17:58:33,084 ERROR: 'router_json_cmp' failed after 101.08 seconds
2020-06-05 17:58:33,086 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12559/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-05 17:38:11,686 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-05 17:40:47,474 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-05 17:40:47,720 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-05 17:54:55,390 ERROR: '_bgp_has_routes' failed after 37.79 seconds
2020-06-05 17:55:07,202 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12559/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-05 15:45:30,250 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 15:45:30,253 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:45:32,300 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 15:45:32,302 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:45:34,358 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:45:36,415 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:45:38,463 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-05 15:45:38,465 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-05 15:50:50,225 ERROR: 'router_json_cmp' failed after 76.37 seconds
2020-06-05 15:50:50,228 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-05 15:58:30,896 ERROR: 'router_json_cmp' failed after 100.84 seconds
2020-06-05 15:58:30,899 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/TOPOU1804/ErrorLog/log_topotests.txt

<stdin>:11510: trailing whitespace.
        
<stdin>:11604: trailing whitespace.
    
<stdin>:12003: space before tab in indent.
 		return 0;
<stdin>:8573: new blank line at EOF.
+
<stdin>:11377: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Report for bgp_evpn.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2973: FILE: /tmp/f1-28264/bgp_evpn.c:2973:
< WARNING: line over 80 characters
< #3549: FILE: /tmp/f1-28264/bgp_evpn.c:3549:
< WARNING: line over 80 characters
< #3766: FILE: /tmp/f1-28264/bgp_evpn.c:3766:
Report for bgp_evpn_mh.c | 87 issues
===============================================
ERROR: strcpy() is error-prone; please use strlcpy()#1829: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1829:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1831: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1831:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1834: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1834:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1891: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1891:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1893: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1893:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1896: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1896:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1951: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1951:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#1953: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1953:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#1955: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1955:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#1962: FILE: /tmp/f1-28264/bgp_evpn_mh.c:1962:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2024: FILE: /tmp/f1-28264/bgp_evpn_mh.c:2024:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2026: FILE: /tmp/f1-28264/bgp_evpn_mh.c:2026:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2031: FILE: /tmp/f1-28264/bgp_evpn_mh.c:2031:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2053: FILE: /tmp/f1-28264/bgp_evpn_mh.c:2053:
+				strcpy(incons_str + strlen(incons_str),

ERROR: strcpy() is error-prone; please use strlcpy()#2056: FILE: /tmp/f1-28264/bgp_evpn_mh.c:2056:
+			strcpy(incons_str, "-");

WARNING: line over 80 characters
#2185: FILE: /tmp/f1-28264/bgp_evpn_mh.c:2185:
+	nh.type = v4_nhg ? NEXTHOP_TYPE_IPV4_IFINDEX : NEXTHOP_TYPE_IPV6_IFINDEX;

ERROR: strcpy() is error-prone; please use strlcpy()#2574: FILE: /tmp/f1-28264/bgp_evpn_mh.c:2574:
+			strcpy(flags_str + strlen(flags_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#3233: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3233:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#3235: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3235:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "V");

ERROR: strcpy() is error-prone; please use strlcpy()#3238: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3238:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#3318: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3318:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3320: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3320:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3322: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3322:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#3351: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3351:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3353: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3353:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3357: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3357:
+			strcpy(vtep_str, "-");

WARNING: line over 80 characters
#3461: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3461:
+			vty_out(vty, "Flags: L local, R remote, I inconsistent\n");

WARNING: line over 80 characters
#3462: FILE: /tmp/f1-28264/bgp_evpn_mh.c:3462:
+			vty_out(vty, "VTEP-Flags: E EAD-per-ES, V EAD-per-EVI\n");
Report for bgp_evpn_vty.c | 4 issues
===============================================
< ERROR: spaces required around that '?' (ctx:VxW)
< #3753: FILE: /tmp/f1-28264/bgp_evpn_vty.c:3753:
< ERROR: spaces required around that ':' (ctx:WxV)
< #3753: FILE: /tmp/f1-28264/bgp_evpn_vty.c:3753:
Report for bgp_nht.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1039: FILE: /tmp/f1-28264/bgp_nht.c:1039:
< ERROR: space required after that ',' (ctx:VxV)
< #1049: FILE: /tmp/f1-28264/bgp_nht.c:1049:
Report for bitfield.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #61: FILE: /tmp/f1-28264/bitfield.h:61:
Report for debug.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #114: FILE: /tmp/f1-28264/debug.c:114:
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#959: FILE: /tmp/f1-28264/if.c:959:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#962: FILE: /tmp/f2-28264/if.c:962:
103c103
< #1051: FILE: /tmp/f1-28264/if.c:1051:
Report for if_netlink.c | 10 issues
===============================================
< ERROR: code indent should use tabs where possible
< #680: FILE: /tmp/f1-28264/if_netlink.c:680:
< WARNING: please, no space before tabs
< #680: FILE: /tmp/f1-28264/if_netlink.c:680:
< WARNING: please, no spaces at the start of a line
< #680: FILE: /tmp/f1-28264/if_netlink.c:680:
< WARNING: line over 80 characters
< #1483: FILE: /tmp/f1-28264/if_netlink.c:1483:
< WARNING: line over 80 characters
< #1597: FILE: /tmp/f1-28264/if_netlink.c:1597:
Report for prefix.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #49: FILE: /tmp/f1-28264/prefix.h:49:
< WARNING: line over 80 characters
< #50: FILE: /tmp/f1-28264/prefix.h:50:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #78: FILE: /tmp/f1-28264/rt_netlink.c:78:
< WARNING: line over 80 characters
< #2706: FILE: /tmp/f1-28264/rt_netlink.c:2706:
< WARNING: Block comments should align the * on each line
< #3843: FILE: /tmp/f1-28264/rt_netlink.c:3843:
Report for sharp_nht.c | 8 issues
===============================================
< WARNING: void function return statements are not generally useful
< #112: FILE: /tmp/f1-28264/sharp_nht.c:112:
< WARNING: void function return statements are not generally useful
< #125: FILE: /tmp/f1-28264/sharp_nht.c:125:
< WARNING: void function return statements are not generally useful
< #138: FILE: /tmp/f1-28264/sharp_nht.c:138:
< WARNING: void function return statements are not generally useful
< #154: FILE: /tmp/f1-28264/sharp_nht.c:154:
Report for zapi_msg.c | 30 issues
===============================================
< WARNING: line over 80 characters
< #1571: FILE: /tmp/f1-28264/zapi_msg.c:1571:
< WARNING: line over 80 characters
< #1619: FILE: /tmp/f1-28264/zapi_msg.c:1619:
< WARNING: line over 80 characters
< #1661: FILE: /tmp/f1-28264/zapi_msg.c:1661:
< WARNING: line over 80 characters
< #1662: FILE: /tmp/f1-28264/zapi_msg.c:1662:
< WARNING: line over 80 characters
< #1663: FILE: /tmp/f1-28264/zapi_msg.c:1663:
< WARNING: line over 80 characters
< #1664: FILE: /tmp/f1-28264/zapi_msg.c:1664:
< WARNING: line over 80 characters
< #1670: FILE: /tmp/f1-28264/zapi_msg.c:1670:
< WARNING: line over 80 characters
< #1671: FILE: /tmp/f1-28264/zapi_msg.c:1671:
< WARNING: void function return statements are not generally useful
< #1715: FILE: /tmp/f1-28264/zapi_msg.c:1715:
< WARNING: C99 // comments do not match recommendation
< #1736: FILE: /tmp/f1-28264/zapi_msg.c:1736:
< WARNING: C99 // comments do not match recommendation
< #1737: FILE: /tmp/f1-28264/zapi_msg.c:1737:
< WARNING: C99 // comments do not match recommendation
< #1738: FILE: /tmp/f1-28264/zapi_msg.c:1738:
< WARNING: C99 // comments do not match recommendation
< #1770: FILE: /tmp/f1-28264/zapi_msg.c:1770:
< WARNING: braces {} are not necessary for any arm of this statement
< #1782: FILE: /tmp/f1-28264/zapi_msg.c:1782:
< WARNING: void function return statements are not generally useful
< #1794: FILE: /tmp/f1-28264/zapi_msg.c:1794:
Report for zclient.h | 6 issues
===============================================
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #332: FILE: /tmp/f1-28264/zclient.h:332:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #333: FILE: /tmp/f1-28264/zclient.h:333:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #355: FILE: /tmp/f1-28264/zclient.h:355:
Report for zebra_dplane.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2739: FILE: /tmp/f1-28264/zebra_dplane.c:2739:
Report for zebra_evpn.c | 53 issues
===============================================
WARNING: line over 80 characters
#119: FILE: /tmp/f1-28264/zebra_evpn.c:119:
+		vty_out(vty, " Tenant VRF: %s\n", vrf_id_to_name(zevpn->vrf_id));

WARNING: C99 // comments do not match recommendation
#127: FILE: /tmp/f1-28264/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-28264/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

WARNING: line over 80 characters
#150: FILE: /tmp/f1-28264/zebra_evpn.c:150:
+				       zevpn->advertise_gw_macip ? "Yes" : "No");

WARNING: quoted string split across lines
#188: FILE: /tmp/f1-28264/zebra_evpn.c:188:
+			" Number of ARPs (IPv4 and IPv6, local and remote) "
+			"known for this VNI: %u\n",

WARNING: Missing a blank line after declarations
#232: FILE: /tmp/f1-28264/zebra_evpn.c:232:
+		char vni_str[VNI_STR_LEN];
+		snprintf(vni_str, VNI_STR_LEN, "%u", zevpn->vni);

WARNING: void function return statements are not generally useful
#537: FILE: /tmp/f1-28264/zebra_evpn.c:537:
+	return;
+}

WARNING: void function return statements are not generally useful
#577: FILE: /tmp/f1-28264/zebra_evpn.c:577:
+	return;
+}

WARNING: void function return statements are not generally useful
#623: FILE: /tmp/f1-28264/zebra_evpn.c:623:
+	return;
+}

ERROR: return is not a function, parentheses are not required
#943: FILE: /tmp/f1-28264/zebra_evpn.c:943:
+	return (jhash_1word(zevpn->vni, 0));

WARNING: line over 80 characters
#1079: FILE: /tmp/f1-28264/zebra_evpn.c:1079:
+		zlog_debug("Send EVPN_ADD %u %s tenant vrf %s to %s", zevpn->vni,

ERROR: return is not a function, parentheses are not required
#1138: FILE: /tmp/f1-28264/zebra_evpn.c:1138:
+	return (IPV4_ADDR_SAME(vtep_ip, &zvtep->vtep_ip));
Report for zebra_evpn.h | 8 issues
===============================================
WARNING: do not add new typedefs
#41: FILE: /tmp/f1-28264/zebra_evpn.h:41:
+typedef struct zebra_evpn_t_ zebra_evpn_t;

WARNING: do not add new typedefs
#42: FILE: /tmp/f1-28264/zebra_evpn.h:42:
+typedef struct zebra_vtep_t_ zebra_vtep_t;
Report for zebra_evpn_mac.c | 19 issues
===============================================
WARNING: suspect code indent for conditional statements (24, 24)
#740: FILE: /tmp/f1-28264/zebra_evpn_mac.c:740:
+			if (json_mac_hdr == NULL)
+			vty_out(vty, " %-5s", "");

WARNING: line over 80 characters
#988: FILE: /tmp/f1-28264/zebra_evpn_mac.c:988:
+		zlog_warn("%s: MAC %s flags 0x%x neigh list not empty %d", __func__,

WARNING: void function return statements are not generally useful
#1070: FILE: /tmp/f1-28264/zebra_evpn_mac.c:1070:
+	return;
+}

WARNING: quoted string split across lines
#2002: FILE: /tmp/f1-28264/zebra_evpn_mac.c:2002:
+						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u%s, "
+						"entry exists and has not changed ",
Report for zebra_evpn_mac.h | 4 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-28264/zebra_evpn_mac.h:32:
+typedef struct zebra_mac_t_ zebra_mac_t;
Report for zebra_evpn_mh.c | 63 issues
===============================================
WARNING: line over 80 characters
#252: FILE: /tmp/f1-28264/zebra_evpn_mh.c:252:
+					es_evi->es->esi_str, es_evi->zevpn->vni);

ERROR: strcpy() is error-prone; please use strlcpy()#288: FILE: /tmp/f1-28264/zebra_evpn_mh.c:288:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#326: FILE: /tmp/f1-28264/zebra_evpn_mh.c:326:
+			strcpy(type_str + strlen(type_str), "L");

WARNING: Missing a blank line after declarations
#692: FILE: /tmp/f1-28264/zebra_evpn_mh.c:692:
+			zebra_evpn_t *old_zevpn = acc_bd->zevpn;
+			acc_bd->zevpn = NULL;

WARNING: unnecessary whitespace before a quoted newline
#803: FILE: /tmp/f1-28264/zebra_evpn_mh.c:803:
+		vty_out(vty, " Members: \n");

WARNING: suspect code indent for conditional statements (8, 8)
#1014: FILE: /tmp/f1-28264/zebra_evpn_mh.c:1014:
+	if (nh1 == NULL || nh2 == NULL)
+	return false;

WARNING: suspect code indent for conditional statements (8, 8)
#1035: FILE: /tmp/f1-28264/zebra_evpn_mh.c:1035:
+	if (es1 == NULL || es2 == NULL)
+	return false;

WARNING: line over 80 characters
#1092: FILE: /tmp/f1-28264/zebra_evpn_mh.c:1092:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#1103: FILE: /tmp/f1-28264/zebra_evpn_mh.c:1103:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

ERROR: strcpy() is error-prone; please use strlcpy()#2620: FILE: /tmp/f1-28264/zebra_evpn_mh.c:2620:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2622: FILE: /tmp/f1-28264/zebra_evpn_mh.c:2622:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2624: FILE: /tmp/f1-28264/zebra_evpn_mh.c:2624:
+			strcpy(type_str + strlen(type_str), "N");

ERROR: strcpy() is error-prone; please use strlcpy()#2688: FILE: /tmp/f1-28264/zebra_evpn_mh.c:2688:
+			strcpy(type_str + strlen(type_str), "Local");

ERROR: strcpy() is error-prone; please use strlcpy()#2691: FILE: /tmp/f1-28264/zebra_evpn_mh.c:2691:
+				strcpy(type_str + strlen(type_str), ",");

ERROR: strcpy() is error-prone; please use strlcpy()#2692: FILE: /tmp/f1-28264/zebra_evpn_mh.c:2692:
+			strcpy(type_str + strlen(type_str), "Remote");

WARNING: line over 80 characters
#2904: FILE: /tmp/f1-28264/zebra_evpn_mh.c:2904:
+			vty_out(vty, "%%ESI already exists on a different interface\n");

WARNING: line over 80 characters
#3151: FILE: /tmp/f1-28264/zebra_evpn_mh.c:3151:
+		((struct zebra_if *)zif->bondslave_info.bond_if->info)->es_info.es;
Report for zebra_evpn_mh.h | 4 issues
===============================================
WARNING: function definition argument 'ZAPI_HANDLER_ARGS' should also have an identifier name
#295: FILE: /tmp/f1-28264/zebra_evpn_mh.h:295:
+extern void zebra_evpn_proc_remote_es(ZAPI_HANDLER_ARGS);
Report for zebra_evpn_neigh.c | 5 issues
===============================================
WARNING: void function return statements are not generally useful
#914: FILE: /tmp/f1-28264/zebra_evpn_neigh.c:914:
+	return;
+}
Report for zebra_evpn_neigh.h | 12 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-28264/zebra_evpn_neigh.h:32:
+typedef struct zebra_neigh_t_ zebra_neigh_t;

ERROR: Macros with complex values should be enclosed in parentheses
#38: FILE: /tmp/f1-28264/zebra_evpn_neigh.h:38:
+#define ZEBRA_NEIGH_SET_ACTIVE(n) n->state = ZEBRA_NEIGH_ACTIVE

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: /tmp/f1-28264/zebra_evpn_neigh.h:40:
+#define ZEBRA_NEIGH_SET_INACTIVE(n) n->state = ZEBRA_NEIGH_INACTIVE
Report for zebra_l2.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #129: FILE: /tmp/f1-28264/zebra_l2.c:129:
Report for zebra_nhg.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #54: FILE: /tmp/f1-28264/zebra_nhg.c:54:
< ERROR: Bad function definition - uint32_t nhg_get_next_id() should probably be uint32_t nhg_get_next_id(void)
< #71: FILE: /tmp/f1-28264/zebra_nhg.c:71:
< WARNING: space prohibited between function name and open parenthesis '('
< #2700: FILE: /tmp/f1-28264/zebra_nhg.c:2700:
Report for zebra_vxlan.c | 15 issues
===============================================
< WARNING: line over 80 characters
< #3233: FILE: /tmp/f1-28264/zebra_vxlan.c:3233:
< WARNING: line over 80 characters
< #3281: FILE: /tmp/f1-28264/zebra_vxlan.c:3281:
< ERROR: strcpy() is error-prone; please use strlcpy()#3834: FILE: /tmp/f1-28264/zebra_vxlan.c:3834:
< +				strcpy(esi_buf, "-");
---
> WARNING: quoted string split across lines
> #8289: FILE: /tmp/f2-28264/zebra_vxlan.c:8289:
> +						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u, "
> +						"entry exists and has not changed ",
44c103
< #4178: FILE: /tmp/f1-28264/zebra_vxlan.c:4178:
< WARNING: line over 80 characters
< #4478: FILE: /tmp/f1-28264/zebra_vxlan.c:4478:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-172-gdc066174a-0 (missing) -> 7.5-dev-20200605-172-gdc066174a-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-172-gdc066174a-0 (missing) -> 7.5-dev-20200605-172-gdc066174a-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-172-gdc066174a-0 (missing) -> 7.5-dev-20200605-172-gdc066174a-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-172-gdc066174a-0 (missing) -> 7.5-dev-20200605-172-gdc066174a-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200605-172-gdc066174a-0 (missing) -> 7.5-dev-20200605-172-gdc066174a-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 6515, comparing to Git base SHA ce49c42
  • Base image data for Git ce49c42 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12559/artifact/shared/static_analysis/index.html

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
  • sprintf, strcat, strcpy are banned; please use snprintf, strlcat, strlcpy

If you are a new contributor to FRR, please see our contributing guidelines.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 8, 2020

Outdated results 🚧

Basic BGPD CI results: Partial FAILURE, 1 tests failed

_ _
Result SUCCESS git merge/6515 ce4e1d0
Date 06/07/2020
Start 23:03:06
Finish 00:48:42
Run-Time 01:45:36
Total 1815
Pass 1814
Fail 1
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-06-07-23:03:06.txt
Log autoscript-2020-06-07-23:04:03.log.bz2
Memory 505 510 447

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 8, 2020

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12565/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-08 03:42:51,304 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 03:42:51,307 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:42:53,379 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 03:42:53,382 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:42:55,450 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:42:57,525 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:42:59,599 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 03:42:59,603 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:48:19,832 ERROR: 'router_json_cmp' failed after 79.98 seconds
2020-06-08 03:48:19,835 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12565/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
2020-06-08 05:43:23,457 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:43:23,461 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:43:25,538 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:43:25,541 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:43:27,613 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:43:29,691 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:43:31,760 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:43:31,763 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:48:49,006 ERROR: 'router_json_cmp' failed after 80.06 seconds
2020-06-08 05:48:49,009 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12565/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-08 05:34:54,333 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-08 05:37:37,860 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-08 05:37:38,146 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-08 05:52:19,383 ERROR: '_bgp_has_routes' failed after 39.33 seconds
2020-06-08 05:52:31,859 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12565/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-08 05:34:49,770 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-08 05:37:37,151 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-08 05:37:37,401 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-08 05:52:54,493 ERROR: '_bgp_has_routes' failed after 40.39 seconds
2020-06-08 05:53:07,270 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12565/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-08 05:42:17,556 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:42:17,559 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:42:19,605 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:42:19,607 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:42:21,649 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:42:23,705 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:42:25,753 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:42:25,755 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:47:38,747 ERROR: 'router_json_cmp' failed after 76.82 seconds
2020-06-08 05:47:38,749 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-08 05:55:25,632 ERROR: 'router_json_cmp' failed after 101.32 seconds
2020-06-08 05:55:25,634 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r2" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r2-eth1",
  	            "ip": "10.0.1.1",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r2-eth2",
  	            "ip": "10.0.3.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth1",
  		    "ip": "10.0.1.1",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth2",
  		    "ip": "10.0.3.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12565/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-08 03:34:59,509 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-08 03:37:45,045 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-08 03:37:45,281 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-08 03:52:31,372 ERROR: '_bgp_has_routes' failed after 39.24 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 1
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • IPv6 protocols on Ubuntu 18.04
  • Topo tests part 2 on Ubuntu 16.04 i386
  • Debian 10 deb pkg check
  • CentOS 7 rpm pkg check
  • Ubuntu 16.04 deb pkg check
  • Topo tests part 2 on Ubuntu 18.04 amd64
  • Addresssanitizer topotests part 2
  • Fedora 29 rpm pkg check
  • Debian 8 deb pkg check
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Addresssanitizer topotests part 0
  • IPv4 protocols on Ubuntu 18.04
  • IPv4 ldp protocol on Ubuntu 18.04
  • Debian 9 deb pkg check
  • Static analyzer (clang)

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12565/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-08 03:42:51,304 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 03:42:51,307 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:42:53,379 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 03:42:53,382 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:42:55,450 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:42:57,525 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:42:59,599 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 03:42:59,603 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 03:48:19,832 ERROR: 'router_json_cmp' failed after 79.98 seconds
2020-06-08 03:48:19,835 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12565/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
2020-06-08 05:43:23,457 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:43:23,461 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:43:25,538 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:43:25,541 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:43:27,613 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:43:29,691 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:43:31,760 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:43:31,763 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:48:49,006 ERROR: 'router_json_cmp' failed after 80.06 seconds
2020-06-08 05:48:49,009 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12565/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-08 05:34:54,333 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-08 05:37:37,860 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-08 05:37:38,146 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-08 05:52:19,383 ERROR: '_bgp_has_routes' failed after 39.33 seconds
2020-06-08 05:52:31,859 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12565/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-08 05:34:49,770 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-08 05:37:37,151 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-08 05:37:37,401 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-08 05:52:54,493 ERROR: '_bgp_has_routes' failed after 40.39 seconds
2020-06-08 05:53:07,270 ERROR: assert failed at "bgp_evpn_rt5.test_bgp_evpn/test_protocols_convergence": expected ping IPv4 from R1(r1-vrf-101) to R2(192.168.101.41) should be ok
assert 0
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12565/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-08 05:42:17,556 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:42:17,559 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:42:19,605 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:42:19,607 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:42:21,649 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:42:23,705 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:42:25,753 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-08 05:42:25,755 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-08 05:47:38,747 ERROR: 'router_json_cmp' failed after 76.82 seconds
2020-06-08 05:47:38,749 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-08 05:55:25,632 ERROR: 'router_json_cmp' failed after 101.32 seconds
2020-06-08 05:55:25,634 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r2" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r2-eth1",
  	            "ip": "10.0.1.1",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r2-eth2",
  	            "ip": "10.0.3.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth1",
  		    "ip": "10.0.1.1",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r2-eth2",
  		    "ip": "10.0.3.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12565/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-08 03:34:59,509 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-08 03:37:45,045 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-08 03:37:45,281 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-08 03:52:31,372 ERROR: '_bgp_has_routes' failed after 39.24 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

<stdin>:11510: trailing whitespace.
        
<stdin>:11604: trailing whitespace.
    
<stdin>:12003: space before tab in indent.
 		return 0;
<stdin>:8573: new blank line at EOF.
+
<stdin>:11377: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Report for bgp_evpn.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2973: FILE: /tmp/f1-16048/bgp_evpn.c:2973:
< WARNING: line over 80 characters
< #3549: FILE: /tmp/f1-16048/bgp_evpn.c:3549:
< WARNING: line over 80 characters
< #3766: FILE: /tmp/f1-16048/bgp_evpn.c:3766:
Report for bgp_evpn_mh.c | 87 issues
===============================================
ERROR: strcpy() is error-prone; please use strlcpy()#1829: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1829:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1831: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1831:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1834: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1834:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1891: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1891:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1893: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1893:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1896: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1896:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1951: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1951:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#1953: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1953:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#1955: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1955:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#1962: FILE: /tmp/f1-16048/bgp_evpn_mh.c:1962:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2024: FILE: /tmp/f1-16048/bgp_evpn_mh.c:2024:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2026: FILE: /tmp/f1-16048/bgp_evpn_mh.c:2026:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2031: FILE: /tmp/f1-16048/bgp_evpn_mh.c:2031:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2053: FILE: /tmp/f1-16048/bgp_evpn_mh.c:2053:
+				strcpy(incons_str + strlen(incons_str),

ERROR: strcpy() is error-prone; please use strlcpy()#2056: FILE: /tmp/f1-16048/bgp_evpn_mh.c:2056:
+			strcpy(incons_str, "-");

WARNING: line over 80 characters
#2185: FILE: /tmp/f1-16048/bgp_evpn_mh.c:2185:
+	nh.type = v4_nhg ? NEXTHOP_TYPE_IPV4_IFINDEX : NEXTHOP_TYPE_IPV6_IFINDEX;

ERROR: strcpy() is error-prone; please use strlcpy()#2574: FILE: /tmp/f1-16048/bgp_evpn_mh.c:2574:
+			strcpy(flags_str + strlen(flags_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#3233: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3233:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#3235: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3235:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "V");

ERROR: strcpy() is error-prone; please use strlcpy()#3238: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3238:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#3318: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3318:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3320: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3320:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3322: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3322:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#3351: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3351:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3353: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3353:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3357: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3357:
+			strcpy(vtep_str, "-");

WARNING: line over 80 characters
#3461: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3461:
+			vty_out(vty, "Flags: L local, R remote, I inconsistent\n");

WARNING: line over 80 characters
#3462: FILE: /tmp/f1-16048/bgp_evpn_mh.c:3462:
+			vty_out(vty, "VTEP-Flags: E EAD-per-ES, V EAD-per-EVI\n");
Report for bgp_evpn_vty.c | 4 issues
===============================================
< ERROR: spaces required around that '?' (ctx:VxW)
< #3753: FILE: /tmp/f1-16048/bgp_evpn_vty.c:3753:
< ERROR: spaces required around that ':' (ctx:WxV)
< #3753: FILE: /tmp/f1-16048/bgp_evpn_vty.c:3753:
Report for bgp_nht.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1039: FILE: /tmp/f1-16048/bgp_nht.c:1039:
< ERROR: space required after that ',' (ctx:VxV)
< #1049: FILE: /tmp/f1-16048/bgp_nht.c:1049:
Report for bitfield.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #61: FILE: /tmp/f1-16048/bitfield.h:61:
Report for debug.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #114: FILE: /tmp/f1-16048/debug.c:114:
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#959: FILE: /tmp/f1-16048/if.c:959:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#962: FILE: /tmp/f2-16048/if.c:962:
103c103
< #1051: FILE: /tmp/f1-16048/if.c:1051:
Report for if_netlink.c | 10 issues
===============================================
< ERROR: code indent should use tabs where possible
< #680: FILE: /tmp/f1-16048/if_netlink.c:680:
< WARNING: please, no space before tabs
< #680: FILE: /tmp/f1-16048/if_netlink.c:680:
< WARNING: please, no spaces at the start of a line
< #680: FILE: /tmp/f1-16048/if_netlink.c:680:
< WARNING: line over 80 characters
< #1483: FILE: /tmp/f1-16048/if_netlink.c:1483:
< WARNING: line over 80 characters
< #1597: FILE: /tmp/f1-16048/if_netlink.c:1597:
Report for prefix.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #49: FILE: /tmp/f1-16048/prefix.h:49:
< WARNING: line over 80 characters
< #50: FILE: /tmp/f1-16048/prefix.h:50:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #78: FILE: /tmp/f1-16048/rt_netlink.c:78:
< WARNING: line over 80 characters
< #2706: FILE: /tmp/f1-16048/rt_netlink.c:2706:
< WARNING: Block comments should align the * on each line
< #3843: FILE: /tmp/f1-16048/rt_netlink.c:3843:
Report for sharp_nht.c | 8 issues
===============================================
< WARNING: void function return statements are not generally useful
< #112: FILE: /tmp/f1-16048/sharp_nht.c:112:
< WARNING: void function return statements are not generally useful
< #125: FILE: /tmp/f1-16048/sharp_nht.c:125:
< WARNING: void function return statements are not generally useful
< #138: FILE: /tmp/f1-16048/sharp_nht.c:138:
< WARNING: void function return statements are not generally useful
< #154: FILE: /tmp/f1-16048/sharp_nht.c:154:
Report for zapi_msg.c | 30 issues
===============================================
< WARNING: line over 80 characters
< #1571: FILE: /tmp/f1-16048/zapi_msg.c:1571:
< WARNING: line over 80 characters
< #1619: FILE: /tmp/f1-16048/zapi_msg.c:1619:
< WARNING: line over 80 characters
< #1661: FILE: /tmp/f1-16048/zapi_msg.c:1661:
< WARNING: line over 80 characters
< #1662: FILE: /tmp/f1-16048/zapi_msg.c:1662:
< WARNING: line over 80 characters
< #1663: FILE: /tmp/f1-16048/zapi_msg.c:1663:
< WARNING: line over 80 characters
< #1664: FILE: /tmp/f1-16048/zapi_msg.c:1664:
< WARNING: line over 80 characters
< #1670: FILE: /tmp/f1-16048/zapi_msg.c:1670:
< WARNING: line over 80 characters
< #1671: FILE: /tmp/f1-16048/zapi_msg.c:1671:
< WARNING: void function return statements are not generally useful
< #1715: FILE: /tmp/f1-16048/zapi_msg.c:1715:
< WARNING: C99 // comments do not match recommendation
< #1736: FILE: /tmp/f1-16048/zapi_msg.c:1736:
< WARNING: C99 // comments do not match recommendation
< #1737: FILE: /tmp/f1-16048/zapi_msg.c:1737:
< WARNING: C99 // comments do not match recommendation
< #1738: FILE: /tmp/f1-16048/zapi_msg.c:1738:
< WARNING: C99 // comments do not match recommendation
< #1770: FILE: /tmp/f1-16048/zapi_msg.c:1770:
< WARNING: braces {} are not necessary for any arm of this statement
< #1782: FILE: /tmp/f1-16048/zapi_msg.c:1782:
< WARNING: void function return statements are not generally useful
< #1794: FILE: /tmp/f1-16048/zapi_msg.c:1794:
Report for zclient.h | 6 issues
===============================================
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #332: FILE: /tmp/f1-16048/zclient.h:332:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #333: FILE: /tmp/f1-16048/zclient.h:333:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #355: FILE: /tmp/f1-16048/zclient.h:355:
Report for zebra_dplane.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2739: FILE: /tmp/f1-16048/zebra_dplane.c:2739:
Report for zebra_evpn.c | 53 issues
===============================================
WARNING: line over 80 characters
#119: FILE: /tmp/f1-16048/zebra_evpn.c:119:
+		vty_out(vty, " Tenant VRF: %s\n", vrf_id_to_name(zevpn->vrf_id));

WARNING: C99 // comments do not match recommendation
#127: FILE: /tmp/f1-16048/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-16048/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

WARNING: line over 80 characters
#150: FILE: /tmp/f1-16048/zebra_evpn.c:150:
+				       zevpn->advertise_gw_macip ? "Yes" : "No");

WARNING: quoted string split across lines
#188: FILE: /tmp/f1-16048/zebra_evpn.c:188:
+			" Number of ARPs (IPv4 and IPv6, local and remote) "
+			"known for this VNI: %u\n",

WARNING: Missing a blank line after declarations
#232: FILE: /tmp/f1-16048/zebra_evpn.c:232:
+		char vni_str[VNI_STR_LEN];
+		snprintf(vni_str, VNI_STR_LEN, "%u", zevpn->vni);

WARNING: void function return statements are not generally useful
#537: FILE: /tmp/f1-16048/zebra_evpn.c:537:
+	return;
+}

WARNING: void function return statements are not generally useful
#577: FILE: /tmp/f1-16048/zebra_evpn.c:577:
+	return;
+}

WARNING: void function return statements are not generally useful
#623: FILE: /tmp/f1-16048/zebra_evpn.c:623:
+	return;
+}

ERROR: return is not a function, parentheses are not required
#943: FILE: /tmp/f1-16048/zebra_evpn.c:943:
+	return (jhash_1word(zevpn->vni, 0));

WARNING: line over 80 characters
#1079: FILE: /tmp/f1-16048/zebra_evpn.c:1079:
+		zlog_debug("Send EVPN_ADD %u %s tenant vrf %s to %s", zevpn->vni,

ERROR: return is not a function, parentheses are not required
#1138: FILE: /tmp/f1-16048/zebra_evpn.c:1138:
+	return (IPV4_ADDR_SAME(vtep_ip, &zvtep->vtep_ip));
Report for zebra_evpn.h | 8 issues
===============================================
WARNING: do not add new typedefs
#41: FILE: /tmp/f1-16048/zebra_evpn.h:41:
+typedef struct zebra_evpn_t_ zebra_evpn_t;

WARNING: do not add new typedefs
#42: FILE: /tmp/f1-16048/zebra_evpn.h:42:
+typedef struct zebra_vtep_t_ zebra_vtep_t;
Report for zebra_evpn_mac.c | 19 issues
===============================================
WARNING: suspect code indent for conditional statements (24, 24)
#740: FILE: /tmp/f1-16048/zebra_evpn_mac.c:740:
+			if (json_mac_hdr == NULL)
+			vty_out(vty, " %-5s", "");

WARNING: line over 80 characters
#988: FILE: /tmp/f1-16048/zebra_evpn_mac.c:988:
+		zlog_warn("%s: MAC %s flags 0x%x neigh list not empty %d", __func__,

WARNING: void function return statements are not generally useful
#1070: FILE: /tmp/f1-16048/zebra_evpn_mac.c:1070:
+	return;
+}

WARNING: quoted string split across lines
#2002: FILE: /tmp/f1-16048/zebra_evpn_mac.c:2002:
+						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u%s, "
+						"entry exists and has not changed ",
Report for zebra_evpn_mac.h | 4 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-16048/zebra_evpn_mac.h:32:
+typedef struct zebra_mac_t_ zebra_mac_t;
Report for zebra_evpn_mh.c | 63 issues
===============================================
WARNING: line over 80 characters
#252: FILE: /tmp/f1-16048/zebra_evpn_mh.c:252:
+					es_evi->es->esi_str, es_evi->zevpn->vni);

ERROR: strcpy() is error-prone; please use strlcpy()#288: FILE: /tmp/f1-16048/zebra_evpn_mh.c:288:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#326: FILE: /tmp/f1-16048/zebra_evpn_mh.c:326:
+			strcpy(type_str + strlen(type_str), "L");

WARNING: Missing a blank line after declarations
#692: FILE: /tmp/f1-16048/zebra_evpn_mh.c:692:
+			zebra_evpn_t *old_zevpn = acc_bd->zevpn;
+			acc_bd->zevpn = NULL;

WARNING: unnecessary whitespace before a quoted newline
#803: FILE: /tmp/f1-16048/zebra_evpn_mh.c:803:
+		vty_out(vty, " Members: \n");

WARNING: suspect code indent for conditional statements (8, 8)
#1014: FILE: /tmp/f1-16048/zebra_evpn_mh.c:1014:
+	if (nh1 == NULL || nh2 == NULL)
+	return false;

WARNING: suspect code indent for conditional statements (8, 8)
#1035: FILE: /tmp/f1-16048/zebra_evpn_mh.c:1035:
+	if (es1 == NULL || es2 == NULL)
+	return false;

WARNING: line over 80 characters
#1092: FILE: /tmp/f1-16048/zebra_evpn_mh.c:1092:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#1103: FILE: /tmp/f1-16048/zebra_evpn_mh.c:1103:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

ERROR: strcpy() is error-prone; please use strlcpy()#2622: FILE: /tmp/f1-16048/zebra_evpn_mh.c:2622:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2624: FILE: /tmp/f1-16048/zebra_evpn_mh.c:2624:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2626: FILE: /tmp/f1-16048/zebra_evpn_mh.c:2626:
+			strcpy(type_str + strlen(type_str), "N");

ERROR: strcpy() is error-prone; please use strlcpy()#2690: FILE: /tmp/f1-16048/zebra_evpn_mh.c:2690:
+			strcpy(type_str + strlen(type_str), "Local");

ERROR: strcpy() is error-prone; please use strlcpy()#2693: FILE: /tmp/f1-16048/zebra_evpn_mh.c:2693:
+				strcpy(type_str + strlen(type_str), ",");

ERROR: strcpy() is error-prone; please use strlcpy()#2694: FILE: /tmp/f1-16048/zebra_evpn_mh.c:2694:
+			strcpy(type_str + strlen(type_str), "Remote");

WARNING: line over 80 characters
#2906: FILE: /tmp/f1-16048/zebra_evpn_mh.c:2906:
+			vty_out(vty, "%%ESI already exists on a different interface\n");

WARNING: line over 80 characters
#3153: FILE: /tmp/f1-16048/zebra_evpn_mh.c:3153:
+		((struct zebra_if *)zif->bondslave_info.bond_if->info)->es_info.es;
Report for zebra_evpn_mh.h | 4 issues
===============================================
WARNING: function definition argument 'ZAPI_HANDLER_ARGS' should also have an identifier name
#295: FILE: /tmp/f1-16048/zebra_evpn_mh.h:295:
+extern void zebra_evpn_proc_remote_es(ZAPI_HANDLER_ARGS);
Report for zebra_evpn_neigh.c | 5 issues
===============================================
WARNING: void function return statements are not generally useful
#914: FILE: /tmp/f1-16048/zebra_evpn_neigh.c:914:
+	return;
+}
Report for zebra_evpn_neigh.h | 12 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-16048/zebra_evpn_neigh.h:32:
+typedef struct zebra_neigh_t_ zebra_neigh_t;

ERROR: Macros with complex values should be enclosed in parentheses
#38: FILE: /tmp/f1-16048/zebra_evpn_neigh.h:38:
+#define ZEBRA_NEIGH_SET_ACTIVE(n) n->state = ZEBRA_NEIGH_ACTIVE

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: /tmp/f1-16048/zebra_evpn_neigh.h:40:
+#define ZEBRA_NEIGH_SET_INACTIVE(n) n->state = ZEBRA_NEIGH_INACTIVE
Report for zebra_l2.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #129: FILE: /tmp/f1-16048/zebra_l2.c:129:
Report for zebra_nhg.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #54: FILE: /tmp/f1-16048/zebra_nhg.c:54:
< ERROR: Bad function definition - uint32_t nhg_get_next_id() should probably be uint32_t nhg_get_next_id(void)
< #71: FILE: /tmp/f1-16048/zebra_nhg.c:71:
< WARNING: space prohibited between function name and open parenthesis '('
< #2700: FILE: /tmp/f1-16048/zebra_nhg.c:2700:
Report for zebra_vxlan.c | 15 issues
===============================================
< WARNING: line over 80 characters
< #3233: FILE: /tmp/f1-16048/zebra_vxlan.c:3233:
< WARNING: line over 80 characters
< #3281: FILE: /tmp/f1-16048/zebra_vxlan.c:3281:
< ERROR: strcpy() is error-prone; please use strlcpy()#3834: FILE: /tmp/f1-16048/zebra_vxlan.c:3834:
< +				strcpy(esi_buf, "-");
---
> WARNING: quoted string split across lines
> #8289: FILE: /tmp/f2-16048/zebra_vxlan.c:8289:
> +						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u, "
> +						"entry exists and has not changed ",
44c103
< #4178: FILE: /tmp/f1-16048/zebra_vxlan.c:4178:
< WARNING: line over 80 characters
< #4478: FILE: /tmp/f1-16048/zebra_vxlan.c:4478:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200608-01-gce4e1d061-0 (missing) -> 7.5-dev-20200608-01-gce4e1d061-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200608-01-gce4e1d061-0 (missing) -> 7.5-dev-20200608-01-gce4e1d061-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200608-01-gce4e1d061-0 (missing) -> 7.5-dev-20200608-01-gce4e1d061-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200608-01-gce4e1d061-0 (missing) -> 7.5-dev-20200608-01-gce4e1d061-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200608-01-gce4e1d061-0 (missing) -> 7.5-dev-20200608-01-gce4e1d061-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 6515, comparing to Git base SHA ce49c42
  • Base image data for Git ce49c42 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12565/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 8, 2020

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/6515 ce4e1d0
Date 06/08/2020
Start 15:38:06
Finish 16:03:59
Run-Time 25:53
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-06-08-15:38:06.txt
Log autoscript-2020-06-08-15:39:02.log.bz2
Memory 520 523 451

For details, please contact louberger

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
  • sprintf, strcat, strcpy are banned; please use snprintf, strlcat, strlcpy

If you are a new contributor to FRR, please see our contributing guidelines.

@srimohans srimohans self-requested a review June 9, 2020 15:46
@louberger
Copy link
Member

memory usage in LabN BGP CI increases significantly with this PR:
MASTER: 488 465 426 (this varies about 1-2% per run)
This PR: Memory | 520 523 451

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 9, 2020

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/6515 b612838
Date 06/09/2020
Start 11:25:27
Finish 11:51:27
Run-Time 26:00
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-06-09-11:25:27.txt
Log autoscript-2020-06-09-11:26:29.log.bz2
Memory 518 502 446

For details, please contact louberger

@louberger
Copy link
Member

memory usage in LabN BGP CI increases significantly with this PR:
MASTER: 488 465 426 (this varies about 1-2% per run)
This PR: Memory | 520 523 451

Similar results can bee seen for bgpds in topotest.
New results: from https://ci1.netdef.org/artifact/FRR-FRRPULLREQ/TP2U1804AMD64/build-12565/TestExecutionLogs/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/summary.txt

130 ce1 BGPd heap: 7360 KiB --> 41 MiB (0.6728 KiB/vpn route) 1 0
131 ce1 Zebra heap: 8180 KiB --> 33 MiB (0.4964 KiB/vpn route) 1 0
132 ce2 BGPd heap: 7360 KiB --> 41 MiB (0.6728 KiB/vpn route) 1 0
133 ce2 Zebra heap: 8324 KiB --> 37 MiB (0.5735 KiB/vpn route) 1 0
134 ce3 BGPd heap: 7360 KiB --> 36 MiB (0.5728 KiB/vpn route) 1 0
135 ce3 Zebra heap: 7376 KiB --> 31 MiB (0.4725 KiB/vpn route) 1 0
136 r1 BGPd heap: 7640 KiB --> 223 MiB (4.3072 KiB/vpn route) 1 0
137 r1 Zebra heap: 9944 KiB --> 34 MiB (0.4811 KiB/vpn route) 1 0
138 r2 BGPd heap: 7640 KiB --> 205 MiB (3.9472 KiB/vpn route) 1 0
139 r2 Zebra heap: 9980 KiB --> 9980 KiB (0.0 KiB/vpn route) 1 0
140 r3 BGPd heap: 7640 KiB --> 225 MiB (4.3472 KiB/vpn route) 1 0
141 r3 Zebra heap: 9948 KiB --> 35 MiB (0.501 KiB/vpn route) 1 0
142 r4 BGPd heap: 7908 KiB --> 349 MiB (6.8218 KiB/vpn route) 1 0
143 r4 Zebra heap: 9952 KiB --> 58 MiB (0.961 KiB/vpn route) 1 0

Current master: https://ci1.netdef.org/download/FRR-FRR-TOPO2U18AMD64/build_logs/FRR-FRR-TOPO2U18AMD64-3377.log

build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,878 INFO: 130 ce1 BGPd heap: 7372 KiB --> 41 MiB (0.6726 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,878 INFO: 131 ce1 Zebra heap: 8128 KiB --> 34 MiB (0.5174 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,878 INFO: 132 ce2 BGPd heap: 7372 KiB --> 41 MiB (0.6726 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,878 INFO: 133 ce2 Zebra heap: 7984 KiB --> 65 MiB (1.1403 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,878 INFO: 134 ce3 BGPd heap: 7372 KiB --> 36 MiB (0.5726 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,878 INFO: 135 ce3 Zebra heap: 7324 KiB --> 31 MiB (0.4735 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,878 INFO: 136 r1 BGPd heap: 7648 KiB --> 216 MiB (4.167 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,879 INFO: 137 r1 Zebra heap: 9892 KiB --> 33 MiB (0.4622 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,879 INFO: 138 r2 BGPd heap: 7520 KiB --> 197 MiB (3.7896 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,879 INFO: 139 r2 Zebra heap: 9892 KiB --> 9892 KiB (0.0 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,879 INFO: 140 r3 BGPd heap: 7648 KiB --> 218 MiB (4.207 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,879 INFO: 141 r3 Zebra heap: 9752 KiB --> 33 MiB (0.465 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,879 INFO: 142 r4 BGPd heap: 7964 KiB --> 335 MiB (6.5407 KiB/vpn route) 1 0
build 09-Jun-2020 05:41:22 2020-06-09 12:41:22,879 INFO: 143 r4 Zebra heap: 10060 KiB --> 59 MiB (0.9788 KiB/vpn route) 1 0

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 9, 2020

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12585/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-09 18:28:33,381 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:28:33,383 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:28:35,425 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:28:35,427 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:28:37,487 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:28:39,543 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:28:41,602 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:28:41,605 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:33:54,406 ERROR: 'router_json_cmp' failed after 76.85 seconds
2020-06-09 18:33:54,408 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12585/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-09 16:17:31,679 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-09 16:20:16,183 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-09 16:20:16,437 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-09 16:34:38,879 ERROR: '_bgp_has_routes' failed after 38.24 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12585/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-09 18:25:40,006 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:25:40,010 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:25:42,085 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:25:42,088 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:25:44,161 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:25:46,221 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:25:48,288 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:25:48,291 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:31:12,443 ERROR: 'router_json_cmp' failed after 81.73 seconds
2020-06-09 18:31:12,446 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-09 18:39:18,858 ERROR: 'router_json_cmp' failed after 108.42 seconds
2020-06-09 18:39:18,862 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details) Topo tests part 2 on Ubuntu 18.04 amd64: No useful log found
Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12585/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-09 16:26:06,714 ERROR: 'router_json_cmp' failed after 6.62 seconds
2020-06-09 16:26:06,715 ERROR: assert failed at "test_bgp-vrf-route-leak-basic/test_vrf_route_leak": BGP VRF DONNA check failed:
  Generated JSON diff error report:
  
  
  > $: d2 has key '10.0.1.0/24' which is not present in d1
  > $: d2 has key '10.0.3.0/24' which is not present in d1
  
  
assert False
2020-06-09 16:28:31,011 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 16:28:31,015 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:28:33,079 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 16:28:33,082 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:28:35,136 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:28:37,212 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:28:39,259 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 16:28:39,262 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:33:53,065 ERROR: 'router_json_cmp' failed after 76.95 seconds
2020-06-09 16:33:53,066 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12585/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-09 18:17:17,862 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-09 18:20:06,775 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-09 18:20:07,090 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-09 18:35:18,333 ERROR: '_bgp_has_routes' failed after 40.22 seconds
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12585/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-09 18:17:40,379 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-09 18:20:33,549 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-09 18:20:33,784 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-09 18:36:56,814 ERROR: '_bgp_has_routes' failed after 37.94 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Addresssanitizer topotests part 0
  • IPv4 ldp protocol on Ubuntu 18.04
  • Debian 8 deb pkg check
  • Addresssanitizer topotests part 2
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Debian 9 deb pkg check
  • Debian 10 deb pkg check
  • CentOS 7 rpm pkg check
  • Static analyzer (clang)
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • IPv6 protocols on Ubuntu 18.04
  • Topo tests part 2 on Ubuntu 16.04 i386
  • Fedora 29 rpm pkg check
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 1

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12585/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-09 18:28:33,381 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:28:33,383 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:28:35,425 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:28:35,427 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:28:37,487 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:28:39,543 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:28:41,602 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:28:41,605 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:33:54,406 ERROR: 'router_json_cmp' failed after 76.85 seconds
2020-06-09 18:33:54,408 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12585/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-09 16:17:31,679 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-09 16:20:16,183 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-09 16:20:16,437 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-09 16:34:38,879 ERROR: '_bgp_has_routes' failed after 38.24 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12585/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-09 18:25:40,006 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:25:40,010 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:25:42,085 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:25:42,088 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:25:44,161 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:25:46,221 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:25:48,288 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 18:25:48,291 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 18:31:12,443 ERROR: 'router_json_cmp' failed after 81.73 seconds
2020-06-09 18:31:12,446 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-09 18:39:18,858 ERROR: 'router_json_cmp' failed after 108.42 seconds
2020-06-09 18:39:18,862 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details) Topo tests part 2 on Ubuntu 18.04 amd64: No useful log found
Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12585/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-09 16:26:06,714 ERROR: 'router_json_cmp' failed after 6.62 seconds
2020-06-09 16:26:06,715 ERROR: assert failed at "test_bgp-vrf-route-leak-basic/test_vrf_route_leak": BGP VRF DONNA check failed:
  Generated JSON diff error report:
  
  
  > $: d2 has key '10.0.1.0/24' which is not present in d1
  > $: d2 has key '10.0.3.0/24' which is not present in d1
  
  
assert False
2020-06-09 16:28:31,011 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 16:28:31,015 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:28:33,079 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 16:28:33,082 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:28:35,136 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:28:37,212 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:28:39,259 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-09 16:28:39,262 ERROR: BGPd StdErr Log:neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

2020-06-09 16:33:53,065 ERROR: 'router_json_cmp' failed after 76.95 seconds
2020-06-09 16:33:53,066 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12585/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-09 18:17:17,862 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-09 18:20:06,775 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-09 18:20:07,090 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-09 18:35:18,333 ERROR: '_bgp_has_routes' failed after 40.22 seconds
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12585/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

Failed check for StdErr Output on daemons:
r1 BGPd StdErr Output:
neighbor_nexthop_self_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
neighbor_nexthop_self_force_cmd[neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?
no_neighbor_nexthop_self_force_cmd[no neighbor <A.B.C.D|X:X::X:X|WORD> next-hop-self force]:
	node 38 (bgp evpn) already has this command installed.
	duplicate install_element call?

Known issue - IGNORING. See https://github.com/FRRouting/frr/issues/349
2020-06-09 18:17:40,379 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-09 18:20:33,549 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-09 18:20:33,784 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-09 18:36:56,814 ERROR: '_bgp_has_routes' failed after 37.94 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

<stdin>:11511: trailing whitespace.
        
<stdin>:11611: trailing whitespace.
    
<stdin>:12010: space before tab in indent.
 		return 0;
<stdin>:8573: new blank line at EOF.
+
<stdin>:11377: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Report for bgp_evpn.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2973: FILE: /tmp/f1-15593/bgp_evpn.c:2973:
< WARNING: line over 80 characters
< #3549: FILE: /tmp/f1-15593/bgp_evpn.c:3549:
< WARNING: line over 80 characters
< #3766: FILE: /tmp/f1-15593/bgp_evpn.c:3766:
Report for bgp_evpn_mh.c | 87 issues
===============================================
ERROR: strcpy() is error-prone; please use strlcpy()#1829: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1829:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1831: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1831:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1834: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1834:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1891: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1891:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1893: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1893:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1896: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1896:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1951: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1951:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#1953: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1953:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#1955: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1955:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#1962: FILE: /tmp/f1-15593/bgp_evpn_mh.c:1962:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2024: FILE: /tmp/f1-15593/bgp_evpn_mh.c:2024:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2026: FILE: /tmp/f1-15593/bgp_evpn_mh.c:2026:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2031: FILE: /tmp/f1-15593/bgp_evpn_mh.c:2031:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2053: FILE: /tmp/f1-15593/bgp_evpn_mh.c:2053:
+				strcpy(incons_str + strlen(incons_str),

ERROR: strcpy() is error-prone; please use strlcpy()#2056: FILE: /tmp/f1-15593/bgp_evpn_mh.c:2056:
+			strcpy(incons_str, "-");

WARNING: line over 80 characters
#2185: FILE: /tmp/f1-15593/bgp_evpn_mh.c:2185:
+	nh.type = v4_nhg ? NEXTHOP_TYPE_IPV4_IFINDEX : NEXTHOP_TYPE_IPV6_IFINDEX;

ERROR: strcpy() is error-prone; please use strlcpy()#2574: FILE: /tmp/f1-15593/bgp_evpn_mh.c:2574:
+			strcpy(flags_str + strlen(flags_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#3233: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3233:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#3235: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3235:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "V");

ERROR: strcpy() is error-prone; please use strlcpy()#3238: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3238:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#3318: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3318:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3320: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3320:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3322: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3322:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#3351: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3351:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3353: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3353:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3357: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3357:
+			strcpy(vtep_str, "-");

WARNING: line over 80 characters
#3461: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3461:
+			vty_out(vty, "Flags: L local, R remote, I inconsistent\n");

WARNING: line over 80 characters
#3462: FILE: /tmp/f1-15593/bgp_evpn_mh.c:3462:
+			vty_out(vty, "VTEP-Flags: E EAD-per-ES, V EAD-per-EVI\n");
Report for bgp_evpn_vty.c | 4 issues
===============================================
< ERROR: spaces required around that '?' (ctx:VxW)
< #3753: FILE: /tmp/f1-15593/bgp_evpn_vty.c:3753:
< ERROR: spaces required around that ':' (ctx:WxV)
< #3753: FILE: /tmp/f1-15593/bgp_evpn_vty.c:3753:
Report for bgp_nht.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1039: FILE: /tmp/f1-15593/bgp_nht.c:1039:
< ERROR: space required after that ',' (ctx:VxV)
< #1049: FILE: /tmp/f1-15593/bgp_nht.c:1049:
Report for bitfield.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #61: FILE: /tmp/f1-15593/bitfield.h:61:
Report for debug.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #114: FILE: /tmp/f1-15593/debug.c:114:
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#959: FILE: /tmp/f1-15593/if.c:959:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#962: FILE: /tmp/f2-15593/if.c:962:
103c103
< #1051: FILE: /tmp/f1-15593/if.c:1051:
Report for if_netlink.c | 10 issues
===============================================
< ERROR: code indent should use tabs where possible
< #680: FILE: /tmp/f1-15593/if_netlink.c:680:
< WARNING: please, no space before tabs
< #680: FILE: /tmp/f1-15593/if_netlink.c:680:
< WARNING: please, no spaces at the start of a line
< #680: FILE: /tmp/f1-15593/if_netlink.c:680:
< WARNING: line over 80 characters
< #1483: FILE: /tmp/f1-15593/if_netlink.c:1483:
< WARNING: line over 80 characters
< #1597: FILE: /tmp/f1-15593/if_netlink.c:1597:
Report for prefix.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #49: FILE: /tmp/f1-15593/prefix.h:49:
< WARNING: line over 80 characters
< #50: FILE: /tmp/f1-15593/prefix.h:50:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #78: FILE: /tmp/f1-15593/rt_netlink.c:78:
< WARNING: line over 80 characters
< #2706: FILE: /tmp/f1-15593/rt_netlink.c:2706:
< WARNING: Block comments should align the * on each line
< #3843: FILE: /tmp/f1-15593/rt_netlink.c:3843:
Report for sharp_nht.c | 8 issues
===============================================
< WARNING: void function return statements are not generally useful
< #112: FILE: /tmp/f1-15593/sharp_nht.c:112:
< WARNING: void function return statements are not generally useful
< #125: FILE: /tmp/f1-15593/sharp_nht.c:125:
< WARNING: void function return statements are not generally useful
< #138: FILE: /tmp/f1-15593/sharp_nht.c:138:
< WARNING: void function return statements are not generally useful
< #154: FILE: /tmp/f1-15593/sharp_nht.c:154:
Report for zapi_msg.c | 30 issues
===============================================
< WARNING: line over 80 characters
< #1571: FILE: /tmp/f1-15593/zapi_msg.c:1571:
< WARNING: line over 80 characters
< #1619: FILE: /tmp/f1-15593/zapi_msg.c:1619:
< WARNING: line over 80 characters
< #1661: FILE: /tmp/f1-15593/zapi_msg.c:1661:
< WARNING: line over 80 characters
< #1662: FILE: /tmp/f1-15593/zapi_msg.c:1662:
< WARNING: line over 80 characters
< #1663: FILE: /tmp/f1-15593/zapi_msg.c:1663:
< WARNING: line over 80 characters
< #1664: FILE: /tmp/f1-15593/zapi_msg.c:1664:
< WARNING: line over 80 characters
< #1670: FILE: /tmp/f1-15593/zapi_msg.c:1670:
< WARNING: line over 80 characters
< #1671: FILE: /tmp/f1-15593/zapi_msg.c:1671:
< WARNING: void function return statements are not generally useful
< #1715: FILE: /tmp/f1-15593/zapi_msg.c:1715:
< WARNING: C99 // comments do not match recommendation
< #1736: FILE: /tmp/f1-15593/zapi_msg.c:1736:
< WARNING: C99 // comments do not match recommendation
< #1737: FILE: /tmp/f1-15593/zapi_msg.c:1737:
< WARNING: C99 // comments do not match recommendation
< #1738: FILE: /tmp/f1-15593/zapi_msg.c:1738:
< WARNING: C99 // comments do not match recommendation
< #1770: FILE: /tmp/f1-15593/zapi_msg.c:1770:
< WARNING: braces {} are not necessary for any arm of this statement
< #1782: FILE: /tmp/f1-15593/zapi_msg.c:1782:
< WARNING: void function return statements are not generally useful
< #1794: FILE: /tmp/f1-15593/zapi_msg.c:1794:
Report for zclient.h | 6 issues
===============================================
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #332: FILE: /tmp/f1-15593/zclient.h:332:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #333: FILE: /tmp/f1-15593/zclient.h:333:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #355: FILE: /tmp/f1-15593/zclient.h:355:
Report for zebra_dplane.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2739: FILE: /tmp/f1-15593/zebra_dplane.c:2739:
Report for zebra_evpn.c | 53 issues
===============================================
WARNING: line over 80 characters
#119: FILE: /tmp/f1-15593/zebra_evpn.c:119:
+		vty_out(vty, " Tenant VRF: %s\n", vrf_id_to_name(zevpn->vrf_id));

WARNING: C99 // comments do not match recommendation
#127: FILE: /tmp/f1-15593/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-15593/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

WARNING: line over 80 characters
#150: FILE: /tmp/f1-15593/zebra_evpn.c:150:
+				       zevpn->advertise_gw_macip ? "Yes" : "No");

WARNING: quoted string split across lines
#188: FILE: /tmp/f1-15593/zebra_evpn.c:188:
+			" Number of ARPs (IPv4 and IPv6, local and remote) "
+			"known for this VNI: %u\n",

WARNING: Missing a blank line after declarations
#232: FILE: /tmp/f1-15593/zebra_evpn.c:232:
+		char vni_str[VNI_STR_LEN];
+		snprintf(vni_str, VNI_STR_LEN, "%u", zevpn->vni);

WARNING: void function return statements are not generally useful
#537: FILE: /tmp/f1-15593/zebra_evpn.c:537:
+	return;
+}

WARNING: void function return statements are not generally useful
#577: FILE: /tmp/f1-15593/zebra_evpn.c:577:
+	return;
+}

WARNING: void function return statements are not generally useful
#623: FILE: /tmp/f1-15593/zebra_evpn.c:623:
+	return;
+}

ERROR: return is not a function, parentheses are not required
#943: FILE: /tmp/f1-15593/zebra_evpn.c:943:
+	return (jhash_1word(zevpn->vni, 0));

WARNING: line over 80 characters
#1079: FILE: /tmp/f1-15593/zebra_evpn.c:1079:
+		zlog_debug("Send EVPN_ADD %u %s tenant vrf %s to %s", zevpn->vni,

ERROR: return is not a function, parentheses are not required
#1138: FILE: /tmp/f1-15593/zebra_evpn.c:1138:
+	return (IPV4_ADDR_SAME(vtep_ip, &zvtep->vtep_ip));
Report for zebra_evpn.h | 8 issues
===============================================
WARNING: do not add new typedefs
#41: FILE: /tmp/f1-15593/zebra_evpn.h:41:
+typedef struct zebra_evpn_t_ zebra_evpn_t;

WARNING: do not add new typedefs
#42: FILE: /tmp/f1-15593/zebra_evpn.h:42:
+typedef struct zebra_vtep_t_ zebra_vtep_t;
Report for zebra_evpn_mac.c | 19 issues
===============================================
WARNING: suspect code indent for conditional statements (24, 24)
#740: FILE: /tmp/f1-15593/zebra_evpn_mac.c:740:
+			if (json_mac_hdr == NULL)
+			vty_out(vty, " %-5s", "");

WARNING: line over 80 characters
#988: FILE: /tmp/f1-15593/zebra_evpn_mac.c:988:
+		zlog_warn("%s: MAC %s flags 0x%x neigh list not empty %d", __func__,

WARNING: void function return statements are not generally useful
#1070: FILE: /tmp/f1-15593/zebra_evpn_mac.c:1070:
+	return;
+}

WARNING: quoted string split across lines
#2002: FILE: /tmp/f1-15593/zebra_evpn_mac.c:2002:
+						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u%s, "
+						"entry exists and has not changed ",
Report for zebra_evpn_mac.h | 4 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-15593/zebra_evpn_mac.h:32:
+typedef struct zebra_mac_t_ zebra_mac_t;
Report for zebra_evpn_mh.c | 63 issues
===============================================
WARNING: line over 80 characters
#252: FILE: /tmp/f1-15593/zebra_evpn_mh.c:252:
+					es_evi->es->esi_str, es_evi->zevpn->vni);

ERROR: strcpy() is error-prone; please use strlcpy()#288: FILE: /tmp/f1-15593/zebra_evpn_mh.c:288:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#326: FILE: /tmp/f1-15593/zebra_evpn_mh.c:326:
+			strcpy(type_str + strlen(type_str), "L");

WARNING: Missing a blank line after declarations
#692: FILE: /tmp/f1-15593/zebra_evpn_mh.c:692:
+			zebra_evpn_t *old_zevpn = acc_bd->zevpn;
+			acc_bd->zevpn = NULL;

WARNING: unnecessary whitespace before a quoted newline
#803: FILE: /tmp/f1-15593/zebra_evpn_mh.c:803:
+		vty_out(vty, " Members: \n");

WARNING: suspect code indent for conditional statements (8, 8)
#1014: FILE: /tmp/f1-15593/zebra_evpn_mh.c:1014:
+	if (nh1 == NULL || nh2 == NULL)
+	return false;

WARNING: suspect code indent for conditional statements (8, 8)
#1035: FILE: /tmp/f1-15593/zebra_evpn_mh.c:1035:
+	if (es1 == NULL || es2 == NULL)
+	return false;

WARNING: line over 80 characters
#1092: FILE: /tmp/f1-15593/zebra_evpn_mh.c:1092:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#1103: FILE: /tmp/f1-15593/zebra_evpn_mh.c:1103:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

ERROR: strcpy() is error-prone; please use strlcpy()#2622: FILE: /tmp/f1-15593/zebra_evpn_mh.c:2622:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2624: FILE: /tmp/f1-15593/zebra_evpn_mh.c:2624:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2626: FILE: /tmp/f1-15593/zebra_evpn_mh.c:2626:
+			strcpy(type_str + strlen(type_str), "N");

ERROR: strcpy() is error-prone; please use strlcpy()#2690: FILE: /tmp/f1-15593/zebra_evpn_mh.c:2690:
+			strcpy(type_str + strlen(type_str), "Local");

ERROR: strcpy() is error-prone; please use strlcpy()#2693: FILE: /tmp/f1-15593/zebra_evpn_mh.c:2693:
+				strcpy(type_str + strlen(type_str), ",");

ERROR: strcpy() is error-prone; please use strlcpy()#2694: FILE: /tmp/f1-15593/zebra_evpn_mh.c:2694:
+			strcpy(type_str + strlen(type_str), "Remote");

WARNING: line over 80 characters
#2906: FILE: /tmp/f1-15593/zebra_evpn_mh.c:2906:
+			vty_out(vty, "%%ESI already exists on a different interface\n");

WARNING: line over 80 characters
#3153: FILE: /tmp/f1-15593/zebra_evpn_mh.c:3153:
+		((struct zebra_if *)zif->bondslave_info.bond_if->info)->es_info.es;
Report for zebra_evpn_mh.h | 4 issues
===============================================
WARNING: function definition argument 'ZAPI_HANDLER_ARGS' should also have an identifier name
#295: FILE: /tmp/f1-15593/zebra_evpn_mh.h:295:
+extern void zebra_evpn_proc_remote_es(ZAPI_HANDLER_ARGS);
Report for zebra_evpn_neigh.c | 5 issues
===============================================
WARNING: void function return statements are not generally useful
#914: FILE: /tmp/f1-15593/zebra_evpn_neigh.c:914:
+	return;
+}
Report for zebra_evpn_neigh.h | 12 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-15593/zebra_evpn_neigh.h:32:
+typedef struct zebra_neigh_t_ zebra_neigh_t;

ERROR: Macros with complex values should be enclosed in parentheses
#38: FILE: /tmp/f1-15593/zebra_evpn_neigh.h:38:
+#define ZEBRA_NEIGH_SET_ACTIVE(n) n->state = ZEBRA_NEIGH_ACTIVE

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: /tmp/f1-15593/zebra_evpn_neigh.h:40:
+#define ZEBRA_NEIGH_SET_INACTIVE(n) n->state = ZEBRA_NEIGH_INACTIVE
Report for zebra_l2.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #129: FILE: /tmp/f1-15593/zebra_l2.c:129:
Report for zebra_nhg.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #54: FILE: /tmp/f1-15593/zebra_nhg.c:54:
< ERROR: Bad function definition - uint32_t nhg_get_next_id() should probably be uint32_t nhg_get_next_id(void)
< #71: FILE: /tmp/f1-15593/zebra_nhg.c:71:
< WARNING: space prohibited between function name and open parenthesis '('
< #2700: FILE: /tmp/f1-15593/zebra_nhg.c:2700:
Report for zebra_vxlan.c | 15 issues
===============================================
< WARNING: line over 80 characters
< #3233: FILE: /tmp/f1-15593/zebra_vxlan.c:3233:
< WARNING: line over 80 characters
< #3281: FILE: /tmp/f1-15593/zebra_vxlan.c:3281:
< ERROR: strcpy() is error-prone; please use strlcpy()#3834: FILE: /tmp/f1-15593/zebra_vxlan.c:3834:
< +				strcpy(esi_buf, "-");
---
> WARNING: quoted string split across lines
> #8289: FILE: /tmp/f2-15593/zebra_vxlan.c:8289:
> +						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u, "
> +						"entry exists and has not changed ",
44c103
< #4178: FILE: /tmp/f1-15593/zebra_vxlan.c:4178:
< WARNING: line over 80 characters
< #4478: FILE: /tmp/f1-15593/zebra_vxlan.c:4478:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200609-00-gb61283835-0 (missing) -> 7.5-dev-20200609-00-gb61283835-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200609-00-gb61283835-0 (missing) -> 7.5-dev-20200609-00-gb61283835-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200609-00-gb61283835-0 (missing) -> 7.5-dev-20200609-00-gb61283835-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200609-00-gb61283835-0 (missing) -> 7.5-dev-20200609-00-gb61283835-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200609-00-gb61283835-0 (missing) -> 7.5-dev-20200609-00-gb61283835-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 6515, comparing to Git base SHA ce49c42
  • Base image data for Git ce49c42 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12585/artifact/shared/static_analysis/index.html

Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
  • sprintf, strcat, strcpy are banned; please use snprintf, strlcat, strlcpy

If you are a new contributor to FRR, please see our contributing guidelines.

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Jun 10, 2020

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12608/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

2020-06-10 16:33:15,950 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-10 16:36:04,796 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-10 16:36:05,072 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-10 16:50:58,173 ERROR: '_bgp_has_routes' failed after 39.70 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12608/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-10 14:38:38,863 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 14:38:40,937 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 14:38:47,126 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 14:44:03,721 ERROR: 'router_json_cmp' failed after 78.77 seconds
2020-06-10 14:44:03,724 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12608/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

2020-06-10 14:30:50,572 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-10 14:33:29,972 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-10 14:33:30,262 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-10 14:48:14,343 ERROR: '_bgp_has_routes' failed after 38.63 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12608/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-10 16:38:53,042 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:38:55,115 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:39:01,316 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:44:25,238 ERROR: 'router_json_cmp' failed after 81.78 seconds
2020-06-10 16:44:25,241 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-10 16:52:31,091 ERROR: 'router_json_cmp' failed after 108.79 seconds
2020-06-10 16:52:31,095 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12608/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

2020-06-10 16:30:48,677 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-10 16:33:33,344 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-10 16:33:33,628 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-10 16:48:36,737 ERROR: '_bgp_has_routes' failed after 39.21 seconds
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12608/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-10 16:42:42,256 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:42:44,302 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:42:50,449 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:48:02,162 ERROR: 'router_json_cmp' failed after 76.83 seconds
2020-06-10 16:48:02,165 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Fedora 29 rpm pkg check
  • Debian 9 deb pkg check
  • Static analyzer (clang)
  • Ubuntu 18.04 deb pkg check
  • Ubuntu 20.04 deb pkg check
  • Ubuntu 16.04 deb pkg check
  • Topo tests part 2 on Ubuntu 16.04 i386
  • IPv6 protocols on Ubuntu 18.04
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 1
  • CentOS 7 rpm pkg check
  • Debian 10 deb pkg check
  • IPv4 ldp protocol on Ubuntu 18.04
  • Addresssanitizer topotests part 0
  • Topo tests part 2 on Ubuntu 18.04 amd64
  • Debian 8 deb pkg check
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • IPv4 protocols on Ubuntu 18.04

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12608/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

2020-06-10 16:33:15,950 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-10 16:36:04,796 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-10 16:36:05,072 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-10 16:50:58,173 ERROR: '_bgp_has_routes' failed after 39.70 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-12608/test

Topology Tests failed for Topo tests part 0 on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-10 14:38:38,863 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 14:38:40,937 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 14:38:47,126 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 14:44:03,721 ERROR: 'router_json_cmp' failed after 78.77 seconds
2020-06-10 14:44:03,724 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-12608/test

Topology Tests failed for Topo tests part 1 on Ubuntu 18.04 amd64:

2020-06-10 14:30:50,572 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
2020-06-10 14:33:29,972 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-10 14:33:30,262 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1804AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-10 14:48:14,343 ERROR: '_bgp_has_routes' failed after 38.63 seconds

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-12608/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-10 16:38:53,042 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:38:55,115 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:39:01,316 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:44:25,238 ERROR: 'router_json_cmp' failed after 81.78 seconds
2020-06-10 16:44:25,241 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
2020-06-10 16:52:31,091 ERROR: 'router_json_cmp' failed after 108.79 seconds
2020-06-10 16:52:31,095 ERROR: assert failed at "test_ldp_vpls_topo1/test_rib": "r1" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 110,
  	    "protocol": "ospf",
  	    "metric": 20,
  	    "selected": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "interfaceName": "r1-eth1",
  	            "ip": "10.0.1.2",
  	            "interfaceIndex": 3,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        },
  	        {
  	            "interfaceName": "r1-eth2",
  	            "ip": "10.0.2.3",
  	            "interfaceIndex": 4,
  	            "fib": true,
  	            "active": true,
  	            "afi": "ipv4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth1",
  		    "ip": "10.0.1.2",
  		    "interfaceIndex": 3,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 1 which is not present in d1: 
  	
  		{
  		    "interfaceName": "r1-eth2",
  		    "ip": "10.0.2.3",
  		    "interfaceIndex": 4,
  		    "fib": true,
  		    "active": true,
  		    "afi": "ipv4"
  		}
  	
  		Closest match in d1 is at index 1 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[1]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topo tests part 1 on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604I386-12608/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 i386:

2020-06-10 16:30:48,677 ERROR: assert failed at "test_all_protocol_startup/test_nexthop_groups_with_route_maps": Route 2.2.2.1/32 not installed with src 192.168.0.1
assert None is not None
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
2020-06-10 16:33:33,344 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-10 16:33:33,628 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604I386/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-10 16:48:36,737 ERROR: '_bgp_has_routes' failed after 39.21 seconds
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TP1U1604I386/ErrorLog/log_topotests.txt

Topo tests part 0 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-12608/test

Topology Tests failed for Topo tests part 0 on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2020-06-10 16:42:42,256 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:42:44,302 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:42:50,449 ERROR: PIMd StdErr Log:% No Path to RP address specified: 192.168.100.1

2020-06-10 16:48:02,162 ERROR: 'router_json_cmp' failed after 76.83 seconds
2020-06-10 16:48:02,165 ERROR: assert failed at "test_isis_sr_topo1/test_rib_ipv4_step10": "rt6" JSON output mismatches the expected result
assert Generated JSON diff error report:
  
  > $->10.0.2.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 30,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.2.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.2.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.2.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1
  	
  
  > $->10.0.3.0/24: d2 has the following element at index 0 which is not present in d1: 
  
  	{
  	    "distance": 115,
  	    "destSelected": true,
  	    "protocol": "isis",
  	    "metric": 20,
  	    "selected": true,
  	    "installed": true,
  	    "prefix": "10.0.3.0/24",
  	    "nexthops": [
  	        {
  	            "fib": true,
  	            "ip": "10.0.7.4",
  	            "active": true,
  	            "afi": "ipv4",
  	            "interfaceName": "eth-rt4"
  	        }
  	    ]
  	}
  
  	Closest match in d1 is at index 0 with the following errors: 
  
  	> $->10.0.3.0/24[0]->nexthops: d2 has the following element at index 0 which is not present in d1: 
  	
  		{
  		    "fib": true,
  		    "ip": "10.0.7.4",
  		    "active": true,
  		    "afi": "ipv4",
  		    "interfaceName": "eth-rt4"
  		}
  	
  		Closest match in d1 is at index 0 with the following errors: 
  	
  		> $->10.0.3.0/24[0]->nexthops[0]: d2 has key 'fib' which is not present in d1

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/TOPOU1604/ErrorLog/log_topotests.txt

<stdin>:11500: trailing whitespace.
        
<stdin>:11600: trailing whitespace.
    
<stdin>:11999: space before tab in indent.
 		return 0;
<stdin>:8573: new blank line at EOF.
+
<stdin>:11366: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Report for bgp_evpn.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2973: FILE: /tmp/f1-20991/bgp_evpn.c:2973:
< WARNING: line over 80 characters
< #3549: FILE: /tmp/f1-20991/bgp_evpn.c:3549:
< WARNING: line over 80 characters
< #3766: FILE: /tmp/f1-20991/bgp_evpn.c:3766:
Report for bgp_evpn_mh.c | 87 issues
===============================================
ERROR: strcpy() is error-prone; please use strlcpy()#1829: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1829:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1831: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1831:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1834: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1834:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1891: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1891:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#1893: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1893:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#1896: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1896:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#1951: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1951:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#1953: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1953:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#1955: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1955:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#1962: FILE: /tmp/f1-20991/bgp_evpn_mh.c:1962:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2024: FILE: /tmp/f1-20991/bgp_evpn_mh.c:2024:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2026: FILE: /tmp/f1-20991/bgp_evpn_mh.c:2026:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2031: FILE: /tmp/f1-20991/bgp_evpn_mh.c:2031:
+			strcpy(buf1, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#2053: FILE: /tmp/f1-20991/bgp_evpn_mh.c:2053:
+				strcpy(incons_str + strlen(incons_str),

ERROR: strcpy() is error-prone; please use strlcpy()#2056: FILE: /tmp/f1-20991/bgp_evpn_mh.c:2056:
+			strcpy(incons_str, "-");

WARNING: line over 80 characters
#2185: FILE: /tmp/f1-20991/bgp_evpn_mh.c:2185:
+	nh.type = v4_nhg ? NEXTHOP_TYPE_IPV4_IFINDEX : NEXTHOP_TYPE_IPV6_IFINDEX;

ERROR: strcpy() is error-prone; please use strlcpy()#2574: FILE: /tmp/f1-20991/bgp_evpn_mh.c:2574:
+			strcpy(flags_str + strlen(flags_str), "A");

ERROR: strcpy() is error-prone; please use strlcpy()#3233: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3233:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "E");

ERROR: strcpy() is error-prone; please use strlcpy()#3235: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3235:
+			strcpy(vtep_flag_str + strlen(vtep_flag_str), "V");

ERROR: strcpy() is error-prone; please use strlcpy()#3238: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3238:
+			strcpy(vtep_flag_str, "-");

ERROR: strcpy() is error-prone; please use strlcpy()#3318: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3318:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3320: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3320:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3322: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3322:
+			strcpy(type_str + strlen(type_str), "I");

ERROR: strcpy() is error-prone; please use strlcpy()#3351: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3351:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#3353: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3353:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#3357: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3357:
+			strcpy(vtep_str, "-");

WARNING: line over 80 characters
#3461: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3461:
+			vty_out(vty, "Flags: L local, R remote, I inconsistent\n");

WARNING: line over 80 characters
#3462: FILE: /tmp/f1-20991/bgp_evpn_mh.c:3462:
+			vty_out(vty, "VTEP-Flags: E EAD-per-ES, V EAD-per-EVI\n");
Report for bgp_evpn_vty.c | 4 issues
===============================================
< ERROR: spaces required around that '?' (ctx:VxW)
< #3753: FILE: /tmp/f1-20991/bgp_evpn_vty.c:3753:
< ERROR: spaces required around that ':' (ctx:WxV)
< #3753: FILE: /tmp/f1-20991/bgp_evpn_vty.c:3753:
Report for bgp_nht.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1039: FILE: /tmp/f1-20991/bgp_nht.c:1039:
< ERROR: space required after that ',' (ctx:VxV)
< #1049: FILE: /tmp/f1-20991/bgp_nht.c:1049:
Report for bitfield.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #61: FILE: /tmp/f1-20991/bitfield.h:61:
Report for debug.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #114: FILE: /tmp/f1-20991/debug.c:114:
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#959: FILE: /tmp/f1-20991/if.c:959:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#962: FILE: /tmp/f2-20991/if.c:962:
103c103
< #1051: FILE: /tmp/f1-20991/if.c:1051:
Report for if_netlink.c | 10 issues
===============================================
< ERROR: code indent should use tabs where possible
< #680: FILE: /tmp/f1-20991/if_netlink.c:680:
< WARNING: please, no space before tabs
< #680: FILE: /tmp/f1-20991/if_netlink.c:680:
< WARNING: please, no spaces at the start of a line
< #680: FILE: /tmp/f1-20991/if_netlink.c:680:
< WARNING: line over 80 characters
< #1483: FILE: /tmp/f1-20991/if_netlink.c:1483:
< WARNING: line over 80 characters
< #1597: FILE: /tmp/f1-20991/if_netlink.c:1597:
Report for prefix.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #49: FILE: /tmp/f1-20991/prefix.h:49:
< WARNING: line over 80 characters
< #50: FILE: /tmp/f1-20991/prefix.h:50:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #78: FILE: /tmp/f1-20991/rt_netlink.c:78:
< WARNING: line over 80 characters
< #2706: FILE: /tmp/f1-20991/rt_netlink.c:2706:
< WARNING: Block comments should align the * on each line
< #3843: FILE: /tmp/f1-20991/rt_netlink.c:3843:
Report for sharp_nht.c | 8 issues
===============================================
< WARNING: void function return statements are not generally useful
< #112: FILE: /tmp/f1-20991/sharp_nht.c:112:
< WARNING: void function return statements are not generally useful
< #125: FILE: /tmp/f1-20991/sharp_nht.c:125:
< WARNING: void function return statements are not generally useful
< #138: FILE: /tmp/f1-20991/sharp_nht.c:138:
< WARNING: void function return statements are not generally useful
< #154: FILE: /tmp/f1-20991/sharp_nht.c:154:
Report for zapi_msg.c | 30 issues
===============================================
< WARNING: line over 80 characters
< #1571: FILE: /tmp/f1-20991/zapi_msg.c:1571:
< WARNING: line over 80 characters
< #1619: FILE: /tmp/f1-20991/zapi_msg.c:1619:
< WARNING: line over 80 characters
< #1661: FILE: /tmp/f1-20991/zapi_msg.c:1661:
< WARNING: line over 80 characters
< #1662: FILE: /tmp/f1-20991/zapi_msg.c:1662:
< WARNING: line over 80 characters
< #1663: FILE: /tmp/f1-20991/zapi_msg.c:1663:
< WARNING: line over 80 characters
< #1664: FILE: /tmp/f1-20991/zapi_msg.c:1664:
< WARNING: line over 80 characters
< #1670: FILE: /tmp/f1-20991/zapi_msg.c:1670:
< WARNING: line over 80 characters
< #1671: FILE: /tmp/f1-20991/zapi_msg.c:1671:
< WARNING: void function return statements are not generally useful
< #1715: FILE: /tmp/f1-20991/zapi_msg.c:1715:
< WARNING: C99 // comments do not match recommendation
< #1736: FILE: /tmp/f1-20991/zapi_msg.c:1736:
< WARNING: C99 // comments do not match recommendation
< #1737: FILE: /tmp/f1-20991/zapi_msg.c:1737:
< WARNING: C99 // comments do not match recommendation
< #1738: FILE: /tmp/f1-20991/zapi_msg.c:1738:
< WARNING: C99 // comments do not match recommendation
< #1770: FILE: /tmp/f1-20991/zapi_msg.c:1770:
< WARNING: braces {} are not necessary for any arm of this statement
< #1782: FILE: /tmp/f1-20991/zapi_msg.c:1782:
< WARNING: void function return statements are not generally useful
< #1794: FILE: /tmp/f1-20991/zapi_msg.c:1794:
Report for zclient.h | 6 issues
===============================================
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #332: FILE: /tmp/f1-20991/zclient.h:332:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #333: FILE: /tmp/f1-20991/zclient.h:333:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #355: FILE: /tmp/f1-20991/zclient.h:355:
Report for zebra_dplane.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2739: FILE: /tmp/f1-20991/zebra_dplane.c:2739:
Report for zebra_evpn.c | 53 issues
===============================================
WARNING: line over 80 characters
#119: FILE: /tmp/f1-20991/zebra_evpn.c:119:
+		vty_out(vty, " Tenant VRF: %s\n", vrf_id_to_name(zevpn->vrf_id));

WARNING: C99 // comments do not match recommendation
#127: FILE: /tmp/f1-20991/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-20991/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

WARNING: line over 80 characters
#150: FILE: /tmp/f1-20991/zebra_evpn.c:150:
+				       zevpn->advertise_gw_macip ? "Yes" : "No");

WARNING: quoted string split across lines
#188: FILE: /tmp/f1-20991/zebra_evpn.c:188:
+			" Number of ARPs (IPv4 and IPv6, local and remote) "
+			"known for this VNI: %u\n",

WARNING: Missing a blank line after declarations
#232: FILE: /tmp/f1-20991/zebra_evpn.c:232:
+		char vni_str[VNI_STR_LEN];
+		snprintf(vni_str, VNI_STR_LEN, "%u", zevpn->vni);

WARNING: void function return statements are not generally useful
#537: FILE: /tmp/f1-20991/zebra_evpn.c:537:
+	return;
+}

WARNING: void function return statements are not generally useful
#577: FILE: /tmp/f1-20991/zebra_evpn.c:577:
+	return;
+}

WARNING: void function return statements are not generally useful
#623: FILE: /tmp/f1-20991/zebra_evpn.c:623:
+	return;
+}

ERROR: return is not a function, parentheses are not required
#943: FILE: /tmp/f1-20991/zebra_evpn.c:943:
+	return (jhash_1word(zevpn->vni, 0));

WARNING: line over 80 characters
#1079: FILE: /tmp/f1-20991/zebra_evpn.c:1079:
+		zlog_debug("Send EVPN_ADD %u %s tenant vrf %s to %s", zevpn->vni,

ERROR: return is not a function, parentheses are not required
#1138: FILE: /tmp/f1-20991/zebra_evpn.c:1138:
+	return (IPV4_ADDR_SAME(vtep_ip, &zvtep->vtep_ip));
Report for zebra_evpn.h | 8 issues
===============================================
WARNING: do not add new typedefs
#41: FILE: /tmp/f1-20991/zebra_evpn.h:41:
+typedef struct zebra_evpn_t_ zebra_evpn_t;

WARNING: do not add new typedefs
#42: FILE: /tmp/f1-20991/zebra_evpn.h:42:
+typedef struct zebra_vtep_t_ zebra_vtep_t;
Report for zebra_evpn_mac.c | 19 issues
===============================================
WARNING: suspect code indent for conditional statements (24, 24)
#740: FILE: /tmp/f1-20991/zebra_evpn_mac.c:740:
+			if (json_mac_hdr == NULL)
+			vty_out(vty, " %-5s", "");

WARNING: line over 80 characters
#988: FILE: /tmp/f1-20991/zebra_evpn_mac.c:988:
+		zlog_warn("%s: MAC %s flags 0x%x neigh list not empty %d", __func__,

WARNING: void function return statements are not generally useful
#1070: FILE: /tmp/f1-20991/zebra_evpn_mac.c:1070:
+	return;
+}

WARNING: quoted string split across lines
#2002: FILE: /tmp/f1-20991/zebra_evpn_mac.c:2002:
+						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u%s, "
+						"entry exists and has not changed ",
Report for zebra_evpn_mac.h | 4 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-20991/zebra_evpn_mac.h:32:
+typedef struct zebra_mac_t_ zebra_mac_t;
Report for zebra_evpn_mh.c | 63 issues
===============================================
WARNING: line over 80 characters
#252: FILE: /tmp/f1-20991/zebra_evpn_mh.c:252:
+					es_evi->es->esi_str, es_evi->zevpn->vni);

ERROR: strcpy() is error-prone; please use strlcpy()#288: FILE: /tmp/f1-20991/zebra_evpn_mh.c:288:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#326: FILE: /tmp/f1-20991/zebra_evpn_mh.c:326:
+			strcpy(type_str + strlen(type_str), "L");

WARNING: Missing a blank line after declarations
#692: FILE: /tmp/f1-20991/zebra_evpn_mh.c:692:
+			zebra_evpn_t *old_zevpn = acc_bd->zevpn;
+			acc_bd->zevpn = NULL;

WARNING: unnecessary whitespace before a quoted newline
#803: FILE: /tmp/f1-20991/zebra_evpn_mh.c:803:
+		vty_out(vty, " Members: \n");

WARNING: suspect code indent for conditional statements (8, 8)
#1014: FILE: /tmp/f1-20991/zebra_evpn_mh.c:1014:
+	if (nh1 == NULL || nh2 == NULL)
+	return false;

WARNING: suspect code indent for conditional statements (8, 8)
#1035: FILE: /tmp/f1-20991/zebra_evpn_mh.c:1035:
+	if (es1 == NULL || es2 == NULL)
+	return false;

WARNING: line over 80 characters
#1092: FILE: /tmp/f1-20991/zebra_evpn_mh.c:1092:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#1103: FILE: /tmp/f1-20991/zebra_evpn_mh.c:1103:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

ERROR: strcpy() is error-prone; please use strlcpy()#2622: FILE: /tmp/f1-20991/zebra_evpn_mh.c:2622:
+			strcpy(type_str + strlen(type_str), "L");

ERROR: strcpy() is error-prone; please use strlcpy()#2624: FILE: /tmp/f1-20991/zebra_evpn_mh.c:2624:
+			strcpy(type_str + strlen(type_str), "R");

ERROR: strcpy() is error-prone; please use strlcpy()#2626: FILE: /tmp/f1-20991/zebra_evpn_mh.c:2626:
+			strcpy(type_str + strlen(type_str), "N");

ERROR: strcpy() is error-prone; please use strlcpy()#2690: FILE: /tmp/f1-20991/zebra_evpn_mh.c:2690:
+			strcpy(type_str + strlen(type_str), "Local");

ERROR: strcpy() is error-prone; please use strlcpy()#2693: FILE: /tmp/f1-20991/zebra_evpn_mh.c:2693:
+				strcpy(type_str + strlen(type_str), ",");

ERROR: strcpy() is error-prone; please use strlcpy()#2694: FILE: /tmp/f1-20991/zebra_evpn_mh.c:2694:
+			strcpy(type_str + strlen(type_str), "Remote");

WARNING: line over 80 characters
#2906: FILE: /tmp/f1-20991/zebra_evpn_mh.c:2906:
+			vty_out(vty, "%%ESI already exists on a different interface\n");

WARNING: line over 80 characters
#3153: FILE: /tmp/f1-20991/zebra_evpn_mh.c:3153:
+		((struct zebra_if *)zif->bondslave_info.bond_if->info)->es_info.es;
Report for zebra_evpn_mh.h | 4 issues
===============================================
WARNING: function definition argument 'ZAPI_HANDLER_ARGS' should also have an identifier name
#295: FILE: /tmp/f1-20991/zebra_evpn_mh.h:295:
+extern void zebra_evpn_proc_remote_es(ZAPI_HANDLER_ARGS);
Report for zebra_evpn_neigh.c | 5 issues
===============================================
WARNING: void function return statements are not generally useful
#914: FILE: /tmp/f1-20991/zebra_evpn_neigh.c:914:
+	return;
+}
Report for zebra_evpn_neigh.h | 12 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-20991/zebra_evpn_neigh.h:32:
+typedef struct zebra_neigh_t_ zebra_neigh_t;

ERROR: Macros with complex values should be enclosed in parentheses
#38: FILE: /tmp/f1-20991/zebra_evpn_neigh.h:38:
+#define ZEBRA_NEIGH_SET_ACTIVE(n) n->state = ZEBRA_NEIGH_ACTIVE

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: /tmp/f1-20991/zebra_evpn_neigh.h:40:
+#define ZEBRA_NEIGH_SET_INACTIVE(n) n->state = ZEBRA_NEIGH_INACTIVE
Report for zebra_l2.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #129: FILE: /tmp/f1-20991/zebra_l2.c:129:
Report for zebra_nhg.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #54: FILE: /tmp/f1-20991/zebra_nhg.c:54:
< ERROR: Bad function definition - uint32_t nhg_get_next_id() should probably be uint32_t nhg_get_next_id(void)
< #71: FILE: /tmp/f1-20991/zebra_nhg.c:71:
< WARNING: space prohibited between function name and open parenthesis '('
< #2700: FILE: /tmp/f1-20991/zebra_nhg.c:2700:
Report for zebra_vxlan.c | 15 issues
===============================================
< WARNING: line over 80 characters
< #3233: FILE: /tmp/f1-20991/zebra_vxlan.c:3233:
< WARNING: line over 80 characters
< #3281: FILE: /tmp/f1-20991/zebra_vxlan.c:3281:
< ERROR: strcpy() is error-prone; please use strlcpy()#3834: FILE: /tmp/f1-20991/zebra_vxlan.c:3834:
< +				strcpy(esi_buf, "-");
---
> WARNING: quoted string split across lines
> #8289: FILE: /tmp/f2-20991/zebra_vxlan.c:8289:
> +						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u, "
> +						"entry exists and has not changed ",
44c103
< #4178: FILE: /tmp/f1-20991/zebra_vxlan.c:4178:
< WARNING: line over 80 characters
< #4478: FILE: /tmp/f1-20991/zebra_vxlan.c:4478:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-00-g8bc74ee70-0 (missing) -> 7.5-dev-20200610-00-g8bc74ee70-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-00-g8bc74ee70-0 (missing) -> 7.5-dev-20200610-00-g8bc74ee70-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-00-g8bc74ee70-0 (missing) -> 7.5-dev-20200610-00-g8bc74ee70-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-00-g8bc74ee70-0 (missing) -> 7.5-dev-20200610-00-g8bc74ee70-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200610-00-g8bc74ee70-0 (missing) -> 7.5-dev-20200610-00-g8bc74ee70-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 6515, comparing to Git base SHA ce49c42
  • Base image data for Git ce49c42 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12608/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 10, 2020

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/6515 8bc74ee
Date 06/10/2020
Start 12:26:38
Finish 12:52:38
Run-Time 26:00
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-06-10-12:26:38.txt
Log autoscript-2020-06-10-12:27:36.log.bz2
Memory 506 522 451

For details, please contact louberger

pguibert6WIND and others added 21 commits June 15, 2020 16:36
MAC address neighbours are read on the same netnamespace where the vxlan
interface is.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
the walk routine is used by vxlan service to identify some contexts in
each specific network namespace, when vrf netns backend is used. that
walk mechanism is extended with some additional paramters to the walk
routine.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
nexthop may sometimes not be passed through zebra, like for onlink
messages.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
…r netns

this is used when parsing the newly network namespaces. actually, to
track the link of some interfaces like vxlan interfaces, both link index
and link nsid are necessary. if a vxlan interface is moved to a new
netns, the link information is in the default network namespace, then
LINK_NSID is the value of the netns by default in the new netns. That
value of the default netns in the new netns is not known, because the
system does not automatically assign an NSID of default network
namespace in the new netns. Now a new NSID of default netns, seen from
that new netns, is created. This permits to store at netns creation the
default netns relative value for further usage.
Because the default netns value is set from the new netns perspective,
it is not needed anymore to use the NETNSA_TARGET_NSID attribute only
available in recent kernels.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
a linux configuration gives some explanation on how to set up an evpn
overlay in network namespaces.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
mac vlan interfaces are supported in different network namespaces.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
this test checks connectivity between a vrf-lite device and a vrf-netns
device. this ensures that evpn serice is importing appropriate evpn rt5
entries in the correct vrf.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Found that the command "evpn mh neigh-holdtime" can be set but
not deleted.  This fix solves the delete process

Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
This reverts commit e3c5c36.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Added description and config commands for the various sub-features
introduced as a part of EVPN Multihoming.

Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
bridge-utils package is not available on tested distributions.
use ip link instead.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
When a local mac is deleted by the dataplane zebra can re-install it
if the MAC is a SYNC MAC (learned from ES peers). The "local_inactive"
bit must be set as a part of the re-install to prevent zebra turning
around and advertising the MAC as locally active.

Also fixed up some debug logs in the slow-fail path to include the VNI.

Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
…atic

As a part of extended MM handing a MAC can be updated from local
to remote while being referenced by SYNC neighs (this is really a
temporary/small window). During this window if the MAC transitions
back to local again we need to re-inforce the previous SYNC flags
(based on the sync-neigh count) as subsequent SYNC updates to the
MAC will be de-duped and ignored.

Ticket: CM-29636

Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com>
if kernel is less than 4.18, then test will not run.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
[no_]neighbor_nexthop_self_cmd & [no_]neighbor_nexthop_self_force_cmd
have duplicate install_element actions on the EVPN_NODE. This causes
duplicate command log errors which are caught by topotests. Remove
these.

Signed-off-by: Pat Ruddy <pat@voltanet.io>
replace these with safe copy functions srlcpy, strlcat, strnlen
and snprintf.

Signed-off-by: Pat Ruddy <pat@voltanet.io>
The code was installing the nexthop group again using
the NLM_F_REPLACE function causing extremely large
route installation times.  This reduces the time from
installing 1 million routes from sharpd with a nhg
from > 200 seconds ( where I gave up ) to ~15
seconds on my machine for 32 x ecmp.  As a side note 1 million
routes using master sharpd takes ~50 seconds to do
the same thing.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
When the dataplane detects that we have no need to
reinstall the same route, setup the NEXTHOP_FLAG_FIB
appropriately.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Make the message parameters align better with other zapi
notifications and change the ID to correctly be a uint32.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
We currently don't support ADD/DEL/REPLACE with proto-based
NHGs that are not already fully resolved and ifindex/onlink
based. If we are handed one that doesn't have ifindex set
i.e. recursive, gracefully fail and with a notification.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
Implement handling of NHG notifications in sharpd so that
the routes don't attempt to use an NHG ID that did not
successfully get created. If it does not get installed, we
fall back to traditional zapi messaging.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
Copy link

@polychaeta polychaeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to FRR!

  • One of your commits has a missing or badly formatted Signed-off-by line; we can't accept your contribution until all of your commits have one
  • sprintf, strcat, strcpy are banned; please use snprintf, strlcat, strlcpy

If you are a new contributor to FRR, please see our contributing guidelines.

@AnuradhaKaruppiah
Copy link
Contributor Author

AnuradhaKaruppiah commented Jun 15, 2020

Based on the discussions in the review meeting we will break this PR up into five separate PRs -

  1. PR-1 (30 commits) - EVPN-MH infra; includes the following sub-features - [mh-prep, EAD, SYNC]
    PS: netns changes will be reverted as a part of [mh-prep]
  2. PR-2 (40 commits) - L3NHG infra work
  3. PR-3 (18 commits) - EVPN refactoring for mpls - [refactor-prep, refactor]
  4. PR-4 (~50 commits) - Remaining EVPN MH work - [DF, IRB, feature-fixes]
  5. PR-5 (21 commits) - netns re-work - [netns]

I will send out PR-1 shortly and link it to this PR (for anybody who wants to see what else is in the pipeline).

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12695/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
<stdin>:11585: trailing whitespace.
        
<stdin>:11685: trailing whitespace.
    
<stdin>:12084: space before tab in indent.
 		return 0;
<stdin>:8569: new blank line at EOF.
+
<stdin>:11451: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Report for bgp_evpn.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2973: FILE: /tmp/f1-21068/bgp_evpn.c:2973:
< WARNING: line over 80 characters
< #3549: FILE: /tmp/f1-21068/bgp_evpn.c:3549:
< WARNING: line over 80 characters
< #3766: FILE: /tmp/f1-21068/bgp_evpn.c:3766:
Report for bgp_evpn_mh.c | 12 issues
===============================================
WARNING: line over 80 characters
#2185: FILE: /tmp/f1-21068/bgp_evpn_mh.c:2185:
+	nh.type = v4_nhg ? NEXTHOP_TYPE_IPV4_IFINDEX : NEXTHOP_TYPE_IPV6_IFINDEX;

WARNING: line over 80 characters
#3460: FILE: /tmp/f1-21068/bgp_evpn_mh.c:3460:
+			vty_out(vty, "Flags: L local, R remote, I inconsistent\n");

WARNING: line over 80 characters
#3461: FILE: /tmp/f1-21068/bgp_evpn_mh.c:3461:
+			vty_out(vty, "VTEP-Flags: E EAD-per-ES, V EAD-per-EVI\n");
Report for bgp_evpn_vty.c | 4 issues
===============================================
< ERROR: spaces required around that '?' (ctx:VxW)
< #3753: FILE: /tmp/f1-21068/bgp_evpn_vty.c:3753:
< ERROR: spaces required around that ':' (ctx:WxV)
< #3753: FILE: /tmp/f1-21068/bgp_evpn_vty.c:3753:
Report for bgp_nht.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1039: FILE: /tmp/f1-21068/bgp_nht.c:1039:
< ERROR: space required after that ',' (ctx:VxV)
< #1049: FILE: /tmp/f1-21068/bgp_nht.c:1049:
Report for bitfield.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #61: FILE: /tmp/f1-21068/bitfield.h:61:
Report for debug.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #114: FILE: /tmp/f1-21068/debug.c:114:
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#965: FILE: /tmp/f1-21068/if.c:965:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#968: FILE: /tmp/f2-21068/if.c:968:
103c103
< #1057: FILE: /tmp/f1-21068/if.c:1057:
Report for if_netlink.c | 10 issues
===============================================
< ERROR: code indent should use tabs where possible
< #680: FILE: /tmp/f1-21068/if_netlink.c:680:
< WARNING: please, no space before tabs
< #680: FILE: /tmp/f1-21068/if_netlink.c:680:
< WARNING: please, no spaces at the start of a line
< #680: FILE: /tmp/f1-21068/if_netlink.c:680:
< WARNING: line over 80 characters
< #1490: FILE: /tmp/f1-21068/if_netlink.c:1490:
< WARNING: line over 80 characters
< #1604: FILE: /tmp/f1-21068/if_netlink.c:1604:
Report for prefix.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #49: FILE: /tmp/f1-21068/prefix.h:49:
< WARNING: line over 80 characters
< #50: FILE: /tmp/f1-21068/prefix.h:50:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #78: FILE: /tmp/f1-21068/rt_netlink.c:78:
< WARNING: line over 80 characters
< #2706: FILE: /tmp/f1-21068/rt_netlink.c:2706:
< WARNING: Block comments should align the * on each line
< #3843: FILE: /tmp/f1-21068/rt_netlink.c:3843:
Report for sharp_nht.c | 8 issues
===============================================
< WARNING: void function return statements are not generally useful
< #130: FILE: /tmp/f1-21068/sharp_nht.c:130:
< WARNING: void function return statements are not generally useful
< #143: FILE: /tmp/f1-21068/sharp_nht.c:143:
< WARNING: void function return statements are not generally useful
< #156: FILE: /tmp/f1-21068/sharp_nht.c:156:
< WARNING: void function return statements are not generally useful
< #172: FILE: /tmp/f1-21068/sharp_nht.c:172:
Report for zapi_msg.c | 30 issues
===============================================
< WARNING: line over 80 characters
< #1572: FILE: /tmp/f1-21068/zapi_msg.c:1572:
< WARNING: line over 80 characters
< #1620: FILE: /tmp/f1-21068/zapi_msg.c:1620:
< WARNING: line over 80 characters
< #1662: FILE: /tmp/f1-21068/zapi_msg.c:1662:
< WARNING: line over 80 characters
< #1663: FILE: /tmp/f1-21068/zapi_msg.c:1663:
< WARNING: line over 80 characters
< #1664: FILE: /tmp/f1-21068/zapi_msg.c:1664:
< WARNING: line over 80 characters
< #1665: FILE: /tmp/f1-21068/zapi_msg.c:1665:
< WARNING: line over 80 characters
< #1671: FILE: /tmp/f1-21068/zapi_msg.c:1671:
< WARNING: line over 80 characters
< #1672: FILE: /tmp/f1-21068/zapi_msg.c:1672:
< WARNING: void function return statements are not generally useful
< #1716: FILE: /tmp/f1-21068/zapi_msg.c:1716:
< WARNING: C99 // comments do not match recommendation
< #1737: FILE: /tmp/f1-21068/zapi_msg.c:1737:
< WARNING: C99 // comments do not match recommendation
< #1738: FILE: /tmp/f1-21068/zapi_msg.c:1738:
< WARNING: C99 // comments do not match recommendation
< #1739: FILE: /tmp/f1-21068/zapi_msg.c:1739:
< WARNING: C99 // comments do not match recommendation
< #1771: FILE: /tmp/f1-21068/zapi_msg.c:1771:
< WARNING: braces {} are not necessary for any arm of this statement
< #1783: FILE: /tmp/f1-21068/zapi_msg.c:1783:
< WARNING: void function return statements are not generally useful
< #1795: FILE: /tmp/f1-21068/zapi_msg.c:1795:
Report for zclient.h | 6 issues
===============================================
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #332: FILE: /tmp/f1-21068/zclient.h:332:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #333: FILE: /tmp/f1-21068/zclient.h:333:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #355: FILE: /tmp/f1-21068/zclient.h:355:
Report for zebra_dplane.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2967: FILE: /tmp/f1-21068/zebra_dplane.c:2967:
Report for zebra_evpn.c | 53 issues
===============================================
WARNING: line over 80 characters
#119: FILE: /tmp/f1-21068/zebra_evpn.c:119:
+		vty_out(vty, " Tenant VRF: %s\n", vrf_id_to_name(zevpn->vrf_id));

WARNING: C99 // comments do not match recommendation
#127: FILE: /tmp/f1-21068/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-21068/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

WARNING: line over 80 characters
#150: FILE: /tmp/f1-21068/zebra_evpn.c:150:
+				       zevpn->advertise_gw_macip ? "Yes" : "No");

WARNING: quoted string split across lines
#188: FILE: /tmp/f1-21068/zebra_evpn.c:188:
+			" Number of ARPs (IPv4 and IPv6, local and remote) "
+			"known for this VNI: %u\n",

WARNING: Missing a blank line after declarations
#232: FILE: /tmp/f1-21068/zebra_evpn.c:232:
+		char vni_str[VNI_STR_LEN];
+		snprintf(vni_str, VNI_STR_LEN, "%u", zevpn->vni);

WARNING: void function return statements are not generally useful
#537: FILE: /tmp/f1-21068/zebra_evpn.c:537:
+	return;
+}

WARNING: void function return statements are not generally useful
#577: FILE: /tmp/f1-21068/zebra_evpn.c:577:
+	return;
+}

WARNING: void function return statements are not generally useful
#623: FILE: /tmp/f1-21068/zebra_evpn.c:623:
+	return;
+}

ERROR: return is not a function, parentheses are not required
#943: FILE: /tmp/f1-21068/zebra_evpn.c:943:
+	return (jhash_1word(zevpn->vni, 0));

WARNING: line over 80 characters
#1079: FILE: /tmp/f1-21068/zebra_evpn.c:1079:
+		zlog_debug("Send EVPN_ADD %u %s tenant vrf %s to %s", zevpn->vni,

ERROR: return is not a function, parentheses are not required
#1138: FILE: /tmp/f1-21068/zebra_evpn.c:1138:
+	return (IPV4_ADDR_SAME(vtep_ip, &zvtep->vtep_ip));
Report for zebra_evpn.h | 8 issues
===============================================
WARNING: do not add new typedefs
#41: FILE: /tmp/f1-21068/zebra_evpn.h:41:
+typedef struct zebra_evpn_t_ zebra_evpn_t;

WARNING: do not add new typedefs
#42: FILE: /tmp/f1-21068/zebra_evpn.h:42:
+typedef struct zebra_vtep_t_ zebra_vtep_t;
Report for zebra_evpn_mac.c | 19 issues
===============================================
WARNING: suspect code indent for conditional statements (24, 24)
#740: FILE: /tmp/f1-21068/zebra_evpn_mac.c:740:
+			if (json_mac_hdr == NULL)
+			vty_out(vty, " %-5s", "");

WARNING: line over 80 characters
#988: FILE: /tmp/f1-21068/zebra_evpn_mac.c:988:
+		zlog_warn("%s: MAC %s flags 0x%x neigh list not empty %d", __func__,

WARNING: void function return statements are not generally useful
#1070: FILE: /tmp/f1-21068/zebra_evpn_mac.c:1070:
+	return;
+}

WARNING: quoted string split across lines
#2002: FILE: /tmp/f1-21068/zebra_evpn_mac.c:2002:
+						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u%s, "
+						"entry exists and has not changed ",
Report for zebra_evpn_mac.h | 4 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-21068/zebra_evpn_mac.h:32:
+typedef struct zebra_mac_t_ zebra_mac_t;
Report for zebra_evpn_mh.c | 43 issues
===============================================
WARNING: line over 80 characters
#252: FILE: /tmp/f1-21068/zebra_evpn_mh.c:252:
+					es_evi->es->esi_str, es_evi->zevpn->vni);

WARNING: Missing a blank line after declarations
#692: FILE: /tmp/f1-21068/zebra_evpn_mh.c:692:
+			zebra_evpn_t *old_zevpn = acc_bd->zevpn;
+			acc_bd->zevpn = NULL;

WARNING: unnecessary whitespace before a quoted newline
#803: FILE: /tmp/f1-21068/zebra_evpn_mh.c:803:
+		vty_out(vty, " Members: \n");

WARNING: suspect code indent for conditional statements (8, 8)
#1014: FILE: /tmp/f1-21068/zebra_evpn_mh.c:1014:
+	if (nh1 == NULL || nh2 == NULL)
+	return false;

WARNING: suspect code indent for conditional statements (8, 8)
#1035: FILE: /tmp/f1-21068/zebra_evpn_mh.c:1035:
+	if (es1 == NULL || es2 == NULL)
+	return false;

WARNING: line over 80 characters
#1092: FILE: /tmp/f1-21068/zebra_evpn_mh.c:1092:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#1103: FILE: /tmp/f1-21068/zebra_evpn_mh.c:1103:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#2419: FILE: /tmp/f1-21068/zebra_evpn_mh.c:2419:
+		 sizeof(mh_buf) - strnlen(mh_buf, sizeof(mh_buf)), "  EVPN-MH:");

WARNING: line over 80 characters
#2911: FILE: /tmp/f1-21068/zebra_evpn_mh.c:2911:
+			vty_out(vty, "%%ESI already exists on a different interface\n");

WARNING: line over 80 characters
#3158: FILE: /tmp/f1-21068/zebra_evpn_mh.c:3158:
+		((struct zebra_if *)zif->bondslave_info.bond_if->info)->es_info.es;
Report for zebra_evpn_mh.h | 4 issues
===============================================
WARNING: function definition argument 'ZAPI_HANDLER_ARGS' should also have an identifier name
#295: FILE: /tmp/f1-21068/zebra_evpn_mh.h:295:
+extern void zebra_evpn_proc_remote_es(ZAPI_HANDLER_ARGS);
Report for zebra_evpn_neigh.c | 5 issues
===============================================
WARNING: void function return statements are not generally useful
#914: FILE: /tmp/f1-21068/zebra_evpn_neigh.c:914:
+	return;
+}
Report for zebra_evpn_neigh.h | 12 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-21068/zebra_evpn_neigh.h:32:
+typedef struct zebra_neigh_t_ zebra_neigh_t;

ERROR: Macros with complex values should be enclosed in parentheses
#38: FILE: /tmp/f1-21068/zebra_evpn_neigh.h:38:
+#define ZEBRA_NEIGH_SET_ACTIVE(n) n->state = ZEBRA_NEIGH_ACTIVE

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: /tmp/f1-21068/zebra_evpn_neigh.h:40:
+#define ZEBRA_NEIGH_SET_INACTIVE(n) n->state = ZEBRA_NEIGH_INACTIVE
Report for zebra_l2.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #129: FILE: /tmp/f1-21068/zebra_l2.c:129:
Report for zebra_nhg.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #54: FILE: /tmp/f1-21068/zebra_nhg.c:54:
< ERROR: Bad function definition - uint32_t nhg_get_next_id() should probably be uint32_t nhg_get_next_id(void)
< #71: FILE: /tmp/f1-21068/zebra_nhg.c:71:
< WARNING: space prohibited between function name and open parenthesis '('
< #2710: FILE: /tmp/f1-21068/zebra_nhg.c:2710:
Report for zebra_vxlan.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #3233: FILE: /tmp/f1-21068/zebra_vxlan.c:3233:
< WARNING: line over 80 characters
< #3281: FILE: /tmp/f1-21068/zebra_vxlan.c:3281:
< WARNING: line over 80 characters
< #4478: FILE: /tmp/f1-21068/zebra_vxlan.c:4478:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12695/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-g8ab4c76ef-0 (missing) -> 7.5-dev-20200615-165-g8ab4c76ef-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-g8ab4c76ef-0 (missing) -> 7.5-dev-20200615-165-g8ab4c76ef-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-g8ab4c76ef-0 (missing) -> 7.5-dev-20200615-165-g8ab4c76ef-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-g8ab4c76ef-0 (missing) -> 7.5-dev-20200615-165-g8ab4c76ef-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-g8ab4c76ef-0 (missing) -> 7.5-dev-20200615-165-g8ab4c76ef-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 6515, comparing to Git base SHA c0757e8
  • Base image data for Git c0757e8 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12695/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 16, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/6515 98203bf
Date 06/15/2020
Start 19:43:03
Finish 20:09:00
Run-Time 25:57
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-06-15-19:43:03.txt
Log autoscript-2020-06-15-19:44:06.log.bz2
Memory 504 494 436

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12696/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12696/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

2020-06-16 01:01:17,565 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-16 01:01:17,836 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-16 01:16:20,757 ERROR: '_bgp_has_routes' failed after 39.68 seconds

r3: zebra crashed. Core file found - Backtrace follows:
[New LWP 17922]
[New LWP 17923]
[New LWP 17924]
[New LWP 17925]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007efe5a6a2428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7efe5b41c880 (LWP 17922))]
#0  0x00007efe5a6a2428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007efe5a6a402a in __GI_abort () at abort.c:89
#2  0x00007efe5b0e0940 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007efe5a76874d in poll () at ../sysdeps/unix/syscall-template.S:84
#5  0x00007efe5b0ee95c in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007efe5b0b877b in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x0000561d25618ea2 in main ()
2020-06-16 01:22:53,332 ERROR: assert failed at "test_ospf6_topo1/test_shutdown_check_stderr": 
r3: zebra crashed. Core file found - Backtrace follows:
[New LWP 17922]
[New LWP 17923]
[New LWP 17924]
[New LWP 17925]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007efe5a6a2428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7efe5b41c880 (LWP 17922))]
#0  0x00007efe5a6a2428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007efe5a6a402a in __GI_abort () at abort.c:89
#2  0x00007efe5b0e0940 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007efe5a76874d in poll () at ../sysdeps/unix/syscall-template.S:84
#5  0x00007efe5b0ee95c in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007efe5b0b877b in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x0000561d25618ea2 in main ()

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12696/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests
  • Static analyzer (clang)
  • Topo tests part 2 on Ubuntu 18.04 amd64
  • Topo tests part 2 on Ubuntu 16.04 amd64
  • Ubuntu 16.04 deb pkg check
  • Topo tests part 2 on Ubuntu 16.04 i386
  • Topo tests part 0 on Ubuntu 18.04 amd64
  • IPv6 protocols on Ubuntu 18.04
  • Fedora 29 rpm pkg check
  • Addresssanitizer topotests part 2
  • Addresssanitizer topotests part 1
  • Topo tests part 1 on Ubuntu 16.04 i386
  • IPv4 ldp protocol on Ubuntu 18.04
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 0
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 18.04
  • Ubuntu 20.04 deb pkg check
  • Topo tests part 0 on Ubuntu 16.04 amd64
  • Topo tests part 1 on Ubuntu 18.04 amd64
  • Debian 9 deb pkg check
  • Topo tests part 0 on Ubuntu 16.04 i386
  • CentOS 7 rpm pkg check
  • Debian 10 deb pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings
Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-12696/test

Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64:

2020-06-16 01:01:17,565 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: line 6: % Unknown command[27]: neighbor 10.0.0.13 remote-as 0 


2020-06-16 01:01:17,836 ERROR: Traceback (most recent call last):
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/bgp.py", line 190, in create_router_bgp
    tgen, router, data_all_bgp, "bgp", build, load_config
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 282, in create_common_configuration
    load_config_to_router(tgen, router)
  File "/root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TP1U1604AMD64/topotests/lib/common_config.py", line 542, in load_config_to_router
    raise InvalidCLIError("%s" % output)
InvalidCLIError: % No BGP process is configured
line 2: Failure to communicate[13] to bgpd, line: no router bgp  



2020-06-16 01:16:20,757 ERROR: '_bgp_has_routes' failed after 39.68 seconds

r3: zebra crashed. Core file found - Backtrace follows:
[New LWP 17922]
[New LWP 17923]
[New LWP 17924]
[New LWP 17925]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007efe5a6a2428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7efe5b41c880 (LWP 17922))]
#0  0x00007efe5a6a2428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007efe5a6a402a in __GI_abort () at abort.c:89
#2  0x00007efe5b0e0940 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007efe5a76874d in poll () at ../sysdeps/unix/syscall-template.S:84
#5  0x00007efe5b0ee95c in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007efe5b0b877b in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x0000561d25618ea2 in main ()
2020-06-16 01:22:53,332 ERROR: assert failed at "test_ospf6_topo1/test_shutdown_check_stderr": 
r3: zebra crashed. Core file found - Backtrace follows:
[New LWP 17922]
[New LWP 17923]
[New LWP 17924]
[New LWP 17925]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007efe5a6a2428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7efe5b41c880 (LWP 17922))]
#0  0x00007efe5a6a2428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007efe5a6a402a in __GI_abort () at abort.c:89
#2  0x00007efe5b0e0940 in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007efe5a76874d in poll () at ../sysdeps/unix/syscall-template.S:84
#5  0x00007efe5b0ee95c in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007efe5b0b877b in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x0000561d25618ea2 in main ()

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12696/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt

<stdin>:11585: trailing whitespace.
        
<stdin>:11685: trailing whitespace.
    
<stdin>:12084: space before tab in indent.
 		return 0;
<stdin>:8569: new blank line at EOF.
+
<stdin>:11451: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Report for bgp_evpn.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2973: FILE: /tmp/f1-31651/bgp_evpn.c:2973:
< WARNING: line over 80 characters
< #3549: FILE: /tmp/f1-31651/bgp_evpn.c:3549:
< WARNING: line over 80 characters
< #3766: FILE: /tmp/f1-31651/bgp_evpn.c:3766:
Report for bgp_evpn_mh.c | 12 issues
===============================================
WARNING: line over 80 characters
#2185: FILE: /tmp/f1-31651/bgp_evpn_mh.c:2185:
+	nh.type = v4_nhg ? NEXTHOP_TYPE_IPV4_IFINDEX : NEXTHOP_TYPE_IPV6_IFINDEX;

WARNING: line over 80 characters
#3460: FILE: /tmp/f1-31651/bgp_evpn_mh.c:3460:
+			vty_out(vty, "Flags: L local, R remote, I inconsistent\n");

WARNING: line over 80 characters
#3461: FILE: /tmp/f1-31651/bgp_evpn_mh.c:3461:
+			vty_out(vty, "VTEP-Flags: E EAD-per-ES, V EAD-per-EVI\n");
Report for bgp_evpn_vty.c | 4 issues
===============================================
< ERROR: spaces required around that '?' (ctx:VxW)
< #3753: FILE: /tmp/f1-31651/bgp_evpn_vty.c:3753:
< ERROR: spaces required around that ':' (ctx:WxV)
< #3753: FILE: /tmp/f1-31651/bgp_evpn_vty.c:3753:
Report for bgp_nht.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1039: FILE: /tmp/f1-31651/bgp_nht.c:1039:
< ERROR: space required after that ',' (ctx:VxV)
< #1049: FILE: /tmp/f1-31651/bgp_nht.c:1049:
Report for bitfield.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #61: FILE: /tmp/f1-31651/bitfield.h:61:
Report for debug.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #114: FILE: /tmp/f1-31651/debug.c:114:
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#965: FILE: /tmp/f1-31651/if.c:965:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#968: FILE: /tmp/f2-31651/if.c:968:
103c103
< #1057: FILE: /tmp/f1-31651/if.c:1057:
Report for if_netlink.c | 10 issues
===============================================
< ERROR: code indent should use tabs where possible
< #680: FILE: /tmp/f1-31651/if_netlink.c:680:
< WARNING: please, no space before tabs
< #680: FILE: /tmp/f1-31651/if_netlink.c:680:
< WARNING: please, no spaces at the start of a line
< #680: FILE: /tmp/f1-31651/if_netlink.c:680:
< WARNING: line over 80 characters
< #1490: FILE: /tmp/f1-31651/if_netlink.c:1490:
< WARNING: line over 80 characters
< #1604: FILE: /tmp/f1-31651/if_netlink.c:1604:
Report for prefix.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #49: FILE: /tmp/f1-31651/prefix.h:49:
< WARNING: line over 80 characters
< #50: FILE: /tmp/f1-31651/prefix.h:50:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #78: FILE: /tmp/f1-31651/rt_netlink.c:78:
< WARNING: line over 80 characters
< #2706: FILE: /tmp/f1-31651/rt_netlink.c:2706:
< WARNING: Block comments should align the * on each line
< #3843: FILE: /tmp/f1-31651/rt_netlink.c:3843:
Report for sharp_nht.c | 8 issues
===============================================
< WARNING: void function return statements are not generally useful
< #130: FILE: /tmp/f1-31651/sharp_nht.c:130:
< WARNING: void function return statements are not generally useful
< #143: FILE: /tmp/f1-31651/sharp_nht.c:143:
< WARNING: void function return statements are not generally useful
< #156: FILE: /tmp/f1-31651/sharp_nht.c:156:
< WARNING: void function return statements are not generally useful
< #172: FILE: /tmp/f1-31651/sharp_nht.c:172:
Report for zapi_msg.c | 30 issues
===============================================
< WARNING: line over 80 characters
< #1572: FILE: /tmp/f1-31651/zapi_msg.c:1572:
< WARNING: line over 80 characters
< #1620: FILE: /tmp/f1-31651/zapi_msg.c:1620:
< WARNING: line over 80 characters
< #1662: FILE: /tmp/f1-31651/zapi_msg.c:1662:
< WARNING: line over 80 characters
< #1663: FILE: /tmp/f1-31651/zapi_msg.c:1663:
< WARNING: line over 80 characters
< #1664: FILE: /tmp/f1-31651/zapi_msg.c:1664:
< WARNING: line over 80 characters
< #1665: FILE: /tmp/f1-31651/zapi_msg.c:1665:
< WARNING: line over 80 characters
< #1671: FILE: /tmp/f1-31651/zapi_msg.c:1671:
< WARNING: line over 80 characters
< #1672: FILE: /tmp/f1-31651/zapi_msg.c:1672:
< WARNING: void function return statements are not generally useful
< #1716: FILE: /tmp/f1-31651/zapi_msg.c:1716:
< WARNING: C99 // comments do not match recommendation
< #1737: FILE: /tmp/f1-31651/zapi_msg.c:1737:
< WARNING: C99 // comments do not match recommendation
< #1738: FILE: /tmp/f1-31651/zapi_msg.c:1738:
< WARNING: C99 // comments do not match recommendation
< #1739: FILE: /tmp/f1-31651/zapi_msg.c:1739:
< WARNING: C99 // comments do not match recommendation
< #1771: FILE: /tmp/f1-31651/zapi_msg.c:1771:
< WARNING: braces {} are not necessary for any arm of this statement
< #1783: FILE: /tmp/f1-31651/zapi_msg.c:1783:
< WARNING: void function return statements are not generally useful
< #1795: FILE: /tmp/f1-31651/zapi_msg.c:1795:
Report for zclient.h | 6 issues
===============================================
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #332: FILE: /tmp/f1-31651/zclient.h:332:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #333: FILE: /tmp/f1-31651/zclient.h:333:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #355: FILE: /tmp/f1-31651/zclient.h:355:
Report for zebra_dplane.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2967: FILE: /tmp/f1-31651/zebra_dplane.c:2967:
Report for zebra_evpn.c | 53 issues
===============================================
WARNING: line over 80 characters
#119: FILE: /tmp/f1-31651/zebra_evpn.c:119:
+		vty_out(vty, " Tenant VRF: %s\n", vrf_id_to_name(zevpn->vrf_id));

WARNING: C99 // comments do not match recommendation
#127: FILE: /tmp/f1-31651/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-31651/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

WARNING: line over 80 characters
#150: FILE: /tmp/f1-31651/zebra_evpn.c:150:
+				       zevpn->advertise_gw_macip ? "Yes" : "No");

WARNING: quoted string split across lines
#188: FILE: /tmp/f1-31651/zebra_evpn.c:188:
+			" Number of ARPs (IPv4 and IPv6, local and remote) "
+			"known for this VNI: %u\n",

WARNING: Missing a blank line after declarations
#232: FILE: /tmp/f1-31651/zebra_evpn.c:232:
+		char vni_str[VNI_STR_LEN];
+		snprintf(vni_str, VNI_STR_LEN, "%u", zevpn->vni);

WARNING: void function return statements are not generally useful
#537: FILE: /tmp/f1-31651/zebra_evpn.c:537:
+	return;
+}

WARNING: void function return statements are not generally useful
#577: FILE: /tmp/f1-31651/zebra_evpn.c:577:
+	return;
+}

WARNING: void function return statements are not generally useful
#623: FILE: /tmp/f1-31651/zebra_evpn.c:623:
+	return;
+}

ERROR: return is not a function, parentheses are not required
#943: FILE: /tmp/f1-31651/zebra_evpn.c:943:
+	return (jhash_1word(zevpn->vni, 0));

WARNING: line over 80 characters
#1079: FILE: /tmp/f1-31651/zebra_evpn.c:1079:
+		zlog_debug("Send EVPN_ADD %u %s tenant vrf %s to %s", zevpn->vni,

ERROR: return is not a function, parentheses are not required
#1138: FILE: /tmp/f1-31651/zebra_evpn.c:1138:
+	return (IPV4_ADDR_SAME(vtep_ip, &zvtep->vtep_ip));
Report for zebra_evpn.h | 8 issues
===============================================
WARNING: do not add new typedefs
#41: FILE: /tmp/f1-31651/zebra_evpn.h:41:
+typedef struct zebra_evpn_t_ zebra_evpn_t;

WARNING: do not add new typedefs
#42: FILE: /tmp/f1-31651/zebra_evpn.h:42:
+typedef struct zebra_vtep_t_ zebra_vtep_t;
Report for zebra_evpn_mac.c | 19 issues
===============================================
WARNING: suspect code indent for conditional statements (24, 24)
#740: FILE: /tmp/f1-31651/zebra_evpn_mac.c:740:
+			if (json_mac_hdr == NULL)
+			vty_out(vty, " %-5s", "");

WARNING: line over 80 characters
#988: FILE: /tmp/f1-31651/zebra_evpn_mac.c:988:
+		zlog_warn("%s: MAC %s flags 0x%x neigh list not empty %d", __func__,

WARNING: void function return statements are not generally useful
#1070: FILE: /tmp/f1-31651/zebra_evpn_mac.c:1070:
+	return;
+}

WARNING: quoted string split across lines
#2002: FILE: /tmp/f1-31651/zebra_evpn_mac.c:2002:
+						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u%s, "
+						"entry exists and has not changed ",
Report for zebra_evpn_mac.h | 4 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-31651/zebra_evpn_mac.h:32:
+typedef struct zebra_mac_t_ zebra_mac_t;
Report for zebra_evpn_mh.c | 43 issues
===============================================
WARNING: line over 80 characters
#252: FILE: /tmp/f1-31651/zebra_evpn_mh.c:252:
+					es_evi->es->esi_str, es_evi->zevpn->vni);

WARNING: Missing a blank line after declarations
#692: FILE: /tmp/f1-31651/zebra_evpn_mh.c:692:
+			zebra_evpn_t *old_zevpn = acc_bd->zevpn;
+			acc_bd->zevpn = NULL;

WARNING: unnecessary whitespace before a quoted newline
#803: FILE: /tmp/f1-31651/zebra_evpn_mh.c:803:
+		vty_out(vty, " Members: \n");

WARNING: suspect code indent for conditional statements (8, 8)
#1014: FILE: /tmp/f1-31651/zebra_evpn_mh.c:1014:
+	if (nh1 == NULL || nh2 == NULL)
+	return false;

WARNING: suspect code indent for conditional statements (8, 8)
#1035: FILE: /tmp/f1-31651/zebra_evpn_mh.c:1035:
+	if (es1 == NULL || es2 == NULL)
+	return false;

WARNING: line over 80 characters
#1092: FILE: /tmp/f1-31651/zebra_evpn_mh.c:1092:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#1103: FILE: /tmp/f1-31651/zebra_evpn_mh.c:1103:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#2419: FILE: /tmp/f1-31651/zebra_evpn_mh.c:2419:
+		 sizeof(mh_buf) - strnlen(mh_buf, sizeof(mh_buf)), "  EVPN-MH:");

WARNING: line over 80 characters
#2911: FILE: /tmp/f1-31651/zebra_evpn_mh.c:2911:
+			vty_out(vty, "%%ESI already exists on a different interface\n");

WARNING: line over 80 characters
#3158: FILE: /tmp/f1-31651/zebra_evpn_mh.c:3158:
+		((struct zebra_if *)zif->bondslave_info.bond_if->info)->es_info.es;
Report for zebra_evpn_mh.h | 4 issues
===============================================
WARNING: function definition argument 'ZAPI_HANDLER_ARGS' should also have an identifier name
#295: FILE: /tmp/f1-31651/zebra_evpn_mh.h:295:
+extern void zebra_evpn_proc_remote_es(ZAPI_HANDLER_ARGS);
Report for zebra_evpn_neigh.c | 5 issues
===============================================
WARNING: void function return statements are not generally useful
#914: FILE: /tmp/f1-31651/zebra_evpn_neigh.c:914:
+	return;
+}
Report for zebra_evpn_neigh.h | 12 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-31651/zebra_evpn_neigh.h:32:
+typedef struct zebra_neigh_t_ zebra_neigh_t;

ERROR: Macros with complex values should be enclosed in parentheses
#38: FILE: /tmp/f1-31651/zebra_evpn_neigh.h:38:
+#define ZEBRA_NEIGH_SET_ACTIVE(n) n->state = ZEBRA_NEIGH_ACTIVE

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: /tmp/f1-31651/zebra_evpn_neigh.h:40:
+#define ZEBRA_NEIGH_SET_INACTIVE(n) n->state = ZEBRA_NEIGH_INACTIVE
Report for zebra_l2.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #129: FILE: /tmp/f1-31651/zebra_l2.c:129:
Report for zebra_nhg.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #54: FILE: /tmp/f1-31651/zebra_nhg.c:54:
< ERROR: Bad function definition - uint32_t nhg_get_next_id() should probably be uint32_t nhg_get_next_id(void)
< #71: FILE: /tmp/f1-31651/zebra_nhg.c:71:
< WARNING: space prohibited between function name and open parenthesis '('
< #2710: FILE: /tmp/f1-31651/zebra_nhg.c:2710:
Report for zebra_vxlan.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #3233: FILE: /tmp/f1-31651/zebra_vxlan.c:3233:
< WARNING: line over 80 characters
< #3281: FILE: /tmp/f1-31651/zebra_vxlan.c:3281:
< WARNING: line over 80 characters
< #4478: FILE: /tmp/f1-31651/zebra_vxlan.c:4478:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12696/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-gd9a5c08da-0 (missing) -> 7.5-dev-20200615-165-gd9a5c08da-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-gd9a5c08da-0 (missing) -> 7.5-dev-20200615-165-gd9a5c08da-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-gd9a5c08da-0 (missing) -> 7.5-dev-20200615-165-gd9a5c08da-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-gd9a5c08da-0 (missing) -> 7.5-dev-20200615-165-gd9a5c08da-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-165-gd9a5c08da-0 (missing) -> 7.5-dev-20200615-165-gd9a5c08da-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 6515, comparing to Git base SHA c0757e8
  • Base image data for Git c0757e8 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12696/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12699/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
<stdin>:11585: trailing whitespace.
        
<stdin>:11685: trailing whitespace.
    
<stdin>:12084: space before tab in indent.
 		return 0;
<stdin>:8569: new blank line at EOF.
+
<stdin>:11451: new blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Report for bgp_evpn.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #2973: FILE: /tmp/f1-6116/bgp_evpn.c:2973:
< WARNING: line over 80 characters
< #3549: FILE: /tmp/f1-6116/bgp_evpn.c:3549:
< WARNING: line over 80 characters
< #3766: FILE: /tmp/f1-6116/bgp_evpn.c:3766:
Report for bgp_evpn_mh.c | 12 issues
===============================================
WARNING: line over 80 characters
#2185: FILE: /tmp/f1-6116/bgp_evpn_mh.c:2185:
+	nh.type = v4_nhg ? NEXTHOP_TYPE_IPV4_IFINDEX : NEXTHOP_TYPE_IPV6_IFINDEX;

WARNING: line over 80 characters
#3460: FILE: /tmp/f1-6116/bgp_evpn_mh.c:3460:
+			vty_out(vty, "Flags: L local, R remote, I inconsistent\n");

WARNING: line over 80 characters
#3461: FILE: /tmp/f1-6116/bgp_evpn_mh.c:3461:
+			vty_out(vty, "VTEP-Flags: E EAD-per-ES, V EAD-per-EVI\n");
Report for bgp_evpn_vty.c | 4 issues
===============================================
< ERROR: spaces required around that '?' (ctx:VxW)
< #3753: FILE: /tmp/f1-6116/bgp_evpn_vty.c:3753:
< ERROR: spaces required around that ':' (ctx:WxV)
< #3753: FILE: /tmp/f1-6116/bgp_evpn_vty.c:3753:
Report for bgp_nht.c | 4 issues
===============================================
< WARNING: Missing a blank line after declarations
< #1039: FILE: /tmp/f1-6116/bgp_nht.c:1039:
< ERROR: space required after that ',' (ctx:VxV)
< #1049: FILE: /tmp/f1-6116/bgp_nht.c:1049:
Report for bitfield.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #61: FILE: /tmp/f1-6116/bitfield.h:61:
Report for debug.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #114: FILE: /tmp/f1-6116/debug.c:114:
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#965: FILE: /tmp/f1-6116/if.c:965:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#968: FILE: /tmp/f2-6116/if.c:968:
103c103
< #1057: FILE: /tmp/f1-6116/if.c:1057:
Report for if_netlink.c | 10 issues
===============================================
< ERROR: code indent should use tabs where possible
< #680: FILE: /tmp/f1-6116/if_netlink.c:680:
< WARNING: please, no space before tabs
< #680: FILE: /tmp/f1-6116/if_netlink.c:680:
< WARNING: please, no spaces at the start of a line
< #680: FILE: /tmp/f1-6116/if_netlink.c:680:
< WARNING: line over 80 characters
< #1490: FILE: /tmp/f1-6116/if_netlink.c:1490:
< WARNING: line over 80 characters
< #1604: FILE: /tmp/f1-6116/if_netlink.c:1604:
Report for prefix.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #49: FILE: /tmp/f1-6116/prefix.h:49:
< WARNING: line over 80 characters
< #50: FILE: /tmp/f1-6116/prefix.h:50:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #78: FILE: /tmp/f1-6116/rt_netlink.c:78:
< WARNING: line over 80 characters
< #2706: FILE: /tmp/f1-6116/rt_netlink.c:2706:
< WARNING: Block comments should align the * on each line
< #3843: FILE: /tmp/f1-6116/rt_netlink.c:3843:
Report for sharp_nht.c | 8 issues
===============================================
< WARNING: void function return statements are not generally useful
< #130: FILE: /tmp/f1-6116/sharp_nht.c:130:
< WARNING: void function return statements are not generally useful
< #143: FILE: /tmp/f1-6116/sharp_nht.c:143:
< WARNING: void function return statements are not generally useful
< #156: FILE: /tmp/f1-6116/sharp_nht.c:156:
< WARNING: void function return statements are not generally useful
< #172: FILE: /tmp/f1-6116/sharp_nht.c:172:
Report for zapi_msg.c | 30 issues
===============================================
< WARNING: line over 80 characters
< #1572: FILE: /tmp/f1-6116/zapi_msg.c:1572:
< WARNING: line over 80 characters
< #1620: FILE: /tmp/f1-6116/zapi_msg.c:1620:
< WARNING: line over 80 characters
< #1662: FILE: /tmp/f1-6116/zapi_msg.c:1662:
< WARNING: line over 80 characters
< #1663: FILE: /tmp/f1-6116/zapi_msg.c:1663:
< WARNING: line over 80 characters
< #1664: FILE: /tmp/f1-6116/zapi_msg.c:1664:
< WARNING: line over 80 characters
< #1665: FILE: /tmp/f1-6116/zapi_msg.c:1665:
< WARNING: line over 80 characters
< #1671: FILE: /tmp/f1-6116/zapi_msg.c:1671:
< WARNING: line over 80 characters
< #1672: FILE: /tmp/f1-6116/zapi_msg.c:1672:
< WARNING: void function return statements are not generally useful
< #1716: FILE: /tmp/f1-6116/zapi_msg.c:1716:
< WARNING: C99 // comments do not match recommendation
< #1737: FILE: /tmp/f1-6116/zapi_msg.c:1737:
< WARNING: C99 // comments do not match recommendation
< #1738: FILE: /tmp/f1-6116/zapi_msg.c:1738:
< WARNING: C99 // comments do not match recommendation
< #1739: FILE: /tmp/f1-6116/zapi_msg.c:1739:
< WARNING: C99 // comments do not match recommendation
< #1771: FILE: /tmp/f1-6116/zapi_msg.c:1771:
< WARNING: braces {} are not necessary for any arm of this statement
< #1783: FILE: /tmp/f1-6116/zapi_msg.c:1783:
< WARNING: void function return statements are not generally useful
< #1795: FILE: /tmp/f1-6116/zapi_msg.c:1795:
Report for zclient.h | 6 issues
===============================================
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #332: FILE: /tmp/f1-6116/zclient.h:332:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #333: FILE: /tmp/f1-6116/zclient.h:333:
< WARNING: function definition argument 'ZAPI_CALLBACK_ARGS' should also have an identifier name
< #355: FILE: /tmp/f1-6116/zclient.h:355:
Report for zebra_dplane.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #2967: FILE: /tmp/f1-6116/zebra_dplane.c:2967:
Report for zebra_evpn.c | 53 issues
===============================================
WARNING: line over 80 characters
#119: FILE: /tmp/f1-6116/zebra_evpn.c:119:
+		vty_out(vty, " Tenant VRF: %s\n", vrf_id_to_name(zevpn->vrf_id));

WARNING: C99 // comments do not match recommendation
#127: FILE: /tmp/f1-6116/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

ERROR: trailing statements should be on next line
#127: FILE: /tmp/f1-6116/zebra_evpn.c:127:
+	if (!zevpn->vxlan_if) { // unexpected

WARNING: line over 80 characters
#150: FILE: /tmp/f1-6116/zebra_evpn.c:150:
+				       zevpn->advertise_gw_macip ? "Yes" : "No");

WARNING: quoted string split across lines
#188: FILE: /tmp/f1-6116/zebra_evpn.c:188:
+			" Number of ARPs (IPv4 and IPv6, local and remote) "
+			"known for this VNI: %u\n",

WARNING: Missing a blank line after declarations
#232: FILE: /tmp/f1-6116/zebra_evpn.c:232:
+		char vni_str[VNI_STR_LEN];
+		snprintf(vni_str, VNI_STR_LEN, "%u", zevpn->vni);

WARNING: void function return statements are not generally useful
#537: FILE: /tmp/f1-6116/zebra_evpn.c:537:
+	return;
+}

WARNING: void function return statements are not generally useful
#577: FILE: /tmp/f1-6116/zebra_evpn.c:577:
+	return;
+}

WARNING: void function return statements are not generally useful
#623: FILE: /tmp/f1-6116/zebra_evpn.c:623:
+	return;
+}

ERROR: return is not a function, parentheses are not required
#943: FILE: /tmp/f1-6116/zebra_evpn.c:943:
+	return (jhash_1word(zevpn->vni, 0));

WARNING: line over 80 characters
#1079: FILE: /tmp/f1-6116/zebra_evpn.c:1079:
+		zlog_debug("Send EVPN_ADD %u %s tenant vrf %s to %s", zevpn->vni,

ERROR: return is not a function, parentheses are not required
#1138: FILE: /tmp/f1-6116/zebra_evpn.c:1138:
+	return (IPV4_ADDR_SAME(vtep_ip, &zvtep->vtep_ip));
Report for zebra_evpn.h | 8 issues
===============================================
WARNING: do not add new typedefs
#41: FILE: /tmp/f1-6116/zebra_evpn.h:41:
+typedef struct zebra_evpn_t_ zebra_evpn_t;

WARNING: do not add new typedefs
#42: FILE: /tmp/f1-6116/zebra_evpn.h:42:
+typedef struct zebra_vtep_t_ zebra_vtep_t;
Report for zebra_evpn_mac.c | 19 issues
===============================================
WARNING: suspect code indent for conditional statements (24, 24)
#740: FILE: /tmp/f1-6116/zebra_evpn_mac.c:740:
+			if (json_mac_hdr == NULL)
+			vty_out(vty, " %-5s", "");

WARNING: line over 80 characters
#988: FILE: /tmp/f1-6116/zebra_evpn_mac.c:988:
+		zlog_warn("%s: MAC %s flags 0x%x neigh list not empty %d", __func__,

WARNING: void function return statements are not generally useful
#1070: FILE: /tmp/f1-6116/zebra_evpn_mac.c:1070:
+	return;
+}

WARNING: quoted string split across lines
#2002: FILE: /tmp/f1-6116/zebra_evpn_mac.c:2002:
+						"        Add/Update %sMAC %s intf %s(%u) VID %u -> VNI %u%s, "
+						"entry exists and has not changed ",
Report for zebra_evpn_mac.h | 4 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-6116/zebra_evpn_mac.h:32:
+typedef struct zebra_mac_t_ zebra_mac_t;
Report for zebra_evpn_mh.c | 43 issues
===============================================
WARNING: line over 80 characters
#252: FILE: /tmp/f1-6116/zebra_evpn_mh.c:252:
+					es_evi->es->esi_str, es_evi->zevpn->vni);

WARNING: Missing a blank line after declarations
#692: FILE: /tmp/f1-6116/zebra_evpn_mh.c:692:
+			zebra_evpn_t *old_zevpn = acc_bd->zevpn;
+			acc_bd->zevpn = NULL;

WARNING: unnecessary whitespace before a quoted newline
#803: FILE: /tmp/f1-6116/zebra_evpn_mh.c:803:
+		vty_out(vty, " Members: \n");

WARNING: suspect code indent for conditional statements (8, 8)
#1014: FILE: /tmp/f1-6116/zebra_evpn_mh.c:1014:
+	if (nh1 == NULL || nh2 == NULL)
+	return false;

WARNING: suspect code indent for conditional statements (8, 8)
#1035: FILE: /tmp/f1-6116/zebra_evpn_mh.c:1035:
+	if (es1 == NULL || es2 == NULL)
+	return false;

WARNING: line over 80 characters
#1092: FILE: /tmp/f1-6116/zebra_evpn_mh.c:1092:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#1103: FILE: /tmp/f1-6116/zebra_evpn_mh.c:1103:
+						(mac->flags & ZEBRA_MAC_REMOTE) ?

WARNING: line over 80 characters
#2419: FILE: /tmp/f1-6116/zebra_evpn_mh.c:2419:
+		 sizeof(mh_buf) - strnlen(mh_buf, sizeof(mh_buf)), "  EVPN-MH:");

WARNING: line over 80 characters
#2911: FILE: /tmp/f1-6116/zebra_evpn_mh.c:2911:
+			vty_out(vty, "%%ESI already exists on a different interface\n");

WARNING: line over 80 characters
#3158: FILE: /tmp/f1-6116/zebra_evpn_mh.c:3158:
+		((struct zebra_if *)zif->bondslave_info.bond_if->info)->es_info.es;
Report for zebra_evpn_mh.h | 4 issues
===============================================
WARNING: function definition argument 'ZAPI_HANDLER_ARGS' should also have an identifier name
#295: FILE: /tmp/f1-6116/zebra_evpn_mh.h:295:
+extern void zebra_evpn_proc_remote_es(ZAPI_HANDLER_ARGS);
Report for zebra_evpn_neigh.c | 5 issues
===============================================
WARNING: void function return statements are not generally useful
#914: FILE: /tmp/f1-6116/zebra_evpn_neigh.c:914:
+	return;
+}
Report for zebra_evpn_neigh.h | 12 issues
===============================================
WARNING: do not add new typedefs
#32: FILE: /tmp/f1-6116/zebra_evpn_neigh.h:32:
+typedef struct zebra_neigh_t_ zebra_neigh_t;

ERROR: Macros with complex values should be enclosed in parentheses
#38: FILE: /tmp/f1-6116/zebra_evpn_neigh.h:38:
+#define ZEBRA_NEIGH_SET_ACTIVE(n) n->state = ZEBRA_NEIGH_ACTIVE

ERROR: Macros with complex values should be enclosed in parentheses
#40: FILE: /tmp/f1-6116/zebra_evpn_neigh.h:40:
+#define ZEBRA_NEIGH_SET_INACTIVE(n) n->state = ZEBRA_NEIGH_INACTIVE
Report for zebra_l2.c | 2 issues
===============================================
< ERROR: do not use assignment in if condition
< #129: FILE: /tmp/f1-6116/zebra_l2.c:129:
Report for zebra_nhg.c | 6 issues
===============================================
< ERROR: do not initialise statics to false
< #54: FILE: /tmp/f1-6116/zebra_nhg.c:54:
< ERROR: Bad function definition - uint32_t nhg_get_next_id() should probably be uint32_t nhg_get_next_id(void)
< #71: FILE: /tmp/f1-6116/zebra_nhg.c:71:
< WARNING: space prohibited between function name and open parenthesis '('
< #2710: FILE: /tmp/f1-6116/zebra_nhg.c:2710:
Report for zebra_vxlan.c | 6 issues
===============================================
< WARNING: line over 80 characters
< #3233: FILE: /tmp/f1-6116/zebra_vxlan.c:3233:
< WARNING: line over 80 characters
< #3281: FILE: /tmp/f1-6116/zebra_vxlan.c:3281:
< WARNING: line over 80 characters
< #4478: FILE: /tmp/f1-6116/zebra_vxlan.c:4478:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12699/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-163-g98203bf52-0 (missing) -> 7.5-dev-20200615-163-g98203bf52-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-163-g98203bf52-0 (missing) -> 7.5-dev-20200615-163-g98203bf52-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-163-g98203bf52-0 (missing) -> 7.5-dev-20200615-163-g98203bf52-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-163-g98203bf52-0 (missing) -> 7.5-dev-20200615-163-g98203bf52-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.5-dev-20200615-163-g98203bf52-0 (missing) -> 7.5-dev-20200615-163-g98203bf52-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 6515, comparing to Git base SHA c0757e8
  • Base image data for Git c0757e8 does not exist - compare skipped

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12699/artifact/shared/static_analysis/index.html

@Spantik
Copy link
Member

Spantik commented Jun 16, 2020

replaced by #6587

@Spantik Spantik closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.