tests : bgp v4 over v6(RFC5549) topojson testcases. #6461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topo tests part 2 on Ubuntu 18.04 amd64: No useful log foundTopo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topo tests part 2 on Ubuntu 16.04 amd64: No useful log foundTopo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topo tests part 2 on Ubuntu 16.04 i386: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
gpnaveen
changed the title
I'm not convinced we need a 30 minute test suite for ONLY 5549.... (edited) Please ignore my comment :P We discussed it in the technical meeting today. |
donaldsharp
reviewed
May 27, 2020
gmshake
reviewed
Jun 5, 2020
polychaeta
previously requested changes
Jun 9, 2020
There was a problem hiding this comment.
Thanks for your contribution to FRR!
- One of your commits has an improperly formatted commit message
If you are a new contributor to FRR, please see our contributing guidelines.
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topo tests part 2 on Ubuntu 16.04 amd64: No useful log foundTopo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topo tests part 2 on Ubuntu 18.04 amd64: No useful log foundTopo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topo tests part 2 on Ubuntu 16.04 i386: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
|
Both commits subject lines need to be updated as per our standard |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topo tests part 2 on Ubuntu 18.04 arm8: No useful log foundTopo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topo tests part 2 on Ubuntu 16.04 amd64: No useful log foundTopo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topo tests part 2 on Ubuntu 18.04 amd64: No useful log foundTopo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topo tests part 2 on Ubuntu 16.04 i386: No useful log foundSuccessful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15381/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15381/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15381/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15381/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15381/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15381/artifact/TP2U1604I386/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15381/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15381/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-15381/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15381/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-15381/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15381/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-15381/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15381/artifact/TP2U1604I386/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-15381/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-15381/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt Addresssanitizer topotests part 2: Incomplete(check logs for details)Successful on other platforms/tests
|
polychaeta
reviewed
Jan 12, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/e81b5cc7ad0501b036858ff9e008b867/raw/6a3cc7aa2bda33b8ca3d40ea335bab52e751f954/cr_6461_1610443833.diff | git apply
diff --git a/tests/topotests/lib/bgp.py b/tests/topotests/lib/bgp.py
index 0f088736e..d056e5b3a 100644
--- a/tests/topotests/lib/bgp.py
+++ b/tests/topotests/lib/bgp.py
@@ -43,7 +43,7 @@ from lib.common_config import (
run_frr_cmd,
FRRCFG_FILE,
retry,
- get_frr_ipv6_linklocal
+ get_frr_ipv6_linklocal,
)
LOGDIR = "/tmp/topotests/"
@@ -264,17 +264,15 @@ def __create_bgp_global(tgen, input_dict, router, build=False):
if router_id:
config_data.append("bgp router-id {}".format(router_id))
- default_ipv4_unicast = bgp_data.setdefault(
- "default_ipv4_unicast", True)
+ default_ipv4_unicast = bgp_data.setdefault("default_ipv4_unicast", True)
- if default_ipv4_unicast == 'False' or default_ipv4_unicast == 'false':
+ if default_ipv4_unicast == "False" or default_ipv4_unicast == "false":
config_data.append("no bgp default ipv4-unicast")
bgp_peer_grp_data = bgp_data.setdefault("peer-group", {})
if "peer-group" in bgp_data and bgp_peer_grp_data:
- peer_grp_data = __create_bgp_peer_group(
- tgen, bgp_peer_grp_data, router)
+ peer_grp_data = __create_bgp_peer_group(tgen, bgp_peer_grp_data, router)
config_data.extend(peer_grp_data)
config_data.append("no bgp network import-check")
@@ -421,12 +419,10 @@ def __create_bgp_unicast_neighbor(
import_cmd = addr_data.setdefault("import", {})
if import_cmd:
try:
- if import_cmd['delete']:
- config_data.append("no import vrf {}".format(import_cmd[
- 'vrf']))
+ if import_cmd["delete"]:
+ config_data.append("no import vrf {}".format(import_cmd["vrf"]))
except KeyError:
- config_data.append("import vrf {}".format(import_cmd['vrf']))
-
+ config_data.append("import vrf {}".format(import_cmd["vrf"]))
max_paths = addr_data.setdefault("maximum_paths", {})
if max_paths:
@@ -693,16 +689,13 @@ def __create_bgp_peer_group(topo, input_dict, router):
remote_as = grp_dict.setdefault("remote-as", None)
capability = grp_dict.setdefault("capability", None)
if update_source:
- config_data.append("{} update-source {}".format(
- neigh_cxt, update_source))
+ config_data.append("{} update-source {}".format(neigh_cxt, update_source))
if remote_as:
- config_data.append("{} remote-as {}".format(
- neigh_cxt, remote_as))
+ config_data.append("{} remote-as {}".format(neigh_cxt, remote_as))
if capability:
- config_data.append("{} capability {}".format(
- neigh_cxt, capability))
+ config_data.append("{} capability {}".format(neigh_cxt, capability))
logger.debug("Exiting lib API: __create_bgp_peer_group()")
return config_data
@@ -737,18 +730,14 @@ def __create_bgp_neighbor(topo, input_dict, router, addr_type, add_neigh=True):
update_source = None
-
- if "neighbor_type" in peer and peer["neighbor_type"] == \
- 'unnumbered':
- ip_addr = nh_details["links"][dest_link]['peer-interface']
- elif "neighbor_type" in peer and peer["neighbor_type"] == \
- 'link-local':
+ if "neighbor_type" in peer and peer["neighbor_type"] == "unnumbered":
+ ip_addr = nh_details["links"][dest_link]["peer-interface"]
+ elif "neighbor_type" in peer and peer["neighbor_type"] == "link-local":
intf = topo[name]["links"][dest_link]["interface"]
ip_addr = get_frr_ipv6_linklocal(tgen, name, intf)
elif dest_link in nh_details["links"].keys():
try:
- ip_addr = \
- nh_details["links"][dest_link][addr_type].split("/")[0]
+ ip_addr = nh_details["links"][dest_link][addr_type].split("/")[0]
except KeyError:
intf = topo[name]["links"][dest_link]["interface"]
ip_addr = get_frr_ipv6_linklocal(tgen, name, intf)
@@ -760,36 +749,43 @@ def __create_bgp_neighbor(topo, input_dict, router, addr_type, add_neigh=True):
neigh_cxt = "neighbor {}".format(ip_addr)
if "peer-group" in peer:
- config_data.append("neighbor {} interface peer-group {}".format(
- ip_addr, peer["peer-group"]))
+ config_data.append(
+ "neighbor {} interface peer-group {}".format(
+ ip_addr, peer["peer-group"]
+ )
+ )
# Loopback interface
if "source_link" in peer:
if peer["source_link"] == "lo":
- update_source = topo[router]["links"]["lo"][
- addr_type].split("/")[0]
+ update_source = topo[router]["links"]["lo"][addr_type].split("/")[0]
else:
- update_source = topo[router]["links"][
- peer["source_link"]]["interface"]
+ update_source = topo[router]["links"][peer["source_link"]][
+ "interface"
+ ]
if "peer-group" not in peer:
- if "neighbor_type" in peer and peer["neighbor_type"] == \
- 'unnumbered':
- config_data.append("{} interface remote-as {}".format(
- neigh_cxt, remote_as))
+ if "neighbor_type" in peer and peer["neighbor_type"] == "unnumbered":
+ config_data.append(
+ "{} interface remote-as {}".format(neigh_cxt, remote_as)
+ )
elif add_neigh:
- config_data.append("{} remote-as {}".format(neigh_cxt,
- remote_as))
+ config_data.append("{} remote-as {}".format(neigh_cxt, remote_as))
if addr_type == "ipv6":
config_data.append("address-family ipv6 unicast")
config_data.append("{} activate".format(neigh_cxt))
- if "neighbor_type" in peer and peer["neighbor_type"] == \
- 'link-local':
- config_data.append("{} update-source {}".format(
- neigh_cxt, nh_details["links"][dest_link]['peer-interface']))
- config_data.append("{} interface {}".format(
- neigh_cxt, nh_details["links"][dest_link]['peer-interface']))
+ if "neighbor_type" in peer and peer["neighbor_type"] == "link-local":
+ config_data.append(
+ "{} update-source {}".format(
+ neigh_cxt, nh_details["links"][dest_link]["peer-interface"]
+ )
+ )
+ config_data.append(
+ "{} interface {}".format(
+ neigh_cxt, nh_details["links"][dest_link]["peer-interface"]
+ )
+ )
disable_connected = peer.setdefault("disable_connected_check", False)
keep_alive = peer.setdefault("keepalivetimer", 60)
@@ -835,8 +831,7 @@ def __create_bgp_neighbor(topo, input_dict, router, addr_type, add_neigh=True):
config_data.append("no {} graceful-restart-disable".format(neigh_cxt))
if capability:
- config_data.append("{} capability {}".format(
- neigh_cxt, capability))
+ config_data.append("{} capability {}".format(neigh_cxt, capability))
if password:
config_data.append("{} password {}".format(neigh_cxt, password))
@@ -895,25 +890,28 @@ def __create_bgp_unicast_address_family(
# Physical interface
else:
# check the neighbor type if un numbered nbr, use interface.
- if "neighbor_type" in peer and peer["neighbor_type"] == \
- 'unnumbered':
- ip_addr = nh_details["links"][dest_link]['peer-interface']
- elif "neighbor_type" in peer and peer["neighbor_type"] == \
- 'link-local':
- intf = topo[peer_name]["links"][dest_link]["interface"]
- ip_addr = get_frr_ipv6_linklocal(tgen, peer_name, intf)
+ if "neighbor_type" in peer and peer["neighbor_type"] == "unnumbered":
+ ip_addr = nh_details["links"][dest_link]["peer-interface"]
+ elif "neighbor_type" in peer and peer["neighbor_type"] == "link-local":
+ intf = topo[peer_name]["links"][dest_link]["interface"]
+ ip_addr = get_frr_ipv6_linklocal(tgen, peer_name, intf)
elif dest_link in nh_details["links"].keys():
try:
- ip_addr = \
- nh_details["links"][dest_link][addr_type].split("/")[0]
+ ip_addr = nh_details["links"][dest_link][addr_type].split("/")[
+ 0
+ ]
except KeyError:
intf = topo[peer_name]["links"][dest_link]["interface"]
ip_addr = get_frr_ipv6_linklocal(tgen, peer_name, intf)
- if addr_type == "ipv4" and bgp_data["ipv6"] and \
- check_address_types("ipv6") and \
- "ipv6" in nh_details["links"][dest_link]:
- deactivate = nh_details["links"][
- dest_link]["ipv6"].split("/")[0]
+ if (
+ addr_type == "ipv4"
+ and bgp_data["ipv6"]
+ and check_address_types("ipv6")
+ and "ipv6" in nh_details["links"][dest_link]
+ ):
+ deactivate = nh_details["links"][dest_link]["ipv6"].split("/")[
+ 0
+ ]
neigh_cxt = "neighbor {}".format(ip_addr)
config_data.append("address-family {} unicast".format(addr_type))
@@ -942,7 +940,6 @@ def __create_bgp_unicast_address_family(
allowas_in = peer.setdefault("allowas-in", None)
capability = peer.setdefault("capability", None)
-
# next-hop-self
if next_hop_self is not None:
if next_hop_self is True:
@@ -1318,8 +1315,9 @@ def verify_bgp_convergence(tgen, topo, dut=None):
"neighbor_type" in peer_details
and peer_details["neighbor_type"] == "link-local"
):
- neighbor_ip = get_frr_ipv6_linklocal(
- tgen, bgp_neighbor, intf)
+ neighbor_ip = get_frr_ipv6_linklocal(
+ tgen, bgp_neighbor, intf
+ )
elif "source_link" in peer_details:
neighbor_ip = topo["routers"][bgp_neighbor][
"links"
@@ -1815,41 +1813,41 @@ def clear_bgp_and_verify(tgen, topo, router):
data = topo["routers"][bgp_neighbor]["links"]
nh_state = None
if dest_link in data:
- neighbor_ip = data[dest_link][addr_type].split(
- "/")[0]
- neighbor_intf = \
- data[dest_link]["peer-interface"]
+ neighbor_ip = data[dest_link][addr_type].split("/")[0]
+ neighbor_intf = data[dest_link]["peer-interface"]
if addr_type == "ipv4":
- ipv4_data = show_bgp_json["ipv4Unicast"][
- "peers"]
+ ipv4_data = show_bgp_json["ipv4Unicast"]["peers"]
if neighbor_ip in ipv4_data:
nh_state = ipv4_data[neighbor_ip]["state"]
# Peer up time dictionary
- msg_rcved_before_clear_bgp[bgp_neighbor] = \
- ipv4_data[neighbor_ip]["msgRcvd"]
+ msg_rcved_before_clear_bgp[bgp_neighbor] = ipv4_data[
+ neighbor_ip
+ ]["msgRcvd"]
else:
# for un numbered interface
nh_state = ipv4_data[neighbor_intf]["state"]
# Peer up time dictionary
- msg_rcved_before_clear_bgp[bgp_neighbor] = \
- ipv4_data[neighbor_intf]["msgRcvd"]
+ msg_rcved_before_clear_bgp[bgp_neighbor] = ipv4_data[
+ neighbor_intf
+ ]["msgRcvd"]
else:
- ipv6_data = show_bgp_json["ipv6Unicast"][
- "peers"]
+ ipv6_data = show_bgp_json["ipv6Unicast"]["peers"]
if neighbor_ip in ipv6_data:
nh_state = ipv6_data[neighbor_ip]["state"]
# Peer up time dictionary
- msg_rcved_before_clear_bgp[bgp_neighbor] = \
- ipv6_data[neighbor_ip]["msgRcvd"]
+ msg_rcved_before_clear_bgp[bgp_neighbor] = ipv6_data[
+ neighbor_ip
+ ]["msgRcvd"]
else:
# for un numbered interface
nh_state = ipv6_data[neighbor_intf]["state"]
# Peer up time dictionary
- msg_rcved_before_clear_bgp[bgp_neighbor] = \
- ipv6_data[neighbor_intf]["msgRcvd"]
+ msg_rcved_before_clear_bgp[bgp_neighbor] = ipv6_data[
+ neighbor_intf
+ ]["msgRcvd"]
if nh_state == "Established":
no_of_peer += 1
@@ -1918,36 +1916,36 @@ def clear_bgp_and_verify(tgen, topo, router):
data = topo["routers"][bgp_neighbor]["links"]
nh_state = None
if dest_link in data:
- neighbor_ip = data[dest_link][addr_type].\
- split("/")[0]
- neighbor_intf = \
- data[dest_link]["peer-interface"]
+ neighbor_ip = data[dest_link][addr_type].split("/")[0]
+ neighbor_intf = data[dest_link]["peer-interface"]
if addr_type == "ipv4":
- ipv4_data = show_bgp_json["ipv4Unicast"][
- "peers"]
+ ipv4_data = show_bgp_json["ipv4Unicast"]["peers"]
if neighbor_ip in ipv4_data:
nh_state = ipv4_data[neighbor_ip]["state"]
# Peer up time dictionary
- msg_rcved_after_clear_bgp[bgp_neighbor] = \
- ipv4_data[neighbor_ip]["msgRcvd"]
+ msg_rcved_after_clear_bgp[bgp_neighbor] = ipv4_data[
+ neighbor_ip
+ ]["msgRcvd"]
else:
# for un numbered interface
nh_state = ipv4_data[neighbor_intf]["state"]
- msg_rcved_after_clear_bgp[bgp_neighbor] = \
- ipv4_data[neighbor_intf]["msgRcvd"]
+ msg_rcved_after_clear_bgp[bgp_neighbor] = ipv4_data[
+ neighbor_intf
+ ]["msgRcvd"]
else:
- ipv6_data = show_bgp_json["ipv6Unicast"][
- "peers"]
+ ipv6_data = show_bgp_json["ipv6Unicast"]["peers"]
if neighbor_ip in ipv6_data:
nh_state = ipv6_data[neighbor_ip]["state"]
# Peer up time dictionary
- msg_rcved_after_clear_bgp[bgp_neighbor] = \
- ipv6_data[neighbor_ip]["msgRcvd"]
+ msg_rcved_after_clear_bgp[bgp_neighbor] = ipv6_data[
+ neighbor_ip
+ ]["msgRcvd"]
else:
# for un numbered interface
nh_state = ipv6_data[neighbor_intf]["state"]
- msg_rcved_after_clear_bgp[bgp_neighbor] = \
- ipv6_data[neighbor_intf]["msgRcvd"]
+ msg_rcved_after_clear_bgp[bgp_neighbor] = ipv6_data[
+ neighbor_intf
+ ]["msgRcvd"]
if nh_state == "Established":
no_of_peer += 1
@@ -1971,12 +1969,13 @@ def clear_bgp_and_verify(tgen, topo, router):
m1 = msg_rcved_before_clear_bgp[peer]
m2 = msg_rcved_after_clear_bgp[peer]
if m1 > m2:
- errormsg = "BGP neighborship is not reset after clear bgp on router" \
- " {}".format(router)
+ errormsg = (
+ "BGP neighborship is not reset after clear bgp on router"
+ " {}".format(router)
+ )
return errormsg
- logger.info("BGP neighborship is reset after clear BGP on router %s",
- router)
+ logger.info("BGP neighborship is reset after clear BGP on router %s", router)
logger.debug("Exiting lib API: {}".format(sys._getframe().f_code.co_name))
return True
@@ -2680,8 +2679,9 @@ def verify_best_path_as_per_admin_distance(
@retry(attempts=5, wait=2, return_is_str=True, initial_wait=2)
-def verify_bgp_rib(tgen, addr_type, dut, input_dict, next_hop=None,
-aspath=None, multi_nh=None):
+def verify_bgp_rib(
+ tgen, addr_type, dut, input_dict, next_hop=None, aspath=None, multi_nh=None
+):
"""
This API is to verify whether bgp rib has any
matching route for a nexthop.
@@ -2819,7 +2819,7 @@ aspath=None, multi_nh=None):
st_rt,
dut,
)
- errormsg=(
+ errormsg = (
"Missing nexthop %s for route"
" %s in RIB of router %s\n",
additional_nexthops_in_required_nhs,
@@ -2834,25 +2834,35 @@ aspath=None, multi_nh=None):
if not isinstance(next_hop, list):
next_hop = [next_hop]
list1 = next_hop
- found_hops = [rib_r["ip"] for rib_r in
- rib_routes_json["routes"][
- st_rt][0]["nexthops"]]
+ found_hops = [
+ rib_r["ip"]
+ for rib_r in rib_routes_json["routes"][st_rt][0][
+ "nexthops"
+ ]
+ ]
list2 = found_hops
- missing_list_of_nexthops = \
- set(list2).difference(list1)
- additional_nexthops_in_required_nhs = \
- set(list1).difference(list2)
+ missing_list_of_nexthops = set(list2).difference(list1)
+ additional_nexthops_in_required_nhs = set(
+ list1
+ ).difference(list2)
if list2:
if additional_nexthops_in_required_nhs:
- logger.info("Missing nexthop %s for route"\
- " %s in RIB of router %s\n", \
- additional_nexthops_in_required_nhs, \
- st_rt, dut)
- errormsg=("Nexthop {} is Missing for "\
- "route {} in RIB of router {}\n".format(
+ logger.info(
+ "Missing nexthop %s for route"
+ " %s in RIB of router %s\n",
additional_nexthops_in_required_nhs,
- st_rt, dut))
+ st_rt,
+ dut,
+ )
+ errormsg = (
+ "Nexthop {} is Missing for "
+ "route {} in RIB of router {}\n".format(
+ additional_nexthops_in_required_nhs,
+ st_rt,
+ dut,
+ )
+ )
return errormsg
else:
nh_found = True
diff --git a/tests/topotests/lib/common_config.py b/tests/topotests/lib/common_config.py
index 183feb925..5b61d43bf 100644
--- a/tests/topotests/lib/common_config.py
+++ b/tests/topotests/lib/common_config.py
@@ -632,37 +632,38 @@ def get_frr_ipv6_linklocal(tgen, router, intf=None, vrf=None):
else:
cmd = "show interface"
for chk_ll in range(0, 60):
- sleep(1/4)
+ sleep(1 / 4)
ifaces = router_list[router].run('vtysh -c "{}"'.format(cmd))
# Fix newlines (make them all the same)
- ifaces = ('\n'.join(ifaces.splitlines()) + '\n').splitlines()
+ ifaces = ("\n".join(ifaces.splitlines()) + "\n").splitlines()
interface = None
ll_per_if_count = 0
for line in ifaces:
# Interface name
- m = re_search('Interface ([a-zA-Z0-9-]+) is', line)
+ m = re_search("Interface ([a-zA-Z0-9-]+) is", line)
if m:
interface = m.group(1).split(" ")[0]
ll_per_if_count = 0
# Interface ip
- m1 = re_search('inet6 (fe80[:a-fA-F0-9]+[\/0-9]+)',
- line)
+ m1 = re_search("inet6 (fe80[:a-fA-F0-9]+[\/0-9]+)", line)
if m1:
local = m1.group(1)
ll_per_if_count += 1
if ll_per_if_count > 1:
- linklocal += [["%s-%s" %
- (interface, ll_per_if_count), local]]
+ linklocal += [["%s-%s" % (interface, ll_per_if_count), local]]
else:
linklocal += [[interface, local]]
try:
if linklocal:
if intf:
- return [_linklocal[1] for _linklocal in linklocal if _linklocal[0]==intf][0].\
- split("/")[0]
+ return [
+ _linklocal[1]
+ for _linklocal in linklocal
+ if _linklocal[0] == intf
+ ][0].split("/")[0]
return linklocal
except IndexError:
continue
@@ -1643,12 +1644,13 @@ def create_interfaces_cfg(tgen, topo, build=False):
interface_data.append("ipv6 address {}".format(intf_addr))
# Wait for vrf interfaces to get link local address once they are up
- if not destRouterLink == 'lo' and 'vrf' in topo[c_router][
- 'links'][destRouterLink]:
- vrf = topo[c_router]['links'][destRouterLink]['vrf']
- intf = topo[c_router]['links'][destRouterLink]['interface']
- ll = get_frr_ipv6_linklocal(tgen, c_router, intf=intf,
- vrf = vrf)
+ if (
+ not destRouterLink == "lo"
+ and "vrf" in topo[c_router]["links"][destRouterLink]
+ ):
+ vrf = topo[c_router]["links"][destRouterLink]["vrf"]
+ intf = topo[c_router]["links"][destRouterLink]["interface"]
+ ll = get_frr_ipv6_linklocal(tgen, c_router, intf=intf, vrf=vrf)
if "ipv6-link-local" in data:
intf_addr = c_data["links"][destRouterLink]["ipv6-link-local"]
@@ -3083,7 +3085,11 @@ def verify_rib(
errormsg = (
"[DUT: {}]: tag value {}"
" is not matched for"
- " route {} in RIB \n".format(dut, _tag, st_rt,)
+ " route {} in RIB \n".format(
+ dut,
+ _tag,
+ st_rt,
+ )
)
return errormsg
@@ -3100,7 +3106,11 @@ def verify_rib(
errormsg = (
"[DUT: {}]: metric value "
"{} is not matched for "
- "route {} in RIB \n".format(dut, metric, st_rt,)
+ "route {} in RIB \n".format(
+ dut,
+ metric,
+ st_rt,
+ )
)
return errormsg
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
polychaeta
reviewed
Jan 12, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/d3c6450472cb9203bcbec6c151c4c430/raw/b94bee23f23a0ba95fd708ea97c6e6d739867abd/cr_6461_1610444051.diff | git apply
diff --git a/tests/topotests/lib/bgp.py b/tests/topotests/lib/bgp.py
index 68a7217dd..c06f06a6e 100644
--- a/tests/topotests/lib/bgp.py
+++ b/tests/topotests/lib/bgp.py
@@ -2516,8 +2516,9 @@ def verify_best_path_as_per_admin_distance(
@retry(attempts=5, wait=2, return_is_str=True, initial_wait=2)
-def verify_bgp_rib(tgen, addr_type, dut, input_dict, next_hop=None,
-aspath=None, multi_nh=None):
+def verify_bgp_rib(
+ tgen, addr_type, dut, input_dict, next_hop=None, aspath=None, multi_nh=None
+):
"""
This API is to verify whether bgp rib has any
matching route for a nexthop.
@@ -2663,25 +2664,35 @@ aspath=None, multi_nh=None):
if not isinstance(next_hop, list):
next_hop = [next_hop]
list1 = next_hop
- found_hops = [rib_r["ip"] for rib_r in
- rib_routes_json["routes"][
- st_rt][0]["nexthops"]]
+ found_hops = [
+ rib_r["ip"]
+ for rib_r in rib_routes_json["routes"][st_rt][0][
+ "nexthops"
+ ]
+ ]
list2 = found_hops
- missing_list_of_nexthops = \
- set(list2).difference(list1)
- additional_nexthops_in_required_nhs = \
- set(list1).difference(list2)
+ missing_list_of_nexthops = set(list2).difference(list1)
+ additional_nexthops_in_required_nhs = set(
+ list1
+ ).difference(list2)
if list2:
if additional_nexthops_in_required_nhs:
- logger.info("Missing nexthop %s for route"\
- " %s in RIB of router %s\n", \
- additional_nexthops_in_required_nhs, \
- st_rt, dut)
- errormsg=("Nexthop {} is Missing for "\
- "route {} in RIB of router {}\n".format(
+ logger.info(
+ "Missing nexthop %s for route"
+ " %s in RIB of router %s\n",
additional_nexthops_in_required_nhs,
- st_rt, dut))
+ st_rt,
+ dut,
+ )
+ errormsg = (
+ "Nexthop {} is Missing for "
+ "route {} in RIB of router {}\n".format(
+ additional_nexthops_in_required_nhs,
+ st_rt,
+ dut,
+ )
+ )
return errormsg
else:
nh_found = True
diff --git a/tests/topotests/lib/common_config.py b/tests/topotests/lib/common_config.py
index 27efecb76..defbe040b 100644
--- a/tests/topotests/lib/common_config.py
+++ b/tests/topotests/lib/common_config.py
@@ -3065,7 +3065,11 @@ def verify_rib(
errormsg = (
"[DUT: {}]: tag value {}"
" is not matched for"
- " route {} in RIB \n".format(dut, _tag, st_rt,)
+ " route {} in RIB \n".format(
+ dut,
+ _tag,
+ st_rt,
+ )
)
return errormsg
@@ -3082,7 +3086,11 @@ def verify_rib(
errormsg = (
"[DUT: {}]: metric value "
"{} is not matched for "
- "route {} in RIB \n".format(dut, metric, st_rt,)
+ "route {} in RIB \n".format(
+ dut,
+ metric,
+ st_rt,
+ )
)
return errormsg
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-16454/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16454/artifact/TP2U1604I386/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-16454/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16454/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-16454/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16454/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-16454/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16454/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-16455/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16455/artifact/TP2U1604I386/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-16455/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16455/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-16455/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16455/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-16455/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16455/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt Topo tests part 1 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1604AMD64-16455/test Topology Tests failed for Topo tests part 1 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16455/artifact/TP1U1604AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
polychaeta
reviewed
Jan 21, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/a69651168786ddb763348f6da91929a3/raw/ec38bdaed4cf887855114c0b16950b43ddbbd946/cr_6461_1611212384.diff | git apply
diff --git a/tests/topotests/lib/bgp.py b/tests/topotests/lib/bgp.py
index 22602cb46..65e584062 100644
--- a/tests/topotests/lib/bgp.py
+++ b/tests/topotests/lib/bgp.py
@@ -2516,8 +2516,9 @@ def verify_best_path_as_per_admin_distance(
@retry(attempts=5, wait=2, return_is_str=True, initial_wait=2)
-def verify_bgp_rib(tgen, addr_type, dut, input_dict, next_hop=None,
-aspath=None, multi_nh=None):
+def verify_bgp_rib(
+ tgen, addr_type, dut, input_dict, next_hop=None, aspath=None, multi_nh=None
+):
"""
This API is to verify whether bgp rib has any
matching route for a nexthop.
@@ -2663,25 +2664,35 @@ aspath=None, multi_nh=None):
if not isinstance(next_hop, list):
next_hop = [next_hop]
list1 = next_hop
- found_hops = [rib_r["ip"] for rib_r in
- rib_routes_json["routes"][
- st_rt][0]["nexthops"]]
+ found_hops = [
+ rib_r["ip"]
+ for rib_r in rib_routes_json["routes"][st_rt][0][
+ "nexthops"
+ ]
+ ]
list2 = found_hops
- missing_list_of_nexthops = \
- set(list2).difference(list1)
- additional_nexthops_in_required_nhs = \
- set(list1).difference(list2)
+ missing_list_of_nexthops = set(list2).difference(list1)
+ additional_nexthops_in_required_nhs = set(
+ list1
+ ).difference(list2)
if list2:
if additional_nexthops_in_required_nhs:
- logger.info("Missing nexthop %s for route"\
- " %s in RIB of router %s\n", \
- additional_nexthops_in_required_nhs, \
- st_rt, dut)
- errormsg=("Nexthop {} is Missing for "\
- "route {} in RIB of router {}\n".format(
+ logger.info(
+ "Missing nexthop %s for route"
+ " %s in RIB of router %s\n",
additional_nexthops_in_required_nhs,
- st_rt, dut))
+ st_rt,
+ dut,
+ )
+ errormsg = (
+ "Nexthop {} is Missing for "
+ "route {} in RIB of router {}\n".format(
+ additional_nexthops_in_required_nhs,
+ st_rt,
+ dut,
+ )
+ )
return errormsg
else:
nh_found = True
diff --git a/tests/topotests/lib/common_config.py b/tests/topotests/lib/common_config.py
index 175d660d1..c8f54d975 100644
--- a/tests/topotests/lib/common_config.py
+++ b/tests/topotests/lib/common_config.py
@@ -4395,4 +4395,3 @@ def verify_ip_nht(tgen, input_dict):
logger.debug("Exiting lib API: verify_ip_nht()")
return False
-
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopo tests part 2 on Ubuntu 18.04 arm8: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-16607/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 arm8: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16607/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 16.04 i386: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1604I386-16607/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 i386: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16607/artifact/TP2U1604I386/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 18.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP2U1804AMD64-16607/test Topology Tests failed for Topo tests part 2 on Ubuntu 18.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16607/artifact/TP2U1804AMD64/ErrorLog/log_topotests.txt Topo tests part 2 on Ubuntu 16.04 amd64: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP0U1604AMD64-16607/test Topology Tests failed for Topo tests part 2 on Ubuntu 16.04 amd64: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-16607/artifact/TP0U1604AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
|
@gpnaveen Please rebase your code and get it to pass CI. |
polychaeta
reviewed
May 18, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:
************* Module test_rfc5549_ebgp_nbr
my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:593:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:650:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.39/10
Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1639:64: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.97/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO5DEB10AMD64-19072/test Topology Tests failed for Topotests debian 10 amd64 part 5: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19072/artifact/TOPO5DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-19072/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19072/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6DEB10AMD64-19072/test Topology Tests failed for Topotests debian 10 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19072/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18I386-19072/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19072/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: FailedDebian 10 amd64 build: Failed (click for details)Debian 10 amd64 build: Unknown Log URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19205/artifact/DEB10BUILD/config.log/config.log.gzDejaGNU Unittests (make check) failed for Debian 10 amd64 build Successful on other platforms/tests
|
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-19072/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19072/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6DEB10AMD64-19072/test Topology Tests failed for Topotests debian 10 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19072/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18I386-19072/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19072/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
|
ci: rerun |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6DEB10AMD64-19207/test Topology Tests failed for Topotests debian 10 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19207/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18I386-19207/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19207/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-19207/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19207/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO1DEB10AMD64-19207/test Topology Tests failed for Topotests debian 10 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19207/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
polychaeta
reviewed
Jun 8, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:
************* Module test_rfc5549_ebgp_nbr
my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:593:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:650:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.39/10
Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1639:64: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.97/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP4U1804AMD64-19513/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19513/artifact/TP4U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4U18I386-19513/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19513/artifact/TOPO4U18I386/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-19513/test Topology Tests failed for Topotests debian 10 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19513/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
polychaeta
reviewed
Jun 22, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:
************* Module test_rfc5549_ebgp_nbr
my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:593:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:650:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.39/10
Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1657:64: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.97/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDTest incomplete. See below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: IncompleteTopotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topotests Ubuntu 18.04 i386 part 4: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18AMD64-19739/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18I386-19739/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 5: No useful log foundTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 i386 part 5: Failed (click for details)Topotests Ubuntu 18.04 i386 part 5: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18AMD64-19739/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 3: No useful log foundTopotests debian 10 amd64 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO5DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 5: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO5DEB10AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 4: Failed (click for details)Topotests Ubuntu 18.04 i386 part 4: No useful log foundTopotests debian 10 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18AMD64-19739/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18I386-19739/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 5: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 5: No useful log foundTopotests Ubuntu 18.04 arm8 part 4: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 4: No useful log foundTopotests Ubuntu 18.04 i386 part 5: Failed (click for details)Topotests Ubuntu 18.04 i386 part 5: No useful log foundTopotests Ubuntu 18.04 arm8 part 9: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 9: No useful log foundTopotests debian 10 amd64 part 4: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO4DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 4: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO4DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18AMD64-19739/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 3: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 3: No useful log foundTopotests debian 10 amd64 part 5: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO5DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 5: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO5DEB10AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO6DEB10AMD64/ErrorLog/log_topotests.txt Addresssanitizer topotests part 4: Incomplete(check logs for details)Topotests Ubuntu 18.04 amd64 part 5: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 5: No useful log foundTopotests Ubuntu 18.04 amd64 part 4: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 4: No useful log foundTopotests Ubuntu 18.04 arm8 part 6: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 6: No useful log foundTopotests debian 10 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 7: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO7DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 1: No useful log foundTopotests Ubuntu 18.04 i386 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18I386-19739/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 7: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO7U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 2: Failed (click for details)Topotests Ubuntu 18.04 i386 part 2: No useful log foundTopotests Ubuntu 18.04 arm8 part 7: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 7: No useful log foundTopotests Ubuntu 18.04 arm8 part 2: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO2U18ARM8-19739/test Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 2: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO2U18ARM8/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18AMD64-19739/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO6U18AMD64/ErrorLog/log_topotests.txt Topotests debian 10 amd64 part 2: Failed (click for details)Topotests debian 10 amd64 part 2: No useful log foundTopotests Ubuntu 18.04 i386 part 6: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO6U18I386-19739/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO6U18I386/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TP1U1804AMD64-19739/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TP1U1804AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 arm8 part 3: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 3: No useful log foundTopotests Ubuntu 18.04 amd64 part 2: Failed (click for details)Topotests Ubuntu 18.04 amd64 part 2: No useful log foundTopotests debian 10 amd64 part 3: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO3DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 3: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO3DEB10AMD64/ErrorLog/log_topotests.txt Topotests Ubuntu 18.04 i386 part 3: Failed (click for details)Topotests Ubuntu 18.04 i386 part 3: No useful log foundTopotests Ubuntu 18.04 i386 part 1: Failed (click for details)Topotests Ubuntu 18.04 i386 part 1: No useful log foundTopotests debian 10 amd64 part 1: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO1DEB10AMD64-19739/test Topology Tests failed for Topotests debian 10 amd64 part 1: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-19739/artifact/TOPO1DEB10AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
1. Updated bgp.py and common_config.py for rfc5549. 2. Added test cases for rfc5549. Signed-off-by: naveen <nguggarigoud@vmware.com>
polychaeta
reviewed
Jun 29, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Pylint found errors in source files changed by this PR:
Pylint report for my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:
************* Module test_rfc5549_ebgp_nbr
my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:593:4: E1305: Too many arguments for format string (too-many-format-args)
my_frr/tests/topotests/bgp_ipv4_over_ipv6/test_rfc5549_ebgp_nbr.py:650:4: E1305: Too many arguments for format string (too-many-format-args)
-----------------------------------
Your code has been rated at 9.39/10
Pylint report for my_frr/tests/topotests/lib/common_config.py:
************* Module lib.common_config
my_frr/tests/topotests/lib/common_config.py:1657:64: E0602: Undefined variable 'unicode' (undefined-variable)
-----------------------------------
Your code has been rated at 9.97/10
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
|
@gpnaveen if this is still relevant, could you update it? |
Closing this. This is invalid. Thank you. |
|
Rebase? |
Please ignore.. Wrong PR i have enabled. I am closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test suite execution time is ~11 minutes.
Signed-off-by: naveen nguggarigoud@vmware.com