isisd: IS-IS Segment Routing support

[odd22]

This PR add Segment Routing support to IS-IS.

It corresponds to the backport of dev_isis_sr branch. Look to this branch for the complete historic of commit.

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12306/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

<stdin>:110: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#959: FILE: /tmp/f1-10330/if.c:959:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#959: FILE: /tmp/f2-10330/if.c:959:
103c103
< #1051: FILE: /tmp/f1-10330/if.c:1051:
Report for if.h | 4 issues
===============================================
< WARNING: function definition argument 'const struct prefix *' should also have an identifier name
< #577: FILE: /tmp/f1-10330/if.h:577:
< WARNING: function definition argument 'const struct prefix *' should also have an identifier name
< #579: FILE: /tmp/f1-10330/if.h:579:
Report for isis_errors.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #43: FILE: /tmp/f1-10330/isis_errors.c:43:
Report for isis_misc.c | 7 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#489: FILE: /tmp/f1-10330/isis_misc.c:489:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#489: FILE: /tmp/f2-10330/isis_misc.c:489:
24c24
< #516: FILE: /tmp/f1-10330/isis_misc.c:516:
< WARNING: Missing a blank line after declarations
< #575: FILE: /tmp/f1-10330/isis_misc.c:575:
Report for isis_nb.c | 44 issues
===============================================
< WARNING: line over 80 characters
< #460: FILE: /tmp/f1-10330/isis_nb.c:460:
< WARNING: line over 80 characters
< #465: FILE: /tmp/f1-10330/isis_nb.c:465:
< WARNING: line over 80 characters
< #467: FILE: /tmp/f1-10330/isis_nb.c:467:
< WARNING: line over 80 characters
< #472: FILE: /tmp/f1-10330/isis_nb.c:472:
< WARNING: line over 80 characters
< #474: FILE: /tmp/f1-10330/isis_nb.c:474:
< WARNING: line over 80 characters
< #478: FILE: /tmp/f1-10330/isis_nb.c:478:
< WARNING: line over 80 characters
< #480: FILE: /tmp/f1-10330/isis_nb.c:480:
< WARNING: line over 80 characters
< #484: FILE: /tmp/f1-10330/isis_nb.c:484:
< WARNING: line over 80 characters
< #486: FILE: /tmp/f1-10330/isis_nb.c:486:
< WARNING: line over 80 characters
< #487: FILE: /tmp/f1-10330/isis_nb.c:487:
< WARNING: line over 80 characters
< #492: FILE: /tmp/f1-10330/isis_nb.c:492:
< WARNING: line over 80 characters
< #494: FILE: /tmp/f1-10330/isis_nb.c:494:
< WARNING: line over 80 characters
< #495: FILE: /tmp/f1-10330/isis_nb.c:495:
< WARNING: line over 80 characters
< #496: FILE: /tmp/f1-10330/isis_nb.c:496:
< WARNING: line over 80 characters
< #497: FILE: /tmp/f1-10330/isis_nb.c:497:
< WARNING: line over 80 characters
< #502: FILE: /tmp/f1-10330/isis_nb.c:502:
< WARNING: line over 80 characters
< #504: FILE: /tmp/f1-10330/isis_nb.c:504:
< WARNING: line over 80 characters
< #508: FILE: /tmp/f1-10330/isis_nb.c:508:
< WARNING: line over 80 characters
< #510: FILE: /tmp/f1-10330/isis_nb.c:510:
< WARNING: line over 80 characters
< #514: FILE: /tmp/f1-10330/isis_nb.c:514:
< WARNING: line over 80 characters
< #516: FILE: /tmp/f1-10330/isis_nb.c:516:
< WARNING: line over 80 characters
< #527: FILE: /tmp/f1-10330/isis_nb.c:527:
Report for isis_nb_config.c | 8 issues
===============================================
< WARNING: line over 80 characters
< #1636: FILE: /tmp/f1-10330/isis_nb_config.c:1636:
< WARNING: line over 80 characters
< #1638: FILE: /tmp/f1-10330/isis_nb_config.c:1638:
< WARNING: line over 80 characters
< #1672: FILE: /tmp/f1-10330/isis_nb_config.c:1672:
< WARNING: line over 80 characters
< #1674: FILE: /tmp/f1-10330/isis_nb_config.c:1674:
Report for isis_nb.h | 4 issues
===============================================
< WARNING: line over 80 characters
< #191: FILE: /tmp/f1-10330/isis_nb.h:191:
< WARNING: line over 80 characters
< #195: FILE: /tmp/f1-10330/isis_nb.h:195:
Report for isis_route.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #133: FILE: /tmp/f1-10330/isis_route.c:133:
< WARNING: line over 80 characters
< #148: FILE: /tmp/f1-10330/isis_route.c:148:
Report for isis_sr.c | 33 issues
===============================================
WARNING: space prohibited between function name and open parenthesis '('
#164: FILE: /tmp/f1-10330/isis_sr.c:164:
+			frr_each (srdb_area_prefix,

WARNING: space prohibited between function name and open parenthesis '('
#484: FILE: /tmp/f1-10330/isis_sr.c:484:
+	frr_each (srdb_area_prefix, &area->srdb.prefix_sids[level - 1], srp) {

WARNING: space prohibited between function name and open parenthesis '('
#1056: FILE: /tmp/f1-10330/isis_sr.c:1056:
+		frr_each (lspdb, &area->lspdb[level - 1], lsp) {

WARNING: space prohibited between function name and open parenthesis '('
#1158: FILE: /tmp/f1-10330/isis_sr.c:1158:
+	frr_each_safe (srdb_node_prefix, &srn->prefix_sids, srp)

WARNING: space prohibited between function name and open parenthesis '('
#1179: FILE: /tmp/f1-10330/isis_sr.c:1179:
+		frr_each_safe (srdb_node, &area->srdb.sr_nodes[level - 1], srn)

WARNING: Missing a blank line after declarations
#1563: FILE: /tmp/f1-10330/isis_sr.c:1563:
+		struct interface *ifp;
+		ifp = if_lookup_prefix(&srp->prefix, VRF_DEFAULT);

WARNING: space prohibited between function name and open parenthesis '('
#1669: FILE: /tmp/f1-10330/isis_sr.c:1669:
+	frr_each (srdb_area_prefix, &area->srdb.prefix_sids[level - 1], srp) {

WARNING: space prohibited between function name and open parenthesis '('
#1740: FILE: /tmp/f1-10330/isis_sr.c:1740:
+	frr_each (srdb_node, &area->srdb.sr_nodes[level - 1], srn) {
Report for isis_zebra.c | 12 issues
===============================================
< WARNING: please, no space before tabs
< #476: FILE: /tmp/f1-10330/isis_zebra.c:476:
< WARNING: please, no space before tabs
< #518: FILE: /tmp/f1-10330/isis_zebra.c:518:
< WARNING: please, no space before tabs
< #559: FILE: /tmp/f1-10330/isis_zebra.c:559:
< WARNING: line over 80 characters
< #692: FILE: /tmp/f1-10330/isis_zebra.c:692:
< WARNING: line over 80 characters
< #699: FILE: /tmp/f1-10330/isis_zebra.c:699:
< WARNING: Missing a blank line after declarations
< #724: FILE: /tmp/f1-10330/isis_zebra.c:724:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12306/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200514-07-g82624cef0-0 (missing) -> 7.4-dev-20200514-07-g82624cef0-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200514-07-g82624cef0-0 (missing) -> 7.4-dev-20200514-07-g82624cef0-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200514-07-g82624cef0-0 (missing) -> 7.4-dev-20200514-07-g82624cef0-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200514-07-g82624cef0-0 (missing) -> 7.4-dev-20200514-07-g82624cef0-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200514-07-g82624cef0-0 (missing) -> 7.4-dev-20200514-07-g82624cef0-0~deb10u1