ospf6d: withdraw redistributed prefixes based on prefix-list changes #6344
Conversation
Problem reported that when an a previously advertised redistributed route should be withdrawn based on a prefix-list change or route-map deletion, the external LSAs would remain in the database and not be withdrawn from peers. This fix does the withdraw when the prefix-list is changed or route-map is deleted. Ticket: CM-28944 Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12160/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: |
| /* | ||
| * if the mapname matches a route-map on | ||
| * ospf6 but the map doesn't exist, it | ||
| * is being deleted. flush and then |
There was a problem hiding this comment.
LGTM. I think there are more fixes required which may be done in separate PR may be as this fixes delete route-map handling.
Below is one of the example where it can be handled better.
If I have prefix-list for permit any and all the static routes are redistributed and then same command is issued again then we send redistribute delete and add to zebra importing routes from zebra again while nothing has changed.
2020/05/16 07:12:39 OSPF6: ospf6_asbr_distribute_list_update: trigger redistribute static reset thread
2020/05/16 07:12:42 OSPF6: sendmsg failed: ifindex: 8: Network is unreachable (101)
2020/05/16 07:12:42 OSPF6: [EC 100663307] Could not send entire message
2020/05/16 07:12:44 OSPF6: ospf6_asbr_routemap_update_timer: route-map R1 update, reset redist static
2020/05/16 07:12:44 OSPF6: Zebra Receive route add: static 2001::1/128 nexthop :: ifindex 4 tag 0
2020/05/16 07:12:44 OSPF6: Redistribute 2001::1/128 (static)
2020/05/16 07:12:44 OSPF6: Advertise as AS-External Id:0.0.0.16 prefix 2001::1/128 metric 0
2020/05/16 07:12:44 OSPF6: Originate AS-External-LSA for 2001::1/128
2020/05/16 07:12:44 OSPF6: Zebra Receive route add: static 3001::1/128 nexthop :: ifindex 4 tag 2000
2020/05/16 07:12:44 OSPF6: Redistribute 3001::1/128 (static)
2020/05/16 07:12:44 OSPF6: Advertise as AS-External Id:0.0.0.17 prefix 3001::1/128 metric 0
2020/05/16 07:12:44 OSPF6: Originate AS-External-LSA for 3001::1/128
2020/05/16 07:12:44 OSPF6: Zebra Receive route add: static 3001::4/128 nexthop :: ifindex 4 tag 2000
Problem reported that when a previously advertised redistributed
route should be withdrawn based on a prefix-list change or route-map
deletion, the external LSAs would remain in the database and not be
withdrawn from peers. This fix does the withdraw when the prefix-list
is changed or route-map is deleted.
Ticket: CM-28944
Signed-off-by: Don Slice dslice@cumulusnetworks.com