build: spring cleaning #6298

eqvinox · 2020-04-27T07:32:56Z

bunch of random build-related crap. most significant change is nicer (and less bug prone) clippy syntax in subdir.am.

No need to put $(top_srcdir) everywhere. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

... so I can reuse it. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

LabN-CI · 2020-04-27T07:35:47Z

Outdated results 🛑

Basic BGPD CI results: FAILURE

_	_
Result	FAILURE git merge/6298 `6816e08` frr.github Build
Date	04/27/2020
Start	03:35:28
Finish	03:35:44
Run-Time	00:16
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2020-04-27-03:35:28.txt
Log	make-2020-04-27-03:35:28.out.bz2
Memory

For details, please contact louberger

eqvinox · 2020-04-27T07:36:25Z

Ah crap... chicken & egg problem... Makefile is not valid at the point in time where python/makefile.py is trying to use it >_>.

(... which I didn't notice because I didn't do a complete full clean between builds...)

These are easy to get subtly wrong, and doing so can cause nondeterministic failures when racing in parallel builds. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

The first #include statement in all FRR .c files should be either zebra.h or config.h. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Dealing with PRIu64 is unfortunately a bit hacky in the frr-format plugin, as in, it works correctly with snprintfrr, but breaks on plain snprintf. There's no good solution unfortunately :/. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Also try explicit 3.9 & 3.10. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

NetDEF-CI · 2020-04-27T07:59:01Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 12 amd64 build: Failed (click for details)

Configure failed for FreeBSD 12 amd64 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/FBSD12AMD64/ErrorLog/log_configure.txt
FreeBSD 12 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/FBSD12AMD64/config.log/config.log

Ubuntu 14.04 amd64 build: Failed (click for details)

Configure failed for Ubuntu 14.04 amd64 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI001BUILD/ErrorLog/log_configure.txt
Ubuntu 14.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI001BUILD/config.log/config.log

Ubuntu 18.04 amd64 build: Failed (click for details)

Configure failed for Ubuntu 18.04 amd64 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/U1804AMD64/ErrorLog/log_configure.txt
Ubuntu 18.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/U1804AMD64/config.log/config.log

Ubuntu 16.04 i386 build: Failed (click for details)

Configure failed for Ubuntu 16.04 i386 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/U1604I386/ErrorLog/log_configure.txt
Ubuntu 16.04 i386 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/U1604I386/config.log/config.log

Debian 8 amd64 build: Failed (click for details)

Debian 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI008BLD/config.log/config.log

Configure failed for Debian 8 amd64 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI008BLD/ErrorLog/log_configure.txt

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI021BUILD/config.log/config.log

Configure failed for Debian 9 amd64 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI021BUILD/ErrorLog/log_configure.txt

FreeBSD 11 amd64 build: Failed (click for details)

Configure failed for FreeBSD 11 amd64 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI009BUILD/ErrorLog/log_configure.txt
FreeBSD 11 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI009BUILD/config.log/config.log

Ubuntu 18.04 ppc64le build: Failed (click for details)

Configure failed for Ubuntu 18.04 ppc64le build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/U1804PPC64LEBUILD/ErrorLog/log_configure.txt
Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/U1804PPC64LEBUILD/config.log/config.log

OpenBSD 6 amd64 build: Failed (click for details)

Configure failed for OpenBSD 6 amd64 build:
(see full configure log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI011BUILD/ErrorLog/log_configure.txt)

checking directory to use for state file... /var/run
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
*** Parse error in /home/ci/cibuild.12036/frr-source: Could not find babeld/.deps/babel_errors.Po (Makefile:7028)
*** Parse error: Could not find babeld/.deps/babel_filter.Po (Makefile:7029)
*** Parse error: Could not find babeld/.deps/babel_interface.Po (Makefile:7030)
*** Parse error: Could not find babeld/.deps/babel_main.Po (Makefile:7031)

OpenBSD 6 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI011BUILD/config.log/config.log

NetBSD 8 amd64 build: Failed (click for details)

NetBSD 8 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI012BUILD/config.log/config.log

Configure failed for NetBSD 8 amd64 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI012BUILD/ErrorLog/log_configure.txt

Ubuntu 16.04 amd64 build: Failed (click for details)

Configure failed for Ubuntu 16.04 amd64 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI014BUILD/ErrorLog/log_configure.txt
Ubuntu 16.04 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI014BUILD/config.log/config.log

CentOS 7 amd64 build: Failed (click for details)

Configure failed for CentOS 7 amd64 build
see configure log in attachment https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI005BUILD/ErrorLog/log_configure.txt
CentOS 7 amd64 build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/CI005BUILD/config.log/config.log

Successful on other platforms/tests

Ubuntu 12.04 amd64 build
Debian 10 amd64 build
Fedora 29 amd64 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12036/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-g6816e080a-0 (missing) -> 7.4-dev-20200427-08-g6816e080a-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-g6816e080a-0 (missing) -> 7.4-dev-20200427-08-g6816e080a-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-g6816e080a-0 (missing) -> 7.4-dev-20200427-08-g6816e080a-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-g6816e080a-0 (missing) -> 7.4-dev-20200427-08-g6816e080a-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-g6816e080a-0 (missing) -> 7.4-dev-20200427-08-g6816e080a-0~deb10u1

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

LabN-CI · 2020-04-27T08:21:24Z

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/6298 `bc76ad3`
Date	04/27/2020
Start	03:55:28
Finish	04:21:18
Run-Time	25:50
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-27-03:55:28.txt
Log	autoscript-2020-04-27-03:56:27.log.bz2
Memory	488 493 426

For details, please contact louberger

LabN-CI · 2020-04-27T08:51:45Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6298 `209135f`
Date	04/27/2020
Start	04:25:29
Finish	04:51:40
Run-Time	26:11
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-27-04:25:29.txt
Log	autoscript-2020-04-27-04:26:31.log.bz2
Memory	497 498 425

For details, please contact louberger

NetDEF-CI · 2020-04-27T09:33:41Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12037/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12037/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-gbc76ad3f2-0 (missing) -> 7.4-dev-20200427-08-gbc76ad3f2-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-gbc76ad3f2-0 (missing) -> 7.4-dev-20200427-08-gbc76ad3f2-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-gbc76ad3f2-0 (missing) -> 7.4-dev-20200427-08-gbc76ad3f2-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-gbc76ad3f2-0 (missing) -> 7.4-dev-20200427-08-gbc76ad3f2-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-08-gbc76ad3f2-0 (missing) -> 7.4-dev-20200427-08-gbc76ad3f2-0~deb10u1

NetDEF-CI · 2020-04-27T09:41:45Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12038/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-12038/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-09-g209135f18-0 (missing) -> 7.4-dev-20200427-09-g209135f18-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-09-g209135f18-0 (missing) -> 7.4-dev-20200427-09-g209135f18-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-09-g209135f18-0 (missing) -> 7.4-dev-20200427-09-g209135f18-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-09-g209135f18-0 (missing) -> 7.4-dev-20200427-09-g209135f18-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200427-09-g209135f18-0 (missing) -> 7.4-dev-20200427-09-g209135f18-0~deb10u1

eqvinox added 3 commits April 27, 2020 09:30

build: use VPATH for vtysh_scan

2768748

No need to put $(top_srcdir) everywhere. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

python: move MakeVars class into separate module

879a9dc

... so I can reuse it. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

tools/symalyzer: fix copypasta

ec8f987

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

polychaeta added bfd clippy labels Apr 27, 2020

eqvinox added 6 commits April 27, 2020 09:52

build: make clippy Makefile rules nicer

94cfb06

These are easy to get subtly wrong, and doing so can cause nondeterministic failures when racing in parallel builds. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

python: add check-first-header tool

980ab2d

The first #include statement in all FRR .c files should be either zebra.h or config.h. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: fix first header

7309092

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib/zlog: fix printfrr format attribute

c2527ed

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

build: move python 2.x to the very last preference

bc76ad3

Also try explicit 3.9 & 3.10. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

eqvinox force-pushed the build-assorted-20200423 branch from 6816e08 to bc76ad3 Compare April 27, 2020 07:52

build: silence idiotic libtool warnings

209135f

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

donaldsharp merged commit abe94d6 into FRRouting:master Apr 27, 2020

eqvinox deleted the build-assorted-20200423 branch April 18, 2021 07:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: spring cleaning #6298

build: spring cleaning #6298

eqvinox commented Apr 27, 2020

LabN-CI commented Apr 27, 2020 •

edited

Loading

Basic BGPD CI results: FAILURE

eqvinox commented Apr 27, 2020 •

edited

Loading

NetDEF-CI commented Apr 27, 2020 •

edited

Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Apr 27, 2020 •

edited

Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Apr 27, 2020

NetDEF-CI commented Apr 27, 2020 •

edited

Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2020

build: spring cleaning #6298

build: spring cleaning #6298

Conversation

eqvinox commented Apr 27, 2020

LabN-CI commented Apr 27, 2020 • edited Loading

Basic BGPD CI results: FAILURE

eqvinox commented Apr 27, 2020 • edited Loading

NetDEF-CI commented Apr 27, 2020 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Apr 27, 2020 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Apr 27, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 27, 2020 • edited Loading

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

NetDEF-CI commented Apr 27, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

LabN-CI commented Apr 27, 2020 •

edited

Loading

eqvinox commented Apr 27, 2020 •

edited

Loading

NetDEF-CI commented Apr 27, 2020 •

edited

Loading

LabN-CI commented Apr 27, 2020 •

edited

Loading

NetDEF-CI commented Apr 27, 2020 •

edited

Loading