ospf6d: ospf6_route_add - stack repeats

[dslicenc]

Signed-off-by: Donald Slice dslice@cumulusnetworks.com
Signed-off-by: Daniel Walton dwalton@cumulusnetworks.com
Reviewed-by: Donald Sharp sharpd@cumulusnetworks.com
Reviewed-by: Chirag Shah chirag@cumulusnetworks.com
Ticket: CM-17238

This is a temporary fix until the root cause for CM-17238 has been
resolved. The fix for CM-17238 will back this commit out.

[riw777]

looks good, will check back in a bit for checks to complete

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11404/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11404/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200324-01-g7c275ab51-0 (missing) -> 7.4-dev-20200324-01-g7c275ab51-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200324-01-g7c275ab51-0 (missing) -> 7.4-dev-20200324-01-g7c275ab51-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200324-01-g7c275ab51-0 (missing) -> 7.4-dev-20200324-01-g7c275ab51-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200324-01-g7c275ab51-0 (missing) -> 7.4-dev-20200324-01-g7c275ab51-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200324-01-g7c275ab51-0 (missing) -> 7.4-dev-20200324-01-g7c275ab51-0~deb10u1

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/6083 7c275ab
Date	03/24/2020
Start	11:38:54
Finish	12:05:01
Run-Time	26:07
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-03-24-11:38:54.txt
Log	autoscript-2020-03-24-11:39:50.log.bz2
Memory	470 480 419

For details, please contact louberger

[dslicenc]

Note that this problem relates the issue reported by #852. The temporary fix proposed in the PR was what was used in Cumulus for the last couple of years. I also notice that in ArchLinux, they commented out the call to table->hook_add, which also made the crash stop. I'll start testing with that approach as well to see the ramification of that way of solving it. If anyone has any thoughts on this, feel free to offer them.

[dslicenc]

To recreate this problem, bring up the following topology:

R1-----------R2
|            |
R3----------R4

R1-R2 link is in area 0.0.0.0
All other links are in area 0.0.0.40

Add "redistribute connected" or "redistribute static" on both R1 and R2.
This causes the Inter-area Router LSAs to be advertised in area 0.0.0.40. When R3 and R4 receive these Inter-area Router LSAs, one of the two loops thru the sequence shown in issue #852 until the stack fills and ospf6d crashes.

[dslicenc]

Decided to scrap this PR and resubmit with another approach that I believe actually addresses the issue. Running automated tests against it now and will submit a new PR soon.