*: Do not check for NULL before using sockunion_free()

[ton31337]

This is already handled in XFREE().

[ton31337]

no, looks like it's needed.

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11081/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-11081/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11081/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-11081/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11081/artifact/TOPOI386/ErrorLog/log_topotests.txt

IPv4 protocols on Ubuntu 14.04: Failed (click for details)

RFC Compliance Test ANVL-BGP4-1.3 failing:
Test Summary
Router adds routes contained in the newly received Update Message to
its routing table
Test Reference
ANVL, setup verification
Test Classification
MUST
Test ANVL-BGP4-1.3: !FAILED!
External peer failed to open BGP4 Connection
with DUT through

RFC Compliance Test ANVL-BGP4-1.4 failing:
Test Summary
Router forwards new Update routes
Test Reference
ANVL, setup verification
Test Classification
MUST
Test ANVL-BGP4-1.4: !FAILED!
External peer failed to open BGP4 Connection
with DUT through

RFC Compliance Test ANVL-BGP4-4.1 failing:
Test Summary
An UPDATE message MAY simultaneously advertise a feasible route and
withdraw multiple unfeasible routes from service.
Test Reference
RFC4271, Sect. 4.3, p 15,
UPDATE Message Format
Test Classification
MAY
Test ANVL-BGP4-4.1: !FAILED!
External peer failed to open BGP4 Connection
with DUT through

RFC Compliance Test ANVL-BGP4-21.4 failing:
Test Summary
Start event is ignored in the OpenSent state.
Test Reference
RFC4271, Sect. 8.2.2, p 63,
BGP Finite State machine
Test Classification
MUST
Test ANVL-BGP4-21.4: !FAILED!
External peer failed to open TCP connection
with DUT through

RFC Compliance Test ANVL-BGP4-21.8 failing:
Test Summary
At OpenSent state if there are no errors in the OPEN message, the
local system:
- sends a KEEPALIVE message, and
- sets a KeepaliveTimer
Test Reference
RFC4271, Sect. 8.2.2, p 65,
BGP Finite State machine
Test Classification
MUST
Test ANVL-BGP4-21.8: !FAILED!
External peer failed to open TCP connection
with DUT through

IPv6 protocols on Ubuntu 14.04: Failed (click for details)

RFC Compliance Test ANVL-BGPPLUS-1.1 failing:
Test Summary
DUT Listens on TCP port 179 for BGP4 Connection
Test Reference
ANVL, setup verification
Test Classification
MUST
Test ANVL-BGPPLUS-1.1: !FAILED!
External peer failed to open TCP connection
with port 179 of DUT through

RFC Compliance Test ANVL-BGPPLUS-6.3 failing:
Test Summary
To have a bi-directional exchange of routing information for a
particular <AFI, SAFI> between a pair of BGP speakers, each such
speaker must advertise to the other (via the Capability Advertisement
mechanism) the capability to support that particular <AFI, SAFI>
routes.
Test Reference
RFC 4760, Sect. 8, p 9,
Use of BGP Capability Advertisement
Test Classification
MUST
Test ANVL-BGPPLUS-6.3: !FAILED!
External peer failed to open TCP connection
with DUT through

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-11081/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64
see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11081/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms/tests

• IPv4 ldp protocol on Ubuntu 16.04
• Ubuntu 14.04 deb pkg check
• Addresssanitizer topotest
• Debian 8 deb pkg check
• Debian 9 deb pkg check
• Debian 10 deb pkg check
• CentOS 7 rpm pkg check
• Static analyzer (clang)
• Fedora 29 rpm pkg check
• Ubuntu 16.04 deb pkg check
• Ubuntu 12.04 deb pkg check