Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct ip prefix token mapping table #5826

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

mjstapp
Copy link
Contributor

@mjstapp mjstapp commented Feb 18, 2020

Fix the table that shows the mapping between ip network cli tokens and the data struct that the cli handler will see. Optional network/subnet types appear as a pointer to an all-zeroes struct, not a NULL pointer.

@LabN-CI

This comment has been minimized.

@NetDEF-CI

This comment has been minimized.

@donaldsharp
Copy link
Member

if this is true how do we tell the diff between 0.0.0.0/0 entered and no entry? This seems wrong.

@mjstapp
Copy link
Contributor Author

mjstapp commented Feb 19, 2020

if this is true how do we tell the diff between 0.0.0.0/0 entered and no entry? This seems wrong.

We get a prefixlen of zero (or a prefix type of zero) - it does (seem to) work, it's just not quite what was in the doc.

@mjstapp
Copy link
Contributor Author

mjstapp commented Feb 19, 2020

CI:rerun

Fix the table that shows the mapping between ip network cli
tokens and the data struct that the cli handler will see.
Optional network/subnet types appear as a pointer to an
all-zeroes struct, not a NULL pointer.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
@mjstapp
Copy link
Contributor Author

mjstapp commented Feb 19, 2020

Pushed to clarify the type/contents of the prefix-type pointers

@LabN-CI
Copy link
Collaborator

LabN-CI commented Feb 19, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5826 05c6b1e
Date 02/19/2020
Start 09:40:54
Finish 10:06:50
Run-Time 25:56
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2020-02-19-09:40:54.txt
Log autoscript-2020-02-19-09:41:57.log.bz2
Memory 461 494 419

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10781/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

IPv4 protocols on Ubuntu 14.04: Failed (click for details)
Successful on other platforms
  • Ubuntu 12.04 deb pkg check
  • Static analyzer (clang)
  • Fedora 29 rpm pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Topology tests on Ubuntu 18.04 amd64
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • Topology tests on Ubuntu 16.04 amd64
  • Debian 10 deb pkg check
  • CentOS 7 rpm pkg check
  • Topotest tests on Ubuntu 16.04 i386
  • Ubuntu 14.04 deb pkg check
  • IPv4 ldp protocol on Ubuntu 16.04
  • Debian 9 deb pkg check

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10781/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200218-03-g9dd750a42-0 (missing) -> 7.4-dev-20200218-03-g9dd750a42-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200218-03-g9dd750a42-0 (missing) -> 7.4-dev-20200218-03-g9dd750a42-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200218-03-g9dd750a42-0 (missing) -> 7.4-dev-20200218-03-g9dd750a42-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200218-03-g9dd750a42-0 (missing) -> 7.4-dev-20200218-03-g9dd750a42-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200218-03-g9dd750a42-0 (missing) -> 7.4-dev-20200218-03-g9dd750a42-0~deb10u1
<TITLE>clang_check</TITLE>

clang_check

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10783/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10783/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200219-00-g05c6b1e4b-0 (missing) -> 7.4-dev-20200219-00-g05c6b1e4b-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200219-00-g05c6b1e4b-0 (missing) -> 7.4-dev-20200219-00-g05c6b1e4b-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200219-00-g05c6b1e4b-0 (missing) -> 7.4-dev-20200219-00-g05c6b1e4b-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200219-00-g05c6b1e4b-0 (missing) -> 7.4-dev-20200219-00-g05c6b1e4b-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200219-00-g05c6b1e4b-0 (missing) -> 7.4-dev-20200219-00-g05c6b1e4b-0~deb10u1
<TITLE>clang_check</TITLE>

clang_check

@donaldsharp donaldsharp merged commit 67c5e28 into FRRouting:master Feb 19, 2020
@mjstapp mjstapp deleted the fix_cli_pfx_doc branch March 4, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants