Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2] tests: fix endian bug in test_typelist #5562

Merged
merged 1 commit into from
Dec 19, 2019
Merged

[7.2] tests: fix endian bug in test_typelist #5562

merged 1 commit into from
Dec 19, 2019

Conversation

mjstapp
Copy link
Contributor

@mjstapp mjstapp commented Dec 18, 2019

[7.2 version] Fix a byte-swapping bug that appeared on big-endian arch but wasn't visible on little-endian.

tests: fix endian bug in test_typelist
703f865 
[7.2 version] Fix a byte-swapping bug that appeared on
big-endian arch but wasn't visible on little-endian.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
@polychaeta polychaeta added the tests Topotests, make check, etc label Dec 18, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented Dec 18, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5562 703f865
Date 12/18/2019
Start 14:40:12
Finish 15:05:50
Run-Time 25:38
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-12-18-14:40:12.txt
Log autoscript-2019-12-18-14:41:03.log.bz2
Memory 426 434 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10152/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-10152/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-12-18 20:15:19,592 ERROR: ******************************************************************************
2019-12-18 20:15:19,592 ERROR: Test Target Summary                                                  Pass Fail
2019-12-18 20:15:19,592 ERROR: ******************************************************************************
2019-12-18 20:15:19,592 ERROR: FILE: scripts/check_linux_vrf.py
2019-12-18 20:15:19,592 ERROR: 14   r1     VRF cust1 IP config                                      0    1
2019-12-18 20:15:19,592 ERROR: 17   r3     VRF cust1 IP config                                      0    1
2019-12-18 20:15:19,592 ERROR: 20   r4     VRF cust1 IP config                                      0    1
2019-12-18 20:15:19,592 ERROR: See /tmp/topotests/bgp_instance_del_test.test_bgp_instance_del_test/output.log for details of errors
2019-12-18 20:15:19,593 ERROR: assert failed at "bgp_instance_del_test.test_bgp_instance_del_test/test_check_linux_vrf": 3 tests failed
2019-12-18 20:17:39,794 ERROR: ******************************************************************************
2019-12-18 20:17:39,795 ERROR: Test Target Summary                                                  Pass Fail
2019-12-18 20:17:39,795 ERROR: ******************************************************************************
2019-12-18 20:17:39,795 ERROR: FILE: scripts/check_linux_vrf.py
2019-12-18 20:17:39,795 ERROR: 14   r1     VRF cust1 IP config                                      0    1
2019-12-18 20:17:39,795 ERROR: 17   r3     VRF cust1 IP config                                      0    1
2019-12-18 20:17:39,795 ERROR: 20   r4     VRF cust1 IP config                                      0    1
2019-12-18 20:17:39,795 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-12-18 20:17:39,795 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_linux_vrf": 3 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10152/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • IPv4 protocols on Ubuntu 14.04
  • Topology tests on Ubuntu 16.04 amd64
  • Debian 9 deb pkg check
  • Topotest tests on Ubuntu 16.04 i386
  • CentOS 7 rpm pkg check
  • Debian 10 deb pkg check
  • Static analyzer (clang)
  • Ubuntu 16.04 deb pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Fedora 29 rpm pkg check
  • Ubuntu 12.04 deb pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10152/artifact/TOPOU1804/MemoryLeaks/

CLANG Static Analyzer Summary

  • Github Pull Request 5562, comparing to Git base SHA 6e8671a

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10152/artifact/shared/static_analysis/index.html

@mjstapp
Copy link
Contributor Author

mjstapp commented Dec 18, 2019

CI:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10157/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-10157/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-12-18 21:46:19,149 ERROR: ******************************************************************************
2019-12-18 21:46:19,149 ERROR: Test Target Summary                                                  Pass Fail
2019-12-18 21:46:19,150 ERROR: ******************************************************************************
2019-12-18 21:46:19,150 ERROR: FILE: scripts/check_linux_vrf.py
2019-12-18 21:46:19,150 ERROR: 14   r1     VRF cust1 IP config                                      0    1
2019-12-18 21:46:19,150 ERROR: 17   r3     VRF cust1 IP config                                      0    1
2019-12-18 21:46:19,150 ERROR: 20   r4     VRF cust1 IP config                                      0    1
2019-12-18 21:46:19,150 ERROR: See /tmp/topotests/bgp_instance_del_test.test_bgp_instance_del_test/output.log for details of errors
2019-12-18 21:46:19,151 ERROR: assert failed at "bgp_instance_del_test.test_bgp_instance_del_test/test_check_linux_vrf": 3 tests failed
2019-12-18 21:48:50,348 ERROR: ******************************************************************************
2019-12-18 21:48:50,348 ERROR: Test Target Summary                                                  Pass Fail
2019-12-18 21:48:50,348 ERROR: ******************************************************************************
2019-12-18 21:48:50,349 ERROR: FILE: scripts/check_linux_vrf.py
2019-12-18 21:48:50,349 ERROR: 14   r1     VRF cust1 IP config                                      0    1
2019-12-18 21:48:50,349 ERROR: 17   r3     VRF cust1 IP config                                      0    1
2019-12-18 21:48:50,349 ERROR: 20   r4     VRF cust1 IP config                                      0    1
2019-12-18 21:48:50,349 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-12-18 21:48:50,349 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_linux_vrf": 3 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10157/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms
  • Addresssanitizer topotest
  • Debian 8 deb pkg check
  • Topology tests on Ubuntu 16.04 amd64
  • Debian 10 deb pkg check
  • CentOS 7 rpm pkg check
  • Topotest tests on Ubuntu 16.04 i386
  • IPv4 protocols on Ubuntu 14.04
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Debian 9 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Static analyzer (clang)
  • Fedora 29 rpm pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Ubuntu 16.04 deb pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10157/artifact/TOPOU1804/MemoryLeaks/

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10157/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-pythontools: changelog-file-missing-explicit-entry 7.2-0 -> 7.2-20191218-00-g703f86574-0 (missing) -> 7.2-20191218-00-g703f86574-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 7.2-0 -> 7.2-20191218-00-g703f86574-0 (missing) -> 7.2-20191218-00-g703f86574-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 7.2-0 -> 7.2-20191218-00-g703f86574-0 (missing) -> 7.2-20191218-00-g703f86574-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 7.2-0 -> 7.2-20191218-00-g703f86574-0 (missing) -> 7.2-20191218-00-g703f86574-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 7.2-0 -> 7.2-20191218-00-g703f86574-0 (missing) -> 7.2-20191218-00-g703f86574-0~deb10u1

CLANG Static Analyzer Summary

  • Github Pull Request 5562, comparing to Git base SHA 6e8671a

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10157/artifact/shared/static_analysis/index.html

@qlyoung
Copy link
Member

qlyoung commented Dec 19, 2019

ci:rerun

@qlyoung qlyoung added the bugfix label Dec 19, 2019
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10158/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-10158/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-12-19 04:56:13,019 ERROR: ******************************************************************************
2019-12-19 04:56:13,019 ERROR: Test Target Summary                                                  Pass Fail
2019-12-19 04:56:13,019 ERROR: ******************************************************************************
2019-12-19 04:56:13,019 ERROR: FILE: scripts/check_linux_vrf.py
2019-12-19 04:56:13,019 ERROR: 14   r1     VRF cust1 IP config                                      0    1
2019-12-19 04:56:13,019 ERROR: 17   r3     VRF cust1 IP config                                      0    1
2019-12-19 04:56:13,020 ERROR: 20   r4     VRF cust1 IP config                                      0    1
2019-12-19 04:56:13,020 ERROR: See /tmp/topotests/bgp_instance_del_test.test_bgp_instance_del_test/output.log for details of errors
2019-12-19 04:56:13,020 ERROR: assert failed at "bgp_instance_del_test.test_bgp_instance_del_test/test_check_linux_vrf": 3 tests failed
2019-12-19 04:58:29,233 ERROR: ******************************************************************************
2019-12-19 04:58:29,233 ERROR: Test Target Summary                                                  Pass Fail
2019-12-19 04:58:29,233 ERROR: ******************************************************************************
2019-12-19 04:58:29,233 ERROR: FILE: scripts/check_linux_vrf.py
2019-12-19 04:58:29,233 ERROR: 14   r1     VRF cust1 IP config                                      0    1
2019-12-19 04:58:29,233 ERROR: 17   r3     VRF cust1 IP config                                      0    1
2019-12-19 04:58:29,233 ERROR: 20   r4     VRF cust1 IP config                                      0    1
2019-12-19 04:58:29,233 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-12-19 04:58:29,234 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_linux_vrf": 3 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10158/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms
  • Topotest tests on Ubuntu 16.04 i386
  • CentOS 7 rpm pkg check
  • Addresssanitizer topotest
  • Debian 10 deb pkg check
  • Debian 8 deb pkg check
  • Debian 9 deb pkg check
  • Topology tests on Ubuntu 16.04 amd64
  • IPv4 protocols on Ubuntu 14.04
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Static analyzer (clang)
  • Fedora 29 rpm pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Ubuntu 16.04 deb pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10158/artifact/TOPOU1804/MemoryLeaks/

CLANG Static Analyzer Summary

  • Github Pull Request 5562, comparing to Git base SHA 6e8671a

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10158/artifact/shared/static_analysis/index.html

@ton31337
Copy link
Member

I get the same error from CI:

frr-rpki-rtrlib depends on librtr0; however:
  Package librtr0 is not installed.

dpkg: error processing package frr-rpki-rtrlib (--install):
dependency problems - leaving unconfigured
Errors were encountered while processing:
frr-rpki-rtrlib

@qlyoung qlyoung merged commit 74d22c3 into FRRouting:stable/7.2 Dec 19, 2019
@mjstapp mjstapp deleted the fix_test_typelist_7_2 branch February 12, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ton31337 ton31337 ton31337 approved these changes

Assignees
No one assigned
Labels
bugfix tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mjstapp @LabN-CI @NetDEF-CI @qlyoung @ton31337 @polychaeta