zebra: netlink FPM interface using zebra data plane #5510

rzalamena · 2019-12-09T19:40:07Z

Summary

In order to reduce code duplication and simplify the FPM code, I've implemented a new FPM netlink interface using the new zebra data plane framework: it reuses all zebra netlink code for encoding messages and does not access zebra data structures directly (no more pointers to data we don't have).

This is a work-in-progress and I'll update it as I finish the todo list below and receive feedback.

I would like to receive reports from FPM netlink users that use RMAC since I don't have the appropriate tools to test it.

TODO

Configuration knobs (address/port)
Status counters

polychaeta

Thanks for your contribution to FRR!

Click for style suggestions

To apply these suggestions:

curl -s https://gist.githubusercontent.com/polychaeta/578b311aa65bbcc21c3ae592df5309be/raw/7841e7ea7690fee10e7b5e05785b805b0e53a776/cr_5510_1575920414.diff | git apply

diff --git a/zebra/rt_netlink.c b/zebra/rt_netlink.c
index 96064be6a..ad5dee43a 100644
--- a/zebra/rt_netlink.c
+++ b/zebra/rt_netlink.c
@@ -1258,8 +1258,8 @@ static void _netlink_route_build_singlepath(const char *routedesc, int bytelen,
 		}
 
 		if (IS_ZEBRA_DEBUG_KERNEL)
-			zlog_debug("%s: (%s): nexthop via if %u(%u)",
-				   __func__, routedesc, nexthop->ifindex,
+			zlog_debug("%s: (%s): nexthop via if %u(%u)", __func__,
+				   routedesc, nexthop->ifindex,
 				   nexthop->vrf_id);
 	}
 }
@@ -1356,8 +1356,8 @@ static void _netlink_route_build_multipath(const char *routedesc, int bytelen,
 
 		if (IS_ZEBRA_DEBUG_KERNEL)
 			zlog_debug("%s: 5549 (%s): nexthop via %s %s if %u",
-				__func__, routedesc, ipv4_ll_buf, label_buf,
-				nexthop->ifindex);
+				   __func__, routedesc, ipv4_ll_buf, label_buf,
+				   nexthop->ifindex);
 		return;
 	}
 
@@ -1374,7 +1374,7 @@ static void _netlink_route_build_multipath(const char *routedesc, int bytelen,
 		if (IS_ZEBRA_DEBUG_KERNEL) {
 			inet_ntop(AF_INET, &nexthop->gate.ipv4, addrstr,
 				  sizeof(addrstr));
-			zlog_debug( "%s: (%s): nexthop via %s %s if %u",
+			zlog_debug("%s: (%s): nexthop via %s %s if %u",
 				   __func__, routedesc, addrstr, label_buf,
 				   nexthop->ifindex);
 		}
@@ -1393,7 +1393,7 @@ static void _netlink_route_build_multipath(const char *routedesc, int bytelen,
 		if (IS_ZEBRA_DEBUG_KERNEL) {
 			inet_ntop(AF_INET, &nexthop->gate.ipv6, addrstr,
 				  sizeof(addrstr));
-			zlog_debug( "%s: (%s): nexthop via %s %s if %u",
+			zlog_debug("%s: (%s): nexthop via %s %s if %u",
 				   __func__, routedesc, addrstr, label_buf,
 				   nexthop->ifindex);
 		}
@@ -1415,8 +1415,8 @@ static void _netlink_route_build_multipath(const char *routedesc, int bytelen,
 			*src = &nexthop->src;
 
 		if (IS_ZEBRA_DEBUG_KERNEL)
-			zlog_debug("%s: (%s): nexthop via if %u",
-				   __func__, routedesc, nexthop->ifindex);
+			zlog_debug("%s: (%s): nexthop via if %u", __func__,
+				   routedesc, nexthop->ifindex);
 	}
 }
 
@@ -1586,10 +1586,9 @@ ssize_t netlink_route_multipath(int cmd, struct zebra_dplane_ctx *ctx,
 	}
 
 	if (IS_ZEBRA_DEBUG_KERNEL)
-		zlog_debug(
-			"%s: %s %pFX vrf %u(%u)", __func__,
-			nl_msg_type_to_str(cmd), p, dplane_ctx_get_vrf(ctx),
-			table_id);
+		zlog_debug("%s: %s %pFX vrf %u(%u)", __func__,
+			   nl_msg_type_to_str(cmd), p, dplane_ctx_get_vrf(ctx),
+			   table_id);
 
 	/*
 	 * If we are not updating the route and we have received
@@ -2150,8 +2149,8 @@ enum zebra_dplane_result kernel_route_update(struct zebra_dplane_ctx *ctx)
 			 * route should cause us to withdraw from
 			 * the kernel the old non-system route
 			 */
-			if (RSYSTEM_ROUTE(dplane_ctx_get_type(ctx)) &&
-			    !RSYSTEM_ROUTE(dplane_ctx_get_old_type(ctx))) {
+			if (RSYSTEM_ROUTE(dplane_ctx_get_type(ctx))
+			    && !RSYSTEM_ROUTE(dplane_ctx_get_old_type(ctx))) {
 				netlink_route_multipath(RTM_DELROUTE, ctx,
 							nl_pkt, sizeof(nl_pkt));
 				netlink_talk_info(netlink_talk_filter,
@@ -2881,9 +2880,8 @@ int netlink_macfdb_read_specific_mac(struct zebra_ns *zns,
 /*
  * Netlink-specific handler for MAC updates using dataplane context object.
  */
-ssize_t
-netlink_macfdb_update_ctx(struct zebra_dplane_ctx *ctx, uint8_t *data,
-			  size_t datalen)
+ssize_t netlink_macfdb_update_ctx(struct zebra_dplane_ctx *ctx, uint8_t *data,
+				  size_t datalen)
 {
 	uint8_t protocol = RTPROT_ZEBRA;
 	struct {
@@ -2956,8 +2954,8 @@ netlink_macfdb_update_ctx(struct zebra_dplane_ctx *ctx, uint8_t *data,
 			   nl_family_to_str(req->ndm.ndm_family),
 			   dplane_ctx_get_ifname(ctx),
 			   dplane_ctx_get_ifindex(ctx), vid_buf,
-			   dplane_ctx_mac_is_sticky(ctx) ? "sticky " : "",
-			   buf, dst_buf);
+			   dplane_ctx_mac_is_sticky(ctx) ? "sticky " : "", buf,
+			   dst_buf);
 	}
 
 	return NLMSG_ALIGN(req->n.nlmsg_len);
@@ -3402,10 +3400,10 @@ enum zebra_dplane_result kernel_mac_update_ctx(struct zebra_dplane_ctx *ctx)
 		return ZEBRA_DPLANE_REQUEST_FAILURE;
 
 	rv = netlink_talk_info(netlink_talk_filter, (struct nlmsghdr *)nl_buf,
-				dplane_ctx_get_ns(ctx), 0);
+			       dplane_ctx_get_ns(ctx), 0);
 
-	return rv == 0 ?
-		ZEBRA_DPLANE_REQUEST_SUCCESS : ZEBRA_DPLANE_REQUEST_FAILURE;
+	return rv == 0 ? ZEBRA_DPLANE_REQUEST_SUCCESS
+		       : ZEBRA_DPLANE_REQUEST_FAILURE;
 }
 
 enum zebra_dplane_result kernel_neigh_update_ctx(struct zebra_dplane_ctx *ctx)
diff --git a/zebra/zebra_dplane.c b/zebra/zebra_dplane.c
index 30271f0c2..0975b0ed3 100644
--- a/zebra/zebra_dplane.c
+++ b/zebra/zebra_dplane.c
@@ -2402,8 +2402,8 @@ enum zebra_dplane_result dplane_mac_add(const struct interface *ifp,
 	enum zebra_dplane_result result;
 
 	/* Use common helper api */
-	ctx = mac_update_internal(DPLANE_OP_MAC_INSTALL, ifp, bridge_ifp,
-				  vid, mac, vtep_ip, sticky);
+	ctx = mac_update_internal(DPLANE_OP_MAC_INSTALL, ifp, bridge_ifp, vid,
+				  mac, vtep_ip, sticky);
 
 	/* Enqueue for processing on the dplane pthread */
 	result = dplane_update_enqueue(ctx);
@@ -2437,8 +2437,8 @@ enum zebra_dplane_result dplane_mac_del(const struct interface *ifp,
 	enum zebra_dplane_result result;
 
 	/* Use common helper api */
-	ctx = mac_update_internal(DPLANE_OP_MAC_DELETE, ifp, bridge_ifp,
-				  vid, mac, vtep_ip, false);
+	ctx = mac_update_internal(DPLANE_OP_MAC_DELETE, ifp, bridge_ifp, vid,
+				  mac, vtep_ip, false);
 
 	/* Enqueue for processing on the dplane pthread */
 	result = dplane_update_enqueue(ctx);
@@ -2463,12 +2463,9 @@ enum zebra_dplane_result dplane_mac_del(const struct interface *ifp,
  * Common helper api for MAC address/vxlan updates
  */
 struct zebra_dplane_ctx *
-mac_update_internal(enum dplane_op_e op,
-		    const struct interface *ifp,
-		    const struct interface *br_ifp,
-		    vlanid_t vid,
-		    const struct ethaddr *mac,
-		    struct in_addr vtep_ip,
+mac_update_internal(enum dplane_op_e op, const struct interface *ifp,
+		    const struct interface *br_ifp, vlanid_t vid,
+		    const struct ethaddr *mac, struct in_addr vtep_ip,
 		    bool sticky)
 {
 	struct zebra_dplane_ctx *ctx = NULL;
diff --git a/zebra/zebra_dplane.h b/zebra/zebra_dplane.h
index f6352b27d..a6ac983f2 100644
--- a/zebra/zebra_dplane.h
+++ b/zebra/zebra_dplane.h
@@ -430,11 +430,11 @@ enum zebra_dplane_result dplane_intf_addr_unset(const struct interface *ifp,
 /*
  * Enqueue evpn mac operations for the dataplane.
  */
-extern struct zebra_dplane_ctx *mac_update_internal(
-	enum dplane_op_e op, const struct interface *ifp,
-	const struct interface *br_ifp,
-	vlanid_t vid, const struct ethaddr *mac,
-	struct in_addr vtep_ip, bool sticky);
+extern struct zebra_dplane_ctx *
+mac_update_internal(enum dplane_op_e op, const struct interface *ifp,
+		    const struct interface *br_ifp, vlanid_t vid,
+		    const struct ethaddr *mac, struct in_addr vtep_ip,
+		    bool sticky);
 
 enum zebra_dplane_result dplane_mac_add(const struct interface *ifp,
 					const struct interface *bridge_ifp,
diff --git a/zebra/zebra_vxlan_private.h b/zebra/zebra_vxlan_private.h
index 73ebb1734..1b0193b70 100644
--- a/zebra/zebra_vxlan_private.h
+++ b/zebra/zebra_vxlan_private.h
@@ -303,7 +303,7 @@ struct zebra_mac_t_ {
 /* remote VTEP advertised MAC as default GW */
 #define ZEBRA_MAC_REMOTE_DEF_GW	0x40
 #define ZEBRA_MAC_DUPLICATE 0x80
-#define ZEBRA_MAC_FPM_SENT  0x100 /* whether or not this entry was sent. */
+#define ZEBRA_MAC_FPM_SENT 0x100 /* whether or not this entry was sent. */
 
 	/* back pointer to zvni */
 	zebra_vni_t     *zvni;

If you are a new contributor to FRR, please see our contributing guidelines.

LabN-CI · 2019-12-09T20:06:10Z

💚 Outdated results

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/5510 `e5a52b4`
Date	12/09/2019
Start	14:40:27
Finish	15:06:07
Run-Time	25:40
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-12-09-14:40:27.txt
Log	autoscript-2019-12-09-14:41:18.log.bz2
Memory	428 427 360

For details, please contact louberger

NetDEF-CI · 2019-12-09T20:13:58Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1604I386/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

NetBSD 7 amd64 build: Failed (click for details)

Make failed for NetBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI012BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI005BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/F29BUILD/ErrorLog/log_package_build.txt

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI011BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI009BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI007BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

Successful on other platforms

Debian 9 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 12.04 amd64 build
Ubuntu 14.04 amd64 build
Debian 8 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1604I386/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

NetBSD 7 amd64 build: Failed (click for details)

Make failed for NetBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI012BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI005BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/F29BUILD/ErrorLog/log_package_build.txt

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI011BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI009BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/CI007BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10026/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

Report for dplane_fpm_nl.c | 12 issues
===============================================
WARNING: braces {} are not necessary for single statement blocks
#431: FILE: /tmp/f1-27933/dplane_fpm_nl.c:431:
+			if (dest == NULL || dest->selected_fib == NULL) {
+				continue;
+			}

WARNING: braces {} are not necessary for single statement blocks
#436: FILE: /tmp/f1-27933/dplane_fpm_nl.c:436:
+			if (CHECK_FLAG(dest->flags, RIB_DEST_UPDATE_FPM)) {
+				continue;
+			}
Report for rt_netlink.c | 4 issues
===============================================
< ERROR: space prohibited after that open parenthesis '('
< #1377: FILE: /tmp/f1-27933/rt_netlink.c:1377:
< ERROR: space prohibited after that open parenthesis '('
< #1396: FILE: /tmp/f1-27933/rt_netlink.c:1396:

rzalamena · 2019-12-09T20:22:14Z

Ops: CI needs to handle the new module, but lets wait this PR becomes mergeable before doing any changes there.

srimohans · 2019-12-09T21:35:27Z

@rzalamena what information do you need regarding "I would like to receive reports from FPM netlink users that use RMAC since I don't have the appropriate tools to test it." ??

We (VMWare) do use FPM interface and also RMAC.

rzalamena · 2019-12-09T23:38:39Z

@rzalamena what information do you need regarding "I would like to receive reports from FPM netlink users that use RMAC since I don't have the appropriate tools to test it." ??

We (VMWare) do use FPM interface and also RMAC.

@srimohans I'm interested to hear if this new FPM module works for you.

Start zebra with it and connect it to your dataplane and see if you get same results as the old FPM module. Here are some suggestion tests that should cover the basics:

Test data plane messages:

Start empty configuration
Start your data plane that uses FPM
Configure new RMACs
Check if kernel and your data plane have the same RMACs
Remove some RMACs
Check if kernel and your data plane have the same RMACs

FPM restart:

Start full configuration (or continue from test 1)
Start your data plane that uses FPM
Check if kernel and your data plane have the same RMACs
Restart your data plane
Check if kernel and your data plane have the same RMACs

FPM VRF removal handling (bug mentioned in the issue in the first comment)

Start full configuration with VRF (or continue from test 1)
Start your data plane that uses FPM
Check if kernel and your data plane have the same RMACs
Remove VRF
Check for zebra crashes (easier if you run zebra with address sanitizer)
Check if kernel and your data plane have the same RMACs

To run with the new module you have to use:

zebra -M dplane_fpm_nl instead of zebra -M fpm.

srimohans · 2019-12-10T04:21:00Z

@rzalamena Sure. Will ping you on slack for more details. Thanks.

mjstapp

I had some questions - I'll take a look and see if I can help make the dplane apis work a bit better for you.

mjstapp · 2019-12-10T17:31:18Z

zebra/dplane_fpm_nl.c

+			}
+
+			/* Enqueue route install. */
+			ctx = dplane_ctx_alloc();


so let's come up with a way for you to re-use a context object in this loop, so we don't have to do so many alloc/free cycles. the code's all there to init / re-init the objectg - it's just a matter of making it available in the right way so it's easy for you to use?

If you can manage it in a easy way it would be great. I did not want to touch this part because it seem to do more allocations in the opaque struct zebra_dplane_ctx and I didn't want to add more complexity to this PR.

zebra/dplane_fpm_nl.c

zebra/zebra_dplane.c

mjstapp · 2019-12-10T17:40:29Z

zebra/zebra_dplane.c

-				 enum dplane_op_e op,
-				 struct route_node *rn,
-				 struct route_entry *re)
+int dplane_ctx_route_init(struct zebra_dplane_ctx *ctx, enum dplane_op_e op,


I'm good with exposing this, but I think we could make the path more useful by ensuring we get a memset in the path, so we can reuse a ctx in the rib walk.

What happens with the allocated data in that function?

Example:

/* Copy nexthops; recursive info is included too */ copy_nexthops(&(ctx->u.rinfo.zd_ng.nexthop), re->nhe->nhg->nexthop, NULL);

NetDEF-CI · 2019-12-10T20:41:21Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/F29BUILD/ErrorLog/log_package_build.txt

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1604I386/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI009BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI012BUILD/config.status/config.status

Successful on other platforms

Ubuntu 16.04 amd64 build
Ubuntu 14.04 amd64 build
Debian 8 amd64 build
Debian 9 amd64 build
Ubuntu 12.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/F29BUILD/ErrorLog/log_package_build.txt

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1604I386/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804AMD64/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI009BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10070/artifact/CI012BUILD/config.status/config.status

Report for dplane_fpm_nl.c | 17 issues
===============================================
ERROR: space prohibited after that '*' (ctx:WxW)
#77: FILE: /tmp/f1-23222/dplane_fpm_nl.c:77:
+} * gfnc;
   ^

WARNING: braces {} are not necessary for single statement blocks
#567: FILE: /tmp/f1-23222/dplane_fpm_nl.c:567:
+			if (dest == NULL || dest->selected_fib == NULL) {
+				continue;
+			}

WARNING: braces {} are not necessary for single statement blocks
#572: FILE: /tmp/f1-23222/dplane_fpm_nl.c:572:
+			if (CHECK_FLAG(dest->flags, RIB_DEST_UPDATE_FPM)) {
+				continue;
+			}
Report for rt_netlink.c | 4 issues
===============================================
< ERROR: space prohibited after that open parenthesis '('
< #1377: FILE: /tmp/f1-23222/rt_netlink.c:1377:
< ERROR: space prohibited after that open parenthesis '('
< #1396: FILE: /tmp/f1-23222/rt_netlink.c:1396:

LabN-CI · 2019-12-10T20:46:05Z

💚 Outdated results

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/5510 `34ce451`
Date	12/10/2019
Start	15:20:27
Finish	15:46:02
Run-Time	25:35
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-12-10-15:20:27.txt
Log	autoscript-2019-12-10-15:21:15.log.bz2
Memory	423 433 360

For details, please contact louberger

NetDEF-CI · 2019-12-10T22:07:12Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI011BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI009BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/F29BUILD/ErrorLog/log_package_build.txt

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1604I386/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804AMD64/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Successful on other platforms

Ubuntu 16.04 amd64 build
Debian 8 amd64 build
Debian 9 amd64 build
Ubuntu 12.04 amd64 build
Ubuntu 14.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI011BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI009BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/F29BUILD/ErrorLog/log_package_build.txt

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1604I386/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804AMD64/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/CI005BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10072/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Report for dplane_fpm_nl.c | 17 issues
===============================================
ERROR: space prohibited after that '*' (ctx:WxW)
#77: FILE: /tmp/f1-18200/dplane_fpm_nl.c:77:
+} * gfnc;
   ^

WARNING: braces {} are not necessary for single statement blocks
#570: FILE: /tmp/f1-18200/dplane_fpm_nl.c:570:
+			if (dest == NULL || dest->selected_fib == NULL) {
+				continue;
+			}

WARNING: braces {} are not necessary for single statement blocks
#575: FILE: /tmp/f1-18200/dplane_fpm_nl.c:575:
+			if (CHECK_FLAG(dest->flags, RIB_DEST_UPDATE_FPM)) {
+				continue;
+			}
Report for rt_netlink.c | 4 issues
===============================================
< ERROR: space prohibited after that open parenthesis '('
< #1377: FILE: /tmp/f1-18200/rt_netlink.c:1377:
< ERROR: space prohibited after that open parenthesis '('
< #1396: FILE: /tmp/f1-18200/rt_netlink.c:1396:

LabN-CI · 2019-12-10T22:11:04Z

💚 Outdated results

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/5510 `c8485a4`
Date	12/10/2019
Start	16:45:27
Finish	17:11:01
Run-Time	25:34
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-12-10-16:45:27.txt
Log	autoscript-2019-12-10-16:46:16.log.bz2
Memory	436 412 354

For details, please contact louberger

LabN-CI · 2019-12-11T17:31:08Z

💚 Outdated results

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git merge/5510 `09ff671`
Date	12/11/2019
Start	12:05:26
Finish	12:31:06
Run-Time	25:40
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-12-11-12:05:26.txt
Log	autoscript-2019-12-11-12:06:18.log.bz2
Memory	419 433 360

For details, please contact louberger

NetDEF-CI · 2019-12-11T17:33:52Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1604I386/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI012BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI005BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/F29BUILD/ErrorLog/log_package_build.txt

Successful on other platforms

Ubuntu 14.04 amd64 build
Debian 9 amd64 build
Debian 8 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 12.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1604I386/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI012BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/CI005BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10084/artifact/F29BUILD/ErrorLog/log_package_build.txt

Report for dplane_fpm_nl.c | 42 issues
===============================================
ERROR: space prohibited after that '*' (ctx:WxW)
#102: FILE: /tmp/f1-25303/dplane_fpm_nl.c:102:
+} * gfnc;
   ^

WARNING: macros should not use a trailing semicolon
#216: FILE: /tmp/f1-25303/dplane_fpm_nl.c:216:
+#define SHOW_COUNTER(label, counter) \
+	vty_out(vty, "%28s: %Lu\n", (label), (counter));

WARNING: %Lu is non-standard C, use %llu
#217: FILE: /tmp/f1-25303/dplane_fpm_nl.c:217:
+	vty_out(vty, "%28s: %Lu\n", (label), (counter));

WARNING: line over 80 characters
#246: FILE: /tmp/f1-25303/dplane_fpm_nl.c:246:
+	json_object_int_add(jo, "connection-closes", gfnc->counters.connection_closes);

WARNING: line over 80 characters
#247: FILE: /tmp/f1-25303/dplane_fpm_nl.c:247:
+	json_object_int_add(jo, "connection-errors", gfnc->counters.connection_errors);

WARNING: line over 80 characters
#248: FILE: /tmp/f1-25303/dplane_fpm_nl.c:248:
+	json_object_int_add(jo, "data-plane-contexts", gfnc->counters.dplane_contexts);

WARNING: line over 80 characters
#250: FILE: /tmp/f1-25303/dplane_fpm_nl.c:250:
+	json_object_int_add(jo, "user-configures", gfnc->counters.user_configures);

WARNING: braces {} are not necessary for single statement blocks
#676: FILE: /tmp/f1-25303/dplane_fpm_nl.c:676:
+			if (dest == NULL || dest->selected_fib == NULL) {
+				continue;
+			}

WARNING: braces {} are not necessary for single statement blocks
#681: FILE: /tmp/f1-25303/dplane_fpm_nl.c:681:
+			if (CHECK_FLAG(dest->flags, RIB_DEST_UPDATE_FPM)) {
+				continue;
+			}
Report for rt_netlink.c | 4 issues
===============================================
< ERROR: space prohibited after that open parenthesis '('
< #1377: FILE: /tmp/f1-25303/rt_netlink.c:1377:
< ERROR: space prohibited after that open parenthesis '('
< #1396: FILE: /tmp/f1-25303/rt_netlink.c:1396:

NetDEF-CI · 2019-12-12T13:37:01Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/F29BUILD/ErrorLog/log_package_build.txt

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI005BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI012BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804AMD64/config.status/config.status

Successful on other platforms

Debian 9 amd64 build
Ubuntu 12.04 amd64 build
Debian 8 amd64 build
Ubuntu 14.04 amd64 build
Ubuntu 16.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/F29BUILD/ErrorLog/log_package_build.txt

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI005BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI012BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10096/artifact/U1804AMD64/config.status/config.status

Report for dplane_fpm_nl.c | 42 issues
===============================================
ERROR: space prohibited after that '*' (ctx:WxW)
#119: FILE: /tmp/f1-10031/dplane_fpm_nl.c:119:
+} * gfnc;
   ^

WARNING: macros should not use a trailing semicolon
#258: FILE: /tmp/f1-10031/dplane_fpm_nl.c:258:
+#define SHOW_COUNTER(label, counter) \
+	vty_out(vty, "%28s: %Lu\n", (label), (counter));

WARNING: %Lu is non-standard C, use %llu
#259: FILE: /tmp/f1-10031/dplane_fpm_nl.c:259:
+	vty_out(vty, "%28s: %Lu\n", (label), (counter));

WARNING: line over 80 characters
#292: FILE: /tmp/f1-10031/dplane_fpm_nl.c:292:
+	json_object_int_add(jo, "connection-closes", gfnc->counters.connection_closes);

WARNING: line over 80 characters
#293: FILE: /tmp/f1-10031/dplane_fpm_nl.c:293:
+	json_object_int_add(jo, "connection-errors", gfnc->counters.connection_errors);

WARNING: line over 80 characters
#294: FILE: /tmp/f1-10031/dplane_fpm_nl.c:294:
+	json_object_int_add(jo, "data-plane-contexts", gfnc->counters.dplane_contexts);

WARNING: line over 80 characters
#296: FILE: /tmp/f1-10031/dplane_fpm_nl.c:296:
+	json_object_int_add(jo, "user-configures", gfnc->counters.user_configures);

WARNING: braces {} are not necessary for single statement blocks
#721: FILE: /tmp/f1-10031/dplane_fpm_nl.c:721:
+			if (dest == NULL || dest->selected_fib == NULL) {
+				continue;
+			}

WARNING: braces {} are not necessary for single statement blocks
#726: FILE: /tmp/f1-10031/dplane_fpm_nl.c:726:
+			if (CHECK_FLAG(dest->flags, RIB_DEST_UPDATE_FPM)) {
+				continue;
+			}
Report for rt_netlink.c | 4 issues
===============================================
< ERROR: space prohibited after that open parenthesis '('
< #1377: FILE: /tmp/f1-10031/rt_netlink.c:1377:
< ERROR: space prohibited after that open parenthesis '('
< #1396: FILE: /tmp/f1-10031/rt_netlink.c:1396:

LabN-CI · 2019-12-12T13:41:07Z

💚 Outdated results

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/5510 `51942d6` (merge failed)
Date	12/12/2019
Start	08:15:17
Finish	08:41:05
Run-Time	25:48
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-12-12-08:15:17.txt
Log	autoscript-2019-12-12-08:16:08.log.bz2
Memory	422 429 360

For details, please contact louberger

NetDEF-CI · 2019-12-12T18:31:49Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/F29BUILD/ErrorLog/log_package_build.txt

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1604I386/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI012BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI005BUILD/config.status/config.status

Successful on other platforms

Ubuntu 12.04 amd64 build
Ubuntu 14.04 amd64 build
Debian 8 amd64 build
Debian 9 amd64 build
Ubuntu 16.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/DEB10BUILD/config.status/config.status

Package building failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/DEB10BUILD/ErrorLog/log_package_build.txt)

make[1]: *** [debian/rules:115: override_dh_missing] Error 255
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/F29BUILD/config.status/config.status

Package building failed for Fedora 29 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/F29BUILD/ErrorLog/log_package_build.txt

Ubuntu 18.04 amd64 build: Failed (click for details)

Package building failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804AMD64/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1604I386/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI009BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

make[1]: *** [override_dh_missing] Error 255
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI011BUILD/config.status/config.status

NetBSD 8 amd64 build: Failed (click for details)

Make failed for NetBSD 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/lib_vty.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo

NetBSD 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI012BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Package building failed for CentOS 7 amd64 build
see package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI005BUILD/ErrorLog/log_package_build.txt
CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10100/artifact/CI005BUILD/config.status/config.status

Report for dplane_fpm_nl.c | 42 issues
===============================================
ERROR: space prohibited after that '*' (ctx:WxW)
#133: FILE: /tmp/f1-29161/dplane_fpm_nl.c:133:
+} * gfnc;
   ^

WARNING: macros should not use a trailing semicolon
#272: FILE: /tmp/f1-29161/dplane_fpm_nl.c:272:
+#define SHOW_COUNTER(label, counter) \
+	vty_out(vty, "%28s: %Lu\n", (label), (counter));

WARNING: %Lu is non-standard C, use %llu
#273: FILE: /tmp/f1-29161/dplane_fpm_nl.c:273:
+	vty_out(vty, "%28s: %Lu\n", (label), (counter));

WARNING: line over 80 characters
#310: FILE: /tmp/f1-29161/dplane_fpm_nl.c:310:
+	json_object_int_add(jo, "connection-closes", gfnc->counters.connection_closes);

WARNING: line over 80 characters
#311: FILE: /tmp/f1-29161/dplane_fpm_nl.c:311:
+	json_object_int_add(jo, "connection-errors", gfnc->counters.connection_errors);

WARNING: line over 80 characters
#312: FILE: /tmp/f1-29161/dplane_fpm_nl.c:312:
+	json_object_int_add(jo, "data-plane-contexts", gfnc->counters.dplane_contexts);

WARNING: line over 80 characters
#318: FILE: /tmp/f1-29161/dplane_fpm_nl.c:318:
+	json_object_int_add(jo, "user-configures", gfnc->counters.user_configures);

WARNING: braces {} are not necessary for single statement blocks
#743: FILE: /tmp/f1-29161/dplane_fpm_nl.c:743:
+			if (dest == NULL || dest->selected_fib == NULL) {
+				continue;
+			}

WARNING: braces {} are not necessary for single statement blocks
#748: FILE: /tmp/f1-29161/dplane_fpm_nl.c:748:
+			if (CHECK_FLAG(dest->flags, RIB_DEST_UPDATE_FPM)) {
+				continue;
+			}
Report for rt_netlink.c | 4 issues
===============================================
< ERROR: space prohibited after that open parenthesis '('
< #1377: FILE: /tmp/f1-29161/rt_netlink.c:1377:
< ERROR: space prohibited after that open parenthesis '('
< #1396: FILE: /tmp/f1-29161/rt_netlink.c:1396:

LabN-CI · 2019-12-12T19:01:00Z

💚 Outdated results

Basic BGPD CI results: SUCCESS, 0 tests failed

_	_
Result	SUCCESS git pull/5510 `6dbab17` (merge failed)
Date	12/12/2019
Start	13:35:18
Finish	14:00:57
Run-Time	25:39
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-12-12-13:35:18.txt
Log	autoscript-2019-12-12-13:36:08.log.bz2
Memory	417 430 360

For details, please contact louberger

adharkar

Hi Rafael,
Thanks for posting this PR. It's a good idea to integrate FPM calls with dplane module.
I have a question regarding reusing encoding functions for kernel netlink messages for FPM netlink message.
In the EVPN case, there are extra custom attributes to the FPM netlink message which are not used in the kernel netlink message.

Function: netlink_route_info_add_nh

if (re && CHECK_FLAG(re->flags, ZEBRA_FLAG_EVPN_ROUTE)) {
	nhi.encap_info.encap_type = FPM_NH_ENCAP_VXLAN;

	zl3vni = zl3vni_from_vrf(nexthop->vrf_id);
	if (zl3vni && is_l3vni_oper_up(zl3vni)) {

		/* Add VNI to VxLAN encap info */
		nhi.encap_info.vxlan_encap.vni = zl3vni->vni;
	}
}

Function: netlink_route_info_encode

	encap = nhi->encap_info.encap_type;
	if (encap > FPM_NH_ENCAP_NONE) {
		addattr_l(&req->n, in_buf_len, RTA_ENCAP_TYPE, &encap,
			  sizeof(uint16_t));
		switch (encap) {
		case FPM_NH_ENCAP_NONE:
			break;
		case FPM_NH_ENCAP_VXLAN:
			vxlan = &nhi->encap_info.vxlan_encap;
			nest = addattr_nest(&req->n, in_buf_len,
					    RTA_ENCAP);
			addattr32(&req->n, in_buf_len, VXLAN_VNI,
				  vxlan->vni);
			addattr_nest_end(&req->n, nest);
			break;
		case FPM_NH_ENCAP_MAX:
			break;
		}
	}

How do we add these attributes with this change?

rzalamena · 2019-12-16T21:12:09Z

In the EVPN case, there are extra custom attributes to the FPM netlink message which are not used in the kernel netlink message.
...
How do we add these attributes with this change?

@adharkar Good catch, I think the more important question here is: why does the FPM interface have this extra attribute while the normal kernel communication doesn't?

The simplest thing to do here is to implement this difference for the zebra kernel netlink function, unless there is something strange here.

Generalize the netlink route message building function so it can be used in the future by the netlink Forwarding Plane Manager (FPM) interface. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

* Use `inet_ntop` instead of `inet_ntoa` * Replace function name with `__func__` * Inline functions Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

* Remove variable `family`; * Remove always false `RTM_DELROUTE` checks; Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Instead of retuning always `0`, lets return the amount of used bytes for the message. This will be used by the new FPM interface to know how many bytes we must reserve for the output buffer. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Add a public reset api, so a context can be reset and reused; add apis to init a context for a route or mac update. Signed-off-by: Mark Stapp <mjs@voltanet.io>

Initial import of the new zebra data plane plugin for FPM netlink. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Implement the code that walks the RIB to send routes that are already inside the RIB. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Those functions are going to be used by the new data plane plugin for netlink FPM. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Implement the code that walks the RMAC to send routes that are already inside installed in the OS. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Add commands to enable/disable and configure FPM. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Add commands to show and reset FPM counters. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Remove code duplication and document hardcoded values. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Add counters to debug the output buffer usage and pull down its data when the remote receiver is slow (so we get more space for writes). Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Enqueue all contexts inside FPM to avoid losing updates and to move all processing to the FPM thread. This helps in situations with huge amount of routes (e.g. BGP peer flapping with a million routes). Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

FPM has a thread to encode and enqueue output buffer that might compete with zebra RIB/RMAC walk on startup, so lets use atomic operations to make sure we are not getting statistic/counters wrong. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Changes: * Let the package builder scripts know that we have a new module that needs to be taken care of. * Include the frr atomic header to avoid undeclared atomic operations. * Disable build on *BSDs because the code is using some zebra netlink functions only available for Linux. * Move data plane FPM module outside old FPM automake definition. * Fix atomic usage for Ubuntu 14.04 (always use explicit). Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

* Use 32bit atomic instead of 64bit. * Don't use semicolon at the end of macros. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Store VNI information in the data plane context so we can use it to build the FPM netlink update with that information later. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

* Break lines longer than 80 columns. * Remove space after '('. * Use '%pIX' instead of 'inet_ntop'. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

To enable them just configure `debug zebra fpm`. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Implement the fix made in `master` to the remain pieces of code in the data plane FPM module. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

rzalamena · 2020-04-14T17:27:41Z

Rebased again to fix recent conflicts.

NetDEF-CI · 2020-04-14T18:58:21Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11852/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-11852/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr source: pkg-js-tools-test-is-missing
W: frr source: newer-standards-version 4.4.1 (current is 4.3.0)
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200414-33-g9d5c32682-0 (missing) -> 7.4-dev-20200414-33-g9d5c32682-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200414-33-g9d5c32682-0 (missing) -> 7.4-dev-20200414-33-g9d5c32682-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200414-33-g9d5c32682-0 (missing) -> 7.4-dev-20200414-33-g9d5c32682-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200414-33-g9d5c32682-0 (missing) -> 7.4-dev-20200414-33-g9d5c32682-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200414-33-g9d5c32682-0 (missing) -> 7.4-dev-20200414-33-g9d5c32682-0~deb10u1

mjstapp

thanks for pushing this through - looks good now

LabN-CI · 2020-04-14T20:18:31Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5510 `9d5c326`
Date	04/14/2020
Start	15:52:23
Finish	16:18:26
Run-Time	26:03
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2020-04-14-15:52:23.txt
Log	autoscript-2020-04-14-15:53:24.log.bz2
Memory	482 481 429

For details, please contact louberger

mjstapp · 2020-04-14T20:39:57Z

Merging this now - if issues come up with further use, we can address those with fix PRs

rzalamena added help wanted preliminary (WiP) zebra fpm labels Dec 9, 2019

polychaeta reviewed Dec 9, 2019

View reviewed changes

srimohans self-requested a review December 9, 2019 21:35

mjstapp self-requested a review December 10, 2019 16:31

mjstapp requested changes Dec 10, 2019

View reviewed changes

rzalamena force-pushed the dplane-fpm-netlink branch from 34ce451 to c8485a4 Compare December 10, 2019 21:42

rzalamena added review & merge me look at me! and removed preliminary (WiP) labels Dec 16, 2019

rzalamena marked this pull request as ready for review December 16, 2019 17:56

adharkar reviewed Dec 16, 2019

View reviewed changes

rzalamena and others added 21 commits April 14, 2020 10:40

zebra: generalize netlink route talk function

e57a3fa

Generalize the netlink route message building function so it can be used in the future by the netlink Forwarding Plane Manager (FPM) interface. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: simplify some netlink debug messages

9266b31

* Use `inet_ntop` instead of `inet_ntoa` * Replace function name with `__func__` * Inline functions Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: simplify netlink_route_multipath

b9c8751

* Remove variable `family`; * Remove always false `RTM_DELROUTE` checks; Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: dataplane context reset and init apis

f73a846

Add a public reset api, so a context can be reset and reused; add apis to init a context for a route or mac update. Signed-off-by: Mark Stapp <mjs@voltanet.io>

zebra: data plane plugin for FPM netlink

d35f447

Initial import of the new zebra data plane plugin for FPM netlink. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: data plane FPM RIB walk code

018e77b

Implement the code that walks the RIB to send routes that are already inside the RIB. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: adapt and export rmac netlink functions

d4d4ec1

Those functions are going to be used by the new data plane plugin for netlink FPM. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: data plane FPM RMAC walk code

bda10ad

Implement the code that walks the RMAC to send routes that are already inside installed in the OS. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: CLI commands for new FPM interface

3bdd7fc

Add commands to enable/disable and configure FPM. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: implement FPM counters

6cc059c

Add commands to show and reset FPM counters. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: simplify FPM buffer full detection

a179ba3

Remove code duplication and document hardcoded values. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: improve FPM output buffer handling

ad4d102

Add counters to debug the output buffer usage and pull down its data when the remote receiver is slow (so we get more space for writes). Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: fix style on data plane FPM module

770a8d2

* Use 32bit atomic instead of 64bit. * Don't use semicolon at the end of macros. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: data plane FPM add support RMAC VNI

f2a0ba3

Store VNI information in the data plane context so we can use it to build the FPM netlink update with that information later. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: fix some formatting/style issues

a50404a

* Break lines longer than 80 columns. * Remove space after '('. * Use '%pIX' instead of 'inet_ntop'. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: hide verbose data plane FPM log messages

e5e444d

To enable them just configure `debug zebra fpm`. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

zebra: fix hash_backet typo in data plane FPM

9d5c326

Implement the fix made in `master` to the remain pieces of code in the data plane FPM module. Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

rzalamena force-pushed the dplane-fpm-netlink branch from 062eaca to 9d5c326 Compare April 14, 2020 17:27

mjstapp approved these changes Apr 14, 2020

View reviewed changes

mjstapp merged commit f3f054c into FRRouting:master Apr 14, 2020

rzalamena deleted the dplane-fpm-netlink branch April 15, 2020 18:47

sworleys mentioned this pull request Apr 20, 2020

zebra: Address invalid memory access on VRF delete. #6192

Closed

zebra: netlink FPM interface using zebra data plane #5510

zebra: netlink FPM interface using zebra data plane #5510

Conversation

rzalamena commented Dec 9, 2019 • edited Loading

Summary

Related

TODO

polychaeta left a comment

Choose a reason for hiding this comment

LabN-CI commented Dec 9, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Dec 9, 2019 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

rzalamena commented Dec 9, 2019

srimohans commented Dec 9, 2019

rzalamena commented Dec 9, 2019

srimohans commented Dec 10, 2019

mjstapp left a comment

Choose a reason for hiding this comment

mjstapp Dec 10, 2019

Choose a reason for hiding this comment

rzalamena Dec 10, 2019

Choose a reason for hiding this comment

mjstapp Dec 10, 2019

Choose a reason for hiding this comment

rzalamena Dec 10, 2019

Choose a reason for hiding this comment

NetDEF-CI commented Dec 10, 2019 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Dec 10, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Dec 10, 2019 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Dec 10, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

LabN-CI commented Dec 11, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Dec 11, 2019 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

NetDEF-CI commented Dec 12, 2019 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Dec 12, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Dec 12, 2019 • edited Loading

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

LabN-CI commented Dec 12, 2019 • edited Loading

Basic BGPD CI results: SUCCESS, 0 tests failed

adharkar left a comment • edited Loading

Choose a reason for hiding this comment

rzalamena commented Dec 16, 2019

rzalamena commented Apr 14, 2020

NetDEF-CI commented Apr 14, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

mjstapp left a comment

Choose a reason for hiding this comment

LabN-CI commented Apr 14, 2020

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

mjstapp commented Apr 14, 2020

rzalamena commented Dec 9, 2019 •

edited

Loading

LabN-CI commented Dec 9, 2019 •

edited

Loading

NetDEF-CI commented Dec 9, 2019 •

edited

Loading

NetDEF-CI commented Dec 10, 2019 •

edited

Loading

LabN-CI commented Dec 10, 2019 •

edited

Loading

NetDEF-CI commented Dec 10, 2019 •

edited

Loading

LabN-CI commented Dec 10, 2019 •

edited

Loading

LabN-CI commented Dec 11, 2019 •

edited

Loading

NetDEF-CI commented Dec 11, 2019 •

edited

Loading

NetDEF-CI commented Dec 12, 2019 •

edited

Loading

LabN-CI commented Dec 12, 2019 •

edited

Loading

NetDEF-CI commented Dec 12, 2019 •

edited

Loading

LabN-CI commented Dec 12, 2019 •

edited

Loading

adharkar left a comment •

edited

Loading