lib: fix heap buf overflow when adding prefix orf

[qlyoung]

Don't lose your way

  ==25988== Invalid read of size 8    
  ==25988==    at 0x4EB8D44: trie_install_fn (plist.c:544)    
  ==25988==    by 0x4EB8D0E: trie_walk_affected (plist.c:452)    
  ==25988==    by 0x4EB8C1E: prefix_list_trie_add (plist.c:583)    
  ==25988==    by 0x4EB78DB: prefix_list_entry_add (plist.c:631)    
  ==25988==    by 0x4EB733D: prefix_bgp_orf_set (plist.c:1905)    
  ==25988==    by 0x46B8A8: bgp_route_refresh_receive (bgp_packet.c:1984)    
  ==25988==    by 0x469406: bgp_process_packet (bgp_packet.c:2327)    
  ==25988==    by 0x41B408: main (bgp_main.c:476)    
  ==25988==  Address 0x74b6e48 is 8 bytes after a block of size 4,096 alloc'd    
  ==25988==    at 0x4C31B25: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)    
  ==25988==    by 0x4EA1888: qcalloc (memory.c:110)    
  ==25988==    by 0x4EB86D5: prefix_list_insert (plist.c:216)    
  ==25988==    by 0x4EB740E: prefix_list_get (plist.c:289)    
  ==25988==    by 0x4EB7295: prefix_bgp_orf_set (plist.c:1891)    
  ==25988==    by 0x46B8A8: bgp_route_refresh_receive (bgp_packet.c:1984)    
  ==25988==    by 0x469406: bgp_process_packet (bgp_packet.c:2327)    
  ==25988==    by 0x41B408: main (bgp_main.c:476)

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/5464 3dbedfb
Date	12/03/2019
Start	13:15:22
Finish	13:40:55
Run-Time	25:33
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-12-03-13:15:22.txt
Log	autoscript-2019-12-03-13:16:12.log.bz2
Memory	435 436 360

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9926/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9926/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191203-05-g3dbedfbda-0 (missing) -> 7.3-dev-20191203-05-g3dbedfbda-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191203-05-g3dbedfbda-0 (missing) -> 7.3-dev-20191203-05-g3dbedfbda-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191203-05-g3dbedfbda-0 (missing) -> 7.3-dev-20191203-05-g3dbedfbda-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191203-05-g3dbedfbda-0 (missing) -> 7.3-dev-20191203-05-g3dbedfbda-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20191203-05-g3dbedfbda-0 (missing) -> 7.3-dev-20191203-05-g3dbedfbda-0~deb10u1

---

CLANG Static Analyzer Summary

• Github Pull Request 5464, comparing to Git base SHA e25ca45
• Base image data for Git e25ca45 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9926/artifact/shared/static_analysis/index.html