Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Reject incoming and outgoing UPDATES for AS_SET and AS_CONFED_SET #5305

Merged
merged 3 commits into from
Dec 4, 2019
Merged

bgpd: Reject incoming and outgoing UPDATES for AS_SET and AS_CONFED_SET #5305

merged 3 commits into from
Dec 4, 2019

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Nov 9, 2019

@polychaeta polychaeta added bgp documentation tests Topotests, make check, etc labels Nov 9, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 9, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5305 1721be2
Date 11/09/2019
Start 17:36:01
Finish 18:01:53
Run-Time 25:52
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-11-09-17:36:01.txt
Log autoscript-2019-11-09-17:36:57.log.bz2
Memory 434 428 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9637/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for bgp_route.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #3165: FILE: /tmp/f1-29099/bgp_route.c:3165:

CLANG Static Analyzer Summary

  • Github Pull Request 5305, comparing to Git base SHA 26109a7

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9637/artifact/shared/static_analysis/index.html

@ton31337 ton31337 closed this Nov 11, 2019
@ton31337 ton31337 reopened this Nov 11, 2019
@donaldsharp donaldsharp self-requested a review November 12, 2019 16:18
donaldsharp
donaldsharp requested changes Nov 12, 2019
View reviewed changes
bgpd/bgp_aspath.c Outdated Show resolved Hide resolved
bgpd/bgp_vty.c Outdated Show resolved Hide resolved
bisdhdh
bisdhdh suggested changes Nov 13, 2019
View reviewed changes
bgpd/bgpd.h Outdated Show resolved Hide resolved
bgpd/bgp_vty.c Outdated Show resolved Hide resolved
bgpd/bgp_vty.c Outdated Show resolved Hide resolved
bgpd/bgp_route.c Show resolved Hide resolved
bgpd/bgp_route.c Show resolved Hide resolved
@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 13, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5305 c46a9ec
Date 11/13/2019
Start 04:35:59
Finish 05:01:41
Run-Time 25:42
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-11-13-04:35:59.txt
Log autoscript-2019-11-13-04:36:53.log.bz2
Memory 432 434 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9689/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for bgp_route.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #3166: FILE: /tmp/f1-15527/bgp_route.c:3166:

CLANG Static Analyzer Summary

  • Github Pull Request 5305, comparing to Git base SHA a6ac9df

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9689/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 13, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5305 d83b5c7
Date 11/13/2019
Start 09:17:19
Finish 09:43:09
Run-Time 25:50
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-11-13-09:17:19.txt
Log autoscript-2019-11-13-09:18:14.log.bz2
Memory 435 418 362

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9692/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for bgp_route.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #3166: FILE: /tmp/f1-10915/bgp_route.c:3166:

CLANG Static Analyzer Summary

  • Github Pull Request 5305, comparing to Git base SHA a6ac9df

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9692/artifact/shared/static_analysis/index.html

@ton31337
bgpd: Reject routes having AS_SET or AS_CONFED_SET
fb29348 
This is the first step towards eliminating AS_SET and AS_CONFED_SET types
and obsolete them in the future.

More information:
https://datatracker.ietf.org/doc/html/draft-ietf-idr-deprecate-as-set-confed-set-02

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@ton31337
doc: Add documentation for bgp reject-as-sets command
f0c81af 
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@ton31337
tests: Add a test case for bgp reject-as-sets
7ea16cb 
Test if AS_SET was stripped and announced without AS_SET to the peers.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Nov 14, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5305 7ea16cb
Date 11/14/2019
Start 13:11:59
Finish 13:37:48
Run-Time 25:49
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-11-14-13:11:59.txt
Log autoscript-2019-11-14-13:12:52.log.bz2
Memory 432 421 359

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9706/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for bgp_route.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #3166: FILE: /tmp/f1-32726/bgp_route.c:3166:

CLANG Static Analyzer Summary

  • Github Pull Request 5305, comparing to Git base SHA 48cb555

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9706/artifact/shared/static_analysis/index.html

@donaldsharp donaldsharp merged commit 2d3c8c2 into FRRouting:master Dec 4, 2019
@ton31337 ton31337 deleted the feature/draft-ietf-idr-deprecate-as-set-confed-set branch December 4, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bisdhdh bisdhdh bisdhdh requested changes

@donaldsharp donaldsharp donaldsharp requested changes

Assignees
No one assigned
Labels
bgp documentation tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ton31337 @LabN-CI @NetDEF-CI @bisdhdh @donaldsharp @polychaeta