Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Use uint32_t for maximum-prefix #5106

Merged
merged 1 commit into from
Oct 7, 2019
Merged

bgpd: Use uint32_t for maximum-prefix #5106

merged 1 commit into from
Oct 7, 2019

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Oct 4, 2019

Currently we have unsigned long which is not what we defined
in CLI (1-4294967295).

Signed-off-by: Donatas Abraitis donatas.abraitis@gmail.com

@polychaeta polychaeta added the bgp label Oct 4, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented Oct 4, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5106 2df14b3
Date 10/04/2019
Start 02:45:53
Finish 03:07:31
Run-Time 21:38
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-04-02:45:53.txt
Log autoscript-2019-10-04-02:46:45.log.bz2
Memory 424 426 359

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9132/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_route.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #2751: FILE: /tmp/f1-23635/bgp_route.c:2751:
< WARNING: line over 80 characters
< #2814: FILE: /tmp/f1-23635/bgp_route.c:2814:

CLANG Static Analyzer Summary

  • Github Pull Request 5106, comparing to Git base SHA bf9846b

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9132/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Oct 4, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5106 9371166
Date 10/04/2019
Start 07:07:46
Finish 07:29:32
Run-Time 21:46
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-04-07:07:46.txt
Log autoscript-2019-10-04-07:08:38.log.bz2
Memory 423 421 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9135/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_route.c | 2 issues
===============================================
< WARNING: quoted string split across lines
< #2814: FILE: /tmp/f1-8400/bgp_route.c:2814:

CLANG Static Analyzer Summary

  • Github Pull Request 5106, comparing to Git base SHA bf9846b

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9135/artifact/shared/static_analysis/index.html

Currently we have unsigned long which is not what we defined
in CLI (1-4294967295).

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Oct 4, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/5106 a0a8703
Date 10/04/2019
Start 08:50:53
Finish 09:12:31
Run-Time 21:38
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-10-04-08:50:53.txt
Log autoscript-2019-10-04-08:51:48.log.bz2
Memory 429 434 359

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9138/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for bgp_route.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #2751: FILE: /tmp/f1-29461/bgp_route.c:2751:
< WARNING: line over 80 characters
< #2813: FILE: /tmp/f1-29461/bgp_route.c:2813:

CLANG Static Analyzer Summary

  • Github Pull Request 5106, comparing to Git base SHA 1867569

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9138/artifact/shared/static_analysis/index.html

@qlyoung
Copy link
Member

qlyoung commented Oct 7, 2019

@ton31337 does this fix #5065 ?

@ton31337
Copy link
Member Author

ton31337 commented Oct 7, 2019

no, this is just a cosmetic change to clean the code, I pushed another PR which fixes 5065.

@qlyoung qlyoung merged commit 0fc3eb2 into FRRouting:master Oct 7, 2019
@ton31337 ton31337 deleted the fix/maximum-prefix_uint16_to_uint32 branch October 7, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants