bgpd: do not send keepalives when KA timer is 0 #4985

qlyoung · 2019-09-16T15:36:51Z

RFC4271 specifies behavior when the hold timer is sent to zero - we
should not send keepalives or run a hold timer. But FRR, and other
vendors, allow the keepalive timer to be set to zero with a nonzero hold
timer. In this case we were sending keepalives constantly and maxing out
a pthread to do so. Instead behave similarly to other vendors and do not
send keepalives.

Unsure what the utility of this is, but blasting keepalives is
definitely the wrong thing to do.

Signed-off-by: Quentin Young qlyoung@cumulusnetworks.com

donaldsharp · 2019-09-16T15:55:34Z

I'd like to see a PR for 7.2 as well please

RFC4271 specifies behavior when the hold timer is sent to zero - we should not send keepalives or run a hold timer. But FRR, and other vendors, allow the keepalive timer to be set to zero with a nonzero hold timer. In this case we were sending keepalives constantly and maxing out a pthread to do so. Instead behave similarly to other vendors and do not send keepalives. Unsure what the utility of this is, but blasting keepalives is definitely the wrong thing to do. Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

NetDEF-CI · 2019-09-16T16:32:26Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/U1604I386/config.status/config.status

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/F29BUILD/config.status/config.status

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/F29BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Debian 10 amd64 build: Failed (click for details)

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/DEB10BUILD/config.status/config.status

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/DEB10BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/U1804AMD64/config.status/config.status

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/U1804AMD64/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/FBSD12AMD64/config.status/config.status

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI005BUILD/config.status/config.status

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI005BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 14.04 amd64 build: Failed (click for details)

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI001BUILD/config.status/config.status

Make failed for Ubuntu 14.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Debian 8 amd64 build: Failed (click for details)

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI008BLD/config.status/config.status

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/U1804PPC64LEBUILD/config.status/config.status

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o
  CC       bgpd/bgp_flowspec_vty.o
  CC       bgpd/bgp_fsm.o

OpenBSD 6 amd64 build: Failed (click for details)

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI011BUILD/config.status/config.status

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI021BUILD/config.status/config.status

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI021BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 7 amd64 build: Failed (click for details)

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI012BUILD/config.status/config.status

Make failed for NetBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI009BUILD/config.status/config.status

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CC       lib/json.lo
  CC       lib/keychain.lo
  CC       lib/lib_errors.lo
  CC       lib/libfrr.lo
  CC       lib/linklist.lo
  CC       lib/log.lo
  CLIPPY   lib/log_vty_clippy.c
  CC       lib/log_vty.lo
  CC       lib/md5.lo

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI014BUILD/config.status/config.status

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI014BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: Failed (click for details)

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI007BUILD/config.status/config.status

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8914/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Successful on other platforms

Ubuntu 12.04 amd64 build

LabN-CI · 2019-09-16T17:40:42Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4985 `bfc18a0`
Date	09/16/2019
Start	13:19:02
Finish	13:40:40
Run-Time	21:38
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-09-16-13:19:02.txt
Log	autoscript-2019-09-16-13:19:51.log.bz2
Memory	431 418 360

For details, please contact louberger

NetDEF-CI · 2019-09-16T18:01:09Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8915/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-8915/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: r1 has no interfaces
2019-09-16 10:06:33,084 ERROR: assert failed at "test_bgp_multiview_topo1/test_bgp_routingTable": Routing Table verification failed for router r1, view 3:
No template matched.
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_3.ref: r1 failed Routing Table Check for view 3:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,14 +1,12 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
-Default local pref 100, local AS 100
-Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
-               i internal, r RIB-failure, S Stale, R Removed
-Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
-Origin codes:  i - IGP, e - EGP, ? - incomplete
+BGP table version is XXX, local router ID is 172.30.1.1
+Status codes: s suppressed, d damped, h history, * valid, > best, = multipath,
+              i internal, r RIB-failure, S Stale, R Removed
+Origin codes: i - IGP, e - EGP, ? - incomplete
 
    Network          Next Hop            Metric LocPrf Weight Path
-*> 10.0.1.0/24      172.16.1.6                             0 65006 i
-*                   172.16.1.8                             0 65008 i
+*  10.0.1.0/24      172.16.1.8                             0 65008 i
 *                   172.16.1.7                             0 65007 i
+*>                  172.16.1.6                             0 65006 i
 *> 10.106.0.0/24    172.16.1.6             100              0 65006 i
 *> 10.106.1.0/24    172.16.1.6             100              0 65006 i
 *> 10.106.2.0/24    172.16.1.6             100              0 65006 i
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_3-post6.1.ref: r1 failed Routing Table Check for view 3:
--- actual BGP routing table
+++ expected BGP routing table
@@ -6,9 +6,9 @@
 Origin codes:  i - IGP, e - EGP, ? - incomplete
 
    Network          Next Hop            Metric LocPrf Weight Path
-*> 10.0.1.0/24      172.16.1.6                             0 65006 i
-*                   172.16.1.8                             0 65008 i
+*  10.0.1.0/24      172.16.1.8                             0 65008 i
 *                   172.16.1.7                             0 65007 i
+*>                  172.16.1.6                             0 65006 i
 *> 10.106.0.0/24    172.16.1.6             100              0 65006 i
 *> 10.106.1.0/24    172.16.1.6             100              0 65006 i
 *> 10.106.2.0/24    172.16.1.6             100              0 65006 i
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1.ref: r1 failed Routing Table Check for view 3:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,9 +1,7 @@
-BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
-Default local pref 100, local AS 100
-Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
-               i internal, r RIB-failure, S Stale, R Removed
-Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
-Origin codes:  i - IGP, e - EGP, ? - incomplete
+BGP table version is XXX, local router ID is 172.30.1.1
+Status codes: s suppressed, d damped, h history, * valid, > best, = multipath,
+              i internal, r RIB-failure, S Stale, R Removed
+Origin codes: i - IGP, e - EGP, ? - incomplete
 
    Network          Next Hop            Metric LocPrf Weight Path
 *  10.0.1.0/24      172.16.1.5                             0 65005 i
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_1-post4.1.ref: r1 failed Routing Table Check for view 3:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,5 +1,4 @@
 BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
-Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
 Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
template /root/bamboo-agent-home/xml-data/build-dir/FRR-FRRPULLREQ-TOPOI386/topotests/bgp_multiview_topo1/r1/show_ip_bgp_view_3-post4.1.ref: r1 failed Routing Table Check for view 3:
--- actual BGP routing table
+++ expected BGP routing table
@@ -1,14 +1,13 @@
 BGP table version is XXX, local router ID is 172.30.1.1, vrf id -
-Default local pref 100, local AS 100
 Status codes:  s suppressed, d damped, h history, * valid, > best, = multipath,
                i internal, r RIB-failure, S Stale, R Removed
 Nexthop codes: @NNN nexthop's vrf id, < announce-nh-self
 Origin codes:  i - IGP, e - EGP, ? - incomplete
 
    Network          Next Hop            Metric LocPrf Weight Path
-*> 10.0.1.0/24      172.16.1.6                             0 65006 i
-*                   172.16.1.8                             0 65008 i
+*  10.0.1.0/24      172.16.1.8                             0 65008 i
 *                   172.16.1.7                             0 65007 i
+*>                  172.16.1.6                             0 65006 i
 *> 10.106.0.0/24    172.16.1.6             100              0 65006 i
 *> 10.106.1.0/24    172.16.1.6             100              0 65006 i
 *> 10.106.2.0/24    172.16.1.6             100              0 65006 i

RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8915/artifact/TOPOI386/ErrorLog/log_topotests.txt

Successful on other platforms

IPv6 protocols on Ubuntu 14.04
Ubuntu 16.04 deb pkg check
Debian 10 deb pkg check
CentOS 7 rpm pkg check
Addresssanitizer topotest
Debian 8 deb pkg check
Topology tests on Ubuntu 16.04 amd64
IPv4 protocols on Ubuntu 14.04
Debian 9 deb pkg check
Fedora 29 rpm pkg check
IPv4 ldp protocol on Ubuntu 16.04
Ubuntu 14.04 deb pkg check
Ubuntu 12.04 deb pkg check
Static analyzer (clang)
Topology tests on Ubuntu 18.04 amd64

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8915/artifact/TOPOI386/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 4985, comparing to Git base SHA 8e0bab8

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8915/artifact/shared/static_analysis/index.html

ton31337 · 2019-09-17T07:19:38Z

ci:rerun

NetDEF-CI · 2019-09-17T08:46:56Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8928/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 4985, comparing to Git base SHA 8e0bab8

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8928/artifact/shared/static_analysis/index.html

polychaeta added the bgp label Sep 16, 2019

qlyoung added the bugfix label Sep 16, 2019

This comment has been minimized.

Sign in to view

qlyoung force-pushed the fix-bgp-zero-keepalive-timer branch from 6fd5af6 to 85cb0af Compare September 16, 2019 16:14

qlyoung force-pushed the fix-bgp-zero-keepalive-timer branch from 85cb0af to bfc18a0 Compare September 16, 2019 16:15

ton31337 approved these changes Sep 16, 2019

View reviewed changes

srimohans approved these changes Sep 16, 2019

View reviewed changes

ton31337 merged commit 3e1fb65 into FRRouting:master Sep 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bgpd: do not send keepalives when KA timer is 0 #4985

bgpd: do not send keepalives when KA timer is 0 #4985

qlyoung commented Sep 16, 2019

This comment has been minimized.

donaldsharp commented Sep 16, 2019

This comment has been minimized.

NetDEF-CI commented Sep 16, 2019

LabN-CI commented Sep 16, 2019

NetDEF-CI commented Sep 16, 2019

ton31337 commented Sep 17, 2019

NetDEF-CI commented Sep 17, 2019

bgpd: do not send keepalives when KA timer is 0 #4985

bgpd: do not send keepalives when KA timer is 0 #4985

Conversation

qlyoung commented Sep 16, 2019

This comment has been minimized.

donaldsharp commented Sep 16, 2019

This comment has been minimized.

NetDEF-CI commented Sep 16, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

LabN-CI commented Sep 16, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Sep 16, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8915/artifact/TOPOI386/MemoryLeaks/

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

ton31337 commented Sep 17, 2019

NetDEF-CI commented Sep 17, 2019

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.