pimd: sh config is showing detail debug, though not configured

[satheeshkarra]

Original Idea is to display normal & detailed debugs when detailed
debug alone is configured. because of this "sh debugs" are showing
wrong Information, because same macro is used to disply the configured
debugs.

that means even if Normal debug is configured, detailed macro returns
TRUE. To avoid this ambiguity check whetehr detailed debug is configured
or not during dumping configured debugs. In all other places using
old macro.

Signed-off-by: Satheesh Kumar K sathk@cumulusnetworks.com

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4886 5e530de
Date	08/27/2019
Start	03:05:18
Finish	03:27:00
Run-Time	21:42
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-08-27-03:05:18.txt
Log	autoscript-2019-08-27-03:06:08.log.bz2
Memory	439 416 356

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8701/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-8701/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

2019-08-27 07:10:51,505 WARNING: BGP is not yet Converged for router r4
2019-08-27 07:11:08,905 WARNING: BGP is not yet Converged for router r1 after bgp clear
2019-08-27 07:11:13,052 WARNING: BGP is not yet Converged for router r1 after bgp clear
*** defaultIntf: warning: r1 has no interfaces
2019-08-27 07:28:12,501 ERROR: ******************************************************************************
2019-08-27 07:28:12,502 ERROR: Test Target Summary                                                  Pass Fail
2019-08-27 07:28:12,502 ERROR: ******************************************************************************
2019-08-27 07:28:12,502 ERROR: FILE: scripts/adjacencies.py
2019-08-27 07:28:12,502 ERROR: 15   r3     All adjacencies up                                       0    1
2019-08-27 07:28:12,502 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/output.log for details of errors
2019-08-27 07:28:12,505 ERROR: assert failed at "bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/test_adjacencies": 1 tests failed

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8701/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms

• Ubuntu 12.04 deb pkg check
• Fedora 29 rpm pkg check
• Static analyzer (clang)
• IPv6 protocols on Ubuntu 14.04
• Ubuntu 16.04 deb pkg check
• Addresssanitizer topotest
• Debian 8 deb pkg check
• Topology tests on Ubuntu 16.04 amd64
• Debian 10 deb pkg check
• CentOS 7 rpm pkg check
• Topotest tests on Ubuntu 16.04 i386
• IPv4 protocols on Ubuntu 14.04
• IPv4 ldp protocol on Ubuntu 16.04
• Ubuntu 14.04 deb pkg check
• Debian 9 deb pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8701/artifact/TOPOU1804/MemoryLeaks/

CLANG Static Analyzer Summary

• Github Pull Request 4886, comparing to Git base SHA dd7c916

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8701/artifact/shared/static_analysis/index.html

[ton31337]

ci:rerun

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8738/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 4886, comparing to Git base SHA dd7c916

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8738/artifact/shared/static_analysis/index.html

[riw777]

looks good