Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: Allow shortened input for show bgp l2vpn evpn route type e|p #4878

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

donaldsharp
Copy link
Member

The show bgp l2vpn evpn route type <es|prefix> commands
only accepted 2 letters. You could not type show bgp l2vpn evpn route type e
or show bgp l2vpn evpn route type p although both are technically legal
since nothing overlaps with them.

Ticket: CM-25988
Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com

The `show bgp l2vpn evpn route type <es|prefix>` commands
only accepted 2 letters.  You could not type `show bgp l2vpn evpn route type e`
or `show bgp l2vpn evpn route type p` although both are technically legal
since nothing overlaps with them.

Ticket: CM-25988
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@polychaeta polychaeta added the bgp label Aug 23, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented Aug 23, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4878 dde42c9
Date 08/23/2019
Start 16:05:22
Finish 16:27:06
Run-Time 21:44
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-08-23-16:05:22.txt
Log autoscript-2019-08-23-16:06:14.log.bz2
Memory 433 418 359

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8688/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4878, comparing to Git base SHA 401ba2a

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8688/artifact/shared/static_analysis/index.html

@srimohans srimohans merged commit 14a45ee into FRRouting:master Aug 24, 2019
@donaldsharp donaldsharp deleted the 2_chars_1_strncmp branch December 9, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants