bgpd: rpki fixes (stable/6.0)

[mroethke]

This fixes #4827 and a bug in in the bgp_table_range_lookup.

The later caused the lookup to fail when the prefix of the top most node was larger than the minimal length of the lookup prefix.

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4855 bbda2e5
Date	08/20/2019
Start	06:30:10
Finish	06:51:45
Run-Time	21:35
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-08-20-06:30:10.txt
Log	autoscript-2019-08-20-06:30:56.log.bz2
Memory	432 433 366

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8650/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-8650/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

2019-08-20 10:54:25,377 ERROR: ******************************************************************************
2019-08-20 10:54:25,383 ERROR: Test Target Summary                                                  Pass Fail
2019-08-20 10:54:25,383 ERROR: ******************************************************************************
2019-08-20 10:54:25,383 ERROR: FILE: scripts/adjacencies.py
2019-08-20 10:54:25,383 ERROR: 10   r2     Core adjacencies up +10.17 secs                          0    1
2019-08-20 10:54:25,383 ERROR: 16   r4     All adjacencies up                                       0    1
2019-08-20 10:54:25,383 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/output.log for details of errors
2019-08-20 10:54:25,387 ERROR: assert failed at "bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/test_adjacencies": 2 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8650/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms

• Ubuntu 14.04 deb pkg check
• IPv4 ldp protocol on Ubuntu 16.04
• Addresssanitizer topotest
• Debian 8 deb pkg check
• Debian 9 deb pkg check
• Topology tests on Ubuntu 16.04 amd64
• IPv4 protocols on Ubuntu 14.04
• CentOS 7 rpm pkg check
• Topotest tests on Ubuntu 16.04 i386
• Debian 10 deb pkg check
• Static analyzer (clang)
• IPv6 protocols on Ubuntu 14.04
• Ubuntu 16.04 deb pkg check
• Fedora 29 rpm pkg check
• Ubuntu 12.04 deb pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8650/artifact/TOPOU1804/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-8650/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

2019-08-20 10:54:25,377 ERROR: ******************************************************************************
2019-08-20 10:54:25,383 ERROR: Test Target Summary                                                  Pass Fail
2019-08-20 10:54:25,383 ERROR: ******************************************************************************
2019-08-20 10:54:25,383 ERROR: FILE: scripts/adjacencies.py
2019-08-20 10:54:25,383 ERROR: 10   r2     Core adjacencies up +10.17 secs                          0    1
2019-08-20 10:54:25,383 ERROR: 16   r4     All adjacencies up                                       0    1
2019-08-20 10:54:25,383 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/output.log for details of errors
2019-08-20 10:54:25,387 ERROR: assert failed at "bgp_l3vpn_to_bgp_direct.test_bgp_l3vpn_to_bgp_direct/test_adjacencies": 2 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8650/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Report for bgp_table.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #162: FILE: /tmp/f1-24077/bgp_table.c:162:

---

CLANG Static Analyzer Summary

• Github Pull Request 4855, comparing to Git base SHA 126f498

No Changes in Static Analysis warnings compared to base

75 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8650/artifact/shared/static_analysis/index.html