sharpd: Fix repeat sub-command to work #4779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repeat sub-command was not properly repeating. It was starting the removal during the install: 2019/08/03 00:10:14.351 SHARP: Inserting 300000 routes 2019/08/03 00:13:01.556 SHARP: Installed All Items 167.204747 2019/08/03 00:13:01.556 SHARP: Removing 300000 routes 2019/08/03 00:13:03.126 SHARP: Inserting 300000 routes 2019/08/03 00:14:34.794 SHARP: Removed all Items 91.668040 2019/08/03 00:16:11.743 SHARP: Installed All Items 188.616462 2019/08/03 00:16:11.743 SHARP: Removing 300000 routes 2019/08/03 00:16:14.256 SHARP: Inserting 300000 routes This command allows the remove to wait till the install is fully finished and vice versa: 2019/08/03 00:22:54 SHARP: Inserting 10000 routes 2019/08/03 00:22:55 SHARP: Installed All Items 0.572028 2019/08/03 00:22:55 SHARP: Removing 10000 routes 2019/08/03 00:22:55 SHARP: Removed all Items 0.568284 2019/08/03 00:22:55 SHARP: Inserting 10000 routes 2019/08/03 00:22:56 SHARP: Installed All Items 0.567687 2019/08/03 00:22:56 SHARP: Removing 10000 routes 2019/08/03 00:22:56 SHARP: Removed all Items 0.551011 Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8520/ This is a comment from an automated CI system. Warnings Generated during build:Debian 10 amd64 build: Successful with additional warningsDebian Package lintian failed for Debian 10 amd64 build: CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base1 Static Analyzer issues remaining.See details at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repeat sub-command was not properly repeating. It was starting
the removal during the install:
2019/08/03 00:10:14.351 SHARP: Inserting 300000 routes
2019/08/03 00:13:01.556 SHARP: Installed All Items 167.204747
2019/08/03 00:13:01.556 SHARP: Removing 300000 routes
2019/08/03 00:13:03.126 SHARP: Inserting 300000 routes
2019/08/03 00:14:34.794 SHARP: Removed all Items 91.668040
2019/08/03 00:16:11.743 SHARP: Installed All Items 188.616462
2019/08/03 00:16:11.743 SHARP: Removing 300000 routes
2019/08/03 00:16:14.256 SHARP: Inserting 300000 routes
This command allows the remove to wait till the install is fully
finished and vice versa:
2019/08/03 00:22:54 SHARP: Inserting 10000 routes
2019/08/03 00:22:55 SHARP: Installed All Items 0.572028
2019/08/03 00:22:55 SHARP: Removing 10000 routes
2019/08/03 00:22:55 SHARP: Removed all Items 0.568284
2019/08/03 00:22:55 SHARP: Inserting 10000 routes
2019/08/03 00:22:56 SHARP: Installed All Items 0.567687
2019/08/03 00:22:56 SHARP: Removing 10000 routes
2019/08/03 00:22:56 SHARP: Removed all Items 0.551011
Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com