Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix implicit declaration warning #4654

Merged
merged 1 commit into from
Jul 8, 2019
Merged

bgpd: fix implicit declaration warning #4654

merged 1 commit into from
Jul 8, 2019

Conversation

edipascale
Copy link
Contributor

Add header with prototype for bgp_path_info_unlock

Signed-off-by: Emanuele Di Pascale emanuele@voltanet.io

Add header with prototype for bgp_path_info_unlock

Signed-off-by: Emanuele Di Pascale <emanuele@voltanet.io>
@polychaeta polychaeta added the bgp label Jul 8, 2019
@donaldsharp
Copy link
Member

Once ci finishes I'll push in

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8294/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

IPv4 protocols on Ubuntu 14.04: Failed (click for details)

RFC Compliance Test ANVL-BGP4-21.8 failing:
Test Summary
At OpenSent state if there are no errors in the OPEN message, the
local system:
- sends a KEEPALIVE message, and
- sets a KeepaliveTimer
Test Reference
RFC4271, Sect. 8.2.2, p 65,
BGP Finite State machine
Test Classification
MUST
Test ANVL-BGP4-21.8: !FAILED!
External peer did not receive expected second
BGP4 KeepAlive Message from DUT

Successful on other platforms
  • Debian 8 deb pkg check
  • Addresssanitizer topotest
  • Debian 9 deb pkg check
  • Topology tests on Ubuntu 16.04 amd64
  • IPv4 ldp protocol on Ubuntu 16.04
  • Ubuntu 14.04 deb pkg check
  • Topotest tests on Ubuntu 16.04 i386
  • Static analyzer (clang)
  • CentOS 7 rpm pkg check
  • Debian 10 deb pkg check
  • IPv6 protocols on Ubuntu 14.04
  • Topology tests on Ubuntu 18.04 amd64
  • Ubuntu 16.04 deb pkg check
  • Ubuntu 12.04 deb pkg check
  • Fedora 29 rpm pkg check

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8294/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

CLANG Static Analyzer Summary

  • Github Pull Request 4654, comparing to Git base SHA 6dcd5d2

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8294/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jul 8, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4654 668cfa9
Date 07/08/2019
Start 14:40:08
Finish 15:02:18
Run-Time 22:10
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-07-08-14:40:08.txt
Log autoscript-2019-07-08-14:41:06.log.bz2
Memory 437 424 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8294/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8294/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

CLANG Static Analyzer Summary

  • Github Pull Request 4654, comparing to Git base SHA 6dcd5d2

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8294/artifact/shared/static_analysis/index.html

@donaldsharp donaldsharp merged commit a700165 into FRRouting:master Jul 8, 2019
@edipascale edipascale deleted the fix_bgp_lbp_warn branch July 9, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants