Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add process pids to 'show modules' #4634

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

mjstapp
Copy link
Contributor

@mjstapp mjstapp commented Jul 2, 2019

Add the process pids to the output produced by 'show modules'. At least in a development setting, where there may be multiple instances of frr running, it can be handy to be able to see the exact pids, for debugging e.g.

The output looks like this:

mjs-uvm18# sho mod
Module information for zebra:
Module Name  Version                   Description

libfrr       7.2-dev-WORK              libfrr core module
zebra        7.2-dev-WORK              zebra daemon
pid: 38143

Module information for sharpd:
Module Name  Version                   Description

libfrr       7.2-dev-WORK              libfrr core module
sharpd       7.2-dev-WORK              sharpd daemon
pid: 38162

@qlyoung
Copy link
Member

qlyoung commented Jul 2, 2019

hell yeah

lib/memory_vty.c Outdated Show resolved Hide resolved
Add the process pids to the output produced by 'show modules'.
At least in a development setting, where there may be multiple
instances of frr running, it can be handy to be able to id
the exact pids, for debugging e.g.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
@mjstapp mjstapp force-pushed the vty_report_pids branch from f95dfc9 to bfae97a Compare July 2, 2019 19:15
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8264/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for memory_vty.c | 2 issues
===============================================
< ERROR: space prohibited before that close parenthesis ')'
< #175: FILE: /tmp/f1-30728/memory_vty.c:175:

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8264/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

CLANG Static Analyzer Summary

  • Github Pull Request 4634, comparing to Git base SHA 5f59000

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8264/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8267/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8267/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: changelog-should-mention-nmu

CLANG Static Analyzer Summary

  • Github Pull Request 4634, comparing to Git base SHA 1c05eb4

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8267/artifact/shared/static_analysis/index.html

@qlyoung qlyoung merged commit db9f2dd into FRRouting:master Jul 2, 2019
@mjstapp mjstapp deleted the vty_report_pids branch June 12, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants