Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: [5.0] interface based peers should automatically override it's peer g… #4596

Merged
merged 1 commit into from
Jul 9, 2019
Merged

bgpd: [5.0] interface based peers should automatically override it's peer g… #4596

merged 1 commit into from
Jul 9, 2019

Conversation

ton31337
Copy link
Member

…roup

When a interface based peer is setup and if it is part of a peer
group we should ignore this and just use the PEER_FLAG_CAPABILITY_ENHE
no matter what.

Signed-off-by: Donald Sharp sharpd@cumulusnetworks.com
Signed-off-by: Donatas Abraitis donatas.abraitis@gmail.com

Related: #3251

…roup

When a interface based peer is setup and if it is part of a peer
group we should ignore this and just use the PEER_FLAG_CAPABILITY_ENHE
no matter what.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
@polychaeta polychaeta added the bgp label Jun 23, 2019
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8195/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 ppc64le build: Failed (click for details) Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8195/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8195/artifact/U1804PPC64LEBUILD/config.status/config.status

Package building failed for Ubuntu 18.04 ppc64le build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8195/artifact/U1804PPC64LEBUILD/ErrorLog/log_package_build.txt)

dh: Unknown sequence debian/backports/rules (choose from: binary binary-arch binary-indep build build-arch build-indep clean install install-arch install-indep)
# Frr needs /proc to check some BSD vs Linux specific stuff.
# Else it fails with an obscure error message pointing out that
# IPCTL_FORWARDING is an undefined symbol which is not very helpful.
if ! [ -e config.status ]; then \
dh_auto_configure -- \
	--enable-exampledir=/usr/share/doc/frr/examples/ \
	--localstatedir=/var/run/frr \
	--sbindir=/usr/lib/frr \
Successful on other platforms
  • Ubuntu 18.04 amd64 build
  • FreeBSD 12 amd64 build
  • Ubuntu 14.04 amd64 build
  • Debian 8 amd64 build
  • Debian 9 amd64 build
  • OmniOS amd64 build
  • FreeBSD 11 amd64 build
  • OpenBSD 6 amd64 build
  • NetBSD 7 amd64 build
  • NetBSD 6 amd64 build
  • CentOS 7 amd64 build
  • Ubuntu 16.04 amd64 build
  • Ubuntu 12.04 amd64 build
  • Ubuntu 16.04 i386 build
  • Fedora 29 amd64 build

@ton31337
Copy link
Member Author

ton31337 commented Jul 7, 2019

anyone?

@donaldsharp donaldsharp merged commit 0bb9df0 into FRRouting:stable/5.0 Jul 9, 2019
@ton31337 ton31337 deleted the fix/force_ehne_if_peer_group_and_interface_5.0 branch July 19, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants