Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: make printfrr int64_t usable #4509

Merged
merged 5 commits into from
Jun 13, 2019

Conversation

eqvinox
Copy link
Contributor

@eqvinox eqvinox commented Jun 12, 2019

also moves from -Os to -O2 & adds a vim snippet

with this, %Lu should actually be usable.

@NetDEF-CI

This comment has been minimized.

eqvinox added 5 commits June 12, 2019 19:35
Signed-off-by: David Lamparter <equinox@diac24.net>
We need to be calling snprintfrr() instead of snprintf() in places that
wrap snprintf in some user-exposed way; otherwise the extensions won't
be available for those functions.

Signed-off-by: David Lamparter <equinox@diac24.net>
... without compiler plugins.

Signed-off-by: David Lamparter <equinox@diac24.net>
Signed-off-by: David Lamparter <equinox@diac24.net>
apparently -Os is quite a bit slower...

Signed-off-by: David Lamparter <equinox@diac24.net>
@eqvinox eqvinox force-pushed the spanish-intquisition branch from 5fdc8d3 to 39c94f8 Compare June 12, 2019 17:36
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8032/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings
Report for compiler.h | 4 issues
===============================================
< WARNING: do not add new typedefs
< #261: FILE: /tmp/f1-13487/compiler.h:261:
< WARNING: do not add new typedefs
< #263: FILE: /tmp/f1-13487/compiler.h:263:
Report for isis_misc.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#486: FILE: /tmp/f1-13487/isis_misc.c:486:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#485: FILE: /tmp/f2-13487/isis_misc.c:485:
24c24
< #513: FILE: /tmp/f1-13487/isis_misc.c:513:

CLANG Static Analyzer Summary

  • Github Pull Request 4509, comparing to Git base SHA 8fd142d

No Changes in Static Analysis warnings compared to base

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8032/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 12, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4509 39c94f8
Date 06/12/2019
Start 15:36:29
Finish 15:59:06
Run-Time 22:37
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-06-12-15:36:29.txt
Log autoscript-2019-06-12-15:37:34.log.bz2
Memory 436 413 360

For details, please contact louberger

@qlyoung qlyoung merged commit 096873b into FRRouting:master Jun 13, 2019
@eqvinox eqvinox deleted the spanish-intquisition branch April 18, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants