Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topotests: backward compatibility fix #4502

Merged

Conversation

rzalamena
Copy link
Member

@rzalamena rzalamena commented Jun 11, 2019

Summary

Allow old topologies to use default parameters from pytest.ini.

Related issue

Fixes #3556

Allow old topologies to use default parameters from `pytest.ini`.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Jun 11, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4502 04ce2b9
Date 06/11/2019
Start 15:06:56
Finish 15:29:46
Run-Time 22:50
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-06-11-15:06:56.txt
Log autoscript-2019-06-11-15:07:59.log.bz2
Memory 436 426 360

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8003/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 4502, comparing to Git base SHA afbdfbb

No Changes in Static Analysis warnings compared to base

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8003/artifact/shared/static_analysis/index.html

Copy link
Member

@rwestphal rwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I confirm this fixes #3556.

@donaldsharp donaldsharp merged commit 6a81b60 into FRRouting:master Jun 13, 2019
@rzalamena rzalamena deleted the topotest-backward-compat branch April 15, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some topotests are not honoring the frrdir configuration setting
5 participants