Fd stuff #4392
Merged
Fd stuff #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
donaldsharp
commented
May 24, 2019
donaldsharp
commented
- Remove SO_MARK socket option as that it was undocumented and could interfere with people's usages of rules
- Update documentation in a bunch of spots
- Update What is displayed to the end user to allow for easier debugging.
The 'show thread cpu' command referenced a 'b' option. Which is not parsed at all in the parse_filter function. As such I do not know what this was referencing as that it has been removed. Update the help strings to reflect this reality. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Upon startup FRR reads in the MAX_FDS variable from it's control files via the getrlimit call. We then setup code to limit the poll data structure size to that value. The OS also limits our FD's to that value because that is what is set. Provide a methodology that a interested end user can figure this data out. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Place in the code the ability for end operators to know how to modify MAX_FDS so that they can run large scale operations. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Add some very basic 'show thread cpu' and 'show thread poll' documentation to our system. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
When issuing a `show bgp neighbor...` command display to the end user the FD used for communication. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
The SO_MARK socket option was being used pre vrf to allow for the separation of the front panel -vs- the management port. This was facilitated by a ip rule. Since this is undocumented anywhere in our system( other than old commits see ed40466 ). We should remove this because this will cause interference with people using rules and are not aware of this offshoot of functionality. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7822/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base11 Static Analyzer issues remaining.See details at |
qlyoung
reviewed
May 24, 2019
| @@ -83,6 +71,13 @@ This file has several parts. Here is an example: | |||
|
|
|||
| Breaking this file down: | |||
|
|
|||
| :: | |||
|
|
|||
| bgpd=yes | |||
There was a problem hiding this comment.
Three spaces pls. Also, for future reference you can write blocks like this as:
Breaking this file down::
bgpd = yes
This is syntax sugar, Sphinx will render the :: as a single : and treat the indented block as a code block.
There was a problem hiding this comment.
Took the liberty of adding that space character and merging.
btw, for future reference, shell doesn't accept spaces around the = 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.