bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HOP attribute #4258

nikos-github · 2019-05-04T06:27:25Z

This is causing interop issues with vendors. According to the RFC, receiver should ignore the NEXT_HOP attribute with MP_REACH_NLRI present. Issue reproduced with Arista peer and fix verified.

Fix should address #3768

Thanks,

Nikos.-

Signed-off-by: nikos ntriantafillis@gmail.com

…P attribute This is causing interop issues with vendors. According to the RFC, receiver should ignore the NEXT_HOP attribute with MP_REACH_NLRI present. Signed-off-by: nikos ntriantafillis@gmail.com

LabN-CI · 2019-05-04T07:31:52Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4258 `88f33d6`
Date	05/04/2019
Start	03:07:03
Finish	03:31:37
Run-Time	24:34
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-04-03:07:03.txt
Log	autoscript-2019-05-04-03:08:00.log.bz2
Memory	433 427 374

For details, please contact louberger

NetDEF-CI · 2019-05-04T07:36:27Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7493/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-7493/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-05-03 23:57:48,531 ERROR: ******************************************************************************
2019-05-03 23:57:48,531 ERROR: Test Target Summary                                                  Pass Fail
2019-05-03 23:57:48,531 ERROR: ******************************************************************************
2019-05-03 23:57:48,531 ERROR: FILE: scripts/adjacencies.py
2019-05-03 23:57:48,531 ERROR: 10   r3     Core adjacencies up                                      0    1
2019-05-03 23:57:48,531 ERROR: 13   r3     All adjacencies up                                       0    1
2019-05-03 23:57:48,531 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-03 23:57:48,533 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_adjacencies": 2 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7493/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Successful on other platforms

Addresssanitizer topotest
Debian 8 deb pkg check
CentOS 6 rpm pkg check
Ubuntu 14.04 deb pkg check
IPv4 ldp protocol on Ubuntu 16.04
IPv4 protocols on Ubuntu 14.04
Debian 9 deb pkg check
Static analyzer (clang)
IPv6 protocols on Ubuntu 14.04
Topology tests on Ubuntu 18.04 amd64
CentOS 7 rpm pkg check
Ubuntu 16.04 deb pkg check
Topotest tests on Ubuntu 16.04 i386
Ubuntu 12.04 deb pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7493/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 4258, comparing to Git base SHA b1ad735

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7493/artifact/shared/static_analysis/index.html

nikos-github · 2019-05-05T02:34:04Z

@mwinter-osr Is the failure expected? I don't believe it's related to my change by looking at it. Please let me know.

nikos-github · 2019-05-06T21:17:09Z

ci:rerun

nikos-github · 2019-05-07T02:15:58Z

@mwinter-osr Is the failure related to a CI issue? Because it's not related to my changes.

dpkg: dependency problems prevent configuration of frr-rpki-rtrlib:
frr-rpki-rtrlib depends on librtr0; however:
  Package librtr0 is not installed.

dpkg: error processing package frr-rpki-rtrlib (--install):
dependency problems - leaving unconfigured
Errors were encountered while processing:
frr-rpki-rtrlib
ci/topotests/run_topotests.sh: line 2: g: command not found
*** defaultIntf: warning: r1 has no interfaces
2019-05-03 23:57:48,531 ERROR: ******************************************************************************
2019-05-03 23:57:48,531 ERROR: Test Target Summary                                                  Pass Fail
2019-05-03 23:57:48,531 ERROR: ******************************************************************************
2019-05-03 23:57:48,531 ERROR: FILE: scripts/adjacencies.py
2019-05-03 23:57:48,531 ERROR: 10   r3     Core adjacencies up                                      0    1
2019-05-03 23:57:48,531 ERROR: 13   r3     All adjacencies up                                       0    1
2019-05-03 23:57:48,531 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-03 23:57:48,533 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_adjacencies": 2 tests failed
*** defaultIntf: warning: lm has no interfaces```

bgpd/bgp_attr.c

NetDEF-CI · 2019-05-07T18:22:16Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7493/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 4258, comparing to Git base SHA b1ad735

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7493/artifact/shared/static_analysis/index.html

bgpd/bgp_attr.c

LabN-CI · 2019-05-09T07:34:53Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4258 `bb77440`
Date	05/09/2019
Start	03:10:27
Finish	03:34:37
Run-Time	24:10
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-09-03:10:27.txt
Log	autoscript-2019-05-09-03:11:12.log.bz2
Memory	447 441 374

For details, please contact louberger

NetDEF-CI · 2019-05-09T08:13:22Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-7593/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-05-09 00:35:21,656 ERROR: ******************************************************************************
2019-05-09 00:35:21,657 ERROR: Test Target Summary                                                  Pass Fail
2019-05-09 00:35:21,657 ERROR: ******************************************************************************
2019-05-09 00:35:21,658 ERROR: FILE: scripts/adjacencies.py
2019-05-09 00:35:21,658 ERROR: FILE: scripts/check_routes.py
2019-05-09 00:35:21,658 ERROR: 40   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-09 00:35:21,659 ERROR: 41   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-09 00:35:21,659 ERROR: 42   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-09 00:35:21,659 ERROR: 43   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-09 00:35:21,659 ERROR: 44   ce1    Local and remote routes +10.43 secs                      0    1
2019-05-09 00:35:21,659 ERROR: 45   ce1    Cust 1 routes from remote                                0    1
2019-05-09 00:35:21,660 ERROR: 46   ce2    Local and remote routes +10.41 secs                      0    1
2019-05-09 00:35:21,660 ERROR: 47   ce2    Cust 1 routes from remote                                0    1
2019-05-09 00:35:21,660 ERROR: 48   ce3    Local and remote routes +10.42 secs                      0    1
2019-05-09 00:35:21,660 ERROR: 49   ce3    Cust 1 routes from remote                                0    1
2019-05-09 00:35:21,660 ERROR: 50   ce4    Local and remote routes +10.38 secs                      0    1
2019-05-09 00:35:21,661 ERROR: 51   ce4    Cust 2 routes from remote                                0    1
2019-05-09 00:35:21,661 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-09 00:35:21,664 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-7593/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
2019-05-09 00:35:06,672 ERROR: ******************************************************************************
2019-05-09 00:35:06,673 ERROR: Test Target Summary                                                  Pass Fail
2019-05-09 00:35:06,673 ERROR: ******************************************************************************
2019-05-09 00:35:06,673 ERROR: FILE: scripts/adjacencies.py
2019-05-09 00:35:06,673 ERROR: FILE: scripts/check_routes.py
2019-05-09 00:35:06,673 ERROR: 40   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-09 00:35:06,673 ERROR: 41   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-09 00:35:06,673 ERROR: 42   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-09 00:35:06,673 ERROR: 43   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-09 00:35:06,673 ERROR: 44   ce1    Local and remote routes +10.46 secs                      0    1
2019-05-09 00:35:06,673 ERROR: 45   ce1    Cust 1 routes from remote                                0    1
2019-05-09 00:35:06,673 ERROR: 46   ce2    Local and remote routes +10.54 secs                      0    1
2019-05-09 00:35:06,673 ERROR: 47   ce2    Cust 1 routes from remote                                0    1
2019-05-09 00:35:06,674 ERROR: 48   ce3    Local and remote routes +10.45 secs                      0    1
2019-05-09 00:35:06,674 ERROR: 49   ce3    Cust 1 routes from remote                                0    1
2019-05-09 00:35:06,674 ERROR: 50   ce4    Local and remote routes +10.49 secs                      0    1
2019-05-09 00:35:06,674 ERROR: 51   ce4    Cust 2 routes from remote                                0    1
2019-05-09 00:35:06,674 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-09 00:35:06,676 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: lm has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-7593/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-05-09 07:34:59,864 ERROR: ******************************************************************************
2019-05-09 07:34:59,865 ERROR: Test Target Summary                                                  Pass Fail
2019-05-09 07:34:59,866 ERROR: ******************************************************************************
2019-05-09 07:34:59,866 ERROR: FILE: scripts/check_linux_vrf.py
2019-05-09 07:34:59,866 ERROR: FILE: scripts/adjacencies.py
2019-05-09 07:34:59,866 ERROR: FILE: scripts/check_routes.py
2019-05-09 07:34:59,866 ERROR: 73   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-09 07:34:59,866 ERROR: 74   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-09 07:34:59,866 ERROR: 75   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-09 07:34:59,866 ERROR: 76   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-09 07:34:59,866 ERROR: 77   ce1    Local and remote routes +10.19 secs                      0    1
2019-05-09 07:34:59,867 ERROR: 78   ce1    Cust 1 routes from remote                                0    1
2019-05-09 07:34:59,867 ERROR: 79   ce2    Local and remote routes +10.18 secs                      0    1
2019-05-09 07:34:59,867 ERROR: 80   ce2    Cust 1 routes from remote                                0    1
2019-05-09 07:34:59,867 ERROR: 81   ce3    Local and remote routes +10.25 secs                      0    1
2019-05-09 07:34:59,867 ERROR: 82   ce3    Cust 1 routes from remote                                0    1
2019-05-09 07:34:59,867 ERROR: 83   ce4    Local and remote routes +10.14 secs                      0    1
2019-05-09 07:34:59,867 ERROR: 84   ce4    Cust 2 routes from remote                                0    1
2019-05-09 07:34:59,867 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-09 07:34:59,870 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms

Ubuntu 14.04 deb pkg check
IPv4 ldp protocol on Ubuntu 16.04
Addresssanitizer topotest
Debian 8 deb pkg check
IPv4 protocols on Ubuntu 14.04
Debian 9 deb pkg check
CentOS 7 rpm pkg check
Static analyzer (clang)
IPv6 protocols on Ubuntu 14.04
Ubuntu 16.04 deb pkg check
Ubuntu 12.04 deb pkg check
CentOS 6 rpm pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1604/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOI386/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1804/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-7593/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-05-09 00:35:21,656 ERROR: ******************************************************************************
2019-05-09 00:35:21,657 ERROR: Test Target Summary                                                  Pass Fail
2019-05-09 00:35:21,657 ERROR: ******************************************************************************
2019-05-09 00:35:21,658 ERROR: FILE: scripts/adjacencies.py
2019-05-09 00:35:21,658 ERROR: FILE: scripts/check_routes.py
2019-05-09 00:35:21,658 ERROR: 40   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-09 00:35:21,659 ERROR: 41   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-09 00:35:21,659 ERROR: 42   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-09 00:35:21,659 ERROR: 43   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-09 00:35:21,659 ERROR: 44   ce1    Local and remote routes +10.43 secs                      0    1
2019-05-09 00:35:21,659 ERROR: 45   ce1    Cust 1 routes from remote                                0    1
2019-05-09 00:35:21,660 ERROR: 46   ce2    Local and remote routes +10.41 secs                      0    1
2019-05-09 00:35:21,660 ERROR: 47   ce2    Cust 1 routes from remote                                0    1
2019-05-09 00:35:21,660 ERROR: 48   ce3    Local and remote routes +10.42 secs                      0    1
2019-05-09 00:35:21,660 ERROR: 49   ce3    Cust 1 routes from remote                                0    1
2019-05-09 00:35:21,660 ERROR: 50   ce4    Local and remote routes +10.38 secs                      0    1
2019-05-09 00:35:21,661 ERROR: 51   ce4    Cust 2 routes from remote                                0    1
2019-05-09 00:35:21,661 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-09 00:35:21,664 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-7593/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
2019-05-09 00:35:06,672 ERROR: ******************************************************************************
2019-05-09 00:35:06,673 ERROR: Test Target Summary                                                  Pass Fail
2019-05-09 00:35:06,673 ERROR: ******************************************************************************
2019-05-09 00:35:06,673 ERROR: FILE: scripts/adjacencies.py
2019-05-09 00:35:06,673 ERROR: FILE: scripts/check_routes.py
2019-05-09 00:35:06,673 ERROR: 40   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-09 00:35:06,673 ERROR: 41   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-09 00:35:06,673 ERROR: 42   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-09 00:35:06,673 ERROR: 43   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-09 00:35:06,673 ERROR: 44   ce1    Local and remote routes +10.46 secs                      0    1
2019-05-09 00:35:06,673 ERROR: 45   ce1    Cust 1 routes from remote                                0    1
2019-05-09 00:35:06,673 ERROR: 46   ce2    Local and remote routes +10.54 secs                      0    1
2019-05-09 00:35:06,673 ERROR: 47   ce2    Cust 1 routes from remote                                0    1
2019-05-09 00:35:06,674 ERROR: 48   ce3    Local and remote routes +10.45 secs                      0    1
2019-05-09 00:35:06,674 ERROR: 49   ce3    Cust 1 routes from remote                                0    1
2019-05-09 00:35:06,674 ERROR: 50   ce4    Local and remote routes +10.49 secs                      0    1
2019-05-09 00:35:06,674 ERROR: 51   ce4    Cust 2 routes from remote                                0    1
2019-05-09 00:35:06,674 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-09 00:35:06,676 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: lm has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-7593/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-05-09 07:34:59,864 ERROR: ******************************************************************************
2019-05-09 07:34:59,865 ERROR: Test Target Summary                                                  Pass Fail
2019-05-09 07:34:59,866 ERROR: ******************************************************************************
2019-05-09 07:34:59,866 ERROR: FILE: scripts/check_linux_vrf.py
2019-05-09 07:34:59,866 ERROR: FILE: scripts/adjacencies.py
2019-05-09 07:34:59,866 ERROR: FILE: scripts/check_routes.py
2019-05-09 07:34:59,866 ERROR: 73   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-09 07:34:59,866 ERROR: 74   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-09 07:34:59,866 ERROR: 75   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-09 07:34:59,866 ERROR: 76   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-09 07:34:59,866 ERROR: 77   ce1    Local and remote routes +10.19 secs                      0    1
2019-05-09 07:34:59,867 ERROR: 78   ce1    Cust 1 routes from remote                                0    1
2019-05-09 07:34:59,867 ERROR: 79   ce2    Local and remote routes +10.18 secs                      0    1
2019-05-09 07:34:59,867 ERROR: 80   ce2    Cust 1 routes from remote                                0    1
2019-05-09 07:34:59,867 ERROR: 81   ce3    Local and remote routes +10.25 secs                      0    1
2019-05-09 07:34:59,867 ERROR: 82   ce3    Cust 1 routes from remote                                0    1
2019-05-09 07:34:59,867 ERROR: 83   ce4    Local and remote routes +10.14 secs                      0    1
2019-05-09 07:34:59,867 ERROR: 84   ce4    Cust 2 routes from remote                                0    1
2019-05-09 07:34:59,867 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-09 07:34:59,870 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Report for bgp_attr.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2700: FILE: /tmp/f1-9438/bgp_attr.c:2700:
Report for bgp_packet.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1537: FILE: /tmp/f1-9438/bgp_packet.c:1537:

CLANG Static Analyzer Summary

Github Pull Request 4258, comparing to Git base SHA b1ad735

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/shared/static_analysis/index.html

donaldsharp · 2019-05-09T23:28:35Z

Let's get the CI issues cleaned up and then we finish this up

nikos-github · 2019-05-10T01:25:09Z

ci:rerun

NetDEF-CI · 2019-05-10T11:51:50Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-7593/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-05-10 04:31:57,959 ERROR: ******************************************************************************
2019-05-10 04:31:57,960 ERROR: Test Target Summary                                                  Pass Fail
2019-05-10 04:31:57,960 ERROR: ******************************************************************************
2019-05-10 04:31:57,960 ERROR: FILE: scripts/adjacencies.py
2019-05-10 04:31:57,961 ERROR: FILE: scripts/check_routes.py
2019-05-10 04:31:57,961 ERROR: 40   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-10 04:31:57,961 ERROR: 41   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-10 04:31:57,961 ERROR: 42   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-10 04:31:57,961 ERROR: 43   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-10 04:31:57,961 ERROR: 44   ce1    Local and remote routes +10.56 secs                      0    1
2019-05-10 04:31:57,961 ERROR: 45   ce1    Cust 1 routes from remote                                0    1
2019-05-10 04:31:57,962 ERROR: 46   ce2    Local and remote routes +10.54 secs                      0    1
2019-05-10 04:31:57,962 ERROR: 47   ce2    Cust 1 routes from remote                                0    1
2019-05-10 04:31:57,962 ERROR: 48   ce3    Local and remote routes +10.48 secs                      0    1
2019-05-10 04:31:57,962 ERROR: 49   ce3    Cust 1 routes from remote                                0    1
2019-05-10 04:31:57,962 ERROR: 50   ce4    Local and remote routes +10.54 secs                      0    1
2019-05-10 04:31:57,962 ERROR: 51   ce4    Cust 2 routes from remote                                0    1
2019-05-10 04:31:57,962 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-10 04:31:57,966 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-7593/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
2019-05-10 04:31:54,757 ERROR: ******************************************************************************
2019-05-10 04:31:54,758 ERROR: Test Target Summary                                                  Pass Fail
2019-05-10 04:31:54,759 ERROR: ******************************************************************************
2019-05-10 04:31:54,759 ERROR: FILE: scripts/adjacencies.py
2019-05-10 04:31:54,760 ERROR: FILE: scripts/check_routes.py
2019-05-10 04:31:54,760 ERROR: 40   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-10 04:31:54,760 ERROR: 41   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-10 04:31:54,761 ERROR: 42   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-10 04:31:54,761 ERROR: 43   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-10 04:31:54,761 ERROR: 44   ce1    Local and remote routes +10.52 secs                      0    1
2019-05-10 04:31:54,761 ERROR: 45   ce1    Cust 1 routes from remote                                0    1
2019-05-10 04:31:54,761 ERROR: 46   ce2    Local and remote routes +10.65 secs                      0    1
2019-05-10 04:31:54,761 ERROR: 47   ce2    Cust 1 routes from remote                                0    1
2019-05-10 04:31:54,762 ERROR: 48   ce3    Local and remote routes +10.11 secs                      0    1
2019-05-10 04:31:54,762 ERROR: 49   ce3    Cust 1 routes from remote                                0    1
2019-05-10 04:31:54,762 ERROR: 50   ce4    Local and remote routes +10.17 secs                      0    1
2019-05-10 04:31:54,762 ERROR: 51   ce4    Cust 2 routes from remote                                0    1
2019-05-10 04:31:54,762 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-10 04:31:54,765 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: lm has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-7593/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-05-10 11:31:43,373 ERROR: ******************************************************************************
2019-05-10 11:31:43,374 ERROR: Test Target Summary                                                  Pass Fail
2019-05-10 11:31:43,374 ERROR: ******************************************************************************
2019-05-10 11:31:43,375 ERROR: FILE: scripts/check_linux_vrf.py
2019-05-10 11:31:43,375 ERROR: FILE: scripts/adjacencies.py
2019-05-10 11:31:43,375 ERROR: FILE: scripts/check_routes.py
2019-05-10 11:31:43,375 ERROR: 73   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-10 11:31:43,375 ERROR: 74   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-10 11:31:43,375 ERROR: 75   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-10 11:31:43,375 ERROR: 76   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-10 11:31:43,376 ERROR: 77   ce1    Local and remote routes +10.44 secs                      0    1
2019-05-10 11:31:43,376 ERROR: 78   ce1    Cust 1 routes from remote                                0    1
2019-05-10 11:31:43,376 ERROR: 79   ce2    Local and remote routes +10.20 secs                      0    1
2019-05-10 11:31:43,376 ERROR: 80   ce2    Cust 1 routes from remote                                0    1
2019-05-10 11:31:43,376 ERROR: 81   ce3    Local and remote routes +10.30 secs                      0    1
2019-05-10 11:31:43,376 ERROR: 82   ce3    Cust 1 routes from remote                                0    1
2019-05-10 11:31:43,376 ERROR: 83   ce4    Local and remote routes +10.57 secs                      0    1
2019-05-10 11:31:43,377 ERROR: 84   ce4    Cust 2 routes from remote                                0    1
2019-05-10 11:31:43,377 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-10 11:31:43,379 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms

Ubuntu 14.04 deb pkg check
IPv4 ldp protocol on Ubuntu 16.04
Addresssanitizer topotest
Debian 8 deb pkg check
IPv4 protocols on Ubuntu 14.04
Debian 9 deb pkg check
CentOS 7 rpm pkg check
Static analyzer (clang)
IPv6 protocols on Ubuntu 14.04
Ubuntu 16.04 deb pkg check
Ubuntu 12.04 deb pkg check
CentOS 6 rpm pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1604/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOI386/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1804/MemoryLeaks/

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-7593/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-05-10 04:31:57,959 ERROR: ******************************************************************************
2019-05-10 04:31:57,960 ERROR: Test Target Summary                                                  Pass Fail
2019-05-10 04:31:57,960 ERROR: ******************************************************************************
2019-05-10 04:31:57,960 ERROR: FILE: scripts/adjacencies.py
2019-05-10 04:31:57,961 ERROR: FILE: scripts/check_routes.py
2019-05-10 04:31:57,961 ERROR: 40   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-10 04:31:57,961 ERROR: 41   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-10 04:31:57,961 ERROR: 42   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-10 04:31:57,961 ERROR: 43   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-10 04:31:57,961 ERROR: 44   ce1    Local and remote routes +10.56 secs                      0    1
2019-05-10 04:31:57,961 ERROR: 45   ce1    Cust 1 routes from remote                                0    1
2019-05-10 04:31:57,962 ERROR: 46   ce2    Local and remote routes +10.54 secs                      0    1
2019-05-10 04:31:57,962 ERROR: 47   ce2    Cust 1 routes from remote                                0    1
2019-05-10 04:31:57,962 ERROR: 48   ce3    Local and remote routes +10.48 secs                      0    1
2019-05-10 04:31:57,962 ERROR: 49   ce3    Cust 1 routes from remote                                0    1
2019-05-10 04:31:57,962 ERROR: 50   ce4    Local and remote routes +10.54 secs                      0    1
2019-05-10 04:31:57,962 ERROR: 51   ce4    Cust 2 routes from remote                                0    1
2019-05-10 04:31:57,962 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-10 04:31:57,966 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-7593/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

*** defaultIntf: warning: r1 has no interfaces
2019-05-10 04:31:54,757 ERROR: ******************************************************************************
2019-05-10 04:31:54,758 ERROR: Test Target Summary                                                  Pass Fail
2019-05-10 04:31:54,759 ERROR: ******************************************************************************
2019-05-10 04:31:54,759 ERROR: FILE: scripts/adjacencies.py
2019-05-10 04:31:54,760 ERROR: FILE: scripts/check_routes.py
2019-05-10 04:31:54,760 ERROR: 40   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-10 04:31:54,760 ERROR: 41   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-10 04:31:54,761 ERROR: 42   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-10 04:31:54,761 ERROR: 43   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-10 04:31:54,761 ERROR: 44   ce1    Local and remote routes +10.52 secs                      0    1
2019-05-10 04:31:54,761 ERROR: 45   ce1    Cust 1 routes from remote                                0    1
2019-05-10 04:31:54,761 ERROR: 46   ce2    Local and remote routes +10.65 secs                      0    1
2019-05-10 04:31:54,761 ERROR: 47   ce2    Cust 1 routes from remote                                0    1
2019-05-10 04:31:54,762 ERROR: 48   ce3    Local and remote routes +10.11 secs                      0    1
2019-05-10 04:31:54,762 ERROR: 49   ce3    Cust 1 routes from remote                                0    1
2019-05-10 04:31:54,762 ERROR: 50   ce4    Local and remote routes +10.17 secs                      0    1
2019-05-10 04:31:54,762 ERROR: 51   ce4    Cust 2 routes from remote                                0    1
2019-05-10 04:31:54,762 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-10 04:31:54,765 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: lm has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOI386/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-7593/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

*** defaultIntf: warning: r1 has no interfaces
2019-05-10 11:31:43,373 ERROR: ******************************************************************************
2019-05-10 11:31:43,374 ERROR: Test Target Summary                                                  Pass Fail
2019-05-10 11:31:43,374 ERROR: ******************************************************************************
2019-05-10 11:31:43,375 ERROR: FILE: scripts/check_linux_vrf.py
2019-05-10 11:31:43,375 ERROR: FILE: scripts/adjacencies.py
2019-05-10 11:31:43,375 ERROR: FILE: scripts/check_routes.py
2019-05-10 11:31:43,375 ERROR: 73   r1     Customer 1 routes in r1 vrf                              0    1
2019-05-10 11:31:43,375 ERROR: 74   r3     Customer 1 routes in r3 vrf                              0    1
2019-05-10 11:31:43,375 ERROR: 75   r4     Customer 1 routes in r4 vrf                              0    1
2019-05-10 11:31:43,375 ERROR: 76   r4     Customer 2 routes in r4 vrf                              0    1
2019-05-10 11:31:43,376 ERROR: 77   ce1    Local and remote routes +10.44 secs                      0    1
2019-05-10 11:31:43,376 ERROR: 78   ce1    Cust 1 routes from remote                                0    1
2019-05-10 11:31:43,376 ERROR: 79   ce2    Local and remote routes +10.20 secs                      0    1
2019-05-10 11:31:43,376 ERROR: 80   ce2    Cust 1 routes from remote                                0    1
2019-05-10 11:31:43,376 ERROR: 81   ce3    Local and remote routes +10.30 secs                      0    1
2019-05-10 11:31:43,376 ERROR: 82   ce3    Cust 1 routes from remote                                0    1
2019-05-10 11:31:43,376 ERROR: 83   ce4    Local and remote routes +10.57 secs                      0    1
2019-05-10 11:31:43,377 ERROR: 84   ce4    Cust 2 routes from remote                                0    1
2019-05-10 11:31:43,377 ERROR: See /tmp/topotests/bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/output.log for details of errors
2019-05-10 11:31:43,379 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_check_routes": 12 tests failed
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Report for bgp_attr.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2700: FILE: /tmp/f1-9438/bgp_attr.c:2700:
Report for bgp_packet.c | 2 issues
===============================================
< WARNING: line over 80 characters
< #1537: FILE: /tmp/f1-9438/bgp_packet.c:1537:

CLANG Static Analyzer Summary

Github Pull Request 4258, comparing to Git base SHA b1ad735

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7593/artifact/shared/static_analysis/index.html

…P attribute This is causing interop issues with vendors. According to the RFC, receiver should ignore the NEXT_HOP attribute with MP_REACH_NLRI present. Signed-off-by: nikos <ntriantafillis@gmail.com>

NetDEF-CI · 2019-05-10T20:57:15Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7622/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bgp_attr.c | 2 issues
===============================================
< WARNING: braces {} are not necessary for single statement blocks
< #2700: FILE: /tmp/f1-3851/bgp_attr.c:2700:
Report for bgp_packet.c | 20 issues
===============================================
< ERROR: strcat() is error-prone; please use strlcat() if possible#713: FILE: /tmp/f1-3851/bgp_packet.c:713:
---
> ERROR: strcat() is error-prone; please use strlcat() if possible#713: FILE: /tmp/f2-3851/bgp_packet.c:713:
29c29
< ERROR: strcpy() is error-prone; please use strlcpy()#717: FILE: /tmp/f1-3851/bgp_packet.c:717:
---
> ERROR: strcpy() is error-prone; please use strlcpy()#717: FILE: /tmp/f2-3851/bgp_packet.c:717:
33c33
< #824: FILE: /tmp/f1-3851/bgp_packet.c:824:
< WARNING: line over 80 characters
< #1537: FILE: /tmp/f1-3851/bgp_packet.c:1537:
< ERROR: strcat() is error-prone; please use strlcat() if possible#1705: FILE: /tmp/f1-3851/bgp_packet.c:1705:
---
> ERROR: strcat() is error-prone; please use strlcat() if possible#1694: FILE: /tmp/f2-3851/bgp_packet.c:1694:
216c212
< ERROR: strcpy() is error-prone; please use strlcpy()#1710: FILE: /tmp/f1-3851/bgp_packet.c:1710:
---
> ERROR: strcpy() is error-prone; please use strlcpy()#1699: FILE: /tmp/f2-3851/bgp_packet.c:1699:
220c216
< #1729: FILE: /tmp/f1-3851/bgp_packet.c:1729:

CLANG Static Analyzer Summary

Github Pull Request 4258, comparing to Git base SHA 0852f7c

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7622/artifact/shared/static_analysis/index.html

LabN-CI · 2019-05-10T21:20:21Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4258 `9738e9a`
Date	05/10/2019
Start	16:55:12
Finish	17:19:45
Run-Time	24:33
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-10-16:55:12.txt
Log	autoscript-2019-05-10-16:56:02.log.bz2
Memory	432 434 359

For details, please contact louberger

attribute [7.0] Port of FRRouting#4258 to stable/7.0 Signed-off-by: Pavel Shirshov <pavelsh@microsoft.com>

bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HOP attribute

bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HO…

88f33d6

…P attribute This is causing interop issues with vendors. According to the RFC, receiver should ignore the NEXT_HOP attribute with MP_REACH_NLRI present. Signed-off-by: nikos ntriantafillis@gmail.com

polychaeta added the bgp label May 4, 2019

nikos-github mentioned this pull request May 5, 2019

Clarification for Unnumbered BGP (RFC 5549) and path attribute NEXT_HOP (3) #3768

Closed

srimohans reviewed May 7, 2019

View reviewed changes

bgpd/bgp_attr.c Show resolved Hide resolved

srimohans approved these changes May 7, 2019

View reviewed changes

vivek-cumulus reviewed May 7, 2019

View reviewed changes

bgpd/bgp_attr.c Show resolved Hide resolved

bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HO…

9738e9a

…P attribute This is causing interop issues with vendors. According to the RFC, receiver should ignore the NEXT_HOP attribute with MP_REACH_NLRI present. Signed-off-by: nikos <ntriantafillis@gmail.com>

nikos-github force-pushed the frr-nexthop branch from bb77440 to 9738e9a Compare May 10, 2019 19:53

eqvinox merged commit a9547dd into FRRouting:master May 14, 2019

nikos-github deleted the frr-nexthop branch May 14, 2019 19:43

pavel-shirshov added a commit to pavel-shirshov/frr that referenced this pull request Jun 18, 2019

bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HOP

86b2b00

attribute [7.0] Port of FRRouting#4258 to stable/7.0 Signed-off-by: Pavel Shirshov <pavelsh@microsoft.com>

pavel-shirshov mentioned this pull request Jun 18, 2019

bgpd: [7.0] IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HOP attribute #4555

Merged

pavel-shirshov pushed a commit to pavel-shirshov/frr that referenced this pull request Jun 19, 2019

Merge pull request FRRouting#4258 from nikos-github/frr-nexthop

bb7df26

bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HOP attribute

mwinter-osr mentioned this pull request Sep 17, 2019

[dev/7.2] BGP IPv4 Notification wrong in case of Invalid NEXT_HOP Attribute (ANVL-BGP4-15.25) #4997

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HOP attribute #4258

bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HOP attribute #4258

nikos-github commented May 4, 2019

LabN-CI commented May 4, 2019

NetDEF-CI commented May 4, 2019

nikos-github commented May 5, 2019 •

edited

Loading

nikos-github commented May 6, 2019

nikos-github commented May 7, 2019 •

edited

Loading

NetDEF-CI commented May 7, 2019

LabN-CI commented May 9, 2019

NetDEF-CI commented May 9, 2019

donaldsharp commented May 9, 2019

nikos-github commented May 10, 2019

NetDEF-CI commented May 10, 2019

NetDEF-CI commented May 10, 2019

LabN-CI commented May 10, 2019

bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HOP attribute #4258

bgpd: IPv6 session flapping with MP_REACH_NLRI and 0.0.0.0 in NEXT_HOP attribute #4258

Conversation

nikos-github commented May 4, 2019

LabN-CI commented May 4, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 4, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7493/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

nikos-github commented May 5, 2019 • edited Loading

nikos-github commented May 6, 2019

nikos-github commented May 7, 2019 • edited Loading

NetDEF-CI commented May 7, 2019

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

LabN-CI commented May 9, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 9, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

donaldsharp commented May 9, 2019

nikos-github commented May 10, 2019

NetDEF-CI commented May 10, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

NetDEF-CI commented May 10, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

LabN-CI commented May 10, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

nikos-github commented May 5, 2019 •

edited

Loading

nikos-github commented May 7, 2019 •

edited

Loading