lib: fix issue with interface node access at startup #4193

pguibert6WIND · 2019-04-24T09:35:19Z

When duplicate name is on two network namespaces, at startup, the
wrong interface is picked up. Because we are at startup, force to return
the exact interface name.

Signed-off-by: Philippe Guibert philippe.guibert@6wind.com

LabN-CI · 2019-04-24T10:33:33Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4193 `be712e5`
Date	04/24/2019
Start	06:09:37
Finish	06:33:20
Run-Time	23:43
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-04-24-06:09:37.txt
Log	autoscript-2019-04-24-06:10:20.log.bz2
Memory	431 444 374

For details, please contact louberger

NetDEF-CI · 2019-04-24T10:39:43Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7347/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 4193, comparing to Git base SHA e400cd8

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7347/artifact/shared/static_analysis/index.html

donaldsharp

this is not the right approach where the end programmer must remember which proper interface name function to call depending on where we are.

rwestphal · 2019-05-21T00:23:51Z

this is not the right approach where the end programmer must remember which proper interface name function to call depending on where we are.

I think this is a good argument, but in this case I think we can't escape from treating the different VRF backends differently.

For historical reasons, the "interface" command uses if_lookup_by_name_all_vrf() since it was decided years ago that it should find the given interface in any VRF if none is specified. But this behavior is problematic for the NetNS backend, where interface names are not necessarily globally unique. I think there's nothing we can do at the API level to solve this problem. The existing if_lookup_*() functions are all working as they are supposed to. The problem we have is that the "interface" command has a very peculiar behavior, so adding a punctual exception here for the NetNS backend is acceptable in my opinion.

donaldsharp · 2019-05-21T15:41:01Z

Discussion during the meeting is that this needs to be looked at across the entire code base and fixes it once and for all.

LabN-CI · 2019-05-25T04:52:20Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4193 `be712e5`
Date	05/25/2019
Start	00:29:36
Finish	00:52:08
Run-Time	22:32
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-25-00:29:36.txt
Log	autoscript-2019-05-25-00:30:38.log.bz2
Memory	428 421 361

For details, please contact louberger

pguibert6WIND · 2019-06-12T11:55:11Z

new changes done here in addition to previous commit.

bfd change of behaviour
bgp code and ospf code has been modified. no change of behaviour

two points I would like to discuss more with review:

I think for bfd if we really want to not change behavior, we should detect vrf backend to call or not 'if_lookup_by_name_all_vrf()'.
second point, we can go further by either removing the call to 'if_lookup_by_name_all_vrf()' or using CONFDATE to schedule an EOL.

LabN-CI · 2019-06-12T12:18:30Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4193 `5c960e0`
Date	06/12/2019
Start	07:55:42
Finish	08:18:17
Run-Time	22:35
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-06-12-07:55:42.txt
Log	autoscript-2019-06-12-07:56:45.log.bz2
Memory	433 433 360

For details, please contact louberger

NetDEF-CI · 2019-06-12T13:07:42Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8022/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#785: FILE: /tmp/f1-5171/if.c:785:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#785: FILE: /tmp/f2-5171/if.c:785:
305c305
< #862: FILE: /tmp/f1-5171/if.c:862:

CLANG Static Analyzer Summary

Github Pull Request 4193, comparing to Git base SHA afbdfbb

No Changes in Static Analysis warnings compared to base

4 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8022/artifact/shared/static_analysis/index.html

pguibert6WIND · 2019-06-21T09:34:12Z

Discussion during the meeting is that this needs to be looked at across the entire code base and fixes it > once and for all.
some changes have been proposed in that direction.please review

pguibert6WIND · 2019-07-01T11:45:44Z

Hi @qlyoung ,
any feedback on this review, pleasE?

qlyoung

Seems okay to me given the problem description but should probably be reviewed by Donald as well

zebra/zebra_ptm.c

LabN-CI · 2019-07-03T01:07:04Z

🚧 Basic BGPD CI results: Partial FAILURE, 273 tests failed, has VALGRIND issues

Results table

_	_
Result	SUCCESS git merge/4193 `5c960e0`
Date	07/02/2019
Start	19:11:06
Finish	21:06:54
Run-Time	01:55:48
Total	1775
Pass	1502
Fail	273
Valgrind-Errors	1
Valgrind-Loss	5
Details	vncregress-2019-07-02-19:11:06.txt
Log	autoscript-2019-07-02-19:12:05.log.bz2
Memory	5556 424 362

For details, please contact louberger

pguibert6WIND · 2019-07-05T15:18:51Z

ci:rerun

pguibert6WIND · 2019-07-08T07:31:20Z

ci:rerun

LabN-CI · 2019-07-08T20:59:43Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4193 `5c960e0`
Date	07/08/2019
Start	16:37:20
Finish	16:59:33
Run-Time	22:13
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-07-08-16:37:20.txt
Log	autoscript-2019-07-08-16:38:26.log.bz2
Memory	423 434 360

For details, please contact louberger

pguibert6WIND · 2019-07-09T13:37:49Z

any reviewers willing to resume the review, please?

rwestphal

Looks good to me.

If possible please turn if_lookup_by_name_all_vrf() into a static function to prevent other people from using it inadvertently. It should be used only internally by lib/if.c to handle a few corner cases, like it's doing right now with your changes.

bgpd/bgp_routemap.c

donaldsharp · 2019-07-30T12:54:20Z

zebra/zebra_ptm.c

+	ptm_lib_find_key_in_msg(in_ctxt, ZEBRA_PTM_BFDVRF_STR, vrf_str);
+
+	if (vrf_str[0] == '\0') {
+		zlog_debug("%s: Key %s not found in PTM msg", __func__,


unguarded debugs?

actually, this is not an error. this can happen to not have vrf in the message.
but the error will be that default vrf does not exist, which needs to return -1.
so I made some changes here

zebra/zebra_ptm.c

donaldsharp · 2019-07-30T12:55:33Z

zebra/zebra_ptm.c

@@ -589,6 +589,8 @@ static int zebra_ptm_handle_msg_cb(void *arg, void *in_ctxt)
 	char port_str[128];
 	char cbl_str[32];
 	char cmd_status_str[32];
+	char vrf_str[64];


How have you tested this particular patch? Can you provide me the details?

actually, I did not test it, as it requires to use external ptm daemon.
I did not make some patch with PTM, but I think some changes should be needed:

src/ptm_event.h:#define MAXNAMELEN 255 src/ptm_bfd.h: char vrf_name[MAXNAMELEN+1]; // from struct ptm_bfd_mhop_key src/ptm_bfd.h: char name[MAXNAMELEN+1]; // from bfd_vrf

what I can see is that even before, the values were not good, as there was a risk of buffer overflow in frr. here, the problem is still present with ptm, but at least, bfd daemon from frr is aligned with the frr internals.

donaldsharp · 2019-07-30T12:58:04Z

bgpd/bgp_routemap.c

@@ -1382,14 +1382,22 @@ static route_map_result_t route_match_interface(void *rule,
 {
 	struct interface *ifp;
 	struct bgp_path_info *path;
+	struct bgp_node *rn;


How does this commit work with route leaking routes? Have you tested this?

the interface should be in the bgp_orig pointer. good point.
I did not test it.
I will try to make a test to check if it is correct ( I focus on vrf-lite backend).

donaldsharp · 2019-07-30T12:59:33Z

lib/if.c

@@ -1141,7 +1141,11 @@ DEFPY_NOSH (interface,
 	 * VRF.
 	 */
 	VRF_GET_ID(vrf_id, vrfname, false);
-	ifp = if_lookup_by_name_all_vrf(ifname);
+	if (vrf_get_backend() == VRF_BACKEND_UNKNOWN ||


As I have stated elsewhere, it is not appropriate for end programmer to know which interface lookup function they must use when. Can we get this right please?

For that, I made a new static routine that will wrap the modification in if_lookup_by_name_relax(). This is mainly to avoid breaking behaviour.

LabN-CI · 2019-08-20T17:19:16Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4193 `9dc268d`
Date	08/20/2019
Start	12:57:17
Finish	13:19:14
Run-Time	21:57
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-08-20-12:57:17.txt
Log	autoscript-2019-08-20-12:58:09.log.bz2
Memory	421 424 359

For details, please contact louberger

NetDEF-CI · 2019-08-20T17:54:15Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8657/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for if.c | 5 issues
===============================================
< WARNING: strncat() is error-prone; please use strlcat() if possible#848: FILE: /tmp/f1-24378/if.c:848:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#848: FILE: /tmp/f2-24378/if.c:848:
305c305
< #925: FILE: /tmp/f1-24378/if.c:925:

CLANG Static Analyzer Summary

Github Pull Request 4193, comparing to Git base SHA d1c6230
Base image data for Git d1c6230 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-8657/artifact/shared/static_analysis/index.html

LabN-CI · 2019-09-30T12:42:01Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git pull/4193 `b02ce68` (merge failed)
Date	09/30/2019
Start	08:20:13
Finish	08:41:59
Run-Time	21:46
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-09-30-08:20:13.txt
Log	autoscript-2019-09-30-08:21:07.log.bz2
Memory	430 431 360

For details, please contact louberger

NetDEF-CI · 2019-09-30T14:13:17Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9083/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 4193, comparing to Git base SHA 9898a2f

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9083/artifact/shared/static_analysis/index.html

pguibert6WIND · 2019-09-30T15:37:58Z

ci:rerun

NetDEF-CI · 2019-09-30T18:06:41Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9085/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 4193, comparing to Git base SHA 9898a2f

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9085/artifact/shared/static_analysis/index.html

LabN-CI · 2019-10-08T13:16:18Z

🛑 Basic BGPD CI results: FAILURE

Results table

_	_
Result	FAILURE git merge/4193 `4f52376` frr.github Build
Date	10/08/2019
Start	09:15:29
Finish	09:16:17
Run-Time	00:48
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2019-10-08-09:15:29.txt
Log	make-2019-10-08-09:15:29.out.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2019-10-08T13:56:15Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/F29BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: version control conflict marker in file
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^~~~~~~
make[1]: *** [Makefile:7402: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/F29BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/DEB10BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: version control conflict marker in file
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^~~~~~~
make[1]: *** [Makefile:7403: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/DEB10BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804AMD64/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: version control conflict marker in file
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^~~~~~~
gmake[1]: *** [Makefile:7402: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 14.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 14.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI001BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")
 ^~~~~~~~~~
  CC       bgpd/bgp_flowspec.o

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804PPC64LEBUILD/config.log/

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI021BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI021BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: expected identifier or '('
<<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
^
1 error generated.
gmake[1]: *** [Makefile:7401: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI011BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: version control conflict marker in file
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^~~~~~~
gmake[1]: *** [Makefile:7402: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI009BUILD/config.status/config.status

NetBSD 7 amd64 build: Failed (click for details)

Make failed for NetBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: expected identifier or '(' before '<<' token
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^
gmake[1]: *** [Makefile:7402: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI012BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI005BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI005BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI014BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI014BUILD/config.status/config.status

Successful on other platforms

Ubuntu 12.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1604I386/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/F29BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: version control conflict marker in file
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^~~~~~~
make[1]: *** [Makefile:7402: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/F29BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/DEB10BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: version control conflict marker in file
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^~~~~~~
make[1]: *** [Makefile:7403: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/DEB10BUILD/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804AMD64/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804AMD64/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: version control conflict marker in file
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^~~~~~~
gmake[1]: *** [Makefile:7402: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/FBSD12AMD64/config.status/config.status

Ubuntu 14.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 14.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI001BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI008BLD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")
 ^~~~~~~~~~
  CC       bgpd/bgp_flowspec.o

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/U1804PPC64LEBUILD/config.log/

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI021BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI021BUILD/config.status/config.status

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: expected identifier or '('
<<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
^
1 error generated.
gmake[1]: *** [Makefile:7401: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI011BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: version control conflict marker in file
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^~~~~~~
gmake[1]: *** [Makefile:7402: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI009BUILD/config.status/config.status

NetBSD 7 amd64 build: Failed (click for details)

Make failed for NetBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:178:1: error: expected identifier or '(' before '<<' token
 <<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41
 ^
gmake[1]: *** [Makefile:7402: lib/if.lo] Error 1
  CC       lib/if_rmap.lo
  CC       lib/imsg-buffer.lo
  CC       lib/imsg.lo

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI012BUILD/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI005BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI005BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI014BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
bgpd/bgp_filter.c:468:1: note: #pragma message: bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command
 CPP_NOTICE("bgpd: remove deprecated 'ip as-path access-list WORD <deny|permit> LINE' command")

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9171/artifact/CI014BUILD/config.status/config.status

Report for if.c | 9 issues
===============================================
< ERROR: spaces required around that '<' (ctx:OxW)
< #178: FILE: /tmp/f1-16044/if.c:178:
< WARNING: line over 80 characters
< #375: FILE: /tmp/f1-16044/if.c:375:
< WARNING: strncat() is error-prone; please use strlcat() if possible#918: FILE: /tmp/f1-16044/if.c:918:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#896: FILE: /tmp/f2-16044/if.c:896:
318c309
< #995: FILE: /tmp/f1-16044/if.c:995:

sarav511 · 2019-10-10T07:38:53Z

lib/if.c

@@ -175,6 +175,7 @@ static struct interface *if_create_backend(const char *name, ifindex_t ifindex,
 	return ifp;
 }

+<<<<<<< bf2c18c1e30992b46e4d87c8109508788da41d41


Guess you've missed this

right. thanks

this is a change of behaviour when configuring bfd sessions. the user may not mention the vrf name when configuring sessions, and the session may stick to the vrf where the interface name is, if the vrf backend is the default one. This behaviour is not accurate enough, and the proposal is to always use a specific vrf ( either default one, or mentioned one). Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

the interface name is encoded in ptm messages. prior to that, the interface name was looked up against all the vrfs. the proposed change consists in identifying a vrf where the interface is hosted, namely either default vrf if no vrf is mentioned, or the vrf specified. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

as external_info structure may be used to store interface index to look for, the vrf identifier may also be necessary to reduce the search when a route map has to be applied, and an interface is searched. the interface to look for is found according to interface index and vrf identifier. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

instead of looking up the interface among all vrf instances, apply the route-map lookup interface based on the bgp instance that is accessible, by using the bgp_table where the rn is stored, because the bgp_table gives access to bgp instance. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

interface whose name is "vrf name" is in the vrf with vrf_id identified as nexthop vrf identifier. instead of parsing all vrfs, go directly to use the appropriate one. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

LabN-CI · 2019-10-15T12:21:17Z

🛑 Basic BGPD CI results: FAILURE

Results table

_	_
Result	FAILURE git merge/4193 `2d2f82b` frr.github Build
Date	10/15/2019
Start	08:20:29
Finish	08:21:16
Run-Time	00:47
Total
Pass
Fail
Valgrind-Errors
Valgrind-Loss
Details	vncregress-2019-10-15-08:20:29.txt
Log	make-2019-10-15-08:20:29.out.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2019-10-15T12:34:12Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of 'if_lookup_by_name_all_vrf' follows non-static declaration
static struct interface *if_lookup_by_name_all_vrf(const char *name)
                         ^
./lib/if.h:501:26: note: previous declaration is here
extern struct interface *if_lookup_by_name_all_vrf(const char *ifname);
                         ^
1 error generated.

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI011BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of 'if_lookup_by_name_all_vrf' follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./lib/sockunion.h:26,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI009BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/F29BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of if_lookup_by_name_all_vrf follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./lib/sockunion.h:26,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/F29BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/DEB10BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of if_lookup_by_name_all_vrf follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./lib/sockunion.h:26,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/DEB10BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of 'if_lookup_by_name_all_vrf' follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./lib/sockunion.h:26:0,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/FBSD12AMD64/config.status/config.status

NetBSD 7 amd64 build: Failed (click for details)

Make failed for NetBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of 'if_lookup_by_name_all_vrf' follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^
In file included from ./lib/sockunion.h:26:0,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI014BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI014BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1604I386/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804AMD64/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804AMD64/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI005BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI005BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI021BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI021BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI008BLD/config.status/config.status

Ubuntu 14.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 14.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI001BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o
  CC       bgpd/bgp_flowspec_vty.o
  CC       bgpd/bgp_fsm.o

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804PPC64LEBUILD/config.log/

Successful on other platforms

Ubuntu 12.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

OpenBSD 6 amd64 build: Failed (click for details)

Make failed for OpenBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of 'if_lookup_by_name_all_vrf' follows non-static declaration
static struct interface *if_lookup_by_name_all_vrf(const char *name)
                         ^
./lib/if.h:501:26: note: previous declaration is here
extern struct interface *if_lookup_by_name_all_vrf(const char *ifname);
                         ^
1 error generated.

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI011BUILD/config.status/config.status

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI009BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of 'if_lookup_by_name_all_vrf' follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./lib/sockunion.h:26,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI009BUILD/config.status/config.status

Fedora 29 amd64 build: Failed (click for details)

Make failed for Fedora 29 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/F29BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of if_lookup_by_name_all_vrf follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./lib/sockunion.h:26,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/F29BUILD/config.status/config.status

Debian 10 amd64 build: Failed (click for details)

Make failed for Debian 10 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/DEB10BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of if_lookup_by_name_all_vrf follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./lib/sockunion.h:26,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

Debian 10 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/DEB10BUILD/config.status/config.status

FreeBSD 12 amd64 build: Failed (click for details)

Make failed for FreeBSD 12 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/FBSD12AMD64/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of 'if_lookup_by_name_all_vrf' follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./lib/sockunion.h:26:0,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/FBSD12AMD64/config.status/config.status

NetBSD 7 amd64 build: Failed (click for details)

Make failed for NetBSD 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI012BUILD/ErrorLog/log_make.txt)

  CLIPPY   lib/if_clippy.c
  CC       lib/if.lo
lib/if.c:196:26: error: static declaration of 'if_lookup_by_name_all_vrf' follows non-static declaration
 static struct interface *if_lookup_by_name_all_vrf(const char *name)
                          ^
In file included from ./lib/sockunion.h:26:0,
                 from ./lib/vty.h:29,
                 from ./lib/ferr.h:28,
                 from lib/lib_errors.h:24,

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI012BUILD/config.status/config.status

Ubuntu 16.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 16.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI014BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI014BUILD/config.status/config.status

Ubuntu 16.04 i386 build: Failed (click for details)

Make failed for Ubuntu 16.04 i386 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1604I386/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1604I386/config.status/config.status

Ubuntu 18.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 18.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804AMD64/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804AMD64/config.status/config.status

NetBSD 6 amd64 build: Failed (click for details)

Make failed for NetBSD 6 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI007BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI007BUILD/config.status/config.status

CentOS 7 amd64 build: Failed (click for details)

Make failed for CentOS 7 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI005BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI005BUILD/config.status/config.status

Debian 9 amd64 build: Failed (click for details)

Make failed for Debian 9 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI021BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI021BUILD/config.status/config.status

Debian 8 amd64 build: Failed (click for details)

Make failed for Debian 8 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI008BLD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI008BLD/config.status/config.status

Ubuntu 14.04 amd64 build: Failed (click for details)

Make failed for Ubuntu 14.04 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI001BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/CI001BUILD/config.status/config.status

Ubuntu 18.04 ppc64le build: Failed (click for details)

Make failed for Ubuntu 18.04 ppc64le build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804PPC64LEBUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o
  CC       bgpd/bgp_flowspec_vty.o
  CC       bgpd/bgp_fsm.o

Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804PPC64LEBUILD/config.status/config.status
Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9240/artifact/U1804PPC64LEBUILD/config.log/

Report for if.c | 7 issues
===============================================
< WARNING: line over 80 characters
< #382: FILE: /tmp/f1-14969/if.c:382:
< WARNING: strncat() is error-prone; please use strlcat() if possible#944: FILE: /tmp/f1-14969/if.c:944:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#923: FILE: /tmp/f2-14969/if.c:923:
313c309
< #1021: FILE: /tmp/f1-14969/if.c:1021:
Report for if.h | 4 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #500: FILE: /tmp/f1-14969/if.h:500:
< WARNING: Block comments use * on subsequent lines
< #512: FILE: /tmp/f1-14969/if.h:512:

When duplicate name is on two network namespaces, at startup, the wrong interface is picked up. Because we are at startup, force to return the exact interface name. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

max name length is used for defining the maximum size for vrf attribute. it appears that the size is not enough to align with real vrf name size. so align with default vrf value. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

LabN-CI · 2019-10-15T13:32:07Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/4193 `bf3bf78`
Date	10/15/2019
Start	09:10:28
Finish	09:32:05
Run-Time	21:37
Total	1815
Pass	1815
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-10-15-09:10:28.txt
Log	autoscript-2019-10-15-09:11:18.log.bz2
Memory	433 434 360

For details, please contact louberger

NetDEF-CI · 2019-10-15T15:09:41Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-9242/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for if.c | 7 issues
===============================================
< WARNING: line over 80 characters
< #382: FILE: /tmp/f1-31880/if.c:382:
< WARNING: strncat() is error-prone; please use strlcat() if possible#944: FILE: /tmp/f1-31880/if.c:944:
---
> WARNING: strncat() is error-prone; please use strlcat() if possible#923: FILE: /tmp/f2-31880/if.c:923:
313c309
< #1021: FILE: /tmp/f1-31880/if.c:1021:
Report for if.h | 4 issues
===============================================
< WARNING: Block comments use a trailing */ on a separate line
< #500: FILE: /tmp/f1-31880/if.h:500:
< WARNING: Block comments use * on subsequent lines
< #511: FILE: /tmp/f1-31880/if.h:511:

pguibert6WIND · 2019-10-30T16:47:52Z

Hi @donaldsharp , is it ok for you to mege this PR?

donaldsharp · 2019-10-30T16:49:34Z

I asked about testing for two different issues and got I have not tested this. I'm not interested in committing code that there was no testing and no plan for testing. Did I missunderstand?

pguibert6WIND · 2019-10-31T20:50:33Z

Hi Donald,
sorry but it is very hard to follow the story under this pull request.
for me it was not so explicit.
I will try to get what you need .
thanks

donaldsharp · 2020-06-10T12:32:39Z

This code is now > 6 months old with no recent rebases and no action for request. Setting up for auto-close in 1 week.

donaldsharp · 2020-06-10T12:32:49Z

@polychaeta autoclose in 1 week

polychaeta added the libfrr label Apr 24, 2019

pguibert6WIND mentioned this pull request Apr 24, 2019

Fix interface rtadv #4027

Merged

qlyoung added the bugfix label Apr 24, 2019

pguibert6WIND mentioned this pull request Apr 25, 2019

bgp_vrf_ipv6_rtadv: test bgp ipv6 on separate vrf #4199

Closed

donaldsharp requested changes May 10, 2019

View reviewed changes

pguibert6WIND added the preliminary (WiP) label Jun 4, 2019

pguibert6WIND force-pushed the interface_node_access_way branch from be712e5 to 5c960e0 Compare June 12, 2019 11:52

qlyoung self-requested a review June 18, 2019 15:16

qlyoung reviewed Jul 1, 2019

View reviewed changes

zebra/zebra_ptm.c Outdated Show resolved Hide resolved

rwestphal approved these changes Jul 12, 2019

View reviewed changes

bgpd/bgp_routemap.c Outdated Show resolved Hide resolved

donaldsharp requested changes Jul 30, 2019

View reviewed changes

pguibert6WIND force-pushed the interface_node_access_way branch from 5c960e0 to 9dc268d Compare August 20, 2019 16:11

pguibert6WIND force-pushed the interface_node_access_way branch from 9dc268d to e707555 Compare August 21, 2019 11:58

pguibert6WIND removed the preliminary (WiP) label Oct 1, 2019

pguibert6WIND force-pushed the interface_node_access_way branch from b02ce68 to 4f52376 Compare October 8, 2019 13:10

sarav511 reviewed Oct 10, 2019

View reviewed changes

pguibert6WIND added 5 commits October 15, 2019 14:17

bgpd: flowspec default route uses vrf interface

88cc1fc

interface whose name is "vrf name" is in the vrf with vrf_id identified as nexthop vrf identifier. instead of parsing all vrfs, go directly to use the appropriate one. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

pguibert6WIND force-pushed the interface_node_access_way branch from 4f52376 to 2d2f82b Compare October 15, 2019 12:19

pguibert6WIND added 2 commits October 15, 2019 14:52

lib: fix issue with interface node access at startup

b4990ad

When duplicate name is on two network namespaces, at startup, the wrong interface is picked up. Because we are at startup, force to return the exact interface name. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

bfdd: align max name length with vrf name size

bf3bf78

max name length is used for defining the maximum size for vrf attribute. it appears that the size is not enough to align with real vrf name size. so align with default vrf value. Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

pguibert6WIND force-pushed the interface_node_access_way branch from 2d2f82b to bf3bf78 Compare October 15, 2019 12:53

polychaeta added the autoclose label Jun 10, 2020

pguibert6WIND removed the autoclose label Jun 17, 2020

polychaeta closed this Jun 17, 2020

lib: fix issue with interface node access at startup #4193

lib: fix issue with interface node access at startup #4193

Conversation

pguibert6WIND commented Apr 24, 2019

LabN-CI commented Apr 24, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Apr 24, 2019

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

donaldsharp left a comment

Choose a reason for hiding this comment

rwestphal commented May 21, 2019

donaldsharp commented May 21, 2019

LabN-CI commented May 25, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

pguibert6WIND commented Jun 12, 2019

LabN-CI commented Jun 12, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jun 12, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

4 Static Analyzer issues remaining.

pguibert6WIND commented Jun 21, 2019

pguibert6WIND commented Jul 1, 2019

qlyoung left a comment

Choose a reason for hiding this comment

LabN-CI commented Jul 3, 2019

🚧 Basic BGPD CI results: Partial FAILURE, 273 tests failed, has VALGRIND issues

pguibert6WIND commented Jul 5, 2019

pguibert6WIND commented Jul 8, 2019

LabN-CI commented Jul 8, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

pguibert6WIND commented Jul 9, 2019

rwestphal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LabN-CI commented Aug 20, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Aug 20, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

CLANG Static Analyzer Summary

1 Static Analyzer issues remaining.

LabN-CI commented Sep 30, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Sep 30, 2019

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

pguibert6WIND commented Sep 30, 2019

NetDEF-CI commented Sep 30, 2019

Continuous Integration Result: SUCCESSFUL

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

LabN-CI commented Oct 8, 2019

🛑 Basic BGPD CI results: FAILURE

NetDEF-CI commented Oct 8, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LabN-CI commented Oct 15, 2019

🛑 Basic BGPD CI results: FAILURE

NetDEF-CI commented Oct 15, 2019

Continuous Integration Result: FAILED