zebra: do not set nexthop flag to active just because route-map permt… #4100
Conversation
…s it Testing found a crash in zebra during ifdown processing due to trying to process a nexthop that was not valid. Root cause of the problem was that when the nexthop was checked against a route-map, it would blindly mark it active if the route-map permitted it, even if the nexthop was marked inactive prior to the route-map check. Ticket: CM-24440 Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
There was a problem hiding this comment.
hmm - so the ACTIVE flag in the copied nexthop list is being used to control the message sent to each registered client? if a 'filtered' client turns the ACTIVE flag off, won't that effectively apply the 'filter' to all subsequent clients in the rnh list, now that nothing will turn the flag back on?
|
I suspect your point is valid. Let me take a closer look and have a chat with Donald and revisit. Thanks for looking. |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7177/ This is a comment from an automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base67 Static Analyzer issues remaining.See details at |
Testing found a crash in zebra during ifdown processing due to trying
to process a nexthop that was not valid. Root cause of the problem
was that when the nexthop was checked against a route-map, it would
blindly mark it active if the route-map permitted it, even if the
nexthop was marked inactive prior to the route-map check.
Ticket: CM-24440
Signed-off-by: Don Slice dslice@cumulusnetworks.com