Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topotests: fix missing log file and duplicated output folder #4015

Merged
merged 2 commits into from
Mar 28, 2019
Merged

topotests: fix missing log file and duplicated output folder #4015

merged 2 commits into from
Mar 28, 2019

Conversation

rzalamena
Copy link
Member

Summary

Fix some issues mentioned in an issue (see below).

It was broken on this commit: e1dfa45

When the logs for non-topogen tests were moved to /tmp/topotests from /tmp.

Related Issue

#4009

Components

topotests

@NetDEF-CI

This comment has been minimized.

Sign in to view
@rzalamena
topotests/lib: fallback topology logdir if none was configured
0d5e41c 
`param.get` always evaluates the second argument and it was causing
two log directories being created for topologies using Topogen.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
@LabN-CI

This comment has been minimized.

Sign in to view
@rzalamena
topotests/lib: fix router specific log output
87ba6e1 
Change the router log output to the previous folder so it doesn't get
erased when starting the old API (unbreaks command/output logging on
Topogen).

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
@LabN-CI
Copy link
Collaborator

LabN-CI commented Mar 25, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4015 87ba6e1
Date 03/25/2019
Start 14:49:11
Finish 15:13:00
Run-Time 23:49
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-03-25-14:49:11.txt
Log autoscript-2019-03-25-14:49:55.log.bz2
Memory 500 500 429

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7023/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 9 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7023/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib-dbgsym: package-has-long-file-name 72 (81) > 80
Ubuntu 16.04 i386 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7023/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 71 (81) > 80
Ubuntu 14.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7023/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80
Ubuntu 16.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7023/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80
Ubuntu 18.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7023/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

CLANG Static Analyzer Summary

  • Github Pull Request 4015, comparing to Git base SHA dfff60e

No Changes in Static Analysis warnings compared to base

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7023/artifact/shared/static_analysis/index.html

mjstapp
mjstapp reviewed Mar 26, 2019
View reviewed changes
Copy link
Contributor

@mjstapp mjstapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this out - tried provoking a failed test and ensuring that the output files are captured?

@qlyoung qlyoung added the tests Topotests, make check, etc label Mar 26, 2019
mjstapp
mjstapp approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@mjstapp mjstapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now

@mjstapp mjstapp merged commit 0931097 into FRRouting:master Mar 28, 2019
@mjstapp mjstapp mentioned this pull request Mar 28, 2019
Closed
@rzalamena rzalamena deleted the topotests-fixes branch April 24, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjstapp mjstapp mjstapp approved these changes

Assignees
No one assigned
Labels
tests Topotests, make check, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rzalamena @NetDEF-CI @LabN-CI @mjstapp @qlyoung