Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: zclient provide interface info during reg_requests #4014

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

dslicenc
Copy link
Member

Signed-off-by: Don Slice dslice@cumulusnetworks.com

Summary

Problem found in bgpd where it wasn't learning interface address
information at startup due to the interface information becoming
available before the bgp instance was created. This issue was
caused by an earlier change that tried to make the interface
information discovery process more efficient but left this hole
for bgpd. For now, putting back in the previous method of
gathering interface info via the zclient_send_reg_requests call
and will revisit a more efficient way to get the info in the future.

Related Issue

PR#3730

Components

lib

Problem found in bgpd where it wasn't learning interface address
information at startup due to the interface information becoming
available before the bgp instance was created. This issue was
caused by an earlier change that tried to make the interface
information discovery process more efficient but left this hole
for bgpd. For now, putting back in the previous method of
gathering interface info via the zclient_send_reg_requests call
and will revisit a more efficient way to get the info in the future.

Ticket: CM-23932
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7019/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 9 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7019/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib-dbgsym: package-has-long-file-name 72 (81) > 80
Ubuntu 16.04 i386 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7019/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 71 (81) > 80
Ubuntu 16.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7019/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80
Ubuntu 14.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7019/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80
Ubuntu 18.04 amd64 build: Successful with additional warnings

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7019/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr-rpki-rtrlib: package-has-long-file-name 72 (81) > 80

CLANG Static Analyzer Summary

  • Github Pull Request 4014, comparing to Git base SHA 749d7a8
  • Base image data for Git 749d7a8 does not exist - compare skipped

1 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7019/artifact/shared/static_analysis/index.html

@LabN-CI
Copy link
Collaborator

LabN-CI commented Mar 25, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4014 eeb2dfa
Date 03/25/2019
Start 13:09:27
Finish 13:33:15
Run-Time 23:48
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-03-25-13:09:27.txt
Log autoscript-2019-03-25-13:10:11.log.bz2
Memory 500 483 429

For details, please contact louberger

@qlyoung qlyoung added the libfrr label Mar 26, 2019
@rwestphal rwestphal merged commit add682b into FRRouting:master Mar 29, 2019
@dslicenc dslicenc deleted the zclient-interface-add branch March 29, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants