No log commands #3581

donaldsharp · 2019-01-08T13:12:14Z

Allow the user to turn off log commands cli

LabN-CI · 2019-01-08T13:39:17Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3581 `a406e74`
Date	01/08/2019
Start	08:15:20
Finish	08:39:10
Run-Time	23:50
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-01-08-08:15:20.txt
Log	autoscript-2019-01-08-08:16:08.log.bz2

For details, please contact louberger

NetDEF-CI · 2019-01-08T14:52:54Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6344/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Report for vty.c | 2 issues
===============================================
< ERROR: do not initialise statics to false
< #98: FILE: /tmp/f1-24963/vty.c:98:

Warnings Generated during build:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6344/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6344/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6344/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6344/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6344/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6344/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

Github Pull Request 3581, comparing to Git base SHA fe615b5

No Changes in Static Analysis warnings compared to base

qlyoung

lib/vty.c

qlyoung · 2019-01-08T16:16:10Z

lib/vty.c

+	return CMD_SUCCESS;
+}
+
+DEFUN (no_log_commands,


You could do [no] log commands and

do_log_commands = !strmatch(argv[0]->text, "no")

to save us the new command here

I actually thought about adding a DEFPY but it just seemed like more work than necessary. I also thought we couldn't combine `'no' with DEFUNS?

no, that restriction was lifted a while ago

LabN-CI · 2019-01-11T01:13:02Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3581 `8160f13`
Date	01/10/2019
Start	19:49:18
Finish	20:12:52
Run-Time	23:34
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-01-10-19:49:18.txt
Log	autoscript-2019-01-10-19:50:01.log.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2019-01-11T01:44:13Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6374/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6374/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6374/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6374/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6374/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6374/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6374/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

Github Pull Request 3581, comparing to Git base SHA 45511ba

No Changes in Static Analysis warnings compared to base

louberger · 2019-01-15T15:07:43Z

lib/vty.c

@@ -3075,9 +3075,20 @@ DEFUN (log_commands,
       log_commands_cmd,
       "log commands",
       "Logging control\n"
-       "Log all commands (can't be unset without restart)\n")
+       "Log all commands\n")


The original use case of this was to disallow a use to "hide" changes by disabling logging. I don't feel strongly about this, but think it worth explicitly discussing in the weekly meeting.

louberger · 2019-01-22T02:00:29Z

plan discussed last week was to add a flag to allow (or disallow) usage of 'no log commands'. Also needs corresponding update in docs...

LabN-CI · 2019-01-29T14:57:52Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3581 `822b1bf`
Date	01/29/2019
Start	09:33:57
Finish	09:57:41
Run-Time	23:44
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-01-29-09:33:57.txt
Log	autoscript-2019-01-29-09:34:39.log.bz2
Memory

For details, please contact louberger

NetDEF-CI · 2019-01-29T15:11:36Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6521/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 i386 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6521/artifact/U1604I386/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 9 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 9 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6521/artifact/CI021BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 16.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6521/artifact/CI014BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 18.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6521/artifact/U1804AMD64/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 4 tags overridden (3 warnings, 1 info)

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Ubuntu 14.04 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6521/artifact/CI001BUILD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

Debian 8 amd64 build: Successful with additional warnings:

Debian Package lintian failed for Debian 8 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6521/artifact/CI008BLD/ErrorLog/log_lintian.txt)

W: frr: package-name-doesnt-match-sonames libfrr0 libfrrospfapiclient0
N: 3 tags overridden (3 warnings)

CLANG Static Analyzer Summary

Github Pull Request 3581, comparing to Git base SHA b539a22

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-6521/artifact/shared/static_analysis/index.html

eqvinox

See inline comment, should be a startup time command line option.

eqvinox · 2019-02-07T17:55:55Z

configure.ac

@@ -533,6 +537,9 @@ if test "$ac_cv_lib_json_c_json_object_get" = no; then
 fi
 ])

+AC_ARG_ENABLE([command_log_disable],
+    AS_HELP_STRING([--enable_command_log_disable], [Dissallow the `no log commands` command]))
+


To record the state here, I had suggested a command line option, and meant a daemon startup time option with that (e.g. --command-log-always). Adding configure options is generally not a good idea and really not warranted for this one.

LabN-CI · 2019-05-25T00:58:15Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3581 `822b1bf`
Date	05/24/2019
Start	20:35:29
Finish	20:58:04
Run-Time	22:35
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-24-20:35:29.txt
Log	autoscript-2019-05-24-20:36:35.log.bz2
Memory	397 429 360

For details, please contact louberger

NetDEF-CI · 2019-05-31T12:33:41Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

OpenBSD 6 amd64 build: Failed (click for details)

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI011BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for OpenBSD 6 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI011BUILD/ErrorLog/log_pytests.txt

FreeBSD 11 amd64 build: Failed (click for details)

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI009BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 11 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI009BUILD/ErrorLog/log_pytests.txt

Fedora 29 amd64 build: Failed (click for details)

Fedora 29 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/F29BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Fedora 29 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/F29BUILD/ErrorLog/log_pytests.txt

FreeBSD 12 amd64 build: Failed (click for details)

FreeBSD 12 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/FBSD12AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 12 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/FBSD12AMD64/ErrorLog/log_pytests.txt

NetBSD 7 amd64 build: Failed (click for details)

NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI012BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for NetBSD 7 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI012BUILD/ErrorLog/log_pytests.txt

Ubuntu 16.04 i386 build: Failed (click for details)

Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/U1604I386/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 i386 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/U1604I386/ErrorLog/log_pytests.txt

Ubuntu 16.04 amd64 build: Failed (click for details)

Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI014BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI014BUILD/ErrorLog/log_pytests.txt

Ubuntu 18.04 amd64 build: Failed (click for details)

Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/U1804AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/U1804AMD64/ErrorLog/log_pytests.txt

CentOS 6 amd64 build: Failed (click for details)

CentOS 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI006BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for CentOS 6 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI006BUILD/ErrorLog/log_pytests.txt

NetBSD 6 amd64 build: Failed (click for details)

NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI007BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for NetBSD 6 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI007BUILD/ErrorLog/log_pytests.txt

CentOS 7 amd64 build: Failed (click for details)

CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI005BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for CentOS 7 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI005BUILD/ErrorLog/log_pytests.txt

Debian 8 amd64 build: Failed (click for details)

Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI008BLD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 8 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI008BLD/ErrorLog/log_pytests.txt

Debian 9 amd64 build: Failed (click for details)

Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI021BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 9 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI021BUILD/ErrorLog/log_pytests.txt

Ubuntu 14.04 amd64 build: Failed (click for details)

Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI001BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 14.04 amd64 build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/CI001BUILD/ErrorLog/log_pytests.txt

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: config.log output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/U1804PPC64LEBUILD/config.log/ Ubuntu 18.04 ppc64le build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/U1804PPC64LEBUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 ppc64le build
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7896/artifact/U1804PPC64LEBUILD/ErrorLog/log_pytests.txt

Successful on other platforms

Ubuntu 12.04 amd64 build
OmniOS amd64 build

LabN-CI · 2019-05-31T12:38:15Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3581 `b9298c2`
Date	05/31/2019
Start	08:15:14
Finish	08:38:00
Run-Time	22:46
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-31-08:15:14.txt
Log	autoscript-2019-05-31-08:16:18.log.bz2
Memory	433 424 360

For details, please contact louberger

donaldsharp · 2019-05-31T12:40:48Z

@louberger and @eqvinox -> I've finally updated this. Please take a look at this when you get a chance

LabN-CI · 2019-05-31T13:28:13Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3581 `5811d48`
Date	05/31/2019
Start	09:05:15
Finish	09:28:00
Run-Time	22:45
Total	1810
Pass	1810
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-31-09:05:15.txt
Log	autoscript-2019-05-31-09:06:21.log.bz2
Memory	435 434 360

For details, please contact louberger

NetDEF-CI · 2019-05-31T14:03:20Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7899/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topology tests on Ubuntu 18.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1804-7899/test

Topology Tests failed for Topology tests on Ubuntu 18.04 amd64:

2019-05-31 13:24:41,306 ERROR: assert failed at "test_all_protocol_startup/test_error_messages_vtysh": Vtysh StdErr Output check failed for router r1
assert "2019/05/31 1...log commands'" == ''
  - 2019/05/31 13:24:41 unknown: Ran out of docstring while parsing '[no] log commands'
r1 failed IP Routing table check:
--- Actual IP Routing Table
+++ Expected IP RoutingTable
@@ -1,4 +1,3 @@
-2019/05/31 XX:XX:XX unknown: Ran out of docstring while parsing '[no] log commands'
 C>* 192.168.0.0/24 is directly connected, r1-eth0, XX:XX:XX
 C>* 192.168.1.0/26 is directly connected, r1-eth1, XX:XX:XX
 C>* 192.168.2.0/26 is directly connected, r1-eth2, XX:XX:XX
2019-05-31 13:25:41,701 ERROR: assert failed at "test_all_protocol_startup/test_converge_protocols": IP Routing table failed for r1
  --- Actual IP Routing Table
  +++ Expected IP RoutingTable
  @@ -1,4 +1,3 @@
  -2019/05/31 XX:XX:XX unknown: Ran out of docstring while parsing '[no] log commands'
   C>* 192.168.0.0/24 is directly connected, r1-eth0, XX:XX:XX
   C>* 192.168.1.0/26 is directly connected, r1-eth1, XX:XX:XX
   C>* 192.168.2.0/26 is directly connected, r1-eth2, XX:XX:XX
assert 1 == 0
  -1
  +0
*** defaultIntf: warning: r1 has no interfaces

r4: bgpd crashed. Core file found - Backtrace follows:
[New LWP 30758]
[New LWP 30766]
[New LWP 30765]
Core was generated by `/usr/lib/frr/bgpd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fe0d84efe97 in ?? ()
[Current thread is 1 (LWP 30758)]
#0  0x00007fe0d84efe97 in ?? ()
Backtrace stopped: Cannot access memory at address 0x7ffc4c5e76e0
2019-05-31 13:32:10,527 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_memory_leak": 
r4: bgpd crashed. Core file found - Backtrace follows:
[New LWP 30758]
[New LWP 30766]
[New LWP 30765]
Core was generated by `/usr/lib/frr/bgpd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fe0d84efe97 in ?? ()
[Current thread is 1 (LWP 30758)]
#0  0x00007fe0d84efe97 in ?? ()
Backtrace stopped: Cannot access memory at address 0x7ffc4c5e76e0


r1: zebra crashed. Core file found - Backtrace follows:
[New LWP 30817]
[New LWP 30818]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
[Current thread is 1 (Thread 0x7f5d308ed7c0 (LWP 30817))]
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f5d2fb22801 in __GI_abort () at abort.c:79
#2  0x00007f5d30569f1d in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007f5d2fbf6bf9 in __GI___poll (fds=0x55abaf3c9690, nfds=5, timeout=0) at ../sysdeps/unix/sysv/linux/poll.c:29
#5  0x00007f5d30576a59 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007f5d30548e03 in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x000055abae1ecf61 in main ()

r1: bgpd crashed. Core file found - Backtrace follows:
[New LWP 30835]
[New LWP 30843]
[New LWP 30844]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/bgpd'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
[Current thread is 1 (Thread 0x7f7dedecd7c0 (LWP 30835))]
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f7decd64801 in __GI_abort () at abort.c:79
#2  0x00007f7dedb49f1d in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007f7dedb2da74 in qfree () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#5  0x0000558be86d5594 in bgp_path_info_unlock ()
#6  0x0000558be86d5645 in bgp_path_info_extra_free ()
#7  0x0000558be86d5551 in bgp_path_info_unlock ()
#8  0x0000558be86d57a9 in bgp_path_info_reap ()
#9  0x0000558be86d58ce in ?? ()
#10 0x0000558be86dba87 in bgp_clear_route ()
#11 0x0000558be86dbbe0 in bgp_clear_route_all ()
#12 0x0000558be877db25 in bgp_fsm_change_status ()
#13 0x0000558be87246b0 in peer_delete ()
#14 0x0000558be8727ce9 in bgp_delete ()
#15 0x0000558be86a166e in sigint ()
#16 0x00007f7dedb49fb3 in quagga_sigevent_process () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#17 0x00007f7dedb56ca5 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#18 0x00007f7dedb28e03 in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#19 0x0000558be869f3b1 in main ()
2019-05-31 13:32:16,492 ERROR: assert failed at "bgp_l3vpn_to_bgp_vrf.test_bgp_l3vpn_to_bgp_vrf/test_memory_leak": 
r1: zebra crashed. Core file found - Backtrace follows:
[New LWP 30817]
[New LWP 30818]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
[Current thread is 1 (Thread 0x7f5d308ed7c0 (LWP 30817))]
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f5d2fb22801 in __GI_abort () at abort.c:79
#2  0x00007f5d30569f1d in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007f5d2fbf6bf9 in __GI___poll (fds=0x55abaf3c9690, nfds=5, timeout=0) at ../sysdeps/unix/sysv/linux/poll.c:29
#5  0x00007f5d30576a59 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#6  0x00007f5d30548e03 in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#7  0x000055abae1ecf61 in main ()

r1: bgpd crashed. Core file found - Backtrace follows:
[New LWP 30835]
[New LWP 30843]
[New LWP 30844]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/bgpd'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
[Current thread is 1 (Thread 0x7f7dedecd7c0 (LWP 30835))]
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007f7decd64801 in __GI_abort () at abort.c:79
#2  0x00007f7dedb49f1d in ?? () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#3  <signal handler called>
#4  0x00007f7dedb2da74 in qfree () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#5  0x0000558be86d5594 in bgp_path_info_unlock ()
#6  0x0000558be86d5645 in bgp_path_info_extra_free ()
#7  0x0000558be86d5551 in bgp_path_info_unlock ()
#8  0x0000558be86d57a9 in bgp_path_info_reap ()
#9  0x0000558be86d58ce in ?? ()
#10 0x0000558be86dba87 in bgp_clear_route ()
#11 0x0000558be86dbbe0 in bgp_clear_route_all ()
#12 0x0000558be877db25 in bgp_fsm_change_status ()
#13 0x0000558be87246b0 in peer_delete ()
#14 0x0000558be8727ce9 in bgp_delete ()
#15 0x0000558be86a166e in sigint ()
#16 0x00007f7dedb49fb3 in quagga_sigevent_process () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#17 0x00007f7dedb56ca5 in thread_fetch () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#18 0x00007f7dedb28e03 in frr_run () from /usr/lib/x86_64-linux-gnu/frr/libfrr.so.0
#19 0x0000558be869f3b1 in main ()

*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7899/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Topology tests on Ubuntu 16.04 amd64: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-7899/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2019-05-31 06:24:36,517 ERROR: assert failed at "test_all_protocol_startup/test_error_messages_vtysh": Vtysh StdErr Output check failed for router r1
assert "2019/05/31 0...log commands'" == ''
  - 2019/05/31 06:24:36 unknown: Ran out of docstring while parsing '[no] log commands'
r1 failed IP Routing table check:
--- Actual IP Routing Table
+++ Expected IP RoutingTable
@@ -1,4 +1,3 @@
-2019/05/31 XX:XX:XX unknown: Ran out of docstring while parsing '[no] log commands'
 C>* 192.168.0.0/24 is directly connected, r1-eth0, XX:XX:XX
 C>* 192.168.1.0/26 is directly connected, r1-eth1, XX:XX:XX
 C>* 192.168.2.0/26 is directly connected, r1-eth2, XX:XX:XX
2019-05-31 06:25:36,820 ERROR: assert failed at "test_all_protocol_startup/test_converge_protocols": IP Routing table failed for r1
  --- Actual IP Routing Table
  +++ Expected IP RoutingTable
  @@ -1,4 +1,3 @@
  -2019/05/31 XX:XX:XX unknown: Ran out of docstring while parsing '[no] log commands'
   C>* 192.168.0.0/24 is directly connected, r1-eth0, XX:XX:XX
   C>* 192.168.1.0/26 is directly connected, r1-eth1, XX:XX:XX
   C>* 192.168.2.0/26 is directly connected, r1-eth2, XX:XX:XX
assert 1 == 0
  -1
  +0
*** defaultIntf: warning: r1 has no interfaces
*** defaultIntf: warning: lm has no interfaces

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7899/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topotest tests on Ubuntu 16.04 i386: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-7899/test

Topology Tests failed for Topotest tests on Ubuntu 16.04 i386:

2019-05-31 06:24:43,043 ERROR: assert failed at "test_all_protocol_startup/test_error_messages_vtysh": Vtysh StdErr Output check failed for router r1
assert "2019/05/31 0...log commands'" == ''
  - 2019/05/31 06:24:42 unknown: Ran out of docstring while parsing '[no] log commands'
r1 failed IP Routing table check:
--- Actual IP Routing Table
+++ Expected IP RoutingTable
@@ -1,4 +1,3 @@
-2019/05/31 XX:XX:XX unknown: Ran out of docstring while parsing '[no] log commands'
 C>* 192.168.0.0/24 is directly connected, r1-eth0, XX:XX:XX
 C>* 192.168.1.0/26 is directly connected, r1-eth1, XX:XX:XX
 C>* 192.168.2.0/26 is directly connected, r1-eth2, XX:XX:XX
2019-05-31 06:25:43,480 ERROR: assert failed at "test_all_protocol_startup/test_converge_protocols": IP Routing table failed for r1
  --- Actual IP Routing Table
  +++ Expected IP RoutingTable
  @@ -1,4 +1,3 @@
  -2019/05/31 XX:XX:XX unknown: Ran out of docstring while parsing '[no] log commands'
   C>* 192.168.0.0/24 is directly connected, r1-eth0, XX:XX:XX
   C>* 192.168.1.0/26 is directly connected, r1-eth1, XX:XX:XX
   C>* 192.168.2.0/26 is directly connected, r1-eth2, XX:XX:XX
assert 1 == 0
  -1
  +0
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: r1 has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
*** defaultIntf: warning: lm has no interfaces
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument
RTNETLINK answers: Invalid argument

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7899/artifact/TOPOI386/ErrorLog/log_topotests.txt

Successful on other platforms

Static analyzer (clang)
CentOS 6 rpm pkg check
IPv6 protocols on Ubuntu 14.04
Fedora 29 rpm pkg check
Ubuntu 16.04 deb pkg check
Ubuntu 12.04 deb pkg check
Debian 8 deb pkg check
Addresssanitizer topotest
IPv4 protocols on Ubuntu 14.04
Debian 9 deb pkg check
IPv4 ldp protocol on Ubuntu 16.04
Ubuntu 14.04 deb pkg check
CentOS 7 rpm pkg check

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7899/artifact/TOPOU1804/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7899/artifact/TOPOU1604/MemoryLeaks/
Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7899/artifact/TOPOI386/MemoryLeaks/

CLANG Static Analyzer Summary

Github Pull Request 3581, comparing to Git base SHA 9c61cec

No Changes in Static Analysis warnings compared to base

11 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7899/artifact/shared/static_analysis/index.html

Add 'no log commands' cli and at the same time add a --command-log-always to the daemon startup cli. If --command-log-always is specified then all commands are auto-logged and the 'no log commands' form of the command is now ignored. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Add documentation for the '--command-log-always' daemon cli and how to use it. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

LabN-CI · 2019-05-31T15:06:06Z

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3581 `80d02ad`
Date	05/31/2019
Start	10:43:08
Finish	11:05:53
Run-Time	22:45
Total	1813
Pass	1813
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2019-05-31-10:43:08.txt
Log	autoscript-2019-05-31-10:44:09.log.bz2
Memory	403 432 360

For details, please contact louberger

NetDEF-CI · 2019-05-31T15:29:23Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7903/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

Github Pull Request 3581, comparing to Git base SHA 9c61cec

No Changes in Static Analysis warnings compared to base

11 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7903/artifact/shared/static_analysis/index.html

louberger · 2019-06-01T21:12:11Z

doc/user/basic.rst

-   restarting the daemon.
+   including passwords. If the daemon startup option `--command-log-always`
+   is used to start the daemon then this command is turned on by default
+   and cannot be turned off and the [no] form of the command is dissallowed.


At this point, I'd be fine with just the command line - but I guess there is a use case for using log commands temporarily, e.g., for debugging.

eqvinox

Awesome.

This comment has been minimized.

Sign in to view

qlyoung reviewed Jan 8, 2019

View reviewed changes

donaldsharp force-pushed the no_log_commands branch from a406e74 to 8160f13 Compare January 11, 2019 00:34

donaldsharp added the review & merge me look at me! label Jan 11, 2019

louberger requested changes Jan 15, 2019

View reviewed changes

louberger added submitter action required The author/submitter needs to do something (fix, rebase, add info, etc.) and removed review & merge me look at me! labels Jan 22, 2019

donaldsharp force-pushed the no_log_commands branch from 8160f13 to 822b1bf Compare January 29, 2019 13:56

donaldsharp added review & merge me look at me! and removed submitter action required The author/submitter needs to do something (fix, rebase, add info, etc.) labels Jan 29, 2019

eqvinox requested changes Feb 7, 2019

View reviewed changes

eqvinox added submitter action required The author/submitter needs to do something (fix, rebase, add info, etc.) and removed review & merge me look at me! labels Feb 12, 2019

qlyoung added the vtysh label Mar 26, 2019

donaldsharp force-pushed the no_log_commands branch from 822b1bf to b9298c2 Compare May 31, 2019 12:12

donaldsharp force-pushed the no_log_commands branch from b9298c2 to 5811d48 Compare May 31, 2019 12:57

donaldsharp added 2 commits May 31, 2019 10:06

doc: Add doc for new configure option

80d02ad

Add documentation for the '--command-log-always' daemon cli and how to use it. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

donaldsharp force-pushed the no_log_commands branch from 5811d48 to 80d02ad Compare May 31, 2019 14:07

louberger reviewed Jun 1, 2019

View reviewed changes

louberger approved these changes Jun 1, 2019

View reviewed changes

eqvinox approved these changes Jun 3, 2019

View reviewed changes

eqvinox merged commit 5a4ac9d into FRRouting:master Jun 3, 2019

donaldsharp deleted the no_log_commands branch December 9, 2019 16:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No log commands #3581

No log commands #3581

donaldsharp commented Jan 8, 2019

LabN-CI commented Jan 8, 2019

This comment has been minimized.

NetDEF-CI commented Jan 8, 2019

qlyoung left a comment •

edited

Loading

qlyoung Jan 8, 2019 •

edited

Loading

donaldsharp Jan 11, 2019

qlyoung Feb 4, 2019

LabN-CI commented Jan 11, 2019

NetDEF-CI commented Jan 11, 2019

louberger Jan 15, 2019

louberger commented Jan 22, 2019

LabN-CI commented Jan 29, 2019

NetDEF-CI commented Jan 29, 2019

eqvinox left a comment

eqvinox Feb 7, 2019

LabN-CI commented May 25, 2019

NetDEF-CI commented May 31, 2019

LabN-CI commented May 31, 2019

donaldsharp commented May 31, 2019

LabN-CI commented May 31, 2019

NetDEF-CI commented May 31, 2019

LabN-CI commented May 31, 2019

NetDEF-CI commented May 31, 2019

louberger Jun 1, 2019

eqvinox left a comment

No log commands #3581

No log commands #3581

Conversation

donaldsharp commented Jan 8, 2019

LabN-CI commented Jan 8, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

This comment has been minimized.

NetDEF-CI commented Jan 8, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Checkout code: Successful with additional warnings:

Warnings Generated during build:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian 9 amd64 build: Successful with additional warnings:

Debian 8 amd64 build: Successful with additional warnings:

Ubuntu 14.04 amd64 build: Successful with additional warnings:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

qlyoung left a comment • edited Loading

Choose a reason for hiding this comment

qlyoung Jan 8, 2019 • edited Loading

Choose a reason for hiding this comment

donaldsharp Jan 11, 2019

Choose a reason for hiding this comment

qlyoung Feb 4, 2019

Choose a reason for hiding this comment

LabN-CI commented Jan 11, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jan 11, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Debian 8 amd64 build: Successful with additional warnings:

Debian 9 amd64 build: Successful with additional warnings:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

louberger Jan 15, 2019

Choose a reason for hiding this comment

louberger commented Jan 22, 2019

LabN-CI commented Jan 29, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented Jan 29, 2019

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Ubuntu 16.04 i386 build: Successful with additional warnings:

Debian 9 amd64 build: Successful with additional warnings:

Ubuntu 16.04 amd64 build: Successful with additional warnings:

Ubuntu 18.04 amd64 build: Successful with additional warnings:

Ubuntu 14.04 amd64 build: Successful with additional warnings:

Debian 8 amd64 build: Successful with additional warnings:

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

3 Static Analyzer issues remaining.

eqvinox left a comment

Choose a reason for hiding this comment

eqvinox Feb 7, 2019

Choose a reason for hiding this comment

LabN-CI commented May 25, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 31, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

LabN-CI commented May 31, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

donaldsharp commented May 31, 2019

LabN-CI commented May 31, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

NetDEF-CI commented May 31, 2019

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

CLANG Static Analyzer Summary

No Changes in Static Analysis warnings compared to base

qlyoung left a comment •

edited

Loading

qlyoung Jan 8, 2019 •

edited

Loading