bgp_vty: Fix vpn_leak_postchange_all() every time "router bgp ASNUM" context is entered

[adeg]

Summary

Two bugfixes:

1. In rare cases when the default BGP instance is instantiated after VRF bgp instances (see comment to bgp_mplsvpn.c:vpn_leak_postchange_all() for an example), the "router bgp" command needs to call vpn_leak_postchange_all() to start the route leaking process. The issue was it was never checked if the "router bgp" command was actually used to create the default BGP instance or just to enter into "router bgp" command context. This resulted in vpn_leak_postchange_all() executed every time (and vpn routes re-announced to all peers) when the user was entering "router bgp" command context.

2. The other commit just adds a missing endline which was causing distorted output in vtysh in rare cases, for example, when there were no peers configured and the user has issued "bgp disable-ebgp-connected-route-check" command.

Components

[bgpd, vtysh]

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5912/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Failed

Fedora 24 amd64 build: Successful
FreeBSD 11 amd64 build: Successful
NetBSD 7 amd64 build: Successful
Ubuntu 16.04 amd64 build: Successful
Ubuntu 16.04 i386 build: Successful
Ubuntu 18.04 amd64 build: Successful
CentOS 6 amd64 build: Successful
NetBSD 6 amd64 build: Successful
CentOS 7 amd64 build: Successful
Debian 8 amd64 build: Successful
Debian 9 amd64 build: Successful
Ubuntu 12.04 amd64 build: Successful
FreeBSD 10 amd64 build: Successful
Ubuntu 14.04 amd64 build: Successful
OmniOS amd64 build: Successful

OpenBSD 6 amd64 build: Failed

Make failed for OpenBSD 6 amd64 build:
(see full make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5912/artifact/CI011BUILD/ErrorLog/log_make.txt)

  CC       bgpd/bgp_ecommunity.o
  CC       bgpd/bgp_encap_tlv.o
  CC       bgpd/bgp_errors.o
  CC       bgpd/bgp_evpn.o
  CLIPPY   bgpd/bgp_evpn_vty_clippy.c
  CC       bgpd/bgp_evpn_vty.o
  CC       bgpd/bgp_filter.o
  CC       bgpd/bgp_flowspec.o
  CC       bgpd/bgp_flowspec_util.o

OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5912/artifact/CI011BUILD/config.status/config.status

[adeg]

CI:rerun

[LabN-CI]

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table

_	_
Result	SUCCESS git merge/3325 3702f84
Date	11/13/2018
Start	20:20:42
Finish	20:44:10
Run-Time	23:28
Total	1816
Pass	1816
Fail	0
Valgrind-Errors	0
Valgrind-Loss	0
Details	vncregress-2018-11-13-20:20:42.txt
Log	autoscript-2018-11-13-20:21:24.log.bz2

For details, please contact louberger

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5914/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

---

CLANG Static Analyzer Summary

• Github Pull Request 3325, comparing to Git base SHA bc620fb

No Changes in Static Analysis warnings compared to base