Pim bsd #3263
Pim bsd #3263
Conversation
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDSee below for issues. This is a comment from an EXPERIMENTAL automated CI system. Get source and apply patch from patchwork: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedCentOS 7 rpm pkg check: Successful Topotest tests on Ubuntu 16.04 i386: FailedTopology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOI386-5808/test Topology Tests failed for Topotest tests on Ubuntu 16.04 i386 Topology tests on Ubuntu 16.04 amd64: FailedTopology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-5808/test Topology Tests failed for Topology tests on Ubuntu 16.04 amd64 Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5808/artifact/TOPOI386/MemoryLeaks/
|
When trying to run PIM on *bsd, the kernel expects to only allow the pim kernel socket to work if we elevate priviledges. So do so. This commit gets us further in the startup of PIM on *bsd but is not sufficient to get it fully started yet. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
When sending a sockoption for MRT_INIT, *bsd requires that the data passed in must be 1. While linux does not, the code was sending in a positive value that was causing issues on *bsd of protocol not supported. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-5815/ This is a comment from an EXPERIMENTAL automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base |
PIM on *BSD systems ( such as they are ) was not properly working. This should make the issues raised in #3245 go away. I have not done any actual real work to see what does/does not work on *bsd beyond verifying that the pim socket to the kernel is now created. There might be other limitations that we run into.